15:00:13 <vishalmanchanda> #startmeeting horizon
15:00:14 <opendevmeet> Meeting started Wed Jul  5 15:00:13 2023 UTC and is due to finish in 60 minutes.  The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:14 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:14 <opendevmeet> The meeting name has been set to 'horizon'
15:00:26 <tmazur> o/
15:00:46 <vishalmanchanda> hello everyone
15:01:46 <rdopiera> o/
15:02:10 <vishalmanchanda> let's start the meeting
15:02:58 <vishalmanchanda> agenda of meeting can be find here https://etherpad.opendev.org/p/horizon-release-priorities#L32
15:03:14 <vishalmanchanda> #topic Notices
15:03:31 <vishalmanchanda> I am not having any announcements for this week.
15:03:45 <vishalmanchanda> Just a casual reminder about schedule.
15:04:05 <vishalmanchanda> This week is R-13 week. Bobcat-2 milestone
15:04:43 <vishalmanchanda> moving to the next topic
15:04:54 <vishalmanchanda> #topic Release priorities
15:05:09 <vishalmanchanda> Any updates on integration job failure.
15:05:31 <rdopiera> I have some good news
15:05:38 <vishalmanchanda> I can see 3 tests are failing now in https://review.opendev.org/c/openstack/horizon/+/886867
15:05:46 <rdopiera> we have found the reason for the javascript errors
15:06:05 <vishalmanchanda> ohh nice🙂)
15:06:06 <rdopiera> it's this patch https://review.opendev.org/c/openstack/requirements/+/883402
15:06:28 <rdopiera> the problem is that jquery-migrate 3.x requires jquery 3.x or newer to work
15:06:43 <vishalmanchanda> ok
15:06:49 <rdopiera> but only jquery-migrate was updated, jquery is still at 1.2
15:06:53 <vishalmanchanda> ohh I missed that
15:07:21 <rdopiera> the solution is either to rollback that rollback of a rollback again, or to upgrade jquery to 3.x
15:07:42 <vishalmanchanda> beacuse in my local env. the series of patch I purposed I updated jQuery version to 3.x
15:08:01 <rdopiera> I tried to do that yesterday with some patches, but I hit a dependency cycle between the global requirements and horizon's requirements.txt
15:08:30 <vishalmanchanda> rdopiera: ok that I will update
15:08:35 <rdopiera> basically the patch to global requirements fails, becase horizon requires jquery < 2
15:08:58 <vishalmanchanda> but are you sure that will fix the issue, I mean upgrading jQuery version to 3.x?
15:09:02 <rdopiera> and the patch to horizon fails, becase global requirements has the version pinned
15:09:17 <rdopiera> it will fix the issue with the menu not working on a click
15:09:23 <vishalmanchanda> ok
15:09:29 <rdopiera> there might be further issues that we didn't see yet
15:09:39 <vishalmanchanda> yeah
15:09:52 <rdopiera> but I guess we will handle them as they come
15:11:12 <vishalmanchanda> ok, one question here any specific reason you updated to XStatic-jQuery===2.2.4.1
15:11:21 <vishalmanchanda> not  3.3.2.1
15:11:23 <vishalmanchanda> ?
15:11:43 <vishalmanchanda> This patch https://review.opendev.org/c/openstack/requirements/+/887607/1/upper-constraints.txt#80 I am talking about
15:14:58 <vishalmanchanda> rdopiera: ^^
15:19:12 <rdopiera> vishalmanchanda: I wanted to upgrade it as little as possible, which in hindsight was a mistake
15:19:35 <rdopiera> vishalmanchanda: we should upgrade to the latest available, probably also upgrade the xstatic
15:19:36 <vishalmanchanda> ok
15:22:58 <vishalmanchanda> I will purpose a patch to update Xstatic-Jquery version to 3.3.2.1 in openstack/requirements
15:26:05 <vishalmanchanda> after that let's see what more issue we get.
15:29:15 <vishalmanchanda> your patch is failing due to version dependency issues
15:29:26 <vishalmanchanda> we have to do that step by step
15:30:03 <vishalmanchanda> like first we need to raise the version in ``gloabl-requirements.txt``
15:31:06 <vishalmanchanda> then we can bump jQuery version in upper-constraints.txt`` file.
15:32:25 <rdopiera> I see, thank you
15:33:07 <vishalmanchanda> I just purposed a patch for that in openstack/requirements https://review.opendev.org/c/openstack/requirements/+/887720
15:34:56 <vishalmanchanda> let see if CI is pass for that.
15:37:23 <vishalmanchanda> if this pass https://review.opendev.org/c/openstack/requirements/+/887720
15:39:17 <vishalmanchanda> then we will update jQuery version in horizon ``requirements.txt``
15:39:33 <vishalmanchanda> then in ``upper.constraints.txt``
15:40:07 <vishalmanchanda> we done the same when we bump django version in the past.
15:40:52 <vishalmanchanda> https://review.opendev.org/c/openstack/requirements/+/813405
15:41:03 <vishalmanchanda> https://review.opendev.org/c/openstack/horizon/+/815393
15:41:15 <vishalmanchanda> https://review.opendev.org/c/openstack/requirements/+/815096
15:42:19 <vishalmanchanda> Let see
15:42:34 <vishalmanchanda> I have one more update
15:44:40 <vishalmanchanda> I missed to add "xstatic-angular-fileupload pypi" under Openstack release process.
15:45:07 <vishalmanchanda> I got know it today from release team.
15:45:34 <vishalmanchanda> I will push the patch to fix it asap.
15:45:53 <vishalmanchanda> I have no other topic to discuss for today.
15:45:59 <vishalmanchanda> #topic open-discussion
15:46:11 <vishalmanchanda> Do we have any other topic to discuss?
15:49:26 <vishalmanchanda> If no other topic to discuss, let's end this meeting
15:49:38 <vishalmanchanda> thanks everyone for joining.
15:49:48 <vishalmanchanda> #endmeeting