15:00:09 #startmeeting horizon 15:00:09 Meeting started Wed Aug 23 15:00:09 2023 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. 15:00:09 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 15:00:09 The meeting name has been set to 'horizon' 15:02:09 o/ 15:03:07 rdopiera: tmazur :hi, ping for horizon weekly meeting. 15:03:53 o/ 15:04:08 hello everyone 15:04:48 let's start the meeting 15:05:01 agenda of the meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities#L40 15:05:09 #topic Notices 15:05:29 few announcements from my side for this week. 15:05:57 First of all a gentle reminder about the schedule. 15:06:06 This week is R-6 week. 15:06:26 Next week is Feature freeze week, but horizon follows intermediary releases model. 15:06:37 o/ 15:07:10 So we can merge patches till R-1 week(Sep 25 - Sep 29), but try to merge patches before R-3 week(Hard StringFreeze).so that translations of string can happen smoothly. 15:07:50 Next week, we have to push a patch for Cycle Highlights. 15:07:55 I will do that. 15:08:24 moving to next announcement 15:10:29 Tc is planning to make py 3.11 as voting in 2024.1 release. 15:10:38 it is non-voting as of now. 15:10:47 https://lists.openstack.org/pipermail/openstack-discuss/2023-August/034807.html 15:11:20 As of now python 3.11 is failing in horizon 15:11:30 https://zuul.opendev.org/t/openstack/build/05818346981e4b409f929fffd9435954/log/job-output.txt#32511-32519 15:12:21 basically few Volumebackup tests are failing, I will try to fix those failed tests. 15:13:03 moving to next announcement 15:14:00 As you may know, nomination of TC and PTL is started. 15:14:38 So I am going to nominate myself for Horizon PTL for 2024.1 cycle. 15:15:08 Please let me know if anyone else is also interested. 15:16:21 that's all announcements from my side for this week. 15:16:40 moving to the next topic 15:16:56 #topic Release priorities 15:17:45 rdopiera: I guess now CI will pass for PyMemcacheCache patch https://review.opendev.org/c/openstack/horizon/+/891828 15:18:33 just wondering if we should add a release note about switching to PyMemcacheCache with reason 15:18:52 or no need of adding the release note? 15:19:00 rdopiera: ^^ 15:19:13 vishalmanchanda: it doesn't pass 15:19:22 vishalmanchanda: I can't get it working for some reason 15:19:37 it keeps failing with ModuleNotFoundError 15:20:17 ohh looking. 15:21:43 vishalmanchanda: it seems that the version that global requirements wants, 4.0.0, is no longer called 'memcache' from python import side 15:21:49 so the django code crashes 15:22:08 I will try with the django-pymemcache plugin 15:23:56 rdopiera: ok. 15:24:20 just looking at how other openstack project using it https://codesearch.openstack.org/?q=pymemcache&i=nope&literal=nope&files=&excludeFiles=&repos= 15:26:08 rdopiera: for scss patch https://review.opendev.org/c/openstack/horizon/+/890403 , I think we may need to write a ansible task for that. 15:26:14 vishalmanchanda: is this possible that the integration and tempest tests have their own configuration where they configure memcached? 15:26:51 rdopiera: yes. I think they have. 15:27:23 about the scss patch, when I went to check the name of the package on debian, I noticed that it's described as deprecated, and that sassc should be used instead. Unfrotunately, sassc has no --scss option. 15:27:42 do you know where that config is? 15:31:21 rdopiera: config must be mentioned in these logs https://zuul.opendev.org/t/openstack/build/a1082efef2804b7193da8251df57e906/logs 15:31:27 thanks 15:31:44 I will look for that 15:31:45 but I will check with my colleague and let you know the exact path. 15:32:29 answering your question, yes, we definitely would need to mention both the memcached and the scss changes in the release notes, however, I'm afraid to merge those pathes so late in the release cycle 15:33:37 patches* 15:33:52 we can discuss at that time once the patches are ready that we should merge it in this cycle or in next cycle. 15:34:02 yes 15:34:15 I'm also worried about the scss compiler being deprecated 15:34:25 hmm. 15:34:32 perhaps we should convert our scss to sass at some point? 15:34:42 that will also let us use the mainstream bootstrap 15:35:26 fully automated conversion should be possible 15:36:36 honestly I have no idea about scss. I will look into this asap and let you know about my finding. 15:38:13 in other news, the py3.11 failure is also due to an invalid regular expression in PySass 15:38:32 ohh:( 15:39:45 I have a patch ready that monekypatches it 15:39:47 Radomir Dopieralski proposed openstack/horizon master: Add workaround for invalid regex in PySass https://review.opendev.org/c/openstack/horizon/+/892561 15:39:55 here it is 15:41:47 it will fail pep8 now 15:42:00 but something along these lines should work 15:42:59 Radomir Dopieralski proposed openstack/horizon master: Add workaround for invalid regex in PySass https://review.opendev.org/c/openstack/horizon/+/892561 15:43:00 sorry, mistake 15:43:05 Can we fix this issue here https://github.com/Kronuz/pyScss ? 15:43:22 and do a new release which we can use in horizon. 15:44:03 I think so 15:44:22 I assumed that since we have that monkeypatching file, we can't fix things 15:44:39 I will propose a pull request 15:44:49 a patch is also purposed their https://github.com/Kronuz/pyScss/pull/426/commits/60414f5d573315a8458b5fbcdf69e5c648c44a9a 15:45:29 I remember Ivan is also maintainer in that repo. 15:45:33 they seem to have unmerged prs from 2014... 15:46:39 do you remember Ivan forked this repo we used that repo in horizon. 15:48:02 https://pypi.org/project/pyScss/ 15:49:04 rdopiera: we can check with Kronuz to add you maintainer in that repo 15:52:03 I just noticed it is already fixed in pyScss https://github.com/Kronuz/pyScss/commit/73559d047706ccd4593cf6aa092de71f35164723 15:52:13 I don't want to be a maintainer :-( 15:52:21 oh, cool 15:52:28 just need to create a new release now. 15:52:56 let's comment in that repo to request for a new release. 15:56:27 I will let the tests for the patch run anyways, because I want to see if 3.11 will pass with it 15:57:14 yeah. let's see. 15:58:16 we can merge that patch also, and once new version is released for pyScss. we can revert that later. 16:00:19 sass not found. 16:01:21 ok let's keep looking at these issues. 16:02:00 thanks, everyone for joining. See you next week. 16:02:30 #endmeeting