12:02:14 <david-lyle> #startmeeting horizondrivers
12:02:15 <openstack> Meeting started Wed Sep  9 12:02:14 2015 UTC and is due to finish in 60 minutes.  The chair is david-lyle. Information about MeetBot at http://wiki.debian.org/MeetBot.
12:02:16 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
12:02:18 <openstack> The meeting name has been set to 'horizondrivers'
12:02:25 <david-lyle> anyone around ?
12:02:26 <r1chardj0n3s> o/
12:02:30 <tsufiev> o?
12:02:36 <mrunge> o/
12:02:38 <tsufiev> o/
12:02:46 <david-lyle> tsufiev: is that head scratching?
12:02:52 <r1chardj0n3s> looks like :)
12:03:03 <tsufiev> david-lyle, finger accidentally hit Shift :)
12:04:40 <robcresswell> o/
12:04:45 <david-lyle> so there isn't a set agenda for today, and the carry over angular items should probably wait for a 2000 UTC instance of this meeting
12:05:00 <david-lyle> are there any more FFE we should discuss first?
12:05:10 <david-lyle> there were a couple asked about
12:05:12 <robcresswell> I think there was a couple on the mailer...
12:05:20 <david-lyle> shelving/unshelving
12:05:31 * david-lyle needs to find BP
12:05:58 <robcresswell> This one was requested
12:06:03 <robcresswell> #link https://blueprints.launchpad.net/horizon/+spec/unified-job-interface-map-ui
12:06:16 <robcresswell> And also
12:06:17 <david-lyle> https://blueprints.launchpad.net/horizon/+spec/horizon-shelving-command
12:06:30 <robcresswell> #link https://blueprints.launchpad.net/horizon/+spec/horizon-shelving-command
12:06:42 <robcresswell> (Did I do that right?)
12:06:48 <david-lyle> yes
12:07:21 <david-lyle> I actually thought there was a much older shelving patch set
12:07:27 * tsufiev notices that not everybody knows about Horizon blueprint template
12:07:40 <mrunge> tsufiev, that bp is from time before
12:07:45 <robcresswell> There was this old patch, linked on the bp
12:07:46 <mrunge> this is ANCIENT
12:07:50 <tsufiev> mrunge, I meant the Sahara bp
12:08:24 <robcresswell> #link https://review.openstack.org/#/c/84646/
12:08:34 <david-lyle> yes exactly
12:09:10 <david-lyle> probably because I autoabandoned the other
12:09:21 <david-lyle> they proposed a new
12:10:04 <robcresswell> So the shleving one has code with some reviews, and is only 236 lines
12:10:27 <david-lyle> that one should be rather harmless
12:10:38 <david-lyle> and low risk, IMO
12:11:40 <robcresswell> Added myself to review. I'm happy with that being FFE
12:11:57 <mrunge> hmm, that would be a user visible change in liberty then :)
12:12:08 <robcresswell> mrunge: Curvature is visible too :p
12:12:26 <mrunge> robcresswell, hey! we have a second feature then!
12:12:49 <robcresswell> Just needs a couple more reviews, but nearly there.
12:13:03 <mrunge> david-lyle, ffe granted for shelve/unshelve?
12:13:12 <david-lyle> I think so
12:13:31 <mrunge> ok
12:13:42 <david-lyle> I added to RC-1
12:13:47 <david-lyle> if you'll remove the -2
12:13:52 <mrunge> done already
12:14:14 <david-lyle> ok the other was the job-interface-map-ui
12:14:20 <david-lyle> for sahara
12:15:20 <david-lyle> which BTW has several usable visible changes already in Liberty, for those keeping score
12:15:37 <david-lyle> ;)
12:15:46 <mrunge> really? I went through the list lately
12:15:59 <mrunge> and it's mostly code shifting, adjusting style
12:16:57 <robcresswell> It has quite a few reviews, ~500 lines so not huge, only touches sahara code.
12:17:08 <david-lyle> I'm actually ok with this one too
12:17:18 <david-lyle> it only needs 1 +2
12:17:21 <doug-fish> ... are we saying we think its mergable?
12:17:41 <robcresswell> Looks like it
12:17:44 <doug-fish> I'm just reviewing now (was preparation expected?) and https://review.openstack.org/#/c/209683/10/openstack_dashboard/contrib/sahara/content/data_processing/jobs/templates/data_processing.jobs/job_interface_arguments_template.html seems a bit concerning
12:17:54 <doug-fish> lots of script inside the html
12:18:22 <doug-fish> in fact a large string holding html in the script in the html file
12:18:37 <robcresswell> Not necessarily that is is mergeable in current state, but that it could be merged within FF.
12:18:43 <doug-fish> ah ok
12:18:50 <doug-fish> I can see that then
12:18:58 <david-lyle> doug-fish: the sahara code base has had fun things like that since the beginning
12:19:09 <david-lyle> because it was developed in a vacuum
12:19:19 <robcresswell> How strict are we expected to be on Contrib code styles?
12:19:32 <david-lyle> I believe in M they will move it back out of tree
12:19:42 <david-lyle> robcresswell: I have not been super strict
12:19:59 <robcresswell> I would normally immediately -1 for any inline styles or JS, but if thats part of their style and they are moving out anyway, I dont mind as much.
12:20:00 <david-lyle> because there was already precedent allowing in
12:20:22 <doug-fish> ok - I didn't realize we had that sort of thing in the sahara code already
12:21:04 <tsufiev> doug-fish, there were all kinds of weird things in their JS code
12:21:06 <david-lyle> not ideal, but to be fair, we (being the horizon team) aren't really maintaining it either
12:21:41 <mrunge> I see a pattern with sahara code being rushed in at the end of the cycle
12:21:49 <david-lyle> if they are happy with it and can maintain, I'm flexible
12:22:17 <david-lyle> mrunge: the pattern is more that we can't muster reviews for it until the end of the cycle
12:22:26 <mrunge> david-lyle, yes
12:22:32 <david-lyle> this particular patch is the youngest by far
12:22:35 <mrunge> and since we felt guilty, we merged
12:23:33 <mrunge> ls
12:23:37 <mrunge> darn
12:24:17 <david-lyle> going through the workflows/forms there are a ton of validation items that I think would help a lot, that aren't there too, but I know I haven't had time to try and go add them
12:24:30 <david-lyle> not that particular bp
12:25:20 <david-lyle> anyway, strong feelings?
12:25:59 <doug-fish> no - I'll settle down
12:26:06 <robcresswell> No strong objections from me
12:26:20 <david-lyle> IIUC, this is supporting a mainly UI feature that was added to Sahara in L
12:26:28 <david-lyle> hence the desire to make it visible
12:26:50 <mrunge> makes sense
12:26:54 <david-lyle> I'll grant the FFE and review the patch
12:27:22 <david-lyle> again FFEs are not guarantees, of anything other than reviews
12:28:46 <david-lyle> ok, I think that's the outstanding FFEs
12:30:49 <david-lyle> any other new bps to discuss or should we go back to hack and slash
12:30:50 <david-lyle> ?
12:31:22 <robcresswell> Nothing from me, can continue culling old bps
12:31:27 <david-lyle> the total list is 264 now
12:31:42 <david-lyle> was 29* recently
12:31:52 <david-lyle> so getting better
12:32:01 <robcresswell> Slowly improving :)
12:32:07 <mrunge> *+1*
12:32:14 <tsufiev> david-lyle, speaking of new bps, the one about glance image upload is in the agenda
12:32:45 <robcresswell> I still have a list of old bps that could be abandoned too
12:33:48 <david-lyle> tsufiev: you're right that one never got an official +1/-1
12:36:29 <david-lyle> TravT who has the most familiarity with glance raised several concerns about the bp after the meeting
12:37:23 <david-lyle> originally I was leaning toward accepting, but now I'm a bit the other way
12:37:44 <david-lyle> seems like the API version check has not been added yet
12:37:55 <david-lyle> could be I'm missing it
12:38:00 <tsufiev> david-lyle, anyways, we're not in a hurry here, I was going to work on it during M cycle
12:38:18 <tsufiev> I'll ask Travis to add his concerns to bp's whiteboard
12:38:43 <tsufiev> so I think we could skip it until we're certain about it
12:40:05 <david-lyle> mrunge, robcresswell, doug-fish? https://blueprints.launchpad.net/horizon/+spec/import-images
12:40:36 <david-lyle> #info FFE granted https://blueprints.launchpad.net/horizon/+spec/horizon-shelving-command
12:40:58 <david-lyle> #info FFE granted https://blueprints.launchpad.net/horizon/+spec/unified-job-interface-map-ui
12:41:05 <robcresswell> Trav left a comment last week saying that the concern is around a hard requirement on Glance v2
12:41:33 <david-lyle> robcresswell: yes there is no check in the code for the presence of the v2 API
12:42:52 <robcresswell> He didn't leave any comments on the bp itself, though. It looks pretty well formed, but code needs more work I suppose to support both versions?
12:42:57 <doug-fish> I'm having a hard time understanding the bp - are the import tasks a glance feature?
12:43:10 <david-lyle> doug-fish: a new one I believe
12:43:45 <doug-fish> does this bp assume horizon and glance are on the same node?
12:43:53 <doug-fish> (trying to sort out how this is being managed)
12:44:24 <david-lyle> no, it looks like a new API call has been added
12:44:42 <david-lyle> https://review.openstack.org/#/c/218773/3/openstack_dashboard/api/glance.py
12:44:52 <david-lyle> which is v2 only
12:45:05 <doug-fish> ah super - thanks!
12:46:32 <david-lyle> I don't see a pressing need for this before Mitaka
12:46:47 <mrunge> did any of us test it yet?
12:46:54 <robcresswell> No, and it sounds like the implementation needs work
12:47:12 <robcresswell> (but that is only based on Travs remark, havent dobne much research yet)
12:47:16 <robcresswell> done*
12:47:31 <doug-fish> wouldn't it make sense that this is an alternative to the legacy import, and would replace it when glance v2 is available?
12:48:46 <david-lyle> doug-fish: so I believe v2 is the current API and v1 is supported
12:49:02 <david-lyle> although nova only supports v1
12:49:08 <david-lyle> I think we have time
12:49:27 <david-lyle> I think this seems like a natural for M-1
12:50:06 <doug-fish> sure - that makes sense. I'll read up.
12:50:49 <david-lyle> #info FFE denied for https://blueprints.launchpad.net/horizon/+spec/import-images
12:51:08 <david-lyle> ok rob a couple of easy ones to bring us home
12:51:21 <robcresswell> #link https://blueprints.launchpad.net/horizon/+spec/override-records-per-page
12:51:24 <david-lyle> *robcresswell
12:52:21 <david-lyle> I think we can cull that until someone is ready to tackle it
12:52:25 <robcresswell> Yup
12:52:40 <david-lyle> which hasn't happened in 2 years
12:52:45 <doug-fish> :-)
12:52:48 <tsufiev> at least not until session_engine moves away from signed cookies
12:53:53 <robcresswell> #link https://blueprints.launchpad.net/horizon/+spec/more-criteria-filters
12:54:20 <david-lyle> #info https://blueprints.launchpad.net/horizon/+spec/override-records-per-page marked obsolete
12:54:58 <david-lyle> I think is superseded, but need to find a bp
12:55:28 <tsufiev> david-lyle, https://blueprints.launchpad.net/horizon/+spec/filtered-client-side-table ?
12:56:04 <david-lyle> yes tsufiev, the application of that one
12:56:12 <david-lyle> which is a large WIP
12:56:20 <david-lyle> no need for two large WIP
12:56:24 <david-lyle> around the same area
12:57:53 <david-lyle> #info https://blueprints.launchpad.net/horizon/+spec/more-criteria-filters marked superseded
12:58:03 <robcresswell> #link https://blueprints.launchpad.net/horizon/+spec/storagedriverconfigurator
12:58:11 <robcresswell> Probably do this last one quickly
12:59:14 <david-lyle> I remember this one
13:00:11 <david-lyle> I'm not sure it really fits, but needs a more concrete proposal and an owner
13:00:19 <david-lyle> even if it did
13:00:32 <doug-fish> yeah, this seems like it's a rough idea, not a blueprint
13:00:36 <david-lyle> I'm think we should shelve that one
13:00:50 <robcresswell> Yeah. The bp itself is not very helpful. If there is demand, it can just be rewritten
13:01:13 <robcresswell> There isn't much concrete info in there, or patches that we would wwant to keep track of.
13:01:54 <david-lyle> #info https://blueprints.launchpad.net/horizon/+spec/storagedriverconfigurator marked obsolete
13:02:01 <david-lyle> and we're at time
13:02:28 <david-lyle> Thanks everyone. Next week's meeting should be more of the second part than the first :)
13:02:32 <david-lyle> #endmeeting