20:00:00 #startmeeting horizondrivers 20:00:01 Meeting started Wed Apr 6 20:00:00 2016 UTC and is due to finish in 60 minutes. The chair is robcresswell. Information about MeetBot at http://wiki.debian.org/MeetBot. 20:00:02 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 20:00:05 The meeting name has been set to 'horizondrivers' 20:00:08 o/ 20:00:14 o/ 20:00:26 \o 20:00:56 \o 20:01:17 o/ 20:01:21 (◠‿◠✿)ノ 20:01:32 Lets get started 20:01:39 #topic Notices 20:01:44 o/ 20:01:54 o/ 20:02:07 Only one thing to mention briefly 20:02:14 #link https://etherpad.openstack.org/p/horizon-newton-summit 20:02:34 Make sure any last minute items are listed. I've reorganised it, and drafted the sessions to match 20:03:02 But if there is any last minute content or sugestions, add it and I'll see about adding to the schedule. 20:03:39 Are the things under line 97 all topics for the contributors meetup? 20:04:00 Yep 20:04:16 Thanks, sounds good. 20:04:35 I've moved items around to match common topics, and the others are more like individual issues that we can discuss at the meetup. 20:05:40 Agenda for today is empty. Does anyone have any blueprints they would like looked at? Otherwise I'll pick at random for review. 20:05:56 I have one, I think 20:06:21 Go ahead 20:06:29 * TravT looking at summit again 20:06:43 #link https://blueprints.launchpad.net/horizon/+spec/remove-httplib2-dep 20:06:49 * david-lyle had to find 20:07:24 this is somewhat time sensitive, in that the longer it's not merged, the more people write tests that are potentially broken 20:07:53 it started simple and onioned on me 20:08:17 sounds like it's a critical piece of work though 20:08:24 Ah yeah, we discussed this yesterday. It fixes a *really* annoying bug too (https://bugs.launchpad.net/horizon/+bug/1517704) 20:08:25 Launchpad bug 1517704 in OpenStack Dashboard (Horizon) "Test still passes even with tests failure" [High,In progress] - Assigned to David Lyle (david-lyle) 20:08:41 yeah, that was the onion part 20:08:50 Ah, sorry about that 20:09:51 Thinking approve and mark high. Any objections? 20:10:07 well 20:10:10 :) 20:10:40 makes sense to me. Let's put david-lyle on the spot! 20:11:11 #info https://blueprints.launchpad.net/horizon/+spec/remove-httplib2-dep Approved, High priority 20:11:17 +1 20:11:45 thanks 20:12:03 Oops, forgot to change topic 20:12:10 #topic Blueprint review 20:12:28 Any others? 20:13:14 I'll pick some out. 20:13:21 #link https://blueprints.launchpad.net/horizon/+spec/flavorconfigurator 20:14:13 -1 for not giving direct link to nova bp 20:14:21 Are blueprints still supposed to use the blueprint template that we used to use? 20:14:28 bpokorny: Yes 20:14:36 -1 for that too 20:14:37 Agree with TravT that this one is light on details. 20:15:04 so how would the flavor info get back and forth with the nova hosts??? that bp causes me more questions 20:15:29 its been up for 2 months or so, likely wont go anywhere :/ 20:15:37 Still, too early to remove outright. 20:15:52 Lets move on. I left a comment asking for more detail. 20:16:01 I have a favorite 20:16:06 #link https://blueprints.launchpad.net/horizon/+spec/next-steps 20:16:59 I like the idea. 20:17:09 do we want to make that a horizon construct ? 20:17:16 It's driven by what we want to do with the lbaas wizard 20:17:20 I think so 20:17:24 I do 20:17:24 like a wf is free to have anything for a landing page on success 20:17:49 Kinda like the Sahara guide 20:17:51 and that page could have next steps etc , common actions / status polling 20:17:53 I don't think any workflows have landing pages do they? 20:18:07 does Sahara? 20:18:09 doug-fish: Sahara has a step by step IIRC 20:18:16 they typically do not take advantage of that, but it's there to be used 20:18:16 It did before we removed it 20:18:29 It was veeeery laggy 20:19:02 But it was a cool idea. We've talked before about directing Create Net to details for further config 20:19:28 yes, I'd hope this functionality would work for that scenario as well 20:19:30 doug-fish: are these really separate actions or just actions that also include help text and can be displayed differenly? 20:19:45 it's the 2nd 20:20:01 I'd like to see two workflows use that concept, then drive some sort of "let's refactor anything common" from there ? 20:20:37 okay, from a angular registry perspective, i'd see this as being extra information being registered with the action. 20:20:50 agreed 20:22:09 robcresswell: would/could create net use this right away? 20:22:30 We're a long way off rewriting all the networking panels in angular 20:23:00 it's reasonably straightforward to put into Horizon https://review.openstack.org/#/c/301770/ 20:23:26 it *could* be done in the plugin, but would actually be more code. And less available for others to exploit. 20:23:58 Oh I agree on it being in the horizon lib 20:24:27 Sorry I think I misconstrued the question. 20:24:46 I'm for approving; the concept is good and we can refine the implementation in code review. 20:25:07 I'm a fan, but not entirely unbiased. :-) 20:25:27 It'd be useful for complex nested resources (mainly neutron work is jumping to mind) 20:25:36 i think the idea is good. definitely need to talk a bit about impl details. 20:25:41 I think that it's on the details page, it's useful. My concern was burying the lead 20:25:50 but the tables have that handled 20:26:10 doug-fish: part of my point being that these aren't really different actions. 20:26:20 that extra help text could be used in row / batch actions 20:26:25 as pop up or something as well 20:26:30 so, this is a JS only thing? 20:26:30 hover over 20:26:30 oh I see 20:26:43 david-lyle: Seems like its being targeted at angular 20:26:44 so this is impl detail 20:26:46 david-lyle: yes, I think so 20:26:57 it's new function you can get only with the new code 20:26:57 but is in the BP as well. 20:27:08 the bp specifically says angular 20:27:17 no much for consistency, but have to make change somewhere 20:27:36 *not 20:27:43 I dont think it would be huge issue; this is unlikely to be on every single detail page 20:27:43 doug-fish: this all just interesting extra metadata about an action 20:27:57 and the actions directive already has templates where you choose how to render it in the input args 20:28:09 well to developers that's what it is; I hope to users it's clarity on what should happen after creating a new object 20:28:11 so some details pages will have actions on the top right, and some in the page? 20:28:19 But I think it fits nicely with making creation more wf-oriented 20:28:20 it was more about locating 20:28:48 I wouldn't say no, just voicing observations 20:29:02 I think all details pages will have actions on the top right. Some details pages will also have some inline actions with extra text as well 20:29:12 I think its more about guiding people on more complex setup 20:29:20 doug-fish: ok, that's not in the mock 20:29:29 hence my confusion 20:29:35 oh wiat 20:29:38 I'm dumb 20:29:41 nevermind 20:29:54 time for a success? 20:30:20 I have no time for success 20:30:32 haha 20:30:47 looks good 20:30:47 +! 20:30:50 +1 20:31:26 Marking low, since its mainly aesthetic 20:32:00 i'll leave a comment reflecting my input above 20:32:08 #info https://blueprints.launchpad.net/horizon/+spec/next-steps Approved, marked Low 20:32:12 thanks TravT 20:32:44 yeah, sounds good, thx for the input! 20:33:18 btw, there is no ConfForFlavor bp in nova 20:33:30 #link https://blueprints.launchpad.net/horizon/+spec/horizon-multiple-objects-uploading 20:34:19 david-lyle: Can you leave a comment on that bp; when we circle back round later, we can just obsolete right away unless its updated. 20:34:32 robcresswell: sure 20:34:38 thanks 20:34:42 it's either dead all around or far in the future 20:35:06 Yeah, but I'd like to at least give the author a fair chance to respond 20:35:53 So this object store bp, its unclear if its Python or Angular based 20:36:27 I would assume Angular, but it was put up early March and could be either... 20:36:45 the need is there either way 20:37:20 True. I don't know how this ties in to r1chardj0n3s work 20:38:55 I don't think r1chardj0n3s has a bp 20:39:16 I can't see any conflicting blueprints. I think approve, but ask for clarification on code and ask author to work with richard. 20:39:32 makes sense to me 20:39:42 robcresswell: i think you need to state it is angular though 20:39:47 we deprecated django version 20:40:02 TravT: Yup, thats what I meant by clarification on code 20:40:06 okay 20:40:07 cool 20:40:08 vive le django! 20:40:27 remember the django? 20:40:35 we should buy david-lyle a shirt with that 20:40:38 :) 20:40:46 +1 TravT 20:40:58 btw, props on the local-settings.d last release 20:41:04 I'll take one of those shirts too though 20:41:11 * david-lyle unsure of the gender of django 20:41:24 masculine 20:41:29 feminine is djanga 20:42:14 but django is like a ship 20:42:18 #info https://blueprints.launchpad.net/horizon/+spec/horizon-multiple-objects-uploading Approved 20:42:34 * david-lyle will investigate 20:42:43 An old, old wooden ship 20:42:51 * robcresswell hoping everyone has seen Anchorman 20:43:41 #link https://blueprints.launchpad.net/horizon/+spec/angularize-vpn-table 20:43:56 oh oh 20:43:59 kick it out 20:44:12 vpn -> plugin 20:45:51 It looks like they intend to put the 4 tab tables in one page... 20:45:53 :/ 20:46:36 Either way, VPNaaS is a neutron plugin so should follow the path of LBaaS 20:46:39 vpn is no longer part of neutron proper 20:46:44 right 20:47:01 same with fwaas 20:47:22 sounds fine to me 20:47:32 I would be reluctant to put much more work on those into the horizon tree 20:47:39 other than bug fixes 20:48:34 * david-lyle going mobile 20:49:00 robcresswell: why is "plugin" and "operator" feedback one topic? 20:49:57 TravT: Operator rarely uses an entire session, so it seemed sensible to use the fishbowl for something that was most likely to get a larger group of people from outside Horizon 20:50:16 #info https://blueprints.launchpad.net/horizon/+spec/angularize-vpn-table Marked Obsolete; left comment about creating a Horizon plugin. 20:51:57 #link https://blueprints.launchpad.net/horizon/+spec/css-conventions 20:52:07 I think this has been superseded by hurgleburgler 20:52:08 uh oh 20:52:21 yeah 20:53:17 From the BP: "This blueprint is mainly about including some kind of documentation for contributors and reviewers to refer to." 20:53:47 Yeah, which exists now I believe 20:54:03 i'd say this is superceded / done with no clear additional done criteria giving it reason to stay open 20:54:04 yeah, we've been attempting to document as we go 20:54:35 http://docs.openstack.org/developer/horizon/topics/customizing.html and http://docs.openstack.org/developer/horizon/topics/styling.html 20:55:26 many of our naming conventions are defined by our use of Bootstrap as a css framework 20:55:45 #info https://blueprints.launchpad.net/horizon/+spec/css-conventions marked Superseded 20:56:12 #link https://blueprints.launchpad.net/horizon/+spec/enhance-tox 20:56:30 Wait, thats been approved, ignore it 20:57:03 * TravT ignored. check. 20:57:08 ha 20:57:42 #link https://blueprints.launchpad.net/horizon/+spec/operation-history-log 20:59:10 how would this work with multiple horizon processes deployed? 20:59:18 just rely on session affinity of load balancer? 20:59:25 shared FS? 20:59:30 I'd think a separate service would be needed to store the history 20:59:44 that kind of state seems well outside what Horiozn itself should be doing 21:00:27 Yeah. I dont think Horizon should be handling this logic. It sounds like something we would display, but would be handled elsewhere 21:00:45 okay, thanks for the meeting today. catch you on the flip side 21:00:54 Yeah, thats time. 21:00:58 Thanks all 21:01:06 Thanks! 21:01:09 #endmeeting