13:00:37 <Luzi> #startmeeting image_encryption
13:00:38 <openstack> Meeting started Mon Sep 16 13:00:37 2019 UTC and is due to finish in 60 minutes.  The chair is Luzi. Information about MeetBot at http://wiki.debian.org/MeetBot.
13:00:39 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
13:00:41 <openstack> The meeting name has been set to 'image_encryption'
13:00:56 <Luzi> #topic Roll Call
13:01:19 <mhen> o/
13:01:27 <fungi> a deh ya!
13:01:35 <moguimar> o/
13:01:43 <fungi> (but not very caffeinated yet)
13:03:38 <Luzi> welcome to another monday :)
13:03:51 <Luzi> maybe we wait one more minute or two
13:05:34 <moguimar> I pinged redrobot
13:06:21 <Luzi> #topic Barbican Consumer API Update
13:06:56 <Luzi> moguimar, mhen is currently reviewing :)
13:07:04 <mhen> yes, I started to have a look at the patches for secret consumers
13:07:23 <mhen> so far they seem fine to me, however I'm not that familiar with all aspects of Barbican's internals, so there are parts I can't really judge
13:07:53 <mhen> thus, I don't feel particularly qualified to give a review score to be perfectly honest
13:09:18 <mhen> are there any guidelines for giving a +1 besides https://docs.openstack.org/infra/manual/developers.html#peer-review ?
13:09:43 <moguimar> not that I'm aware of
13:09:58 <fungi> i think there's some guidance in the project teams guide section on code review, checking now
13:10:36 <fungi> #link https://docs.openstack.org/project-team-guide/review-the-openstack-way.html How to Review Changes the OpenStack Way
13:11:03 <mhen> fungi, thanks!
13:11:27 <fungi> not sure if it has anything significantly different in there about +1, but worth skimming
13:14:48 <mhen> btw, did I miss a patchset or is the API controller for secret consumers still missing?
13:17:12 <mhen> ^ moguimar ?
13:17:47 <moguimar> still missing
13:17:53 <mhen> okay
13:18:07 <moguimar> I'm a bit blocked with some other tasks
13:18:19 <moguimar> but this week I should be done with them
13:18:51 <mhen> moguimar, sounds good. Thanks for your work!
13:19:14 <Luzi> yes thank you moguimar :)
13:21:45 <redrobot> moguimar, \o/
13:21:45 <moguimar> thanks for the reviews =D
13:22:06 <Luzi> hi redrobot
13:22:16 * mhen skimmed fungi's linked review howto in the meantime and learned some useful recommendations about voting on a patch
13:22:28 <Luzi> #topic Image Encryption Specs
13:23:35 <Luzi> next topic, the specs without updates from our side this week, as we have another deadline approaching
13:23:51 <Luzi> #topic Open Discussion
13:24:06 <Luzi> are there any other topics?
13:25:51 <fungi> i didn't have anything
13:26:36 <Luzi> okay, thank you all for joining this meeting :)
13:26:42 <Luzi> #endmeeting image_encryption