15:01:06 #startmeeting ironic 15:01:06 Meeting started Mon Jun 26 15:01:06 2023 UTC and is due to finish in 60 minutes. The chair is JayF. Information about MeetBot at http://wiki.debian.org/MeetBot. 15:01:06 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 15:01:06 The meeting name has been set to 'ironic' 15:01:15 Gooood morning Ironic'ers! Who all is here this morning? 15:01:19 o/ 15:01:20 o/ 15:01:26 o/ 15:01:54 o/ 15:02:02 #topic Announcements/Reminder 15:02:20 This is where I'd usually note to review things wiht #ironic-week-prio and to mark things as #ironic-week-prio if you want it reviewed 15:02:34 but frankly, unit tests are a mess (to be addressed later) and we should not approve anything until they are fixes 15:02:50 please point review love at the priority order of: unit tests; ironic-week-prio ;) 15:03:21 There were no action items out of our 6/19 meeting, so I'm skipping that agenda item. 15:03:33 #topic Reivew Ironic CI status 15:03:44 you know, I put all the commenst in open discussion, but I think we can talk about this here 15:03:58 Unit tests are broken! At least, they are until more things merge 15:04:11 there are at least three separate things that we need to get unit tests back in good shape 15:04:17 First: Failures when running migrations 15:04:34 the changes we believe will fix this, and undo any attempts to mitigate the damage since it's been busted are 15:04:39 #link https://review.opendev.org/c/openstack/ironic/+/886985 15:04:46 #link https://review.opendev.org/c/openstack/ironic/+/886881 15:04:49 #link https://review.opendev.org/c/openstack/ironic/+/886196 15:05:03 Second: Failures in TestNeutronVifPortMixing 15:05:22 this one, we don't have fixed, but it's not really OK for it to fail intermittantly all the time either 15:05:31 I proposed a change to disable it, and a bug to track re-enabling 15:05:37 #link https://review.opendev.org/c/openstack/ironic/+/886911 15:05:42 #link https://bugs.launchpad.net/ironic/+bug/2024994 15:06:11 If you don't think this is the right approach; please comment in the bug and/or the change, I'm open to other solutions but not really Ok with us just suffering under a test that fails 5-10% of the time for any longer :D 15:06:18 and finally 15:06:28 Adding tests to ensure SQLA2.0 compat is not broken 15:06:38 #link https://review.opendev.org/c/openstack/ironic/+/885797 to fix tests under sqla 2.0 15:06:53 #link https://review.opendev.org/c/openstack/ironic/+/886020 adds a sqla 2.0 job (we need to rebase this once tests are fixed) 15:07:22 #link https://review.opendev.org/c/openstack/ironic/+/886871 Fixes an SAWarning around DB schema -- I'm not sure this is really testing related, but I think it's another change we need to land to make CI fully happy 15:07:41 Any thoughts on this? Did I miss anything? Any discussion we wanna have around this? 15:07:46 to at least... remove a warning that will become an error at some point 15:08:13 JayF: thanks, I believe that's all, and a lot :) 15:08:15 No issues, I believe the first few are already in route to CI 15:08:55 This all just makes me wonder if there's something we can look at from a higher level to help in the future 15:09:10 like writing something in migrations tests to ensure you never pass a SQLA object in the data dict 15:09:43 I don't really know, but it seems obvious we need more guardrails given the age of some of the miscoded tests fixed in 886881 15:10:41 It is not the most widely known aspect of sqlalchemy, fwiw 15:10:56 and it's going to crop up more as people do sqla migrations 15:10:56 so definitely not "easy" 15:11:16 Part of me wonders if there's a guardrail to put in for oslo db 15:11:27 to try and "save" the smaller projects from tha pain we just felt over the last two weeks 15:11:40 That can be a whole debate 15:12:06 well I might spike on having the discussion, if it gets to code then I can wail against that lol 15:12:18 heh 15:12:25 but I look at this this way: if it took us two weeks-ish, as a team that has more sqla strength than most 15:12:33 Merged openstack/ironic master: Fix test_migrations with firmware information. https://review.opendev.org/c/openstack/ironic/+/886881 15:12:34 then a smaller project with a similar bug has very little chance 15:12:55 but that's not an ironic problem; but I'll still try and spread the love of our lessons learned 15:13:00 going to move on now unless there's further? 15:13:44 no objection here 15:13:56 #topic Review ongoing 2023.2 workstreams 15:13:59 #link https://etherpad.opendev.org/p/IronicWorkstreams2023.2 15:14:22 I've been behind on reviewing some of this stuff because I've been pointing all my brainpower at tests; going to try and correct that this week. 15:16:17 no comments on workstreams, moving on 15:16:21 #topic Open Discussion 15:16:26 I have a note here on PTL availability 15:16:47 #note JayF will be mostly unavailable upstream the week of 7/10. 15:17:09 do you need someone to run the meeting that week? 15:17:12 Can someone volunteer to run the 7/10 and also 7/17 meetings? I should be here week of 7/17 just being careful 15:17:51 That week I'll be visiting my coworkers in the UK, so I'll be in a different timezone even if I get to point my brain at upstream :D 15:18:38 * TheJulia checks calendars 15:18:43 I can't =( 15:18:52 7/10 I'm on vacation 15:19:00 Worse case, if I put this call out next week and get some "no"s, we can cancel the meeting. 15:19:04 7/17 I'm traveling back .-. 15:19:12 This has been the most substantive one in a while just because of the unit tests :D 15:19:20 I'm available 15:19:24 for both? 15:19:27 yeah 15:19:28 I'm also available 15:19:41 who wants what? 15:19:44 rpittau: if you'd like to, the gavel is yours 15:19:48 You tell me and I'll put it in an action so we can have it marked 15:19:58 as it is voluntold, so shall it be written :P 15:20:07 #action rpittau to run Ironic meeting 7/10 and 7/17 15:20:07 hehehe 15:20:11 lol 15:20:16 evil man, evil :) 15:20:21 Anything else for Open Discussion? 15:20:24 yay (?) 15:20:31 rpittau: worst comes to worst, let lmk :) 15:20:34 rpittau: it'll be your turn for PTL soon ;) 15:20:41 heh 15:20:42 rpittau: just embarce the gavel 15:20:43 * rpittau hides 15:20:49 * TheJulia hears evil laughter from the background 15:20:58 * TheJulia notes in our line of work, evil is good. 15:21:04 ++ 15:21:15 Anything non-philosophical for the rest of open discussion? hah 15:22:04 Aight, I think that does it then. 15:22:07 #endmeeting