16:01:50 <TheJulia> #startmeeting ironic_bfv
16:01:51 <openstack> Meeting started Thu Jun  8 16:01:50 2017 UTC and is due to finish in 60 minutes.  The chair is TheJulia. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:01:52 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:01:54 <openstack> The meeting name has been set to 'ironic_bfv'
16:02:01 <TheJulia> Good morning everyone!
16:02:15 <derekh> o/
16:02:22 <TheJulia> Our agenda for today
16:02:25 <TheJulia> #link https://wiki.openstack.org/wiki/Meetings/Ironic-BFV
16:02:43 <TheJulia> #topic Announcements/Reminders
16:03:19 <TheJulia> I believe this is the week of Pike-2, so we definitely need to start getting some reviews and some of the code landed soon.
16:03:48 <hshiina> that's right
16:04:17 <mjturek> o/
16:04:25 <mjturek> hey everyone :)
16:04:26 <TheJulia> I and mjturek rebased/updated some of the patches to try and get that cleaned up.  Hopefully later today well have patches with clean ci runs ready for review
16:04:40 * TheJulia should have said that backwards, but *shrug*
16:05:02 <TheJulia> That being said, that is also current status :)
16:05:09 <mjturek> yeaaah, screwed up py27/35 and pep8 in a couple places. Will have fixed shortly
16:05:40 <TheJulia> #info Reviewers, please consult the list of revisions at https://etherpad.openstack.org/p/Ironic-BFV
16:06:06 <TheJulia> I guess we should move on to current status unless anyone has anything to announce?
16:06:56 * TheJulia thinks she has crickets, or everyone is watching US congressional testimony
16:07:11 <mjturek> oh - I probably can't make next week's meeting, but I will try!
16:07:25 <TheJulia> mjturek: Okay, good to know, thanks!
16:07:31 <TheJulia> Moving on!
16:07:36 <TheJulia> #topic Current Status
16:07:50 <TheJulia> Our etherpad is fairly up to date, https://etherpad.openstack.org/p/Ironic-BFV
16:08:39 <TheJulia> mjturek is going to fix a couple minor breaks above, and we'll get everything rebased so we have verified+1 for CI
16:08:53 <TheJulia> I also saw the notes from last week \o/
16:09:01 <TheJulia> but we can discuss that more in discussion. :)
16:09:09 <TheJulia> Anyone have any status updates to report?
16:09:12 <derekh> We were talking about tempest and a new CI job last week, I've proposed a new CI job here https://review.openstack.org/#/c/470307/
16:09:33 <mjturek> yep it looks good derekh!
16:09:37 <hshiina> derekh: thanks
16:09:47 <derekh> but its a WIP until the tempest test are ready any we know what ironic-tempest-regex to use
16:10:00 <TheJulia> oohhhh
16:10:08 <TheJulia> Is that on the ether pad?
16:10:22 <derekh> yup, line 38
16:10:40 <TheJulia> awesome!
16:10:47 <TheJulia> Wow, things are coming together kind of nicely
16:12:04 <TheJulia> Anything else to bring up?
16:13:01 <TheJulia> Moving on if there is nothing else
16:13:23 * TheJulia waits a little bit
16:13:57 <derekh> nothing from me
16:13:58 <mjturek> I'm good - I'm pretty sure I've handled the comments in the current two patches. If I've missed anything, please ping me
16:14:07 <TheJulia> Awesome
16:14:08 <TheJulia> #topic Planning/Priorities
16:14:48 <TheJulia> I think the priorities at the moment are getting the patchset in order with CI feedback and reviews.
16:15:57 <TheJulia> The skip deployment patch may need a little more work, hshiina I left a reply in review after checking the revisions that mjturek updated.
16:16:23 <TheJulia> I'd like to discuss that, if you have time hshiina
16:16:41 * TheJulia feels like she is just kind of stating the obvious today :)
16:17:43 <mjturek> yeaaah need to dig into the skip patch a bit today, will review
16:17:53 <hshiina> TheJulia: sure.
16:18:31 <TheJulia> I think we're good to move on to Open Discussion at this point, unless there is anything we should incorporate or that needs to be raised?
16:19:31 <mjturek> I'm good :) (wow we're blazing through today)
16:19:45 <TheJulia> *shrugs*
16:19:56 <TheJulia> #topic Open Discussion
16:21:48 <TheJulia> bare with me a moment, I'm looking for a specific revision to pose a question/thought
16:21:58 <mjturek> np
16:23:56 <TheJulia> So, going back to https://review.openstack.org/#/c/454243/ which is the skip patch, and then glancing at https://review.openstack.org/#/c/441944/9/ironic/drivers/modules/agent.py which is the patch hshiina proposed.  Which adds task.driver.boot.prepare_instance(task).  I feel like that is already called by the Agent deploy driver's prepare method.
16:24:36 <TheJulia> I think that would cover it, with the wire-in being in the conductor before deploy.prepare, but I could very well be wrong or recalling something incorrectly
16:26:22 <TheJulia> so, looking for the link, it looks like I'm wrong
16:26:40 <TheJulia> we would need to re-call it it seems, since we are truly only performing attachment on power ops in this case
16:27:06 <TheJulia> err, that is only when active
16:27:43 <mjturek> so basically prepare_instance wasn't getting called unless the node was already ACTIVE?
16:27:51 <TheJulia> https://review.openstack.org/#/c/406290/34/ironic/drivers/modules/agent.py
16:28:06 <TheJulia> so yeah, we do need to still call prepare_instance because we are in DEPLOYING
16:28:39 <TheJulia> prepare_instance only gets called because of the conductor takeover code
16:29:29 <hshiina> TheJulia: yes, prepare_instance is not called in bfv case.
16:29:45 <TheJulia> I'll update the revision this afternoon to reflect that
16:30:04 <hshiina> TheJulia: thanks
16:30:14 <mjturek> cool
16:31:37 <TheJulia> hshiina: I think i still need to digest your changes in ironic/drivers/modules/pxe.py.  Do you see them as necessary with the skip patchset?
16:32:52 <hshiina> i think it is necessary
16:33:28 <hshiina> some configuration for pxe is done in prepare_ramdisk
16:34:03 <hshiina> if prepare_ramdisk is not called, some work seems necessary in prepare_instnce
16:35:06 <TheJulia> Okay, that seems very likely given how complex both of those methods are
16:36:56 <TheJulia> I'll update the skip revision later today
16:37:21 <TheJulia> Anything else to discuss today?
16:39:06 <hshiina> i have nothing
16:39:58 <TheJulia> Excellent, Thank you everyone!
16:40:05 <mjturek> thanks TheJulia!
16:40:07 <mjturek> ttyl
16:40:07 <derekh> ty
16:40:12 <hshiina> thank you!
16:41:21 <TheJulia> #endmeeting