16:02:38 <Sukhdev> #startmeeting ironic_neutron
16:02:38 <openstack> Meeting started Mon Feb  1 16:02:38 2016 UTC and is due to finish in 60 minutes.  The chair is Sukhdev. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:02:38 <apuimedo> :'(
16:02:39 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:02:42 <openstack> The meeting name has been set to 'ironic_neutron'
16:02:46 <jroll> morning
16:02:48 <apuimedo> sorry Sukhdev
16:02:54 <devananda> morning
16:02:57 <Sukhdev> apuimedo : no worries
16:03:09 <vdrok> o/
16:03:13 <Sukhdev> #topic: Agenda
16:03:20 <Sukhdev> #link: https://wiki.openstack.org/wiki/Meetings/Ironic-neutron#Meeting_February_1.2C_2016
16:03:37 <Sukhdev> I kept the same agenda from last week
16:03:47 <davidlenwell> o/
16:03:48 <Sukhdev> we'll modify as we go along
16:03:59 <Sukhdev> #topic: Announcements
16:04:22 <Sukhdev> If you are planning on presenting a session at Austin Summit, deadline is today
16:04:35 <Sukhdev> before midnight tonight PST
16:04:35 <jroll> actually, it got extended to tomorrow
16:04:48 <jroll> http://lists.openstack.org/pipermail/openstack-dev/2016-February/085462.html
16:04:48 <vdrok> yep, tomorrow 2359 pst
16:04:57 <Sukhdev> jroll : oh really - did not know that - thanks for sharing
16:05:04 <jroll> np
16:05:29 <Sukhdev> #topic: Integration Status
16:06:10 <Sukhdev> Looks like most of patches are working fine
16:06:25 <Sukhdev> I tested them all - other than one, all worked just fine
16:06:35 <Sukhdev> I posted the comment on the one
16:06:47 <jroll> so, the nova patch issue is actually a client bug imo
16:07:01 <jroll> the client should return portgroup_uuid as an attribute of port
16:07:08 <jroll> I believe right now it returns portgroup_id
16:07:44 <Sukhdev> jroll : yes - that is correct
16:08:33 <Sukhdev> Other than that, I am up and running all the latest patches
16:09:17 <Sukhdev> If others do not find any issue with these, shall we consider merging them?
16:09:27 <Sukhdev> It is really a pain to manage them :-)
16:10:20 <jroll> I've been asking folks to review them, and I believe some have been doing so
16:10:30 <Sukhdev> jroll devananda : we decided couple of weeks ago the order in which they should be merged
16:10:38 <Sukhdev> can we execute on that plan?
16:10:38 <jroll> I've been slacking on reviews myself, unfortunately
16:10:46 <jroll> and I can't tell people to merge things
16:11:00 <jroll> Sukhdev: we did execute, using -2s as the border
16:11:13 <jroll> so when a group of patches is all +A, we can remove the -2 and they will land
16:12:57 <Sukhdev> how and when we decided to add +A?
16:13:24 <jroll> +A is done by core reviewers when they feel the patch is ready
16:13:28 <jroll> that's the approval
16:13:36 <Sukhdev> I noticed some of them have some minor comments -but, mostly addressed
16:13:41 <devananda> the API patches had some issues which I pointed out last week
16:13:58 <jroll> well, these need to go through review until reviewers are satisfied
16:14:20 <jroll> I can't make people approve patches, and I can't approve patches if other reviewers don't think they should be
16:14:40 <jroll> does that make sense?
16:15:04 <Sukhdev> jroll : understood - I am just suggesting that we can start asking cores to review them
16:15:26 <jroll> Sukhdev: I've been asking for weeks
16:15:28 <Sukhdev> sometime people sit and wait as they think these are still being worked on
16:15:30 <jroll> and some cores are reviewing them
16:15:54 <jroll> or rather, rloo, deva, and myself. haven't seen much from other cores there
16:16:03 <jroll> oh and vdrok
16:16:03 <Sukhdev> jroll : cool - as long as you are asking them, then we are good
16:16:50 <Sukhdev> well, we need two +2's :-):-)
16:17:51 <vdrok> Sukhdev, rather we need no -1s :)
16:18:18 <Sukhdev> devananda : regarding the API issue, jroll and you were going to look into it - any update on that front
16:18:31 <Sukhdev> vdrok : absolutely
16:19:18 <vdrok> Sukhdev, iirc it is about hiding portgroups completely for earlier api versions
16:19:52 <Sukhdev> vdrok : yes - backward compatibility
16:19:54 <vdrok> vsaienko did fixed that I guess, looking at the code
16:21:35 <Sukhdev> I did not look at the patches as of last Wednesday -
16:23:08 <Sukhdev> seems like deva disappeared -
16:23:21 <jroll> there he is
16:23:24 <jroll> 16:18:18        Sukhdev | devananda : regarding the API issue, jroll and you were going to look into it - any update on that front
16:23:48 <devananda> sorry about that. fat fingered a command and broke my irc client
16:23:51 <Sukhdev> yup he was there, but, I do not see him now
16:24:01 <jroll> heh
16:24:04 <Sukhdev> devananda : ah ha
16:24:18 <devananda> I proposed a small patch on top to fix it (let me get the link)
16:24:54 <devananda> https://review.openstack.org/#/c/273119/
16:25:45 <vdrok> devananda, yep, vsaienko added that to api change, along with some more validation of input to some fields
16:25:57 <Sukhdev> #link: https://review.openstack.org/#/c/273119/
16:26:08 <devananda> vdrok: great - I'll take a look
16:26:36 <Sukhdev> I will add this to the etherpad to keep track of this -
16:27:32 <Sukhdev> Other than this and nova patch, we are looking good
16:28:34 <vdrok> also this one https://review.openstack.org/#/c/139687/53 will have some more refactoring, it's already in progress
16:28:44 <vdrok> to resolve rloo comments
16:29:07 <devananda> jroll: if you and/or rloo +2 the patches, I will start +2/+A'ing as they are ready
16:29:16 <devananda> up to the API changes, that is
16:29:24 <jroll> devananda: cool, I'll get on it today/tomorrow
16:29:33 <devananda> that will at least reduce the rebase load on these folks
16:29:54 <devananda> https://review.openstack.org/#/c/206244/51 and https://review.openstack.org/#/c/139687/50 are the tricky ones right now
16:30:02 <devananda> they both have a lot of API changes
16:30:22 <devananda> honestly, I should spend a whole day (maybe two) going over these two patches
16:30:25 <devananda> I just haven't had the time :(
16:30:45 <Sukhdev> devananda : thanks
16:30:45 <jroll> ditto
16:32:01 <Sukhdev> jroll : for nova patch - where do the fix need to go?
16:32:29 <jroll> Sukhdev: the client should return portgroup_uuid on the port object
16:33:23 <Sukhdev> so, this will go with the API fix then
16:33:39 <Sukhdev> i mean after
16:34:23 <jroll> right, it's a client thing, assuming the api already returns it
16:35:44 <Sukhdev> Anything on the integration status?
16:35:57 <Sukhdev> I mean anything else
16:37:04 <Sukhdev> I have been carrying the tempest testing topic from previous meetings, but, never got to it
16:37:13 <Sukhdev> yuriy are you here?
16:37:48 <Sukhdev> I saw a patch, but, have not had a chance to review it -
16:38:32 <Sukhdev> looks like yuriy is not here - so, will skip it
16:38:45 <Sukhdev> I am done with the agenda that I had in mind
16:38:57 <Sukhdev> #topic: Open Discussion
16:39:15 <Sukhdev> Anything we need to discuss ?
16:39:25 <Sukhdev> we have 21 mins
16:39:55 <vdrok> btw here is the link - https://review.openstack.org/#/c/269157/
16:40:00 <Sukhdev> Otherwise, lets use those 20 min. to write up proposals for summit sessions :-):-)
16:40:02 <jroll> I've got nothing here
16:40:15 <Sukhdev> #link:https://review.openstack.org/#/c/269157/
16:40:40 <Sukhdev> vdrok : thanks
16:41:16 <Sukhdev> OK - folks, looks like we are done
16:41:36 <Sukhdev> Thanks for attending
16:41:41 <Sukhdev> bye
16:41:45 <devananda> o/
16:41:50 <jroll> thanks Sukhdev
16:41:55 <vdrok> bye
16:41:58 <Sukhdev> #endmeeting