18:02:30 <TheJulia> #startmeeting ironic_ui
18:02:30 <openstack> Meeting started Tue Apr  4 18:02:30 2017 UTC and is due to finish in 60 minutes.  The chair is TheJulia. Information about MeetBot at http://wiki.debian.org/MeetBot.
18:02:31 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
18:02:33 <openstack> The meeting name has been set to 'ironic_ui'
18:03:26 <TheJulia> Our agenda, as always https://wiki.openstack.org/wiki/Meetings/Ironic-ui
18:03:30 <TheJulia> #link https://wiki.openstack.org/wiki/Meetings/Ironic-ui
18:03:55 <TheJulia> #topic Announcements/Reminders
18:04:30 <TheJulia> #info TheJulia will likely miss the meeting next week, and will be on vacation the following week. crushil has volunteered to run the meeting next week.
18:04:37 <TheJulia> That is all I have, anyone else?
18:05:21 <TheJulia> I know crushil was unable to make it today.
18:05:26 <crushil> I am here
18:05:29 <crushil> Just listening in
18:05:35 <TheJulia> o/
18:05:37 <crushil> \o
18:05:37 <TheJulia> Awesome
18:05:52 <TheJulia> Okay, well, If there are no other announcements, I guess we shall proceed.
18:06:36 <TheJulia> #topic Current Status
18:07:29 <TheJulia> I had an item to look at jasmine unit test automation, and realized that our npm job was not actually firing any tests, although I don't know the details of how that works to fix it.
18:07:49 <TheJulia> betherly: By chance, is that something you have any knowledge of?
18:08:38 <betherly> TheJulia: hmm no i wasn't aware that was happening. I'll take a look
18:08:50 <TheJulia> Thank you betherly
18:09:12 <TheJulia> #info betherly to look at the unit test execution issues
18:09:14 <betherly> TheJulia: I'll probably have a response tomorrow now as I'm slightly brain dead this evening lol
18:09:23 <TheJulia> betherly: no worries!
18:09:54 <TheJulia> Other than that issue, ppiela_ has a number of revisions to be rebased due to merge conflicts.
18:10:02 <TheJulia> ppiela_: By chance, are you here today?
18:10:24 <betherly> ppiela_: TheJulia: id be happy to help with the rebasing if it would be useful?
18:10:39 <ppiela_> I am here
18:11:01 <crushil> I can help out with rebasing too
18:11:36 <TheJulia> ppiela_: Any objections for people to pickup some of the revisions and rebase them?
18:11:42 <ppiela_> I got pulled off to work on other stuff
18:11:58 <betherly> ppiela_: just let us know what you want us to do :) im very happy to help with that tomorrow but don't want duplicate work being done or to step on toes
18:12:19 <TheJulia> ppiela_: it happens :)
18:12:31 <ppiela_> I dont have a problem with that, but really want to understand what I did wrong
18:12:31 <betherly> yup!
18:12:59 <betherly> ppiela_: i can do it over a video call if that would be useful?
18:13:08 <betherly> It's likely nothing you did wrong
18:13:16 <betherly> Just things merging in weird order
18:13:27 <betherly> I haven't looked into it yet though
18:13:29 <TheJulia> ppiela_: oh, on the rebase you did?
18:14:06 <ppiela_> Thanks. If it is not holding up others, I would like to make another pass before calling for the cavalry
18:14:20 <TheJulia> ppiela_: I think ``git rebase -R`` would have prevented it instead of ``git rebase``
18:14:22 <betherly> ok. just ping me if you need a hand
18:14:31 <ppiela_> thx
18:14:44 <TheJulia> But anyway, we should  back on track.
18:14:54 <TheJulia> Anyone have any other statuses to report?
18:15:51 <TheJulia> I guess not, moving on...
18:16:08 <TheJulia> #topic Planning/Priorities
18:16:34 <TheJulia> The only priority that I see right now is getting the outstanding revisions rebased, but even that is not an urgent activity.
18:17:02 <TheJulia> I looked at launchpad earlier today and we had no new bugs.
18:18:09 <TheJulia> Any questions or items regrant planning or priority?
18:19:25 * TheJulia hears crickets
18:20:00 <TheJulia> Since we have no discussion items, we will just go to open discussion.
18:20:13 <TheJulia> #topic Open Discussion
18:21:20 <TheJulia> Anyone have anything they wish to discuss today?
18:21:31 <ppiela_> Nothing here
18:22:02 <soliosg> I have a newbie question. Does ironic-ui relies on python-ironicclient or talks directly to ironic-api?
18:22:05 <TheJulia> robcresswell: Out of curiosity, should we still expect testing guidelines around Pike-3?
18:22:21 <TheJulia> soliosg: It uses python-ironicclient
18:22:57 <TheJulia> soliosg: Requests are proxied through horizon
18:22:57 <soliosg> Thanks. I found that in requirements.txt, just wanted to confirm.
18:23:30 <TheJulia> soliosg: Thank you for asking :)
18:23:44 <soliosg> Is there a plan to migrate to openstackclient in the future?
18:23:57 <soliosg> That's actually my manager's question ;)
18:24:34 <ppiela_> soliosg: that has not been discussed
18:24:39 <TheJulia> soliosg: so, we import python-ironicclient for the rest API client, and openstackclient actually federated out all OSC commands and api calls out to client libraries
18:24:51 <jroll> openstackclient isn't a python SDK, right, just a CLI
18:25:33 <TheJulia> Basically what jroll said too :)
18:26:23 <TheJulia> soliosg: Was there a specific concern with invoking python-ironicclient?
18:26:53 <soliosg> Thank you
18:27:57 <soliosg> Oh, no concern actually
18:28:13 <TheJulia> Okay, just wanted to make sure.  :)
18:28:39 <TheJulia> Excellent!  Anything else to discuss today? Aside from using the ui to take over the world of course.... :)
18:30:05 <ppiela_> I have do a style/philosophy question on the ironuc-ui api modules
18:30:51 <ppiela_> To what extent should be trying to make them faithful 1:1 proxies of the client?
18:31:07 <ppiela_> This is coming up in code reviews
18:31:23 <ppiela_> For example, node_id versus node_ident
18:32:47 <ppiela_> Should the api calls accept both node names and uuids even though the ui components will likely always have the uuid?
18:32:53 <TheJulia> Internal style consistency is more important than the variable naming for a single value. If someone really feels strongly about it, it can be bulk changed in a revision, but I don't think naming is really a big deal. I'd be more concerned about including extra data in the reply from horizon to the web page
18:34:34 <TheJulia> We kind of had the same discussion in shade, and I think we started leaning towards name_or_id for positional variable names
18:34:38 <robcresswell> TheJulia: pike-1, so next week.
18:34:53 <jroll> TheJulia: +1
18:34:54 <robcresswell> Sorry, just out atm but reading the scrollback :)
18:35:06 <TheJulia> robcresswell: awesome!
18:36:04 <TheJulia> #info robcresswell reports that we should have some integration testing guidance from horizon next week.
18:36:58 <TheJulia> ppiela_: if it is positional, it... really should not be a big deal. Hopefully that answers your question? :)
18:37:20 <ppiela_> TheJulia: I agree on consistency. Let's see how things go
18:37:38 <TheJulia> Sounds good!
18:37:38 <ppiela_> TheJulia: yes it does
18:37:45 <TheJulia> Anything else to discuss today?
18:39:11 * TheJulia hears crickets and thinks everyone can have twenty minutes back
18:39:26 <ppiela_> Thank you!
18:39:54 <soliosg> Thanks everyone!
18:40:14 <TheJulia> Thank you everyone!
18:40:16 <TheJulia> #endmeeting