18:01:09 #startmeeting ironic_ui 18:01:10 Meeting started Tue Jun 20 18:01:09 2017 UTC and is due to finish in 60 minutes. The chair is TheJulia. Information about MeetBot at http://wiki.debian.org/MeetBot. 18:01:11 o/ 18:01:12 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 18:01:14 The meeting name has been set to 'ironic_ui' 18:01:17 \o 18:01:17 Hello 18:01:37 Hey crushil: How are things? 18:01:49 ppiela, BUsy. How about you? 18:02:03 Greetings everyone! 18:02:26 Busy also, did you get your Ironic setup going? 18:02:40 Our agenda, as always; 18:02:40 Hi TheJulia: 18:02:42 ppiela, I did. Hi TheJulia 18:02:45 #link https://wiki.openstack.org/wiki/Meetings/Ironic-ui 18:02:56 crushil: Cool! 18:03:11 crushil: I had meant to checkin 18:03:20 #topic Announcements/Reminders 18:03:52 The only thing I have is that we are about a month away from needing to cut the ironic-ui release for the translation team to be able to do any translation updates before the end of the cycle. 18:03:52 None here 18:04:50 So, tl;dr, reviewing would be appreciated. :) 18:05:21 #info ironic-ui is approximately 1 month from where we will need to cut the release to enable time for the translation team to perform their work. 18:05:30 Anyone have anything else? 18:05:45 I will be out for 3 weeks starting monday 18:06:08 I'll try to do some reviews before I leave 18:06:16 crushil: Much appreciated! 18:06:44 thanks crushil: 18:07:26 #topic Current Status 18:07:54 #info Please review :) 18:07:57 #undo 18:07:58 Removing item from minutes: #info Please review :) 18:08:09 #info Please review outstanding reviews for ironic-ui. :) 18:08:22 I think that sums up priorities as well actually 18:09:28 ppiela: I noticed you updated the testing framework revision, I'll look at it after the meeting. 18:09:36 I would like to see the unit test work land asap as it will effect all subsequent commits 18:09:56 Agreed, I noticed the delta was about ~124 lines, so it should be quick to review 18:10:01 well, re-review 18:10:23 #topic Planning/Priorities 18:11:08 #info Priority is https://review.openstack.org/#/c/469459/ 18:11:34 ppiela: I see it has 2x +1, so if nothing stand out as problematic I'll land it in a little bit. 18:11:57 Is there anything else that is a priority right now that anyone wants to raise at this time? 18:11:59 TheJulia: great! 18:12:16 https://review.openstack.org/#/c/473539/ 18:13:01 That patchset adds support for testing port-based functionality 18:13:48 Ah yes, good one to get landed next as well 18:13:49 #info Next priority is https://review.openstack.org/#/c/473539/ 18:14:03 Anything else? 18:15:00 I would like to work with both anup and rama to get their changes landed in the next week 18:16:01 It doesn't look like we have anup today, do you happen to remember rama's IRC handle? 18:16:18 rama_y 18:17:22 I got rama_y's attention :) 18:17:28 o/ 18:17:32 o/ 18:18:25 o/ anupn 18:18:37 Hi all 18:18:48 Hi anupn: 18:19:00 and rama_y 18:19:10 anupn: rama_y: Long story short, we've been prioritizing since we need to cut our release in about a month for translation folks to have time 18:19:25 hi ppiela 18:20:20 anupn: rama_y: thanks for the good review comments 18:21:32 ppiela: :) Thanks for the patch, important stuff 18:21:42 with the resource_class patch, is it possible to add unit tests as an add-on? 18:22:31 Thanks for the unit testing patch, ppiela 18:22:33 anupn:, rama_y: I would like to work with you to get your changes landed in the next week, I think we are close 18:22:43 TheJulia, ppiela: when can unit test framework patch be landed? 18:22:46 ppiela, ok 18:22:50 rama_y: the preference is to go ahead and have the patches with the change. If you absolutely must propose as a follow-up patch, then I guess we can hold off landing it until the the unit tests are written. 18:22:51 that sounds good 18:23:00 The general rule is that tests should land with changes 18:23:17 Right 18:24:19 Also, regarding next week, we are hoping to have some additional review bandwidth on hand, so that should help things as well. :) 18:24:46 with set-boot-device patch, wondering if nodes can be set to a specific boot device in batch? 18:25:37 rama_y: that is a great question, I'm fairly sure that the API does not support that 18:25:45 since it would be a node level operation 18:26:08 Yes; so, I will make sure the patch supports only per node 18:26:09 Requests could be pipelined, but that would be about it since they are in distinct patches 18:26:15 TheJulia: interested in your thinking on that question 18:26:53 ppiela: how so? 18:27:06 * TheJulia also wonders if we're entering discussion territory :) 18:27:22 TheJulia: probably so 18:27:46 Well, since we do seem to be in that territory, and if there are no objections, we can go to open discussion to continue. 18:28:15 #topic Open Discussion 18:28:36 ppiela: So interested in the question that rama_y raised regarding batch setting of boot device? 18:29:05 * TheJulia feels slightly confused :) 18:29:18 but that needs to also create such API in ironic? 18:29:49 TheJulia: for set_boot_device batch use case, would the "controller" look at the list of selected nodes, and find a common set of options from which to select? 18:30:53 At least API wise, the set_boot_device action is limited to a post on a resource attached to a node, so API wise, it is a serialized operation that can only be completed one at time. 18:32:15 * TheJulia hopes that answers the question 18:32:19 Same thing for 'node-get-supported-boot-devices', I think. 18:32:28 yup 18:32:34 yup 18:32:55 :) 18:33:25 Batch operations typically involve the user selecting a set of nodes and applying an operation to them, e.g. set-maintenance-true 18:33:55 In some cases this might be a noop 18:34:39 We know the applied value has meaning for all nodes 18:36:16 ppiela: I see what your asking now 18:36:19 Boot device is different in that respect in that there may not be values common to all nodes 18:37:05 Yeah, it is driver or management controller specific in some cases if memory serves 18:37:16 but we also don't store the current state 18:37:23 so it would have to be queried explicitly 18:37:33 yes 18:38:11 yes 18:39:39 since the status should be known by the controller, it makes sense to allow a batch operation (but the controller would have to do all the work) for setting maintenance. boot device is a one-off admin explicit action per node, typically when troubleshooting something like a failed TripleO upgrade. 18:40:00 I just dont know if users would value the batch set everyone to a value functionality 18:40:31 I doubt they would for boot devices since it's use is limited to troubleshooting. 18:40:43 Right 18:40:47 Maintenance, it makes sense if someone's business processes support/encourage it 18:40:48 * anupn agrees with TheJulia 18:41:02 Yes 18:41:40 My vote is not to do the batch use case, we can add it later if there is demand 18:42:18 sounds good 18:42:27 ++ 18:42:37 Do we feel the need for an #agreed? or are we good? 18:42:41 yes, i feel no need of it for now 18:42:57 * TheJulia senses we are good 18:43:03 yep 18:43:06 yep 18:43:37 Anything else to discuss? Sports? Trading cards? Taking over the world? 18:43:56 TheJulia, ppiela, what is the recommendation for running npm tests? 18:45:06 rama_y: I think `npm test` should work for you 18:45:38 TheJulia, ppiela rama_y is there going to be discussion about IronicUI in PTG 18:45:53 ok 18:46:03 good question anupn 18:46:31 * anupn loves travelling that's other fact ;) 18:46:50 rama_y: Does that answer your question. npm run test will run them, and I recommend that we all start adding more 18:46:54 anupn: I'm presently planning on attending, I don't know about others yet. 18:47:12 yes ppiela, thanks 18:48:24 TheJulia, I see, I am not sure as I heard of some budget issue at work 18:50:05 anupn: To better answer the question, if others will be there, we can surely carve out some time to discuss UI. 18:50:19 TheJulia, got you 18:51:26 Anything else for today? 18:51:39 Not here 18:51:52 Same here, thanks for the discussion 18:52:25 not from me 18:52:28 Awesome, thank you everyone, and see you in #openstack-ironic 18:52:32 Have a wonderful day! 18:52:34 #endmeeting