14:00:12 #startmeeting javascript 14:00:13 Meeting started Wed Jul 13 14:00:12 2016 UTC and is due to finish in 60 minutes. The chair is vkramskikh. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:00:14 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 14:00:17 The meeting name has been set to 'javascript' 14:00:20 hey everyone 14:00:24 who's there? 14:00:29 hi! 14:01:26 I'm here 14:02:01 we have th only topic to discuss 14:02:09 #topic Integration with the libraries we've agreed on 14:02:46 we have a review request from krot_vaca_jul19 with integration with karma, babel and jasmine: https://review.openstack.org/#/c/334268/ 14:03:07 I believe these libraries should be added in the single patch 14:03:20 there are lots of thing to discuss and change 14:03:38 so I think it should be split into a few review requests 14:04:02 I've created a review request with Babel integration: https://review.openstack.org/#/c/334267/ 14:04:20 I think it should be base request for all others and should be reviewed first 14:04:36 so please review, though I don't think it will be merged until the next week 14:05:01 since we agreed with krot_vaca_jul19 that we should merge each other review requests 14:05:24 I'll prepare review request with Webpack soon 14:06:00 that's all I wanted to say :) I believe next week things will go faster 14:06:25 any questions on this? 14:06:27 support your idea to proceed with separate requests, this definitely will make review process faster 14:06:38 what about requests for karma and node-fetch ? 14:06:50 i see TBD for them in the agenda 14:06:52 they should go next 14:07:06 I've only dealt with babel by now 14:08:37 #topic Open discussion 14:08:55 does anyone have anything else to discuss? 14:09:51 hi cardeois__ :) 14:10:05 hey hi ! sorry for to be late 14:10:12 we still love you :) 14:10:22 ahah oh you 14:10:37 we don't have much to discuss, I just wanted to announce that I wanted to split https://review.openstack.org/#/c/334268/ into a few requests, one request for one library 14:10:58 I've started with babel https://review.openstack.org/#/c/334267/ , webpack will go next 14:11:26 oh ok, why not yes. I have some reviews depending on that, but I'll deal with it 14:11:48 do you have anything else to discuss? 14:12:24 Well maybe one thing 14:12:38 I was just wondering how we want to architecture our openstack-library 14:13:29 Should we base our work from fuel, or maybe pythonopenstack-sdk ? If I'm correct we are trying to do a javascript version of this sdk right? 14:14:06 I believe we should base on pythonopenstack-sdk - Fuel don't have much stuff to base on 14:14:26 but I think we should wait for krotscheck to come back from his vacation - I don't have strong opinion on this 14:14:57 Yeah that's what I was thinking too. As it would be nice for user using our library to have a seamless transition from python to javascript (if they want to switch) 14:15:12 Sure we can wait, I was just wondering if this was agreed already or not 14:15:51 no it wasn't 14:16:02 that's a nice topic for the next meeting 14:16:09 In case you missed it I've created a review for the first step of devstack gate https://review.openstack.org/#/c/339748/4 14:17:06 I'll take a look, though I see it's based on https://review.openstack.org/#/c/334268/ 14:17:30 My main concern I have left are: 14:17:30 - Do we want coverage for functional tests? (I did it but it's not blocking) 14:17:30 - I generate a cloudsConfig file similar to clouds.yaml but it's not very nice, I'll let you read that 14:17:55 it is because I needed tests, and didn't want to setup jasmine again 14:18:03 and karma, and istanbul... 14:18:42 I believe for both of your questions we need to wait for krotscheck 14:19:54 I'll try to create separate review requests for karma and rebase https://review.openstack.org/#/c/334268/ on it by the end of this week 14:20:14 ok sure 14:20:52 If you create some jasmine tests try to put them in `test/unit` so we would have `test/functional` later (see https://review.openstack.org/#/c/339679/2) 14:21:14 ok :) 14:21:46 Oh yeah and one last thing (we'll have to wait for krotscheck too I guess) but for our unit tests we'll have to define a way to mock our `fetch` calls returning promises 14:22:27 As we use an isomorphic library it's not obvious, and I guess we don't want to have 10 lines of setup in each test to moch an ajax call 14:22:46 So we'll have to find/use/create a library for easy mocking of fetch 14:22:53 I'm dealing with the same issue in Fuel right now :) we used to use Sinon but it doesn't work with fetch 14:23:20 We could try https://www.npmjs.com/package/fetch-mock but I don't know if it works well 14:23:28 they say isomorphic-fetch is handled though 14:23:50 me too. I'll post it to #openstack-javascript if I find it out first 14:24:01 OK great 14:24:37 I won't be able to work much on that this week, sorry. I'll try to spend the few hours I have left on devstack 14:24:46 But I could help next week 14:25:34 find, I believe we won't have integration with babel/jasmine/karma by the next week anyway 14:25:49 because we I agreed I can't merge my own review requests 14:26:47 yeah make sense 14:27:15 Alright, I've nothing else to talk about. Do you? 14:27:37 I don't. let's end the meeting then 14:27:41 #endmeeting