13:53:14 <zxiiro> #startmeeting jjb
13:53:15 <openstack> Meeting started Fri Sep  8 13:53:14 2017 UTC and is due to finish in 60 minutes.  The chair is zxiiro. Information about MeetBot at http://wiki.debian.org/MeetBot.
13:53:16 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
13:53:18 <openstack> The meeting name has been set to 'jjb'
13:53:26 <zxiiro> #chair waynr electrofelix
13:53:27 <openstack> Current chairs: electrofelix waynr zxiiro
13:53:45 <zxiiro> #topic jjb-2.0
13:54:11 <zxiiro> I guess this is really our only topic at the moment unless someone else wants us to discuss something later?
13:54:43 <zxiiro> electrofelix: so I think we should get this https://review.openstack.org/333076 landed asap before another patch is merged that breaks this again.
13:54:47 <waynr> hmm wasn't there someone else were were considering as a jjb core a month or two ago? did that ever happen?
13:55:05 <waynr> s/er w/ w/
13:56:17 <electrofelix> I was hoping to understand the purpose of the __deepcopy__ a bit more
13:56:20 <zxiiro> just looked at the last meetings notes I don't see it
13:56:45 <zxiiro> #info zxiiro thinks https://review.openstack.org/333076 should land asap
13:57:00 <zxiiro> #info electrofelix wants to understand the purpose of __deepcopy__ a bit more
13:57:12 <zxiiro> #action electrofelix to review https://review.openstack.org/333076
13:57:15 <zxiiro> electrofelix: ok
13:57:18 <waynr> #info waynr also thinks https://review.openstack.org/333076 should land sooner rather than later
13:58:27 <zxiiro> #link https://review.openstack.org/#/q/status:open+project:openstack-infra/jenkins-job-builder+branch:master+topic:2.0-config-format 2.0 config format
13:58:41 <zxiiro> waynr: electrofelix: ^ I think we decided to go with this? if so we should probably merge those patches
13:58:58 <zxiiro> looks like there's a few merge conflicts for 3 of the patches. I can look into fixing that
13:59:11 <zxiiro> #action zxiiro to resolve merge conflicts in https://review.openstack.org/#/q/status:open+project:openstack-infra/jenkins-job-builder+branch:master+topic:2.0-config-format
13:59:38 <waynr> i can review those patches
14:00:17 <waynr> might need reminders occasionally though ;)
14:00:18 <electrofelix> zxiiro: I'm go with that, I'll start reviewing and will look out for the updates
14:00:26 <zxiiro> sounds good
14:00:40 <zxiiro> #action electrofelix & waynr to review 2.0-config-format patches
14:00:52 <zxiiro> #link https://etherpad.openstack.org/p/jjb_api_v2.0 EtherPad of JJB 2.0 items
14:01:20 <zxiiro> ok i think this is the last thing... electrofelix, waynr anything from the etherpad we want  to discuss?
14:01:28 <electrofelix> waynr: can you help me understand what's happening with __deepcopy__, what changed to require it?
14:01:35 <electrofelix> guess we can discuss after the meeting
14:02:25 <waynr> yeah i can go over that with you
14:02:33 <waynr> during meeting or not
14:02:42 <zxiiro> yeah we can talk about that now too
14:02:49 <zxiiro> electrofelix: there was an email thread about it
14:02:50 <waynr> i have to look it over again myself actually but i remember thinking it looked legit
14:04:03 <electrofelix> waynr: was it not added recently?
14:04:34 <zxiiro> electrofelix: the jinja patch needs it. Let me look up the email thread...
14:04:36 <electrofelix> ah found it
14:04:45 <zxiiro> electrofelix: oh? you got it? ok
14:09:54 <openstackgerrit> Thanh Ha proposed openstack-infra/jenkins-job-builder master: Default groovy-postbuild to newest plugin format  https://review.openstack.org/478372
14:11:35 <openstackgerrit> Thanh Ha proposed openstack-infra/jenkins-job-builder master: Default slack to newest plugin config format  https://review.openstack.org/478669
14:12:48 <openstackgerrit> Thanh Ha proposed openstack-infra/jenkins-job-builder master: Default conditional-publisher to newest plugin format  https://review.openstack.org/478378
14:13:01 <zxiiro> electrofelix: waynr alright I fixed the 3 merge conflicts in the meantime.
14:13:26 <zxiiro> anything else we want to discuss during the meeting?
14:14:31 <zxiiro> electrofelix: I think the only other thing for JJB 2.0 is you mentioned you wanted to redo the config plugin system. Any progress on that?
14:17:46 <electrofelix> yes, just not quite ready with the second patch, I almost forgot I had a question on it before I made a change
14:19:07 <electrofelix> https://github.com/openstack-infra/jenkins-job-builder/blob/master/jenkins_jobs/modules/helpers.py#L490
14:20:08 <electrofelix> with the changes we've made to get plugin configuration information from specific plugin sections, I think this __future__ section should be dropped for the v2 release for individual plugin behaviour and instead added to the two plugins it affects
14:20:50 <zxiiro> agreed. I think that's the right thing to do
14:21:02 <zxiiro> waynr: ^
14:21:26 <electrofelix> as in a) switch it to default to taking the order from the yaml, and b) place the ability to use the old behaviour under "[plugin 'trigger_parameter...'] use_old_param_order = True"
14:21:52 <electrofelix> or something like that, that was the last thing blocking ensuring that only the 'plugins' namespace needed to be passed to the plugins
14:23:12 <waynr> that sounds good to me
14:24:18 <waynr> well it'll break JJB for my ex coworkers but all they will have to do is avoid upgrading or chang their config files
14:24:40 <electrofelix> were they using that option?
14:25:08 <zxiiro> #info electrofelix asks if we should move param order setting to inside plugin sections for V2
14:25:27 <electrofelix> or rather were they using trigger parameterized plugins and relying on the old behaviour of using the order defined in the code for the precedence of the parameters?
14:25:52 <zxiiro> #agreed We will move the param order config into plugins section.
14:25:55 <waynr> oh wait
14:26:26 <waynr> nevermind, i was confused...i was misremembering something and misreading what you wrote
14:26:35 <waynr> it won't break anything for excoworkers of mine
14:26:48 <electrofelix> as in predefined-parameters would be overridden by current-parameters even if the yaml put it afterwards
14:27:14 <electrofelix> yeah, I just realised it might cause you to think I meant about the project params precedence order ;)
14:27:41 <waynr> yah i see what you mean now
14:30:32 <zxiiro> electrofelix: I feel confused now. so currently if someone lists a parameter last it will take precedence over the same parameter if it's defined above?
14:30:39 <zxiiro> electrofelix: so with the change what happens?
14:30:53 <zxiiro> electrofelix: it will take the first defined parameter listed?
14:32:05 <electrofelix> zxiiro: in the trigger parameter plugins, the original code hardcoded the order the XML was emitted for each of the possible settings, however Jenkins allowed you to order them to control which ones would override others and thus control the value of the parameter passed to the triggered build
14:33:21 <electrofelix> so a user might assume that they could order the yaml definition for that plugin in the same way to decide that the can pass through 'current-parameters', and then override a single parameter by placing the 'predefined-parameter' block afterwards
14:33:53 <electrofelix> unfortunately this was not supported by the code at the time and instead it would enforce a specific order https://github.com/openstack-infra/jenkins-job-builder/blob/master/jenkins_jobs/modules/helpers.py#L475-L486
14:34:27 <zxiiro> electrofelix: oh i see. ok understood
14:34:56 <electrofelix> So to change it to allow it to be controlled based on the order the user would specify to match what jenkins allowed, and at the same time not break any existing ones needed to allow switching between old hardcoded order and new user defined order
14:34:58 <electrofelix> ;)
14:35:34 <zxiiro> i think i never noticed this because i almost exclusively use only string parameters
14:36:12 <waynr> do you pass parameters to downstream jobs?
14:36:25 <zxiiro> yes
14:37:15 <zxiiro> in that case i almost exclusively run only paramters from property files
14:39:30 <waynr> well anyway i agree with dispensing with the __future__ config section in favor of the plugin specific config section
14:40:08 <zxiiro> Yeah. As long as we document it. I think it's fair game for V2
14:41:31 <zxiiro> ok anything else to discuss? If I'm correct I think V2 is just blocked on 3 things at the moment:
14:41:31 <zxiiro> 1) YAML Parser patch
14:41:31 <zxiiro> 2) Plugin namespace config
14:41:32 <zxiiro> 3) 2.0-config-format
14:41:42 <zxiiro> which all have action items so I think we're on track to getting 2.0 out.
14:42:16 <zxiiro> if we can get 1) and 3) merged soon we'll be a little closer.
14:42:54 <zxiiro> electrofelix: think you can get YAML Parser patch in today? should we try to iron it out now that everyone's here?
14:43:48 <zxiiro> #action electrofelix to continue working on plugin namespace config patch
14:44:08 <electrofelix> just approved, I'd been experimenting with it as we talked and read back over the email thread as well
14:44:25 <zxiiro> awesome
14:44:38 <zxiiro> alright if there's nothing else I guess we can end the meeting?
14:45:43 <waynr> +1
14:45:48 <electrofelix> I think I'm good with all of the reviews for '3', so I'll try to get something up soon for '2'
14:45:59 <zxiiro> great. sounds good
14:46:01 <zxiiro> #endmeeting