09:03:45 <saggi> #startmeeting karbor
09:03:45 <openstack> Meeting started Tue Aug 16 09:03:45 2016 UTC and is due to finish in 60 minutes.  The chair is saggi. Information about MeetBot at http://wiki.debian.org/MeetBot.
09:03:46 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
09:03:49 <openstack> The meeting name has been set to 'karbor'
09:03:53 <saggi> Hi everyone
09:03:56 <yuval> hello
09:03:58 <chenying> hi
09:04:04 <saggi> 1st karbor meeting
09:04:05 <xiangxinyong> hello
09:04:09 <zengchen> good morning
09:04:20 <xiangxinyong> morning sir
09:04:58 <saggi> #topic renaming issues
09:05:09 <saggi> I saw that there are already patches for renaming
09:05:28 <saggi> But as yuval found out we can't change some stuff until the renaming window
09:05:45 <chenying> I will submit a patch of smaug-dashbard for name change today.
09:05:53 <saggi> the question is should we change all the import now or later
09:06:10 <yuval> We can start renaming stuff (code, deliverables, etc) but the repistory name will have to wait until the gerrit maintenance window
09:06:16 <saggi> yuval: can we rename\alias the packages?
09:06:32 <saggi> Thank I think we should rename now
09:06:35 <saggi> who agrees?
09:06:39 <yuval> I agree
09:06:41 <chenying> why
09:06:58 <saggi> We don't have a lot of projects depend on us now.
09:07:10 <yuval> The maintenance window could take a few weeks and we are in the middle of the transition
09:07:11 <saggi> Any import path change will cause them to rename as well
09:07:26 <saggi> renaming now ill make it easier for people to depend on karbor
09:09:09 <chenying> only  rename\alias the packages smaug to karbor?
09:09:10 <yuval> btw, yinwei, zhonghua here?
09:09:34 <yuval> smile-loubin?
09:09:50 <saggi> #startvote Should we rename code now? Yes, No
09:09:51 <openstack> Begin voting on: Should we rename code now? Valid vote options are Yes, No.
09:09:52 <openstack> Vote using '#vote OPTION'. Only your last vote counts.
09:10:05 <saggi> Yes
09:10:21 <yuval> chenying: any reason why not to change?
09:10:34 <saggi> confusing with the repository?
09:10:46 <zhonghua> hi, sorry for my late coming
09:10:53 <saggi> maybe the packages can't be changed?
09:11:14 <yuval> saggi: we should also rename on pypi
09:11:39 <chenying> I think we shoudld change code now. I mistake it.
09:11:56 <yuval> #vote yes
09:11:57 <zhonghua> saggi: sorry, I am late, what are we voting for?
09:12:05 <yuval> #vote Yes
09:12:10 <saggi> #vote Yes
09:12:13 <xiangxinyong> guys, so the another meaning of this vote is whether merged this code https://review.openstack.org/#/c/354024/?
09:12:13 <chenying> #vote yes
09:12:40 <saggi> zhonghua: On whether to change the code now or later
09:12:55 <saggi> after the repo change
09:13:11 <zhonghua> saggi: thanks
09:13:30 <zhonghua> #vote Yes
09:13:33 <yuval> please note that we need to make a small change to project-config to make the fullstack ci work correctly after we change the karbor directory
09:13:53 <saggi> I'm ending the vote
09:13:56 <saggi> #endvote
09:13:57 <openstack> Voted on "Should we rename code now?" Results are
09:13:58 <openstack> Yes (4): saggi, chenying, zhonghua, yuval
09:14:34 <saggi> OK, a lot of patches are going to break so let's fast track these patches
09:14:45 <chenying> I am afraid that if the repo have not been changed, the CI may be failed/
09:14:47 <yuval> saggi: I think there are some patches we must pass before
09:14:55 <saggi> yuval: Which?
09:15:00 <xiangxinyong> I agree
09:15:11 <yuval> https://review.openstack.org/355427
09:15:22 <yuval> fixes fullstack
09:16:01 <saggi> I was close to passing a few minutes ago
09:16:33 <xiangxinyong> https://review.openstack.org/#/c/355709/
09:16:39 <chenying> I will rebase the patch of smaug about name change.
09:16:47 <yuval> chenying: only fullstack will break, we need to make a slight change to project-config in order to make it work again
09:16:55 <xiangxinyong> https://review.openstack.org/#/c/355771/
09:17:17 <xiangxinyong> could you merge these two patches?
09:17:28 <saggi> I added the workflow to it
09:17:34 <chenying> I submit the patch about name change. I have kept all the unit tests Ok.
09:17:37 <xiangxinyong> They are simple, but it is important
09:17:52 <saggi> They already had +2 from me
09:18:35 <xiangxinyong> thanks
09:18:43 <chenying> xiangxinyong: You can wait the patch about name change is merged.
09:18:53 <saggi> So I'll give priority to renaming patches.
09:19:18 <yuval> chenying: saggi: please wait before you merge the name change. we need to post a fullstack fix to project-config
09:19:25 <yuval> also verify deliverables are ok
09:20:19 <yuval> not sure we can change setup.cfg as it affects packages and maybe pypi
09:21:51 <yuval> also we cant change the name of packages. smaug depends on python-smaugclient which requires a a change in requirements project
09:22:04 <saggi> yuval: We could just have new packages.
09:22:17 <saggi> the old packages would still exists but never updated
09:22:30 <saggi> projects that need to upgrade will change the dependency
09:23:02 <yuval> saggi: IMO smaug cannot depend on python-karborclient unless it is added to openstack/requirements
09:23:36 <saggi> than we should add it there
09:23:54 <chenying> I have comment the python-karborclient in the requirements.txt.
09:24:50 <yuval> ok, let's continue the technicals after the meeting
09:25:03 <saggi> #topic How d#topic Dashboard Items Review (xiangxinyong)
09:25:13 <saggi> #topic topic Dashboard Items Review (xiangxinyong)
09:25:20 <saggi> #topic Dashboard Items Review (xiangxinyong)
09:25:22 <xiangxinyong> we could review these dashboard patches, since some vendors are using karbor to develop their plugin.
09:25:53 <xiangxinyong> But it seems like if these patches are merged, chenying will rebase his patch
09:25:53 <saggi> They have reviews
09:25:59 <xiangxinyong> thanks saggi
09:26:38 <yuval> I'll try to get to it
09:26:45 <xiangxinyong> thanks yuval
09:26:51 <saggi> xiangxinyong: The problem is I'm kind of reluctant to do workflow+1 on the dashboard.
09:27:04 <saggi> I can do it but I'm not always sure about the order
09:28:02 <xiangxinyong> oh
09:28:10 <saggi> #topic Support checkpoint scheduled clean (xiangxinyong)
09:28:30 <xiangxinyong> I have updated this spec.
09:28:30 <saggi> The bp is up. It looks OK to me apart from some of the technical details are missing.
09:28:39 <saggi> When will the check happen
09:29:06 <xiangxinyong> The scheduled operation is triggered
09:29:41 <xiangxinyong> I have updated the database struct.
09:29:49 <zhonghua> are we sure to restore the checkpoint into two places?
09:30:04 <saggi> So it will check for deletions when it start to backup?
09:30:25 <saggi> If the maximum is changed than it will have to wait until the next tirggering to delete
09:30:30 <saggi> I'm OK with that
09:30:37 <chenying> The bp now add a database table checkpoint_records. when we create/update checkpoint data in bank. at the same time, create/update the data in datbase.
09:30:57 <xiangxinyong> saggi: yeah
09:31:12 <xiangxinyong> chenying: +1
09:31:17 <saggi> I'll probably +2 and merge it later today if it doesn't have any objections on it.
09:31:32 <saggi> I'm still waiting for +2s on my BP
09:31:38 <zhonghua> xiangxiyong: do you consider to config the bank as an optional store place?
09:31:40 <xiangxinyong> Thanks saggi
09:32:00 <saggi> #topic The new implementation about the 'suspend/resume' operation (zengchen)
09:32:06 <yuval> zhonghua: what do you mean as an optional store place?
09:32:26 <zhonghua> yuval: let us discuss later
09:32:34 <yuval> zhonghua: ok
09:32:47 <xiangxinyong> zhonghua: ok
09:32:48 <zengchen> saggi:do you have seen my comments?
09:33:48 <saggi> zengchen: This is what I don't understand. We can now update (in the classic sense) an operation.
09:34:13 <saggi> Why do we need this specialized mechanism?
09:34:28 <saggi> It's not that bad to send the entire object.
09:34:38 <saggi> and it keeps the interface as a classic REST API
09:35:14 <zengchen> saggi:first we have not senario to update the operation except the 'suspend/resume' operation
09:35:59 <saggi> zengchen: Changing the plan attached
09:36:02 <saggi> changing the trigger
09:37:00 <zengchen> saggi:I mean user can 'suspend/resume' operation by invoking 'update' interface.
09:37:24 <saggi> I think we shouldn't have the update interface. Use the regular POST update and send the full object.
09:38:13 <zengchen> saggi:yes, i aggree with you.
09:38:32 <saggi> That just have the suspend\resume us it.
09:38:54 <saggi> Let's first see if it becomes and issues before adding something specialized for it.
09:39:48 <zengchen> saggi:if we want to update the operation, we should define the senarioes.
09:40:27 <zengchen> saggi:i mean update the operation by different senario.
09:41:32 <saggi> You just need to look at the new object and compare it to the new one.
09:41:33 <saggi> 1. If the trigger changed you need to unregister from the old one and register to the new
09:41:33 <saggi> 2. If the plan changed just update it in the DB
09:41:33 <saggi> 3. if the status changed wither remove or add to the trigger.
09:41:40 <zengchen> saggi:it is not only update the db, but also update the logic.
09:42:02 <saggi> Other fields are only relevant upon triggering
09:43:02 <zengchen> saggi:i understand you. i will try. but it is not simple.
09:43:21 <saggi> zengchen: Thanks
09:43:38 <saggi> #topic  New protection plugin I/S implementation (yuvalbr)
09:43:47 <saggi> I will go over it TODAY!
09:43:51 <yuval> lol
09:43:59 <saggi> It's just so long
09:44:04 <yuval> :\
09:44:10 <saggi> and daunting
09:44:40 <yuval> has anyone else had the chance to look into it?
09:44:49 <chenying> I think these patches in smaug wait the patch about name change being merged/
09:45:20 <saggi> chenying: It's a huge patch. It will probably get a bunch of revisions. Review it now but we will push it after the name change.
09:45:37 <chenying> It is terrible for me to rebase the patch.
09:45:47 <saggi> Everyone please review it. It's important since we need it for things like guest agent support and it's a must for stabilizing the plugin interface.
09:46:09 <saggi> chenying: We will not push it before the name change. But you can star leaving comments about the content
09:46:25 <chenying> saggi: Ok
09:47:13 <saggi> yuval: Anything you would like to add?
09:47:18 <yuval> saggi: bope
09:47:20 <yuval> *nope
09:47:27 <saggi> #topic open discussion
09:47:32 <saggi> Anything else?
09:49:02 <saggi> OK than we're done
09:49:05 <saggi> Thanks everyone
09:49:11 <xiangxinyong> Thanks
09:49:49 <saggi> #endmeeting