09:00:39 <saggi> #startmeeting karbor
09:00:40 <openstack> Meeting started Tue Jan  3 09:00:39 2017 UTC and is due to finish in 60 minutes.  The chair is saggi. Information about MeetBot at http://wiki.debian.org/MeetBot.
09:00:41 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
09:00:43 <openstack> The meeting name has been set to 'karbor'
09:00:46 <saggi> Hi everyone
09:00:51 <yinwei_computer> hi
09:00:51 <yuval> Hey :)
09:01:07 <edisonxiang> hello
09:01:14 <zhonghua> hi
09:01:16 <saggi> Talking to you all from Chengdu
09:01:18 <saggi> !
09:01:23 <saggi> 🎉
09:01:28 <leon_wang> hi
09:01:32 <chenying_> hi
09:01:38 <zengchen> hey!
09:01:45 <zhonghua> saggi: :)
09:02:03 <yinwei_computer> I'm on remote site
09:02:25 <saggi> I've been busy this week so I didn't have a lot of time to review
09:02:39 <saggi> There also doesn't seem to be anything on the docket
09:03:03 <saggi> #topic bugfixing
09:03:16 <saggi> How is this been going? Any progress?
09:03:29 <yuval> we have some dashboard things open
09:03:39 <yuval> https://bugs.launchpad.net/bugs/1643331
09:03:41 <openstack> Launchpad bug 1643331 in Karbor "karbor-dashboard: provider is being get for each checkpoint" [Low,Triaged]
09:03:44 <yuval> https://bugs.launchpad.net/bugs/1622594
09:03:45 <openstack> Launchpad bug 1622594 in Karbor "Update checkpoint status in checkpoint page" [Medium,Triaged] - Assigned to chenying (ying-chen)
09:03:48 <yuval> https://bugs.launchpad.net/bugs/1643338
09:03:49 <openstack> Launchpad bug 1643338 in Karbor "karbor-dashboard: Missing Plan edit - change resource and parameters" [High,Triaged]
09:04:35 <saggi> Only one is assigned
09:04:42 <yuval> also, protection plugin adjustment are required and I think work on them has already began by chenying
09:05:16 <chenying_> yuval: Yes I will work on the glance protection plugin adjustment first.
09:05:49 <yuval> xiangxinyong here?
09:06:04 <edisonxiang> yeah, I am here
09:06:21 <saggi> edisonxiang: can you work on the remaining bugs?
09:06:33 <yuval> edisonxiang: :)
09:06:51 <saggi> 1643338 and 1643331
09:07:05 <edisonxiang> sure
09:07:07 <yinwei_computer> I find one bug unassigned, which I think Luobin or I could fix it.
09:07:11 <yinwei_computer> https://bugs.launchpad.net/karbor/+bug/1554851
09:07:12 <openstack> Launchpad bug 1554851 in Karbor "Support pagination for protectables" [Low,Triaged]
09:07:41 <edisonxiang> https://launchpad.net/karbor/+milestone/ocata
09:07:51 <edisonxiang> every thing is here.
09:08:06 <chenying_> https://bugs.launchpad.net/karbor/+bug/1554851  I have addressed the comment in this bug. Maybe we need think more about  pagination for protectables API.
09:08:31 <chenying_> Not all the protectables plugins can support pagination feature.
09:08:31 <yinwei_computer> chenying_, we could talk about the bug offline
09:08:55 <chenying_> yinwei_computer: Ok
09:10:05 <yinwei_computer> got your point, if plugins don't support list with anchor, there's no way to support pagination @chenying_
09:10:19 <chenying_> https://bugs.launchpad.net/karbor/+bug/1650239 This bug will be submitted base on chenzeng's client patch.
09:10:20 <openstack> Launchpad bug 1650239 in Karbor "Support clients with privileged user in karbor" [Undecided,New] - Assigned to chenying (ying-chen)
09:10:38 <chenying_> yinwei_computer: Yes.
09:10:48 <zengchen> I hope everyone can reivew my patch on the bug https://bugs.launchpad.net/karbor/+bug/1566793
09:10:49 <openstack> Launchpad bug 1566793 in Karbor "authenticate in protection service client" [High,In progress] - Assigned to zengchen (chenzeng2)
09:11:43 <edisonxiang> 1643338 and 1643331 have already been assigned to me:)
09:12:30 <yuval> zengchen: which? I found two, but both are workflow -1
09:12:31 <saggi> 😁
09:14:30 <zengchen> yuval:you can see them listed in the comments at 'https://bugs.launchpad.net/karbor/+bug/1566793'. yes, 2 patches of them are workflow -1, but other ones are ready.
09:14:31 <openstack> Launchpad bug 1566793 in Karbor "authenticate in protection service client" [High,In progress] - Assigned to zengchen (chenzeng2)
09:14:41 <yuval> zengchen: will take a look
09:15:11 <zengchen> yuval:like https://review.openstack.org/#/c/404644/. thank you.
09:17:27 <yuval> zengchen: https://review.openstack.org/#/c/407990/ is in merge conflict
09:17:36 <yuval> zengchen: so is https://review.openstack.org/#/c/408382/
09:17:52 <zengchen> yuval:ok, I will update them.
09:17:59 <yinwei_computer> two patches on this bug? @zengchen
09:19:07 <zengchen> yinwei_computer:there are 4.
09:20:42 <zengchen> yinwei_computer:you can review  https://review.openstack.org/#/c/404644/ first.
09:21:09 <yinwei_computer> I see those 4 in launch pad.
09:21:19 <yinwei_computer> thanks for fixing it!
09:22:04 <zengchen> yinwei_compute:yes, if you have time, review them. thanks.
09:22:22 <saggi> Anything important for me to go over?
09:22:48 <yuval> we should starting closing the multi tenant isolation
09:23:18 <yinwei_computer> @zengchen, I will
09:23:42 <yinwei_computer> is there any bug I or Luobin could help on? @yuval @saggi
09:24:05 <saggi> yuval: ^^
09:24:28 <yuval> saggi: I don't really recall where we were on the multi tenant issue
09:24:38 <yuval> saggi: ¯\_(ツ)_/¯
09:24:47 <saggi> We have a spec up
09:24:52 <yuval> saggi: will have to read the spec again
09:25:06 <chenying_> yinwei_computer: You can see the bugs list in launchpad. Some of them are not marked 'Assigned'.
09:25:10 <yuval> ಥ_ಥ
09:25:32 <saggi> The main objection is that it requires creating a lot of providers.
09:25:41 <saggi> Since we can't figure out how to do templating
09:26:12 <saggi> The current solution can evolve to templated providers if we ever figure it out so it shouldn't block the spec.
09:26:22 <saggi> IMHO
09:27:59 <yinwei_computer> maybe we could have more details on how to map keystone users/groups to bank users/groups
09:28:17 <yinwei_computer> in the spec
09:29:15 <chenying_> We also need think about the datbase bank use case .
09:29:16 <yinwei_computer> what's your opinion on tenant isolation (cross site authentication), chenying_
09:29:25 <saggi> The spec purposefully ignores this since it's a policy issue. We don't know how the admin would decide to map those with providers. I could add an example.
09:30:30 <yinwei_computer> yes, that'll be better
09:31:24 <saggi> I'll add a comment
09:31:27 <saggi> so I don't forget
09:31:45 <chenying_> yinwei_computer: I have addressed some comments, I will review it again if it have been updated. My oppion is that we need think over about the cross-site use case first.
09:32:38 <edisonxiang> https://review.openstack.org/#/c/372846/ I saw this patch is submitted by leon_wang.
09:33:19 <chenying_> saggi have updete the newest patch about it.
09:33:29 <saggi> edisonxiang: I took over it
09:33:49 <edisonxiang> saggi: understood.
09:35:46 <saggi> I think we are done with bugs for today
09:36:01 <saggi> #topic Open Discussion
09:36:06 <saggi> Anything else?
09:38:08 <saggi> OK
09:38:14 <saggi> Thanks everyone!
09:38:28 <saggi> #endmeeting