09:26:08 <jiaopengju> #startmeeting karbor
09:26:09 <openstack> Meeting started Tue Jul 30 09:26:08 2019 UTC and is due to finish in 60 minutes.  The chair is jiaopengju. Information about MeetBot at http://wiki.debian.org/MeetBot.
09:26:10 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
09:26:12 <openstack> The meeting name has been set to 'karbor'
09:26:20 <jiaopengju> #topic code review
09:26:56 <jiaopengju> The spec file of bp 'Add support for image boot server backup with data' has been merged
09:27:21 <jiaopengju> And the implement patch is ready, you can review it. https://review.opendev.org/#/c/673157/
09:28:20 <liushuai> I will review as soon as possible.
09:29:41 <jiaopengju> After this patch been merged, we should do some refactor of the method get_xxx_status
09:30:39 <jiaopengju> in multi plugins, it have the related function. it's better to move them together, so that we can reduce the duplicate code
09:31:58 <jiaopengju> def get_server_status(nova_client, server_id):
09:31:58 <jiaopengju> LOG.debug('Polling server (server_id: %s)', server_id)
09:31:58 <jiaopengju> try:
09:31:58 <jiaopengju> server = nova_client.servers.get(server_id)
09:31:58 <jiaopengju> status = server.status
09:31:59 <jiaopengju> except exception.NotFound:
09:32:05 <jiaopengju> status = 'not-found'
09:32:07 <jiaopengju> LOG.debug('Polled server (server_id: %s) status: %s', server_id, status)
09:32:09 <jiaopengju> return status
09:32:11 <jiaopengju> for example
09:33:23 <jiaopengju> do you agree? liushuai :)
09:33:35 <liushuai> i agree
09:33:40 <jiaopengju> haha
09:33:46 <jiaopengju> it's good
09:34:05 <jiaopengju> so go on next
09:35:13 <jiaopengju> #topic Not particularly important patches
09:36:54 <jiaopengju> Recently, I review many patches about spelling errors, web link errors etc, it's very confused, but it seems we can not avoid them
09:38:09 <jiaopengju> I think we should tell the 'contributor' do more work about these in one patch, not in multi patches. Do you have any suggestions?
09:41:19 <liushuai> sorry for disconnect
09:41:57 <jiaopengju> it's ok
09:41:59 <liushuai> The network is not stable
09:42:31 <jiaopengju> repeat my words:  Recently, I review many patches about spelling errors, web link errors etc, it's very confused, but it seems we can not avoid them
09:42:36 <jiaopengju> I think we should tell the 'contributor' do more work about these in one patch, not in multi patches. Do you have any suggestions?
09:43:57 <liushuai> yes, one type of error should in one patch
09:45:06 <jiaopengju> ok, please let the contributors know if you review any of these patch.
09:45:23 <jiaopengju> do you have any topics to share or disscuss?
09:45:54 <liushuai> i do not hav
09:46:01 <liushuai> have
09:46:10 <jiaopengju> #endmeeting