18:02:38 #startmeeting keystone 18:02:38 Meeting started Tue Aug 12 18:02:38 2014 UTC and is due to finish in 60 minutes. The chair is dolphm. Information about MeetBot at http://wiki.debian.org/MeetBot. 18:02:39 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 18:02:41 The meeting name has been set to 'keystone' 18:02:46 real quick... 18:02:53 #topic Feature Proposal Freeze: August 21st 18:02:56 that's next week 18:03:23 and it means your blueprints need to be feature complete, stable and in review by that day, else be bumped to kilo 18:03:38 if you don't think something is going to make it, give me a heads up ASAP 18:03:59 we're definitely talking about the blocked ones later on the agenda 18:04:15 so that is all, ping me later if you have questions :) 18:04:17 dolphm, both spec and impl needs to be up there by 8/21? 18:04:30 or just bp and spec 18:04:48 gyee: according to the rest of the community, your spec should have landed weeks ago to be considered for juno 18:05:18 gyee: i did a poor job of communicating that here, so i'm not considering that to be a strict rule 18:05:23 if something looks stable, let's consider it 18:05:26 #topic Cleanup / Abandonment of WIP and Lingering reviews in Keystone repositories 18:05:28 ++ 18:05:38 will we be following that for Kilo? 18:05:44 we have a lot of old reviews that need to be pruned 18:05:49 lbragstad: likely, yes 18:05:56 lbragstad: the earlier specs land the better 18:06:04 ok, cool 18:06:24 on stale reviews: cores, feel free to abandon things that look like they aren't going to land. be sure to include an explanation 18:06:38 abandoned reviews can be re-opened by the author, so it's not like a permament -2 or anything 18:07:34 at the very least, if something is miserably failing gate jobs and needs some love, leave it as WIP until someone can tackle it 18:07:47 morganfainberg: anything else to add or are you afk? 18:07:54 I'll probably do that with most of mine, and get people to focus only on the ones that are high priority 18:08:05 * ayoung the worst offender for malingering reviews 18:08:13 ayoung: i was thinking the same thing 18:08:17 for mine i mean 18:08:27 You meant for both. 18:08:33 sure, ok 18:08:43 ayoung: i'm far worse on allowing my reviews to stagnate! 18:08:49 ya'll get paid on number of reviews? :) 18:09:18 gyee: are you offereing? 18:09:19 * gyee hides 18:09:23 dstanek: ++ 18:09:33 i just fix stuff as i see it in other people's reviews 18:09:39 dstanek: ++ 18:09:41 or when poking around 18:09:57 renaming this on the agenda... 18:10:00 #topic Last specs for Juno 18:10:10 auth data https://review.openstack.org/#/c/107325/ 18:10:21 unscoped catalog https://review.openstack.org/#/c/107333/ 18:10:39 yep, so hopefully everyone has seen this, we talked about it a few weeks ago 18:10:45 gyee: did you have one for consideration? (that's nearly implemented?:) 18:11:03 dolphm, the x.509 auth depends on generic mapping 18:11:09 need to get some actual votes on it though if its going to go through 18:11:13 I am working with Kristy on this to get the generic mapping working first 18:11:15 dolphm, o/ here now 18:11:32 gyee: ++ cool 18:11:53 gyee: ? https://blueprints.launchpad.net/keystone/+spec/generic-mapping-federation 18:11:54 dolphm, but don't have anything to add to your comments 18:12:03 gyee: whats your bp name, i'll link them 18:12:43 dolphm, https://review.openstack.org/#/c/105913/5/specs/juno/x509-ssl-client-cert-authn.rst 18:12:47 #link https://review.openstack.org/#/c/107325/ auth data spec 18:12:55 #link https://review.openstack.org/#/c/107333/ unscoped catalog spec 18:12:58 https://blueprints.launchpad.net/keystone/+spec/x509-ssl-client-cert 18:12:58 -authn 18:13:11 ++ for auth data spec 18:13:11 is https://review.openstack.org/#/c/107325/6/specs/juno/auth-specific-data.rst proposing get rid of /v3/catalog? 18:13:24 no sure about the unscoped catalog one though 18:13:41 gyee: is there an implementation for the x509 spec somewhere? 18:14:23 dolphm, no, there's an implemented based on auth plugin which I abandon https://review.openstack.org/#/c/103736/ 18:14:41 but I don't have one based on generic map yet 18:14:50 gyee: are we likely to see one before next week? 18:15:14 interesting 18:15:16 gyee: if not, we should plan this for kilo now 18:15:30 dolphm, lets do it for Kilo to be safe 18:15:38 I need to get the generic map working 18:15:45 right now its not truly "generic" 18:15:50 gyee: awesome, i'd like some more focus there :) 18:16:25 mapping is only capable of mapping to user_id and group_id right now from what I can tell 18:16:27 stevemar's not here, but open id connect support is in the same boat. blocked by generic mapping 18:16:38 gyee: that's true (a list of groups) 18:16:39 I need to get it to a point where we can map one set to another set of attributes 18:17:03 gyee: i think generic mapping/reeingeneered federation patch will also be posponed for K ? 18:17:09 dolphm: ^^ 18:17:22 marekd: should it be postponed? 18:17:28 marekd, we need it to be truly generic 18:17:41 dolphm: it's still marked as WIP. 18:17:52 marekd: correct; do you think it needs more time? 18:18:10 i don't know how far the implementation is behind the spec 18:18:59 dolphm: i posted my comments a long time ago, and since then I haven't heard anything. gyee says he works with Kristy on that so he can answer whether it's far beyond the spec but AFAIR it needs more time. 18:19:17 i'm going to bump all 3 to 'next' (kilo) for now, and if something changes this week, we can re-evaluate 18:19:27 dolphm: great! 18:19:53 dolphm, ++ 18:20:02 jamielennox: my impression of auth data and the unscoped catalog is that they can be ready for code review this week if the specs are approved - is that true? 18:20:04 since they are all related 18:20:11 yeah 18:20:29 dolphm: i have a WIP for unscoped catalog 18:20:41 dolphm: auth data should be fairly trivial but i haven't done it 18:20:59 you had a patch to move /catalog to /auth/catalog from memory 18:21:07 that's still up, somewhere 18:21:40 o/ 18:22:00 dolphm: so yes, if we approve them i can have code ready in a day or two 18:22:00 stevemar: fyi, bumping openid connect to kilo unless mapping gets some traction this week 18:22:07 generic-mapping 18:22:19 jamielennox: ack 18:22:25 dolphm, ok, did Henry give his opinion on the matter? 18:22:31 dolphm, what is the Aug 21 deadline again? blueprints or code must be under review? 18:22:35 stevemar: unavailable 18:22:41 topol: code 18:22:46 topol, the latter 18:22:52 topol, the whole shebang 18:22:53 topol: stable code in review 18:22:55 bnemec: sorry just saw comment from further back - it's proposing to move it to /auth/catalog not get rid of it 18:22:57 there are 3 reasons to have the unscoped catalog, BTW: list projcts, list domains, exchage the unscoped token for a token 18:23:07 oops bknudson ^ was for you 18:23:20 jamielennox: ok. 18:24:00 was just hoping that /v3/catalog could be made consistent with this 18:24:19 bknudson: it would be 18:24:28 catalog is optional anyway so I can the base auth plugin can handle that logic 18:24:43 if catalog is absent, try to fetch it via the catalog api 18:25:02 gyee: that's going to be /v3/auth/catalog and not /v3/catalog 18:25:20 assuming jamielennox's auth-data spec is approved 18:25:35 just write your code to use JSON Home to find the resource and you won't have to worry about it 18:25:57 bknudson: =) 18:26:18 I am fine either way, just a matter of consistency 18:26:42 if everybody is going with JSON home, why not 18:27:04 In K somebody can work on client support. 18:27:04 #topic Keystone Weekly Bug Report 18:27:05 lbragstad: o/ 18:27:07 this is new :) 18:27:19 http://pasteraw.com/b0r3xfk41debm0tdjwcewtmf9k2lf0f 18:27:36 so, just wanting to do a weekly bug round up 18:28:01 just a quick 30 second "here are all the bugs that were opened against us in the last 7 days and their status" 18:28:22 lbragstad, neat, thanks for this, helps for folks like me who don't look at launchpad often enough 18:28:29 "ldap binary fields fail when code try to convert to utf8" is interesting... I thought we fixed it 18:28:44 I can do this for keystone, keystonemiddleware, and python-keystoneclient 18:28:52 but then it also shows that we're using LDAP inefficiently and fetching more attrs than we need to 18:28:52 lbragstad, that would be awesome 18:28:55 lbragstad: for future reference, you could use the wonderful launchpad api to query this stuff 18:29:06 dolphm 18:29:10 it's built on the api 18:29:18 :D 18:29:19 lbragstad: win 18:29:25 https://github.com/lbragstad/openstack-infra-scripts 18:29:42 dolphm, lbragstad, there is also the untriaged bot that triple-o is using, we might be able to use that and report in the channel at X interval what bugs are not looked at 18:29:48 some minor modifications I did to jogo's bug roundup infra scripts 18:30:29 hopeing this will help up triage bugs a little faster, not saying it's not fast enough :) 18:30:33 hoping* 18:30:45 lbragstad: well now you just need a more recent run - everything in the paste is out of date :P 18:31:11 dolphm: sounds good, I'll run this for keystone, keystonemiddleware, and python-keystoneclient before every meeting and paste the results 18:31:43 lbragstad: and if possible: openstack-api-site for bugs with the identity-api tag 18:31:56 dolphm: good point, I can built that in 18:31:58 i haven't worked with tags in the api, so i don't know how well that will go 18:32:02 Gotta drop. Back on line in an hour-ish 18:32:09 ayoung: ack 18:32:34 bug love appreciated :) 18:32:50 #topic What is a sane default cache timeout? 18:32:52 dstanek: o/ 18:32:56 #link https://bugs.launchpad.net/keystone/+bug/1355919 18:32:57 Launchpad bug 1355919 in keystone "By default when caching is enabled, objects will be cached forever" [Medium,In progress] 18:33:10 so i want to get opinions from the group 18:33:15 what would be a sane setting? 18:33:17 dolphm, dstanek, that is the case for assignment, tokens have a default already 18:33:19 forever is an unreasonable default 18:33:31 dstanek, dolphm, i think catalog is also affected by that bug (now) 18:33:57 there were a few cache_time options with no default 18:33:58 i chose 10 minutes in my patch, but i would be open to discussion 18:34:18 assignment, catalog and token IIRC 18:34:20 dstanek, really? we cache the stuff *forever*?!! 18:34:29 gyee: by default 18:34:36 oh my 18:34:37 gyee: there is code that will remove cached entries for some things 18:34:42 I thought we didn't cache anything by default 18:34:42 dstanek, fairly certain token has a default 18:34:47 but as far as i can tell it's not everything 18:34:49 dstanek: i was just going to suggest "minutes", so 10 fits my answer :) 18:35:07 or it used to 18:35:09 vlah 18:35:11 blah* 18:35:25 morganfainberg: :-) 18:35:25 bknudson, you have to turn on caching, the config is very deployment specific 18:35:54 bknudson, but if you do turn it on, it caches forever (well barring an invalidation because of update, keystone is *good* about invalidating when things change) 18:36:00 morganfainberg: typo-correcting your frustration is either coincidental or ironic, i can't remember which 18:36:13 10 minutes seems reasonable to me. 18:36:14 dolphm, both! 18:36:35 morgon: I believe both global cache and token cache is disabled by default 18:36:47 keystone doesn't know about users when you have them in ldap 18:36:59 the review itself it trivial if we agree on 10 minutes - https://review.openstack.org/#/c/113586 18:37:07 so if you enable caching for users then it won't notice a change for the cache time? 18:37:16 (read-only ldap) 18:37:19 bknudson, its a feature to cache LDAP lookups 18:37:20 and it's dependent on an even more trivial review: https://review.openstack.org/#/c/113585/ 18:37:22 performance gain 18:37:30 bknudson, 10 mins works for me, may i suggest we do the same thing we do for the "enable" have a global default that can be overridded by the individual subsystem 18:37:44 10 mins sounds good 18:37:48 right now we do 3 LDAP roundtrips with every auth 18:37:54 morganfainberg: that would be easy enough 18:38:05 gyee: for extra security 18:38:14 huh? 18:38:16 3-factor authentication 18:38:20 dolphm: ++ 18:38:20 dstanek, yah, and it means as we add more caching, people don't need to remember adding the default 18:38:27 heh, I get the joke now 18:38:31 we need to have the openstack code proposal bot give us sample config updates daily <-- someone #action themselves thx 18:38:34 dstanek, it would just be changing the lambdas 18:38:43 dolphm, infra nixed that 18:38:55 dolphm, when i proposed it -- or is that a joke 18:39:18 morganfainberg: i'm serious - why was it nixed? 18:39:41 dolphm, because it "wasn't what they wanted" they want sample configs to be generated on release. - it was a lot of back and forth. 18:39:56 dolphm, i'll revisit it, but it was pretty resounding "no, not the right answer" 18:40:04 we never used the lockutils stuff... it was just pulled in via oslo-incubator. 18:40:28 can't we automate the sample conf generation stuff in Jenkins? 18:40:34 like some sort of hook? 18:40:43 nova doesn't have a sample config in git repo 18:40:45 generated on release is dumb for the sake of docs 18:40:47 gyee, no, automation is not allowed to commit to a repo. 18:40:55 i have a test i can commit that will break if the config isn't up to date - that may help a little 18:41:07 morganfainberg, seem dump to having to manually generate it every time 18:41:12 dumb 18:41:16 dstanek, i can add a simple non-voting job that tells us if it is out of date 18:41:22 dstanek: we tried the test breaking on sample config and it was a disaster 18:41:24 dstanek, infra wasn't opposed to that really 18:41:44 but we cant *gate* on it being up-to-date 18:41:49 dolphm, fyi updated meeting agenda 18:42:02 morganfainberg: that would be better than where we're at 18:42:05 http://git.openstack.org/cgit/openstack/nova/tree/etc/nova/README-nova.conf.txt 18:42:06 bknudson: i didn't realize we had a test. i remember the issues generating the config 18:42:10 i'll revisit proposal bot with them first. 18:42:30 ack 18:42:36 we could just go with Nova's approach and not have a sample config in git 18:42:47 anyway...i'll create a patch to have a global default cache_time 18:42:50 bknudson, that is likely what we'll be told to do. 18:42:59 bknudson: i think that's a terrible approach from the perspective of docs and new user experience. it's an unnecessary hurdle 18:43:08 dolphm +++ 18:43:08 morganfainberg: and i'm happy to argue against it 18:43:14 I find the sample config in git handy 18:43:23 dolphm, ++ i'll poke ya when we get there (later today) 18:43:26 bknudson: i link people to it every couple days, for sure 18:43:31 morganfainberg: thanks 18:43:35 #topic Attempt to assign a role to a non existent user should fail 18:43:37 dolphm, if we go non-voting job, it'll be a check-only job 18:43:45 (not run at gate time) 18:43:46 bknudson: ++ i point people to it quite a bit 18:43:50 i just wanted to bring this up again, because i'm the sole voice on this, along with everyone filing bugs 18:43:55 #link https://bugs.launchpad.net/keystone/+bug/1355655 18:43:56 Launchpad bug 1355655 in keystone "Attempt to assign a role to a non existent user should fail" [Undecided,Opinion] 18:44:14 i think the reason for that was federated users. 18:44:15 i left it as opinion, but i really think we should 404 for invalid data. users will forever be confused 18:44:27 morganfainberg: correct 18:44:39 there have been arguments that we shouldn't 404 for this. 18:45:00 for the case where you're using LDAP and for some reason the user hasn't been added yet 18:45:23 We should get a use case that says why this must fail 18:45:36 bknudson, i'm not sure that is really a valid case. esp. with the user_id mapping stuff 18:45:39 the complaint here is just that tempest fails. 18:46:00 how do you give roles to users in federation anyway? i thought they were always mapped to a group 18:46:05 what's the real issue? 18:46:07 dstanek, they are. 18:46:16 bknudson: user experience is the use case 18:46:30 the one that i see, anyway 18:46:31 ok, but this bug report isn't about UX 18:46:40 bknudson: agree/understood 18:47:03 i'm just going to put it on the agenda everytime someone complains :) 18:47:15 #topic notifications for role assignments 18:47:17 stevemar: o/ 18:47:21 the behaviour, i think, is not intutitive and will keep confusing people 18:47:23 #link https://review.openstack.org/#/c/112204/ 18:47:24 dolphm, hey 18:47:27 i'm fine with 404ing in this case now since the user_id mapping happened 18:47:29 thx 18:47:29 dstanek: ++ 18:47:35 morganfainberg: ++ 18:47:37 dstanek: test writers? 18:47:40 dolphm, it changes the landscape some. 18:47:52 so, i tossed up some code for emitting notifications for role_assignments 18:47:56 https://review.openstack.org/#/c/112204/ 18:48:01 i'd appreciate some reviews :) 18:48:13 and for dolphm - do you want a spec/bp/bug for this? 18:48:29 stevemar: no spec for weird public api notification format? :P 18:48:58 dolphm, it's not all that different 18:49:01 i think notifications are a public api that is severely undocumented in openstack, i just want to make sure we're not contributing to that mess 18:49:09 stevemar, I thought you should get a purple heart for modifying the notification payload :) 18:49:18 gyee, hooray 18:49:23 stevemar: weird = arbitrary and clients needs to understand it and for it to be stable 18:49:28 yeah it was a mess earlier 18:49:47 dolphm, i agree the docs suck atm 18:49:57 dolphm, i was just going to add a small bit of info 18:50:07 dolphm, but if you want me to overhaul them, i cans 18:50:28 stevemar: as long as we're documenting what we're doing and holding ourselves to it? 18:50:34 stevemar, but why stop at role assignment? it should be for any sort of updates 18:50:56 we'll need a new notifications wrapper class for each kind of update? 18:50:59 stevemar: i know there was compaints from jogo and nova that these notifications conform to a stable api 18:51:03 gyee: role assigment is just an odd one, because there's not a resource entity in the picture 18:51:06 gyee, role assignments in particular were weird, cause it has multiple entities being affected 18:51:11 lbragstad, yes, right now we can't tell what's being updated 18:51:14 yeah ^ 18:51:26 only the resource ID is not good enough 18:51:42 gyee, yeah, cause you don't know what the role is being assigned to, and on what project 18:51:49 you could almost emit 3 notifications :-/ 18:51:51 (or domain) 18:51:58 dolphm, nope! 18:52:06 but i'd rather bring it back to the use case - who's going to consume the notifications and what do they care about? 18:52:25 say PATCH /users/user_id, how can we tell which fields are being updated? 18:52:47 gyee: why do you need to know which fields were updated? 18:53:00 Which openstack service care about role assigments? Are we concerned about delete role_assignment 18:53:00 gyee: don't you just care about what the new entity looks like? 18:53:04 dolphm, for auditing i would think. it's one of those things an admin should be able to watch with ceilometer 18:53:21 Haneef: delete assignment is sort of handled by token revocation events 18:53:36 Haneef: but for auditing, crud all the assignments 18:54:27 dolphm, yes, even as simply as changing email cause a bunch of changes behind the scene 18:54:53 stevemar: so let's write a short spec on the perspective that an auditor cares about? 18:55:07 dolphm, alright 18:55:37 dolphm et all, i'd still appreciate code reviews! :) 18:56:01 #topic open discussion 18:56:06 YAY 5 MINUTES LEFT 18:57:01 I proposed a minor change to JSON Home spec based on Anne Gentle's feedback: https://review.openstack.org/#/c/113413/ 18:57:32 this is the location she suggested for the relationship link so that we could potentially publish something there 18:57:55 bknudson: ++ 18:58:03 dolphm, What do I need to pay if I changed status of a bug by mistake? 18:58:06 it's not required by json home to have the links lead anywhere, but it's something we could do eventually 18:58:15 ' 18:58:27 bknudson thats a cool option to have 18:58:43 * dolphm liquid-keyboard interaction incident 18:58:56 dolphm any sparks??? 18:59:05 so now I'm also working on refactoring the JSON Home code so that it's easy to change the relationship link 18:59:10 removing duplication 18:59:19 topol: this isn't a thinkpad 18:59:43 dolphm, thinkpads are bullet and water proof 19:00:27 stevemar: that's because it's a brick 19:00:39 I'm guessing there won't be further oslo libs published in J 19:00:48 so the oslo.utils one is probably the last 19:01:10 oop, time 19:01:11 #endmeeting