18:02:32 #startmeeting keystone 18:02:33 Meeting started Tue Sep 9 18:02:32 2014 UTC and is due to finish in 60 minutes. The chair is dolphm. Information about MeetBot at http://wiki.debian.org/MeetBot. 18:02:34 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 18:02:36 The meeting name has been set to 'keystone' 18:02:44 #topic Spoilers 18:02:47 #info it's a watch 18:02:51 o/ 18:02:57 #topic Juno-3 18:03:01 everybody is making watches now 18:03:04 is it round at least? 18:03:07 bknudson: no 18:03:15 Congrats on Juno-3 everyone! not only did we manage to make juno-3, but we were actually the first project to be feature complete for juno :D 18:03:19 so, THANK YOU EVERYONE! 18:03:27 (despite a 20+ hour gate for most of the week) 18:03:46 and the pip failures 18:03:48 +++ 18:04:11 bknudson: and a three fold increase in transient errors in the gate over the past 3 weeks :( 18:04:16 yay! 18:04:22 dolphm, can't let our track record of hitting the deadlines fall off. 18:04:36 morganfainberg: ;) 18:05:13 even though we had two feature freeze exceptions going into RC1, they were both approved and gating long before juno-3 was cut :( 18:05:18 like, 48 hours ahead 18:05:21 sad 18:05:22 anyway 18:05:29 o/ 18:05:30 #topic Juno RC1 18:05:33 #link https://launchpad.net/keystone/+milestone/juno-rc1 18:05:36 feels good to be complete 18:05:40 what's the date on rc1? 18:05:53 bknudson: ASAP 18:06:06 9-25 according to https://wiki.openstack.org/wiki/Juno_Release_Schedule 18:06:12 We need to remove the cinder and neutron jobs that have all of the transient errors. We should not be gating on them 18:06:14 we've started our list of blockers to RC1, and thus the countdown to RC1... RC1 will be cut when everything on the list above is Fix Committed 18:06:24 bknudson, but if we're good earlier we can get cut over and get to work on Kilo! 18:06:36 whoop! 18:06:38 bknudson: 9/25 is the target 18:06:39 let's stop finding bugs then 18:06:47 bknudson: hopefully we'll be stable before then 18:06:55 bknudson: easiest way to do that is to stop looking :) 18:06:58 ayoung, that is a larger conversation - mostly around gate in general 18:07:16 ayoung, that push (functional testing in-tree vs tempest) is looking like a K target across the projects (see ML threads) 18:07:18 yep, just wanted to get it in the log 18:07:36 morganfainberg: do you have a link to that 18:07:48 lbragstad, it's the "TC exercise one" give me a second 18:07:49 i also resumed maintaining the same list as for RC1 blueprints... this time containing code reviews that are blockers for Juno-RC1: 18:07:50 is there more info on the functional testing in-tree? 18:07:51 #link https://gist.github.com/dolph/651c6a1748f69637abd0 18:08:03 I don't know what it means for keystone 18:08:14 https://bugs.launchpad.net/bugs/1361422 is the only incomplete . I can take a look at triaging it 18:08:15 Launchpad bug 1361422 in keystone "When using Keystone API v3, catalog won't be returned" [High,Incomplete] 18:08:21 since keystone isn't depending on other projs seems like there's nothing for us to do. 18:08:39 bknudson, we're mostly there already. our restfultests are sortof what they're doing 18:08:41 But it sure looks like a "using the service_token" problem 18:09:07 bknudson, the integration will still be needed but some of the tests will move to functional in-tree (some of the failures are cinder specific for example) 18:09:07 morganfainberg: so it's not in a separate git repo? 18:09:20 bknudson, nope. it would be (in our case) in keystone 18:09:40 morganfainberg: that's exactly what keystone.test.system should be used for! 18:09:43 ayoung: thank you 18:09:52 hi 18:10:34 #link http://lists.openstack.org/pipermail/openstack-dev/2014-September/044766.html 18:10:59 that thread is part of it, there is also the other various threads that floated the ideas of funcitonal testing (like swift and neutron do) in-tree. 18:11:15 I'm just worried given how much of a mess our tests are in already 18:11:15 and irc discussions. it's been floating around a lot 18:11:36 bknudson, basically the big change is we would have a full devstack to run our functional tests in. 18:11:44 bknudson, but tempest is at it's limit. 18:11:45 ohhh 18:12:08 I did try submitting some tempest tests but then this came up so I abandoned them. 18:12:28 i like the direction of this, but i wish we had seen it coming sooner as a community 18:12:31 because it looks like they don't want keystone tests in tempest 18:12:34 as an inevitable need 18:13:25 bknudson, yep, tempest should be for integration not functional is the general view i've seen 18:13:28 and i don't disagree. 18:13:42 our restful cases are clearly functional 18:14:53 morganfainberg: so you're saying our restful cases are changed to work against devstack keystone rather than the one started by test? 18:14:55 morganfainberg, there would be *no* keystone tests in tempest??? 18:15:21 bknudson, i think we should have a functional tox target that makes it so they *can* run against a live keystone server in devstack 18:15:22 topol: other projects will be using keystone but nothing specific to it. 18:15:22 topol: no keystone-only tests in tempest -- just ones that require integration across multiple projects 18:15:38 dolphm, thanks, that helps 18:15:56 bknudson, but i don't want to make it not possible to run under a local/non-devstack env. if that makes sense. (they might move out of py26/27) 18:16:00 as part of another test they'll probably be adding users and validating tokens 18:16:27 the interesting twist for us is that we only really need to do integration tests with auth_token -- it doesn't matter what service is running behind auth_token, so it might as well be a trivial stub service that just returns 200's. or echo's your auth context back in a response body 18:16:55 dolphm: I think we have middleware tests that essentially do that. 18:17:24 bknudson, yes, but middleware can't spin up a server 18:18:14 it would be good to test with a real SSL connection 18:18:19 ayoung: we *can* do that though 18:18:21 echo wsgi app https://github.com/dolph/keystone-deploy/blob/master/playbooks/roles/http/templates/echo.py 18:18:40 dolphm, good point. I should say "we don't spin up a server" 18:18:53 dolphm, my point was just that the middleware tests were using stubbed data 18:19:07 ayoung: ++ but we could make it a real service (albeit a trivial one) 18:19:49 we should move on ... 18:19:50 we'll want tests with other openstack projects to ensure that we don't change the interface on them. 18:20:20 agree 18:20:21 #topic meeting-topic bugs 18:20:59 so, trying a new thing: we have a new tag in LP on bugs that should be discussed during the weekly meeting 18:21:01 #link https://bugs.launchpad.net/keystone/+bugs?field.tag=meeting-topic 18:21:14 handy! 18:21:14 so, the question for most of these is "should it be a release blocker?" 18:21:44 so, let's start with the two wishlist bugs, which i think can be discussed as one: 18:21:46 #link https://bugs.launchpad.net/keystone/+bug/1331884 18:21:49 Launchpad bug 1331884 in keystone "A V2 token from trust cannot be generated with user/pass" [Wishlist,In progress] 18:21:50 #link https://bugs.launchpad.net/keystone/+bug/1331882 18:21:51 Launchpad bug 1331882 in keystone "trustor_user_id not available in v2 trust token" [Wishlist,In progress] 18:22:03 basically both of them are v2 API impacting 18:22:15 I thought we deprecated it 18:22:42 bknudson: v2? or v2 trusts? 18:22:49 v2 api 18:22:52 *pending* deprecation, still 18:23:09 we reversed the deprecation near the icehouse release 18:23:48 the changes for the trustor_user_id one look good to me 18:24:05 its pretty straightforward 18:24:15 and i like the new bug tag :) 18:24:26 given that this is API impacting, post FF, and it's on a completely undocumented API feature (v2 trusts), i'm inclined to bump to kilo or just leave it as Won't Fix 18:24:31 How is trustor_user_id not available in v2 trust token? 18:24:52 is jamielennox around? 18:24:58 neither of these look like things that obviously need to be blockers 18:25:02 lbragstad: yea, i'm watching 18:25:02 I believe he opened the bug originally 18:25:06 bknudson: it was deprecated, then the deprecation was deprecated once everyone saw the logs being spammed with deprecation warnings 18:25:09 ayoung: the bug description only has a trustee_user_id 18:25:29 dolphm, no, I see that. I just find it hard to believe we missed that in testing, and it has gone this long. 18:25:43 ayoung, it's missing impersonation too 18:25:44 i don't know if i have a strong opinion on whether we should fix it at this point, particularly post RC - it was just something i found 18:25:46 ayoung: and the fact that it's gone on this long means it shouldn't be a blocker :) 18:25:48 stevemar: ++ 18:26:03 dolphm, good point 18:26:12 I wonder if it happened when we moved this to the token provider? 18:26:17 dolphm +++ good logic 18:26:19 right, no one has complained about it so it shouldn't be a blocker 18:26:31 Um, what if it is a regression? 18:26:46 ayoung, wouldn't the tests have spotted that? 18:26:58 stevemar: v2 trusts are untested, AFAIK 18:27:00 stevemar cracks me up 18:27:03 womp womp 18:27:04 even if they're not blockers we can still approve them? 18:27:04 stevemar, not if we missed it 18:27:16 v2 trusts are basically not supported 18:27:19 jamielennox, :D 18:27:50 bknudson: i'd like to -2 both of these until kilo -- unless someone wants to champion for these 18:27:53 then i don't think it's a regression if it's not supported 18:28:28 hard to disagree with that 18:28:43 how far are we willing to go with v2 trusts it at all 18:28:57 i mean if they are "unsupported" ... do we even *want* to support them? 18:29:09 isn't HEAT use v2 trust? 18:29:16 gyee, v3 18:29:20 ah 18:29:21 would be safer from security perspective to remove support 18:29:23 gyee, afaik they use all v3 for that stuff 18:29:25 morganfainberg: well, we haven't supported them since the implementation AFAIK ... i don't see a reason to change that in the middle of feature freeze 18:29:38 http://git.openstack.org/cgit/openstack/keystone/tree/keystone/token/providers/common.py#n87 18:29:47 bknudson: probably so, but we also have a flag to disable trusts altogether 18:29:47 dolphm, i mean in K, i wouldn't remove them now. 18:29:58 morganfainberg: ++ 18:30:02 dolphm, lets allow a fix for the V2 token/trust thing 18:30:24 yeah, there are enough people stuck on V2 that theyr are going to end up using the trusts anyway 18:30:29 just without all of the data needed for audit 18:30:36 ayoung: the fixes for these are far from trivial 18:30:37 the fix is minimal 18:30:38 here's the fix: https://review.openstack.org/#/c/101829/ ? 18:30:52 like this mammoth function: _deal_with_trust_scope(): https://review.openstack.org/#/c/112230/4/keystone/token/controllers.py 18:30:53 ayoung, why woulkdnt we be pushing them to V3? 18:31:05 topol: this isn't an issue in v3 18:31:14 dolphm, pushing users to v3 18:31:14 topol: or is that what you're suggesting 18:31:17 gotcha 18:31:26 I was +2 on https://review.openstack.org/#/c/101829/ a few times already. 18:31:27 +++ pushing!!! 18:31:36 to be fair, the first change was made in june, and yeah bknudson was +2 on it 18:32:02 I wasn't added to it...sorry I missed it. The fix looks good. 18:32:16 dolphm, oh gah that method... 18:32:29 so assuming it hasn't changed much approve and have the fix 18:32:38 dolphm, you have any real problem with me +2Aing that one? 18:32:41 have any of the other integrated projects adopetd V3 this time around? 18:33:04 topol: even keystonemiddleware doesn't really support v3 18:33:11 I can take another look at it too, I had eyes on it before 18:33:13 heat is v3 (for trusts), right? 18:33:14 bknudson, I'm going to +2. You can take it from there 18:33:17 ayoung: if it's introducing a risk, then yes. i haven't reviewed either 18:33:21 that looks pretty good - i'd be inclined to approve the v2 trust fix given it's been there so long 18:33:21 or am I mistaken? 18:33:38 nkinder, correct, this is unrelated to heat 18:33:59 dolphm, Its adding data to the token, but it is passing tempest. Not sure that there is any more risk including it than leaving it out 18:34:30 heat might need to use V2 tokens for a service that is V2 only, but someone obviously saw this 18:34:34 morganfainberg: userstood. Just responding to topol's question about v3 usage 18:34:36 ayoung, adding the data isn't a big change tbh. the other one is 18:34:46 "the other one?" 18:34:58 ayoung, https://review.openstack.org/#/c/112230/4 the trust review 18:35:10 ah 18:35:18 morganfainberg, I'd be OK passing on that one 18:35:18 https://bugs.launchpad.net/keystone/+bug/1331884 18:35:19 Launchpad bug 1331884 in keystone "A V2 token from trust cannot be generated with user/pass" [Wishlist,In progress] 18:36:10 so definitely hold https://review.openstack.org/#/c/112230/ for kilo? 18:36:24 that's much more wishlisty 18:36:25 dolphm, yes 18:36:45 ok, I'll remove the meeting-topic tag from https://bugs.launchpad.net/keystone/+bug/1331882 and leave a comment on the bug report? 18:36:48 Launchpad bug 1331882 in keystone "trustor_user_id not available in v2 trust token" [Wishlist,In progress] 18:37:12 lbragstad: thanks 18:37:23 lbragstad: i already commented on the bug 18:37:27 lbragstad: err patch 18:37:33 cool 18:37:49 dolphm, or even mark "won't fix" 18:37:58 I am not certain I want 112230 18:38:02 i'd be ok with wont fixing it. 18:38:06 me too 18:38:17 i'm inclined to say it's new functionality and we're not adding functionality to v2 18:38:32 ayoung: i'll let you dive into that - i at least want to hold it for kilo for now 18:38:39 morganfainberg: certainly is 18:38:48 morganfainberg, dolphm, ++ 18:38:50 dolphm: did you publish? 18:39:03 dolphm: oops, wrong review 18:39:16 lbragstad: i was thinking i commented on the wrong review :) 18:40:03 lbragstad, dolphm fyi added another bug to the meeting topic list 18:40:16 one more wishlist bug that i just added meeting-topic to before we get into bugs: 18:40:21 #link https://bugs.launchpad.net/keystone/+bug/1350273 18:40:22 Launchpad bug 1350273 in keystone "Filtering services by name doesn't work" [Wishlist,In progress] 18:40:22 stevemar: ack 18:40:23 cool, I'll update the consensus of the other trust bug too 18:40:45 i actually thought this merged awhile back, and it just slipped under my redar 18:41:34 it seems like a safe add (it's a read-only api feature), made all of our deadlines, but was just forgotten about 18:41:49 anyone want to save it for kilo? 18:42:45 i'll take that as a no 18:42:46 seems like a kilo move 18:42:52 stevemar: ? 18:43:26 dolphm, seems like even more impact than the trustor_id one 18:44:03 stevemar: want to hold it for kilo then? 18:44:25 thats my vote, i'll let others weigh in 18:44:44 its 5 lines of real code, and a slew of testing 18:44:46 well, i guess most of the changes are in tests 18:44:56 ayoung, yeah, just realized that now 18:45:01 i'm ok with this - particularly since we've already merged the corresponding identity-api review 18:45:05 dolphm: I vote for putting it in 18:45:08 https://review.openstack.org/#/c/110904/5/keystone/common/sql/core.py,cm that is the real change 18:45:28 and https://review.openstack.org/#/c/110904/5/keystone/catalog/controllers.py,cm 18:45:35 yeah....lets merge this one 18:45:43 meh, lets do it 18:45:47 let's *review* it then 18:45:50 need to look at the tests, but the real code looks good 18:45:59 updating the bug report 18:46:13 this looks like a legitimate bug, and a trivial fix (in code) - tests less trivial but def. reviewable 18:46:30 i'll give it til the end of the week to get gating -- if it's not approved by then, i'll hold it for kilo 18:46:31 dolphm, let rephrase to avoid upsetting sensibilities; lets *allow the* merge of this one 18:47:13 stevemar: CADF one? 18:47:15 dolphm, ++ 18:47:19 dolphm, yep 18:47:20 stevemar: can you set the priority on that? 18:47:43 oh this is brad's one 18:47:46 it seems to me like the service_name one is missing a controller component? where's the python side filtering happening? 18:48:29 jamielennox: in the decorator implementation, IIRC? 18:48:58 stevemar: i'm happy to see this happen in juno 18:49:02 are there a lot of services in a real implementation? 18:49:03 I like that there was already a todo for it. 18:49:21 this would basically always download the table and filter in the app 18:49:23 dolphm, yeah, if we take that out, metering ceilometer for authN events becomes much easier 18:49:48 stevemar: good to note 18:49:49 dolphm: i don't remember the decorator actually doing filtering, it was just a policy tie-in 18:49:51 dolphm, i was thinking, maybe a potential backport to icehouse 18:50:04 stevemar: that i wouldn't want to do :( 18:50:06 (maybe i'm wrong and i did a lot of stuff manually i didn't need to do ) 18:50:24 dolphm, just putting it out there 18:51:04 jamielennox: hmm... worth looking into. henrynash surely knows the answer though 18:51:39 jamielennox: fitering is down is wrap_collection 18:51:48 9 minutes 18:51:52 eek 18:52:00 (done in) 18:52:05 want to reserve 5 for the Kerberos issue, please 18:52:15 so, three more bugs that aren't wishlisty, so this is just deciding if they should be RC blockers or not 18:52:22 ayoung: these should be quick 18:52:24 #link https://bugs.launchpad.net/keystone/+bug/1313956 18:52:25 Launchpad bug 1313956 in keystone "Keystone adds role to non-existing user in specific tenant by API" [Medium,Triaged] 18:52:44 this is the one we've gone back and forth on ^ 18:53:11 dolphm: what's the proposed fix/ 18:53:11 ? 18:53:15 change v2 or change v3? 18:53:18 henrynash: oh - cool i'd never seen that, there might be some code i can pull out.. 18:53:20 patch is in review, but abandoned https://review.openstack.org/#/c/93982/ 18:53:26 both of these seem like a bad idea 18:53:36 I say "won't fix" 18:53:40 bknudson: both 18:54:05 for SAML and the multi-backend patch we don't necessarily know all of the userids that will be possible 18:54:26 ayoung: will you mark the bug as such with an explanation? 18:54:28 lets at least punt on the fix for this release. 18:54:30 Will do 18:54:31 the only counterpoint to ayoung is that we don't allow assignments to federated users. 18:54:40 ayoung, ++ punt to Kilo at the least. 18:54:41 morganfainberg, LDAP is not federated though 18:54:48 #link https://bugs.launchpad.net/keystone/+bug/1326421 18:54:50 Launchpad bug 1326421 in keystone "No endpoint ID in v3 KVS or templated catalog" [Medium,Triaged] 18:54:58 ayoung, ah, right. 18:55:03 oh, I thought this was talking about some kind of _member_ role. 18:55:17 this is going to be a mess to fix -- basically requires rewriting the KVS driver to be v3 ish 18:55:26 i'd rather not do that for RC 18:55:35 ++ 18:55:44 dolphm, ++ i'd like to deprecate the templated backend tbh. but .... 18:55:47 jamielennox: unlses the client is going to choke somewhere without that attr? 18:55:52 dolphm, and templated goes away so can kvs 18:56:10 people love templated backend 18:56:18 and the last one: 18:56:20 #link https://bugs.launchpad.net/keystone/+bug/1346211 18:56:20 bknudson, i don't have the foggiest why. 18:56:21 Launchpad bug 1346211 in keystone "keystone under apache can't handle request chunking" [Low,Triaged] 18:56:23 but it needs a v3 rewrite 18:56:23 dolphm: not off the top of my head 18:56:24 it's fast 18:56:38 this is a long discussion, and the short of it is that keystone doesn't support chunking and we should document that 18:56:39 bknudson, we could improve the SQL one similarly. 18:56:50 dolphm, ++ that is a mod_Wsgi thing 18:56:57 Defer on chunking. Needs an Apache fix to be viable, as Morgan comments in the bug report 18:57:07 ayoung, actually it is a wsgi spec issue 18:57:12 that too 18:57:14 ayoung, "wont fix" + doc is correct 18:57:19 ++ 18:57:23 anyone want to volunteer to write a one sentence doc for this for juno? otherwise, i'll defer to kilo 18:57:29 OK...Kerberos in 2 minutes? 18:57:31 dolphm, i'll add a 1 liner 18:57:37 sold 18:57:42 #topic kerberos 18:58:06 Here's the deal with Kerberos: we want it to be everywhere, but accept that adding an additional Binary dependency is not appropriate 18:58:15 (Kerberos should be done with native libraries) 18:58:21 this is explicitly a client issue, BTW 18:58:24 so... 18:58:32 where should the Kerberos Auth plugin live, then? 18:58:54 ayoung, as an entry point 18:58:59 python-keystoneclient-kerberos 18:59:03 jamielennox, ++ 18:59:04 stackforge? 18:59:05 In KC, but with out the requirements.txt entry 18:59:09 ayoung, in a separate module. 18:59:13 jamielennox, no 18:59:25 I think in the KC repo, but released a s a separate module yes. 18:59:26 ayoung, separate module, separate pacakge 18:59:33 jamielennox: new repo? 18:59:38 ayoung, new repo. 18:59:52 yea, i looked into that before, pip doesn't handle having mutliple packages come out of the same repo well 18:59:53 why is that the answer? It seems like a waste of effort? 19:00:06 jamielennox: ++ pbr says that's a no-go 19:00:10 ayoung, makeing separate packages from one repo is really really ugly 19:00:26 morganfainberg, so is splitting code out into its own repo, but for different reasons 19:00:40 ayoung, pbr also will have issues with separating packages 19:00:43 morganfainberg, we want to be able to ship it in a single package downstream 19:00:46 i think the same thing should be done for the federation work in client that requires lxml that people got annoyed by 19:01:02 jamielennox, are we going to have a separate repo for Federation, too? 19:01:09 ayoung, i would advocate non-standard plugins should all be separate repos 19:01:09 time 19:01:13 THis sounds like what the Nova folks are dealing with the drivers 19:01:17 ayoung: but yes 19:01:21 morganfainberg, Kerberos should be come a standard driver 19:01:34 ayoung, if it has binary deps that cannot be installed everywhere, no. 19:01:36 and that's the nova discussion 19:01:37 #endmeeting