18:01:54 #startmeeting keystone 18:01:55 Meeting started Tue May 16 18:01:54 2017 UTC and is due to finish in 60 minutes. The chair is lbragstad. Information about MeetBot at http://wiki.debian.org/MeetBot. 18:01:56 o/ 18:01:57 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 18:01:59 The meeting name has been set to 'keystone' 18:02:02 hi 18:02:02 o/ 18:02:04 o/ 18:02:04 o/ 18:02:13 ping antwash, ayoung, breton, cmurphy, dstanek, gagehugo, henrynash, hrybacki, knikolla, lamt, lbragstad, notmorgan, ravelar, rderose, rodrigods, samueldmq, spilla 18:02:24 o/ 18:02:25 #link https://etherpad.openstack.org/p/keystone-weekly-meeting 18:02:29 o/ 18:02:59 hopefully everyone had an uneventful trip home from the summit 18:03:35 I did 18:03:48 ayoung: i would hope so! 18:04:06 i bet knikolla's 20 minute walk was brutal 18:04:12 hrybacki, edmondsw want to be added to the ping list? 18:04:21 lbragstad: you bet, haha. 18:04:29 ayoung: I'm on it already :) 18:04:37 ayoung I thought I already was... yes 18:04:47 * ayoung can 18:04:49 't read 18:05:04 edmondsw: we cleaned it up a few meetings ago 18:05:16 #topic announcements 18:05:25 #info pike-2 is three weeks away 18:05:39 which means we'll be in spec freeze for pike 18:06:00 I'll be prioritizing spec reviews the next couple weeks 18:07:44 We also need a documentation liaison 18:08:08 i understand a lot of folks are strapped for resources, but it anyone interested in picking this up? 18:08:22 s/it/is/ 18:08:31 what exactly would that entail? 18:08:41 good question 18:09:14 the documentation liaison is responsible for keystone related documentation changes to the openstack-manuals and other projects under the docs team 18:09:39 I'm interested but their meeting time is a little inconvenient for my time zone 18:09:39 they also serve as a point of contact for the the docs team if they have any keystone questions 18:09:39 rodrigods, I wonder if we could enlist martin for that role? 18:09:51 lbragstad: I'm interested but would like to talk more about 18:10:05 cmurphy: understood 18:10:25 #link http://eavesdrop.openstack.org/#Documentation_Team_Meeting 18:10:32 ^ that's the actual meeting information 18:10:45 * lbragstad wonders if asettle is around 18:11:51 there is some more information about the role in the wiki 18:11:54 #link https://wiki.openstack.org/wiki/CrossProjectLiaisons#Documentation 18:12:14 ayoung: rodrigods is martin an openstack contributor? 18:12:15 lbragstad: fyi there is a current effort for migrating some docs into our tree 18:12:16 o/ sorry I'm late 18:12:20 such as the admin-guide 18:12:33 samueldmq: yep - that was another big discussion at the forum 18:12:34 lbragstad: I can attend the meeting this week as a stop-gap. Don't want to commit just yet to taking it over completely 18:12:41 #link https://etherpad.openstack.org/p/doc-future 18:12:45 talked to asettle at the summit about that, I took a few working items for our Outreach internship 18:13:10 lbragstad: nice, thanks for the linked, I haven't looked into that yet 18:13:10 hrybacki: that makes sense 18:13:25 the tl;dr was that the docs team got hit hard recently 18:13:43 o/ 18:13:47 the discussion was focused on how we can maintain all the documentation work 18:13:48 * hrybacki nods 18:13:58 now that we have less people working on docs 18:14:33 one of the proposals was to move more of the documentation into the project specific repositories and then have the guides rendered by pulling all the guides together 18:15:13 asettle: drove that session, so she's probably be able to clear up the direction there 18:15:47 regardless of what happens, we'll have some documentation work coming down the pipe and I wanted to get an idea of who, if anyone, would be interested in that kind of work 18:16:13 * cmurphy happy to help 18:16:18 I enjoy docs so I'm a candidate 18:16:52 happy to help but not able to guarantee a constant commitment to docs work. 18:16:59 ++ 18:17:02 and that's fine 18:17:15 i know a lot of folks here are stretched thin, too 18:17:34 if that means sharing the responsibility then i think that's ok 18:17:48 we'll just have to make sure communication is on point with the docs team, too 18:18:14 Got it. We'll start browbeating people. 18:18:22 I can take an action item to follow up with asettle 18:18:27 lol 18:18:42 #action lbragstad to follow up with asettle about docs liaison 18:18:44 lbragstad: sjain will be glad to help too, since that is what her internship is about :) 18:18:53 samueldmq: sweet! 18:19:15 but sure if we have lots of folks we can move much faster, which is great 18:19:21 #topic spec proposal freeze exception 18:19:35 #link https://review.openstack.org/#/c/463547/ - Retrieving policy via the API 18:19:41 we should probably have an etherpad with pain points of our docs. and just let people sign up for individual items 18:19:51 -2 18:20:04 lbragstad, so many no. 18:20:21 there are two specification proposed to keystone that enable patrole to test keystone's policy 18:20:45 which is great, but I think we need to work with them on generating the policy using oslo.policy bits instead of fetching it via that API 18:20:48 for $REASONS 18:21:27 lbragstad: what is patrole ? 18:21:34 RBAC testing 18:21:43 I've seen that review but haven't looked into it yet, so I guess now is a good time to learn :) 18:21:45 samueldmq, it is, in essence, a tool for checking RBAC. 18:21:49 lbragstad invite the author to our policy discussions? 18:21:51 #link https://docs.openstack.org/developer/patrole/ 18:21:57 invite the whole team 18:22:14 samueldmq: patrole is a framework for testing policy 18:22:30 * ayoung sobs. Not so quietly. 18:22:45 samueldmq: it will plug into tempest and exercise various policy scenarios in a functional manner 18:22:51 (at least from what I can tell) 18:22:51 hmm that's an interesting idea 18:22:59 sounds like they're proposing similar specs to other project, or plan to 18:23:05 Yeah, interesting. In a "Chinese Fortune" meaning of the term 18:23:06 and we don't want that... 18:23:16 ++ 18:23:35 from what i can tell - it would be only used for patrole to fetch the policy 18:23:43 so it would be an API for testing 18:23:51 If only we had some dynamic way of distributing policy.... 18:23:51 and we've already taken a stance on policy API s 18:24:00 lbragstad: cool, that's an interesting idea 18:24:07 I'd say give them some time in our next policy meeting (or the next one they can make), have them explain patrole, and us explain what we're doing, and try to get on the same page 18:24:16 I wonder if that could evolve to something operators could use in the future to check their policies 18:24:41 edmondsw: ++ 18:24:46 if they're really expressing what they wanted to 18:24:52 i invited them to this meeting but the timing might not have been the best 18:24:54 knikolla, and I would be willing to give the authors our talk from the summit via video conf 18:25:14 ayoung wasn't it recorded? 18:25:23 edmondsw, it was, but I would give it again just for them 18:25:23 imho it sounds like what they want is a capabilities API 18:25:23 could just post the link? 18:25:37 ayoung oh, so you have time to burn after all... ;) 18:25:39 implemented in each of the services 18:25:39 putting the link along with the negative review would be enough 18:25:49 s/enough/great 18:25:59 #link https://www.youtube.com/watch?v=EYYzl0rFCVU 18:26:01 so that they can learn more about the history/context/plans 18:26:04 https://www.openstack.org/videos/boston-2017/per-api-role-based-access-control 18:26:11 Will do 18:26:13 ayoung doesn't sound like the middleware thing is really what they're after anyway 18:26:20 #link https://www.openstack.org/videos/boston-2017/per-api-role-based-access-control 18:26:35 i think they want a list of things they can do 18:26:46 yeah, that's a bit different... as you said, capabilities 18:26:50 (at least that's what I got from reading the spec) 18:27:15 lfrom the spec i got the feeling they just want a way to 'wget policy.json' 18:27:26 knikolla: right 18:27:38 that's how i understood it 18:27:53 that's different from 'what can i do' 18:28:10 So.... 18:28:26 Are we going to go with the RBAC in middleware approach? 18:28:30 i'd also classify another question which is "what is possible" 18:28:36 they talk about 2 things... one being policy.json and another being "when policy is being handled within the code (oslo.policy case)"... not sure what exactly they mean by the latter 18:29:08 before we discuss the patrole thing further, lets talk about the proposal that will actually answer their question if we go with it 18:29:11 sounds to me like cases where checks are hardcoded 18:29:17 they wrote based on policy because that is all there was. 18:29:47 ayoung: ++, we need to get spec approval for pike before spec freeze 18:29:51 they wrote "patrole" based on policy. 18:30:16 Is any core prepared to -2 the RBAC in middleware approach? 18:30:41 I have concerns with upgrades 18:30:46 and maintenance 18:30:47 and the url 18:30:58 lbragstad, enough to -2? 18:31:20 I am concerned about how this fits with the ongoing efforts 18:31:25 I think we can eventually get there 18:31:30 samueldmq +1 18:31:41 but not now, let's keep moving and keep that in the wishlist 18:31:43 enough to -2 it for Pike? 18:31:47 based on the url - possibly, because i found a lot of value in what dstanek had to say about it 18:31:54 and we will eventually get back to it as we move 18:32:08 ayoung: for me I think so 18:32:29 for Pike would be -2, for backlog/wishlist/future repo I'd +2 18:32:37 samueldmq, it will, then, never happen 18:32:51 we are making progress. 18:32:55 samueldmq, no we are not 18:33:09 you are just realizing all the mess I realized years ago 18:33:12 I think the right time will be when we get to split the role checks from the scope checks 18:33:19 once we have only role checks somewhere 18:33:19 samueldmq: it's already been approved for backlog. and the code is almost done. 18:33:30 we can decide where we put those checks (middleware or whatever) 18:33:32 samueldmq: it can be turned off and nothing changes. 18:33:45 i got some very positive feedback from operators who want to see this after seeing the talk. 18:33:52 Hear you nothing that I say? 18:34:07 like i said - my concern is with the url 18:34:31 lbragstad, please state that concern completely. 18:34:36 what if when we get to the point (in cross project) that we split role/scope check and then look at the middleware approach 18:34:46 and no, we wanted to do it differently now that we got to this point 18:34:57 I don't think it make sense for keystone to have to require knowing about the url and maintain that mapping when other parts of OpenStack already have to do that 18:35:18 I am not opposed to it at all, just wanted enough input that this is going to go along very well with the cp efforts 18:35:23 if that breaks - i can't imagine what kind of operator pain that is going to cause 18:35:32 if what breaks? 18:35:34 lbragstad: middleware only knows the url. if you want to use compute:list_servers. it still needs the mapping. 18:36:03 kbyrne: so what's the point of performing role checks in 2 places? 18:36:04 They can't do it today. There is no way to gether up the list of URLs for a project except manually. 18:36:14 the current proposal requires the keystone server to know that POST /v2/servers -> compute:boot_instance 18:36:19 lbragstad, nope 18:36:37 for me it would make sense if we were going to only check roles in the middleware, checking in 2 places is going to be painful imo 18:37:05 the current proposal has a catch all that means it needs to know nothing about a remote service to be drop in compatible. It only has to know about POST /v2/servers if you want a specific role for that 18:37:25 and none of the other projects know about any of the keystone roles with the exception of admin 18:37:36 the service role is in the config file, managed by us 18:37:43 ok - true or false, keystonemiddleware has to query keystone to determine if a user can do a specific operation 18:37:48 neutron has some non-created roles in their policy file 18:37:50 knikolla when you say the code is almost done, does that include things like caching so performance isn't awful? 18:38:07 lbragstad, true (query and cache the rbac data) 18:38:20 lbragstad, it has to do that now, when it validates a token 18:38:23 query and cache 18:38:54 edmondsw, caching is not yet done. It will be cached in memcache along side the token data 18:39:05 sure - but it's asking keystone because we're allowing the ability to store all operations in openstack in keystone based on the url, because that's what middleware requires in order to map to the operation, right? 18:39:18 lbragstad, not just 18:39:36 lbragstad, we need to map an operation to a role. Roles are data in Keystone. The RBAC data is the maintainance of this mapping 18:39:47 it has to be maintained somehow, and this is an operator task 18:40:14 edmondsw: i haven't played around with caching yet, but i can devote enough time to having this work well for Pike if it gets approved for it. 18:40:14 there are workflows that are impossible without the RBAC mechanism] 18:40:21 knikolla, ++ 18:40:59 lets get it in, disabled by default, and let people start working with it 18:41:20 there is no other way to do this 18:41:26 i think there is 18:41:29 is there the concept of experimental yet ? 18:41:32 ayoung define "this" 18:41:51 edmondsw, the 3 use cases from my presentation,. and the workflow I layed out at the end 18:41:53 edmondsw: finding out "which role I need to do X" 18:41:59 yep 18:42:10 this doesn't accomplish that 18:42:27 edmondsw, yes it does. Not 100%, because of policy, obviously, but it is a start 18:42:33 if it is used, it does answer that question 18:42:39 if it is not used, there is no way to answer it 18:42:54 ayoung so you say yes, and then contradict yourself and agree that it doesn't :) 18:42:55 well - the rbac in middleware approarch requires us add an API to keystone that let's keystone answer that question 18:43:03 edmondsw, unless we make every single service give up an API to report their policy, we cannot work with tp-olicty,.json to do this 18:43:26 lbragstad no, it allows keystone to give you an answer with <100% certainty 18:43:30 policy will always still be there 18:43:33 edmondsw, so we make progress. And then we get rid of RBAC in policy 18:43:40 ayoung you can never do that 18:43:49 never ever ever 18:43:54 nor should you want to 18:44:35 I don't disagree with the middleware idea... I just don't want it taking attention away from more important things, or being touted as more than it is 18:45:02 edmondsw, just becuase you guys are doing some propriatey back system lookup does not mean I want to keep supporting the existing mechanism. Just because someone could throw a custom middleware, or even proxy in front of a Keystone server does not mean I should care about that use case 18:45:21 ayoung you're confusing me with someone else... I'm not doing any proprietary back system lookup 18:45:40 I don't work with Henry 18:45:55 nothing I'm saying has anything to do with that 18:45:57 edmondsw, heh 18:46:20 edmondsw, why on earth would you want to continue to enforce RBAC in policy? Aside from momentum? 18:46:42 because there are some things you have to check that you can't check in middleware because it doesn't known enough 18:47:01 like what owns a given resource, for example? 18:47:07 sure 18:47:09 but that's the scope check 18:47:12 no 18:47:27 there are so many very different examples 18:47:52 e.g. changing one attribute needing a different check than changing another attribute on the same resource 18:47:53 edmondsw, none of that is RBAC 18:48:00 ownership is scope check 18:48:26 ayoung if we had a real ownership concept 18:48:37 I don't want to get sidetracked on that... consider my example 18:48:45 please... 18:48:48 see above 18:48:58 edmondsw, what example? 18:49:04 the line that starts with e.g. 18:49:38 currently done via actions API for example in Nova 18:49:48 we have the follow on spec for bodykey 18:49:53 ayoung, no, that's a separate but another good example 18:49:54 that can be done in middleware 18:50:12 won't be done this release due to caution, but not a reason to keep using policy 18:50:29 ayoung I don't believe you'll be able to solve that in middleware. Maybe some subcases, but not all of them 18:51:00 edmondsw: if updating both attributes is done via the same url, a follow up proposal checks the keys in the body of the json. if both keys are there, it checks for both roles required by each key. 18:51:04 ayoung what is the link for that spec anyway? 18:51:53 I don't see how you can handle all possible cases, where the key could be buried layers down in the json hierarchy, same key could mean different things in different places, etc. 18:52:11 https://review.openstack.org/#/c/452198/ 18:52:11 #link https://review.openstack.org/#/c/456974/ 18:52:56 edmondsw, can be vs is. We have an openstack that is out there now. Based on the today restrictions, we have something that can work. If we deploy it, it will become tomorrows guidleine for new API construction 18:53:09 #link https://review.openstack.org/#/c/452198/ 18:53:46 Mine is the spec for this release. Kristi's is for the follow on 18:55:32 we've just jumped 8 steps ahead of where we should be starting... we even agreed the other day that this middleware stuff only helps with what we defined as "future goals" and not our urgent priorities 18:55:58 edmondsw: what are the urgent priorities in your opinion? 18:56:09 as listed in your spec on policy goals 18:56:15 that's what I'm referring to 18:56:22 ah 18:58:33 so admin-ness 18:58:41 I'm not against the middleware... I just don't see why we're spending time on it right now 18:58:52 and that work was submitted and an approach was approved and the fixes are being reviewed and updated 18:59:38 beacuse it is broken and because I have people asking for things from Openstack that can only happen if we have that mechanism 18:59:50 such as? 18:59:52 i personally think that in order to provide the answer to "who can do what" question, we need more service involvement 18:59:55 the Read only role can be done with just that patch and policy as is today 19:00:20 fine grained roles 19:00:22 ayoung you have to know that's not true 19:00:43 edmondsw, I know that it is absolutely true based on the state of OpenStack today. 19:00:52 You need a catch all, and you need explicit rules. 19:01:04 we're out of time 19:01:10 we can carry on in #openstack-keystone 19:01:12 #endmeeting