16:59:19 <knikolla> #startmeeting keystone
16:59:20 <openstack> Meeting started Tue Jan 26 16:59:19 2021 UTC and is due to finish in 60 minutes.  The chair is knikolla. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:59:21 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:59:23 <openstack> The meeting name has been set to 'keystone'
16:59:32 <knikolla> o/
17:00:21 <cmurphy> o/
17:00:26 <lbragstad> o/
17:01:28 <knikolla> #topic Latest Oslo.db errors due to sqlalchemy-migrate deprecation
17:01:49 <bnemec> o/
17:02:05 <knikolla> Oslo.db 8.5.0 makes keystone unit tests fail because sqlalchemy-migrate has been deprecated and we treat deprecation warnings as errors in the unit tests
17:02:10 <knikolla> #link https://review.opendev.org/c/openstack/keystone/+/772566
17:02:28 <knikolla> stops treating deprecation warnings as errors
17:02:58 <knikolla> there was a prior patch, that only stops this particular deprecation warning at  https://review.opendev.org/c/openstack/keystone/+/760678 instead of all
17:03:57 <knikolla> do we still think that treating all deprecation warnings as errors is worth the gate breakage when it happens?
17:05:37 <cmurphy> well it is kind of highlighting that we need to get on the ball with migrating away from sqlalchemy-migrate
17:05:56 <lbragstad> ++
17:05:56 <cmurphy> back when vishakha was working on it it wasn't clear to me how urgent it was, now it is clearer
17:06:18 <cmurphy> if we were still ignoring the warnings then we'd be caught off guard once it actually goes away
17:07:21 <knikolla> i completely agree with the need to getting the ball rolling for alembic
17:07:41 <cmurphy> otoh i can't volunteer to take on that work and i'm not sure who can :/
17:08:59 <knikolla> ditto, it wasn't completely straightforward, and involves some research on how to do it
17:09:40 <knikolla> bnemec: do you have a feel for when/if the sqlalchemy-migrate bits will be completely removed from oslo.db?
17:11:06 <bnemec> Not really. It's been shuffling along in an undead zombie state for years now. It will probably go away when something breaks in a way that would take a lot of effort to fix.
17:11:44 * lbragstad sighs
17:12:04 <lbragstad> where's rick grimes when you need him
17:12:34 <bnemec> lol
17:13:08 <bnemec> I'm curious how many other projects have actually moved to alembic. Last I knew it wasn't something many people had tackled.
17:13:22 <knikolla> i saw glance had done it
17:13:34 <bnemec> That said, I'm a little out of the loop these days so it may have happened and I just didn't notice. :-)
17:13:58 <knikolla> i think they just started the db state as new, and kept the old migrations up to that point.
17:14:56 <bnemec> Might be good to talk to someone who has done it and see how much effort it was.
17:15:11 <knikolla> https://opendev.org/openstack/glance/commit/21d431013f6ad8a9f4a2afc34b66f67ff0d628eb
17:15:40 <bnemec> In fact, a mailing list thread discussing this could help bring it to the attention of projects that don't error on deprecation warnings.
17:16:49 <bnemec> Oh, they did that a long time ago.
17:18:44 <knikolla> though not quite fully apparently https://review.opendev.org/c/openstack/glance/+/760531
17:20:13 <knikolla> for now, are people okay with dropping deprecation warning errors to unblock the gate and then working to find someone to work on the migration?
17:20:34 <cmurphy> sure
17:23:52 <lbragstad> wfm
17:24:33 <knikolla> i'm updating https://review.opendev.org/c/openstack/keystone/+/760678 to pass pep8 and will push as soon as tests pass locally
17:28:21 <knikolla> lbragstad: cmurphy: i'll ping you on -keystone once it's pushed and passing CI
17:28:31 <lbragstad> sounds good
17:28:57 <knikolla> #topic Open Discussion
17:30:23 <cmurphy> the tempest dependencies are finally merged for https://review.opendev.org/c/openstack/keystone-tempest-plugin/+/686305 so that can go in now
17:31:36 <knikolla> awesome, will review
17:31:41 <cmurphy> ty
17:31:43 <knikolla> thanks cmurphy
17:38:26 <knikolla> alright, thanks all!
17:38:28 <knikolla> #endmeeting