19:00:04 <lbragstad> #startmeeting keystone-office-hours
19:00:04 <openstack> Meeting started Tue Aug 29 19:00:04 2017 UTC and is due to finish in 60 minutes.  The chair is lbragstad. Information about MeetBot at http://wiki.debian.org/MeetBot.
19:00:06 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
19:00:08 <openstack> The meeting name has been set to 'keystone_office_hours'
19:03:53 <cmurphy> lbragstad: what's the link to your dashboard for bug related reviews?
19:14:14 <gagehugo> I'm looking into what OSM did for https://review.openstack.org/#/c/498605/
19:15:49 <lbragstad> cmurphy: https://goo.gl/6137Q5
19:24:50 <hrybacki> lbragstad: okay it looks like the evening install guide bit didn't catch traction. But they are dedicating Thursday morning or afternoon to that topic alone
19:25:40 <lbragstad> hrybacki: is there a schedule somewhere for Thursday?
19:25:50 <hrybacki> lbragstad:  https://etherpad.openstack.org/p/docs-i18n-ptg-queens
19:26:03 <hrybacki> it's not quite as filled out as ours is atm
20:03:28 <openstackgerrit> Gage Hugo proposed openstack/keystone master: Copy specific distro pages for install guide  https://review.openstack.org/498605
20:05:09 <gagehugo> cmurphy https://github.com/openstack/openstack-manuals/commit/c7bfdbb44f15ec481f256ba57724ff47f16b3e43
20:05:27 <gagehugo> looks like OSM has some scripts for handling the duplicate pages
20:06:17 <cmurphy> gagehugo: ah so we are supposed to keep duplicates now?
20:08:11 <gagehugo> I kinda hacked the one users page into an inc and included it rather than copying the same file 3 times in ^
20:08:41 <gagehugo> I wonder if we want to copy that script over
20:08:41 <cmurphy> okay neat
20:19:11 <mjax> lbragstad: Do you know if domain specific token providers is a possibility?
20:31:45 <gagehugo> cmurphy yeah I think I like the "pick your distro" approach better
20:33:44 <lbragstad> mjax: not that i am aware of
20:39:22 <otleimat> cmurphy:  For this, https://review.openstack.org/#/c/408304/,  are those changes redundant? Also tried to extend test coverage
20:40:29 <lbragstad> mjax: there is only one token provider configured per keystone node
20:44:58 <cmurphy> otleimat: i'm not sure, i don't see a whole lot of difference in the output with or without the change, with different combinations of parameters, but i may be misunderstanding something
20:48:59 <otleimat> cmurphy: Yeah,  thats's a good point. Since it doesn't fail silently, then the changes in cli.py don't really do anything extra except change the --help msg and subjectively clean up the code?
20:49:25 <otleimat> cmurphy: The unit tests should probably be there in some form though
20:50:34 <cmurphy> ++ to tests
20:58:25 <otleimat> cmurphy: what do you prefer I do with it? Revert the changes in cli.py and then refactor the unit tests?
21:00:36 <otleimat> actually unit tests don't need to be changed. Should all pass with original code
21:06:54 <openstackgerrit> Samuel Pilla proposed openstack/python-keystoneclient master: Add project tags to keystoneclient  https://review.openstack.org/481223
21:17:14 <cmurphy> otleimat: yeah that seems to me like the right way to go, it's definitely good to keep the MappingPurge tests
21:34:04 <openstackgerrit> Gage Hugo proposed openstack/keystone master: Copy specific distro pages for install guide  https://review.openstack.org/498605
21:45:10 <lbragstad> gagehugo: ^ works for me locally
21:45:13 <lbragstad> gagehugo: thanks
21:47:12 <gagehugo> lbragstad I think it's kinda hacky, but it looks like the alternative is to copy over the tool scripts which also looks messy
21:48:24 <lbragstad> yeah
21:48:40 <lbragstad> let have cmurphy take another look
21:48:43 <lbragstad> let's*
21:57:54 <cmurphy> gagehugo: lbragstad yep looks good to me
21:59:08 <lbragstad> #endmeeting