08:10:17 <dalees> #startmeeting Magnum
08:10:17 <opendevmeet> Meeting started Tue Oct 14 08:10:17 2025 UTC and is due to finish in 60 minutes.  The chair is dalees. Information about MeetBot at http://wiki.debian.org/MeetBot.
08:10:17 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
08:10:17 <opendevmeet> The meeting name has been set to 'magnum'
08:10:27 <dalees> Hi, thanks for waiting, and joining.
08:10:30 <dalees> who is around today?
08:10:32 <dalees> o/
08:10:38 <hemanth> o/
08:10:49 <BigMax> o/ (although will need to drop out at half past)
08:11:15 <sd109> o/
08:12:59 <dalees> #topic Release Liason updates
08:13:02 <dalees> #link https://review.opendev.org/c/openstack/releases/+/963815
08:13:23 <dalees> first up, just a quick note to say I've added a patchset to update the release liasons.
08:13:32 <jakeyip> I've just +1 that :)
08:13:42 <dalees> if anyone has comments, there or here are fine.
08:14:15 <dalees> #topic vPTG
08:14:26 <dalees> and the other topic is vPTG - this is in two weeks.
08:14:52 <dalees> in April we had two timeslots, 6am UTC for 1hr.
08:15:23 <dalees> shall i book similar again, or a 2 hour timeslot?
08:16:25 <jakeyip> i think previously we booked 2 because michal was busy and we couldn't have a 2 hr stretch?
08:16:53 <sd109> The same time of day works for me again, happy to do a 2 hour slot
08:17:06 <jakeyip> same
08:17:31 <dalees> how about 6-8am UTC Tuesday, as the planner allows this (which leads into this meeting at 8 UTC)
08:18:13 <dalees> yeah the longer meeting time in a previous PTG was good to continue longer discussions with the same folk
08:19:22 <dalees> #link vPTG etherpad link is https://etherpad.opendev.org/p/oct2025-ptg-magnum
08:20:00 <dalees> add your topics, I'll bring a few over from April to review
08:20:30 <jakeyip> ok
08:20:59 <dalees> #topic Open Discussion
08:21:19 <dalees> anything to raise, from anyone?
08:22:33 <sd109> Nothing from me this week
08:24:57 <jakeyip> nothing from me, do you need anything pushed dalees ?
08:25:59 <dalees> I think we should revisit https://review.opendev.org/c/openstack/magnum/+/952069 and decide a path forwards
08:27:06 <jakeyip> ok, I will take a look
08:27:16 <mnasiadka> And we should also start thinking about https://review.opendev.org/c/openstack/magnum/+/958387
08:27:22 <dalees> there are several options, but having something to backport would be good to resolve the regressions.
08:28:21 <dalees> ah yeah, I've not tested that yet mnasiadka but it would make sense to merge sooner in the cycle and find any problems with it
08:28:33 <mnasiadka> yup
08:29:36 <jakeyip> yeah agree
08:32:33 <dalees> if it works, we should merge it sooner. reverting or adding fixes is always an option. I'll give it some time in the next couple of weeks to try out.
08:33:10 <jakeyip> testing this is challenging ... I'm wondering how other projects handle this
08:34:20 <dalees> yes, there are many things we could miss in dev with the change
08:38:45 <jakeyip> I like https://review.opendev.org/c/openstack/magnum/+/961770
08:40:55 <dalees> it makes for an easy backport, too.
08:42:29 <jakeyip> wondering about the way forward though
08:43:52 <dalees> I think there's a bigger discussion as to whether the api or client *should* be responsible for converting the template name to id.
08:43:56 <jakeyip> sorry, before that, do we need 2 tests in 961770 ? template id and template name?
08:46:50 <dalees> hmm, maybe so. I thought I saw another test that covered that, but they're for non existent cluster templates. I need to check that
08:48:03 <jakeyip> ideally there should be an additional test that should fail without your patch? not sure why that doesn't
08:51:31 <dalees> some of that discussion is in https://review.opendev.org/c/openstack/magnum/+/952069
08:54:36 <jakeyip> oh man I went deep into the test code :P
08:54:49 <jakeyip> anyway, we are almost at time
08:56:08 <dalees> that test is just renamed to make it clearer, and fixed so it tests the thing it used to. Alex linked to the commit that broke them both in 952069.
08:56:20 <jakeyip> oh
08:56:28 <dalees> the test case in 961770 is the same as Alex's change in 952069
08:56:47 <jakeyip> ah I understand now
08:57:22 <dalees> yeah sorry, it wasn't fresh for me either
08:59:22 <jakeyip> prob will be good to have a NOTE(dalees): This is not ideal and support for this will be removed in future clients or something like that
08:59:45 <jakeyip> also, need test_create_cluster_with_cluster_template_id? which is the right test going forward?
09:00:51 <jakeyip> then we can start thinking about new api version going forward
09:01:22 <dalees> yeah it's probably worth an explicit test for template_id if it isn't covered.
09:01:50 <dalees> would you add those as comments and i'll address them
09:02:19 <dalees> I need to depart for now, it's late
09:02:26 <jakeyip> can I click 'start review'? else I cannot reply
09:02:35 <jakeyip> yeah end meeting
09:02:45 <dalees> #endmeeting