15:00:11 <bswartz> #startmeeting manila
15:00:12 <openstack> Meeting started Thu Nov 30 15:00:11 2017 UTC and is due to finish in 60 minutes.  The chair is bswartz. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:14 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:16 <openstack> The meeting name has been set to 'manila'
15:00:21 <bswartz> hello all
15:00:23 <dustins> \o
15:00:29 <amito-infinidat> o/
15:00:29 <tbarron> Hi!
15:01:11 <ganso> hello
15:01:20 <bswartz> courtesy ping: gouthamr zhongjun toabctl xyang markstur vponomaryov cknight
15:01:33 <zhongjun> hi
15:02:12 <bswartz> wow it's a small group today
15:02:43 <tbarron> yeah
15:02:44 <amito-infinidat> and I'll be leaving the chat soon for my bus, unfortunately
15:02:53 <zhongjun> Is it special today?
15:02:53 <bswartz> okay let's get started
15:03:09 <bswartz> no, I would have expected people to be back from holidays
15:03:33 <bswartz> #topic announcements
15:03:37 <jungleboyj> o/
15:04:06 <bswartz> first of all, we already mentioned it on the ML, but welcome zhongjun to the manila core reviewer team!
15:04:16 <ganso> welcome zhongjun! =D
15:04:18 <tbarron> +1000
15:04:21 <zhongjun> Thank you everyone!
15:04:24 <amito-infinidat> welcome :)
15:04:34 <bswartz> zhongjun: is your +2 button working?
15:04:44 <tbarron> zhongjun: just keep catching issues in reviews that I miss!
15:04:51 <zhongjun> bswartz: yes
15:05:03 <bswartz> if you have any questions about our team policies, please come ask me
15:05:05 <jungleboyj> zhongjun:  Congratulations!
15:05:16 <bswartz> I assume you're familiar with all the normal rules about merging changes
15:05:40 <bswartz> second thing -- we are just one week away from milestone 2
15:05:46 <zhongjun> tbarron jungleboyj: :)  thanks
15:06:05 <bswartz> there is a driver proposal freeze next Monday
15:06:06 <zhongjun> bswartz: sure , I will
15:06:12 <bswartz> #link https://releases.openstack.org/queens/schedule.html#q-manila-driver-deadline
15:06:36 <bswartz> I know amito-infinidat is working against that deadline
15:07:12 <amito-infinidat> bswartz: yes. Our CI is running, but we experienced a lab crash last night so some of our hosts have issues not related to the zuul/tempest environment.
15:07:13 <vkmc> o/
15:07:53 <amito-infinidat> bswartz: so we're working to get to a working 3rd party CI.
15:08:10 <bswartz> I'll just remind everyone that feature proposal freeze is just 5 weeks later, and due to the winter holidays, we have very little time to do coding/reviews between milestone 2 and feature proposal freeze
15:08:45 <bswartz> amito-infinidat: sorry to hear that -- I hope you can recover quickly
15:09:04 <amito-infinidat> bswartz: thanks
15:09:10 <bswartz> on to our agenda
15:09:19 <bswartz> #topic Report from Wuhan Bug Smash
15:09:31 <bswartz> zhongjun: I assume you added this?
15:09:39 <bswartz> #link https://etherpad.openstack.org/p/OpenStack-Bug-Smash-Queens-Wuhan-Bugs-List
15:09:55 <zhongjun> bswartz: Actually, it isn't
15:10:42 <zhongjun> bswartz: But I still want to say the good thing is we fixed 17 bugs in whhan bug smash, and all people come from 5 different companies (firberhome, chinamobile, H3c, 99cloud, huawei ). Thanks all of them
15:10:52 <bswartz> the name on the wiki update is tpb -- is that tbarron?
15:11:32 <zhongjun> bswartz: Some of the bugs from dustins’s bug list, thanks dustins
15:11:58 <bswartz> how many of those bugs were related to manila?
15:11:59 <tbarron> bswartz: sorry, in another convo, that was me
15:12:11 <tbarron> look at how many were manila: 17 reviews!
15:12:21 <dustins> zhongjun: Of course! Hopefully that helped out :)
15:12:23 <zhongjun> bswartz:  17 bugs related to manila
15:12:26 <bswartz> oh wow
15:12:26 <tbarron> manila had more reviews than nova or neutron
15:12:29 <bswartz> that's awesome
15:12:37 <dustins> That's amazing!
15:12:39 <tbarron> with five companies participating I think
15:12:45 <bswartz> I dedicated wednesday to reviewing
15:12:52 <bswartz> but I didn't manage to cover that many bugs
15:13:06 <tbarron> Anyways, I've reviewed a bunch, but we need more eyes.
15:13:18 <bswartz> so what's left to do? are all of these fixes merged or are some waiting for review?
15:13:32 <zhongjun> We could continue to review those bugs
15:13:50 <bswartz> yeah I'm clicking some links from the etherpad and seeing these still need reviews
15:14:00 <zhongjun> some waiting for review
15:14:29 <bswartz> so let's try to get some eyes on these bugs -- I'd like to merge them before the milestone, so milestone 2 can deliver a bunch of fixes
15:15:37 <bswartz> I'd like to reorder the next 2 topics
15:15:48 <bswartz> I think it makes sense to cover bugs last, because it can take a lot of time
15:16:01 <bswartz> #topic Use v3 cinder client instead of v2 cinder client
15:16:10 <bswartz> #link https://review.openstack.org/#/c/522478/
15:16:12 <zhongjun> bswartz: thanks
15:16:25 <bswartz> this one is definitely yours zhongjun
15:16:33 <zhongjun> Cinder has been deprecated v2 api in Pike, So Could we use v3 cinder client instead of v2 cinderclient.
15:16:45 <zhongjun> #link https://review.openstack.org/#/c/522478
15:17:05 <zhongjun> #link  https://review.openstack.org/#/c/438195/
15:17:09 <bswartz> why does this look like mostly a deletion of code? did we already support cinderv3?
15:17:33 <zhongjun> It looks like it is work now
15:17:34 <jungleboyj> v3 is a supserset of v2.  Should be pretty painless.
15:18:00 <bswartz> interesting
15:18:08 <bswartz> where do we use cinder outside of the generic driver?
15:18:12 <zhongjun> We just use some of main cinder API
15:18:18 <tbarron> this is similar to my WIP patch: https://review.openstack.org/#/c/516127/
15:18:39 <tbarron> which attempted similar changes for nova & neutron
15:19:01 <tbarron> but maybe I was confused, I thought those options were for those clients to interact with keystone v2
15:19:22 <tbarron> bswartz: I think only generic uses the cinder client
15:19:51 <bswartz> okay so we should look closely at any test failures in the generic driver jobs
15:20:51 <bswartz> tbarron: I see glusterfs and hdfs jobs are hanging around still -- aren't we trying to remove those?
15:21:13 <tbarron> bswartz: yeah, they were removed from the check queue but didn't go away
15:21:34 <tbarron> bswartz: I've been working with infra, there's some weird zuulv3 inheritance at work
15:21:34 <bswartz> what else do we need to do to make them stop consuming resources?
15:21:38 <bswartz> I see
15:22:12 <tbarron> hopefully we'll get it sorted soon
15:22:18 <bswartz> zhongjun: anything we need to discusss related to this patch? or you just wanted to call attention to it for reviews?
15:22:26 <zhongjun> okay,  if the generic driver work fine, we could use cinder v3 instead of v2?
15:22:48 <bswartz> yeah we should not use a deprecated API
15:22:57 <bswartz> so I agree with the intent
15:23:12 <zhongjun> yeah, then just need more eyes on it :)
15:23:14 <bswartz> and because it only affects the generic driver, that's where we should look for regressions
15:23:20 <bswartz> okay thanks
15:23:27 <tbarron> I think the patch is mixing two things but that's probably ok if we just update the commit msg
15:23:33 <tbarron> 1) cinder v2->v3
15:23:44 <tbarron> 2) old deprecated keystone options
15:23:53 <tbarron> used by cinder client
15:24:05 <bswartz> tbarron: I trust you'll provide a -1 then
15:24:13 <tbarron> on it
15:24:14 <bswartz> or just update the commit message
15:24:18 <bswartz> #topic Let's go over new bugs
15:24:26 <zhongjun> tbarron : good
15:24:28 <tbarron> right, we probably should do more of the latter
15:24:33 <bswartz> dustins: you're up
15:24:43 <bswartz> #link https://etherpad.openstack.org/p/manila-bug-triage-pad
15:24:52 <dustins> I'm still digging out from the holiday, so I haven't had a look yet
15:25:01 <dustins> There will be plenty for next week though :D
15:25:13 * dustins just got back yesterday
15:25:23 <bswartz> dustins: we didn't meet last week, and IIRC you were absent 2 weeks ago so we covered this for you
15:25:43 <dustins> bswartz: Yeah, I was in training two weeks ago
15:25:46 * bswartz goes to check
15:26:18 <bswartz> actually I don't see any coverage from 2 week ago
15:26:34 <bswartz> so we haven't really examined this etherpad in 3 weeks
15:26:56 <bswartz> is there some overlap between these bugs and the bug smash bugs?
15:27:27 <dustins> The ones from the bug scrub I picked because they were triaged or were fairly trivial/wish listy thing
15:27:49 <bswartz> at least one bug linked here is "fix released"
15:28:05 <bswartz> so yeah we need to update the etherpad
15:28:28 <tbarron> when we do, probably think about which need backports
15:28:53 <tbarron> e.g. 1730529 s/b backported to pike as it was found in pike
15:28:55 <bswartz> who drives the decision to backport the fixes?
15:28:57 * tbarron cherry-picks
15:29:02 <bswartz> is that dustins?
15:29:07 <bswartz> or you tbarron?
15:29:18 <tbarron> junboli
15:29:38 <bswartz> typically we (netapp) only try to backport fixes that our customers complain about
15:29:43 <tbarron> but we can add pike-backport-potential and cherry-pick
15:29:53 <tbarron> this bug says pike in its title
15:30:08 <tbarron> and we (redhat) do pro-active backports to minimize customer pain
15:30:19 <tbarron> and our expense :-)
15:30:21 <bswartz> tagging the bug with backport-potential in LP is the traditional way to do it
15:30:36 <bswartz> but we haven't been scanning the list for bugs with those tags very consistently
15:30:42 <tbarron> b/c it's more work to do it re-actively than pro-actively if you know it needs fixing
15:31:00 <tbarron> ack on not scanning the list well, I can help
15:31:03 <bswartz> okay well you're welcome to initial backports for the ones you think will matter
15:31:17 <bswartz> s/initial/initiate/
15:31:53 <bswartz> #topic open discussion
15:31:58 <bswartz> okay we have extra time today
15:32:03 <bswartz> anything else we should cover?
15:32:41 <bswartz> alright, thanks everyone
15:32:47 <amito-infinidat> Assuming the CI will finally pass, do you think our driver can be approved till Monday? (the last day according to the sches)
15:32:58 <amito-infinidat> s/sches/schedule
15:33:06 <bswartz> amito-infinidat: the work just needs to be done by then
15:33:07 <ganso> amito-infinidat: monday is the last day for the driver to be proposed
15:33:16 <ganso> amito-infinidat: with working CI and unit tests
15:33:19 <bswartz> we can review it and merge it in the following weeks
15:33:38 <bswartz> we just won't accept half-done drivers or drivers without a working CI system
15:33:46 <bswartz> so don't worry about the review/merge part
15:33:47 <amito-infinidat> ok
15:34:16 <bswartz> #endmeeting