15:00:08 <bswartz> #startmeeting manila
15:00:09 <openstack> Meeting started Thu May 10 15:00:08 2018 UTC and is due to finish in 60 minutes.  The chair is bswartz. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:10 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:13 <openstack> The meeting name has been set to 'manila'
15:00:20 <bswartz> Hello all
15:00:21 <xyang> hi
15:00:30 <dustins> \o
15:00:33 <vgreen> hi
15:00:42 <bswartz> I'm standing in for the Notorious TPB, who is on PTO today
15:00:46 <zhongjun_> Hi
15:00:58 <vgreen> all bow to bswartz
15:01:19 <bswartz> courtesy ping: tbarron gouthamr ganso toabctl markstur vponomaryov cknigh
15:01:35 <gouthamr> o/
15:01:42 <amito> o/
15:02:02 <bswartz> I don't have any announcements today
15:02:10 <bswartz> #agenda https://wiki.openstack.org/wiki/Manila/Meetings
15:02:35 <bswartz> #topic New Drivers
15:02:40 <bswartz> #link https://etherpad.openstack.org/p/manila-rocky-drivers
15:03:04 <bswartz> So we have 2 new drivers under consideration
15:03:16 <bswartz> Inspur has CI already \o/
15:03:26 <bswartz> Anyone from Pure Storage here?
15:03:59 <bswartz> I think tbarron wanted to check on the status of the CI for Pure Storage Manila
15:04:15 <vkmc> o/
15:04:43 <bswartz> It needs to be working by the driver submission deadline on June 4th
15:05:13 <bswartz> Setting up CI systems is hard (and I assume the Pure guys know that) but we have people with experience who can help
15:05:36 <bswartz> Anything else to be mentioned with regard to new drivers?
15:06:14 <bswartz> okay
15:06:27 <bswartz> #topic Python3 Status
15:06:33 <bswartz> #link https://review.openstack.org/#/c/552121/
15:07:06 <bswartz> Thank you vkmc for getting manila-ui in shape for Py3!
15:07:15 <gouthamr> ++
15:07:21 <vkmc> :D
15:07:37 <bswartz> IIRC, this was the only remaining project with py3 issues
15:07:41 <bswartz> Is that right?
15:07:51 <bswartz> So everything is py3 compliant now?
15:08:32 * bswartz hears crickets
15:08:37 <erlon> hey
15:08:54 <bswartz> Let me take a look to check py3 status
15:09:33 * ganso sneaks in
15:09:39 <gouthamr> i suppose this is where we're tracking? https://governance.openstack.org/tc/goals/pike/python35.html#projects-with-remaining-work-on-unit-tests
15:10:03 <bswartz> I think we're good on unit tests
15:10:22 <bswartz> The next step would be to convert the tempest runs to py3 rather than py2
15:10:26 <bswartz> If that's not done already
15:10:39 <vkmc> yeah, we need to convert tempest tests
15:10:51 <vkmc> and also... there was another related bug
15:10:52 <vkmc> let me find it
15:11:07 <bswartz> Is there any reason to beleive that won't "just work"?
15:11:49 <vkmc> #link https://bugs.launchpad.net/manila/+bug/1482633
15:11:50 <openstack> Launchpad bug 1482633 in oslo.service "requests to SSL wrapped sockets hang while reading using py3" [High,Triaged]
15:12:14 <bswartz> This is ancient
15:12:23 <vkmc> yeah
15:12:25 <bswartz> If we're running py3 now then this must be fixed, right?
15:12:47 <vkmc> indeed... that is next on my agenda
15:12:49 <vkmc> also tempest tests
15:12:51 <bswartz> Or are we skipping these tests?
15:13:05 <vkmc> we are skipping those
15:13:12 <bswartz> Doh
15:13:21 <bswartz> I see the comment from zaneb
15:13:35 <bswartz> Eventlet issues related to py3 and SSL
15:13:55 <vkmc> yeah... not sure how to proceed in this case... like, it's blocked by upper constrains
15:13:57 * bswartz silently curses eventlet
15:14:26 <bswartz> Yeah I'm not sure what we can do here
15:14:57 <bswartz> If we run with Apache WSGI instead of the builtin server can we avoid these issues?
15:15:31 <bswartz> It seems like the kind of issue which would prevent actual deployments on Py3, if eventlet is bugged and we depend on it
15:16:00 <vkmc> how much work would be for us to use apache wsgi instead of the builtin server?
15:16:12 <bswartz> Well it works today
15:16:15 <bswartz> But we support both
15:16:39 <bswartz> I'm wondering if using WSGI is an acceptable workaround until the underlying eventlet issues are sorted
15:16:54 <bswartz> Or if we have to tell users not to use py3 atall
15:17:22 <vkmc> this seems something we can bring to the mailing list... since it's not only affecting manila
15:17:43 <bswartz> Yeah eventlet bugs are of interest to the whole community
15:18:00 <bswartz> But for manila in particular, it would be nice to be able to say there is a short term workaround
15:18:34 <bswartz> Otherwise we have to continue to recommend py2.7
15:19:11 <vkmc> yeah, it's good to have a workaround for the moment
15:19:22 <vkmc> but we need to fix it in the short-medium term
15:19:31 <bswartz> Oh well, thanks for bringing up this bug vkmc
15:19:36 <vkmc> not sure how much time distros will keep shipping with py2.7
15:20:07 <bswartz> I think the best approach is to pressure the eventlet guys to get things working with py3.6 so the upper constraint can be removed and we can get on py3 support
15:20:09 <vkmc> like... last Ubuntu LTS version doesn't bring python2.7 installed by default, it ships with py3 directly
15:20:15 <vkmc> yeah
15:20:28 <bswartz> py2.7 is really really old -- it should not be used
15:20:54 <vkmc> agree
15:21:00 <bswartz> So everything related to getting off of py2.7 should be high priority
15:21:15 <vkmc> ah well, let's bring this on the mailing list
15:21:18 <vkmc> I can do that :)
15:21:24 <bswartz> But this issue is bigger than just manila, so we should get the right eyes on it
15:21:26 <bswartz> Thanks!
15:21:39 <bswartz> Moving on..
15:21:45 <bswartz> #topic Bugs
15:21:51 <bswartz> #link https://etherpad.openstack.org/p/manila-bug-triage-pad
15:21:54 <vkmc> I'll make sure to ping people working on py3 migration in the whole community so we get attention from them
15:22:07 <bswartz> dustins: you around?
15:22:26 <dustins> yeah, sorry, being pulled in about a billion different directions
15:22:46 <dustins> First let's go over things we wanted to check in on
15:22:57 <bswartz> dustins: if your body is not made of rubber, that will not end well...
15:23:03 <dustins> #link https://bugs.launchpad.net/manila/+bug/1762900
15:23:04 <openstack> Launchpad bug 1762900 in Manila "tearDownClass manila_tempest_tests.tests.api.test_share_networks_negative.ShareNetworksNegativeTest Failed" [High,Triaged] - Assigned to Tom Barron (tpb)
15:23:04 <gouthamr> :P
15:23:11 <dustins> bswartz: Preaching to the choir :)
15:23:36 <dustins> Well, tbarron's on PTO so we can probably skip this one for this week
15:24:01 <bswartz> k
15:24:05 <dustins> #link https://bugs.launchpad.net/manila/+bug/1753630
15:24:07 <openstack> Launchpad bug 1753630 in Manila "The net, router, and subnet created in the Manila tempest test process are not cleared" [Medium,Fix committed]
15:24:12 <dustins> This one has a fix committed!
15:24:33 <bswartz> Link?
15:24:34 <dustins> So we can probably remove this one from our checking in on
15:24:48 <bswartz> Gerrit didn't update the bug with the patch
15:25:13 <dustins> Looks like it was fixed in master by another change?
15:25:21 <bswartz> #link https://bugs.launchpad.net/manila/+bug/1754588
15:25:22 <openstack> Launchpad bug 1754588 in Manila "After run manila tempest have share network residue" [Undecided,Fix released] - Assigned to haobing1 (haobing1)
15:25:26 <bswartz> #link https://bugs.launchpad.net/manila/+bug/1755467
15:25:27 <openstack> Launchpad bug 1755467 in Manila "After run manila tempest network resource do not be cleared" [Undecided,Fix released] - Assigned to haobing1 (haobing1)
15:25:32 <bswartz> Maybe we can dup this one?
15:25:45 <dustins> I'm fine with that
15:26:20 <bswartz> Done
15:26:27 <gouthamr> #link: https://review.openstack.org/#/c/551206/
15:26:40 <dustins> w00t
15:26:53 <gouthamr> #link: https://review.openstack.org/#/c/552506/
15:26:59 <dustins> #link https://bugs.launchpad.net/manila/+bug/1760644
15:27:00 <openstack> Launchpad bug 1760644 in Manila "API refference contains mistakes" [High,Triaged]
15:27:35 <bswartz> tbarron suggested the submitter fix his own bug
15:27:37 <dustins> Looks like the reporter has not responded to tbarron yet on whether or not they'd be willing to submit some patches
15:27:38 <bswartz> No repsonse that I can see
15:27:39 <gouthamr> we need an owner on 1760644 dustins
15:28:05 <dustins> gouthamr: Right, we were hoping that the reporter would do that
15:28:23 * bswartz looks for volunteers
15:28:48 <bswartz> Anyone?
15:28:58 <bswartz> Doc bugs are easy good karma
15:29:15 <vkmc> o/
15:29:20 <vkmc> I'll take a look
15:29:21 <dustins> I can't commit to it, otherwise I'd audit it
15:29:51 <bswartz> Thanks vkmc
15:30:10 <bswartz> The docs probably need a comprehensive review
15:30:12 <dustins> vkmc++
15:30:20 <dustins> bswartz: I'd say they definitely do
15:30:20 <bswartz> But fixing the specific issue raised here shouldn't take much time
15:30:24 <vkmc> just assigned myself
15:30:29 <vkmc> docs need love yes
15:30:34 <bswartz> Awesome
15:30:45 <bswartz> Anything else on bugs dustins?
15:31:11 <dustins> Yup, I got a new crop
15:31:14 <dustins> one sec
15:31:16 <bswartz> I see 4 more links under 10 May on the etherpad
15:31:32 <dustins> #link https://bugs.launchpad.net/manila/+bug/1770183
15:31:34 <openstack> Launchpad bug 1770183 in Manila "manila-tempest-dsvm-scenario job does not fail if individual tests fail" [Undecided,New]
15:31:54 <bswartz> gouthamr: are you serious?
15:32:00 <gouthamr> yep, i think
15:32:03 <bswartz> This defies logic
15:32:42 <dustins> Woo false positives
15:32:45 <gouthamr> i reported it yesterday, haven't looked into what breaks
15:33:00 <bswartz> Where do you see evidence of failure?
15:33:13 <bswartz> dustins: I think this is actually a false negative
15:33:45 <bswartz> Like when someone smuggles a gun through airport security without getting caught
15:33:46 <dustins> It passed when it should have failed, isn't that a false positive?
15:33:57 <dustins> Eh, doesn't matter
15:34:08 <gouthamr> the evidence is attached
15:34:18 <gouthamr> although the log links are still alive
15:35:16 <gouthamr> wait, i may have messed up the links
15:35:28 <bswartz> 2018-05-08 18:55:21.710924 | primary | 2018-05-08 18:55:21.709 | ======
15:35:28 <bswartz> 2018-05-08 18:55:21.711769 | primary | 2018-05-08 18:55:21.711 | Totals
15:35:28 <bswartz> 2018-05-08 18:55:21.713793 | primary | 2018-05-08 18:55:21.713 | ======
15:35:28 <bswartz> 2018-05-08 18:55:21.715637 | primary | 2018-05-08 18:55:21.715 | Ran: 21 tests in 2024.0000 sec.
15:35:28 <bswartz> 2018-05-08 18:55:21.717477 | primary | 2018-05-08 18:55:21.717 |  - Passed: 5
15:35:29 <bswartz> 2018-05-08 18:55:21.719329 | primary | 2018-05-08 18:55:21.718 |  - Skipped: 16
15:35:29 <bswartz> 2018-05-08 18:55:21.721108 | primary | 2018-05-08 18:55:21.720 |  - Expected Fail: 0
15:35:30 <bswartz> 2018-05-08 18:55:21.723059 | primary | 2018-05-08 18:55:21.722 |  - Unexpected Success: 0
15:35:30 <bswartz> 2018-05-08 18:55:21.724909 | primary | 2018-05-08 18:55:21.724 |  - Failed: 0
15:35:31 <bswartz> 2018-05-08 18:55:21.726904 | primary | 2018-05-08 18:55:21.726 | Sum of execute time for each test: 1990.2418 sec.
15:35:35 <bswartz> Sorry for spam
15:35:39 <gouthamr> yep, wrong job
15:35:42 <gouthamr> :(
15:36:14 <bswartz> Okay well if we have false negatives that's a big deal
15:36:18 <bswartz> But also presumably not hard to fix
15:36:23 <bswartz> Just a test infrastructure issue
15:36:37 <gouthamr> yep.. dustins: i'll take this one
15:36:39 <bswartz> If gouthamr is actively investigating it, I think we can move on
15:37:24 <dustins> gouthamr: You mind assigning it? I can't find you with a current email address
15:37:43 <dustins> #link https://bugs.launchpad.net/manila/+bug/1768453
15:37:44 <openstack> Launchpad bug 1768453 in Manila "filter search type list by extra specs does not take effect" [Undecided,New]
15:37:50 <gouthamr> dustins: yep i will, my LP is the same as nick: gouthamr
15:38:33 <zhongjun_> This bug has been fixed
15:38:33 <dustins> gouthamr: Thought so, just pointed to an old address
15:38:46 <bswartz> zhongjun_: fix merged or fix in gerrit?
15:39:11 <zhongjun_> But it looks like doesn’t relate to the bug link
15:39:22 <gouthamr> this one is a duplicate of https://bugs.launchpad.net/manila/+bug/1768454
15:39:24 <openstack> Launchpad bug 1768454 in Manila "filter search type list by extra specs does not take effect" [Undecided,Fix released] - Assigned to junboli (junboli)
15:39:24 <zhongjun_> Merged
15:39:39 <gouthamr> #link: https://review.openstack.org/#/c/565699/
15:39:51 <bswartz> I marked it dup
15:39:54 <bswartz> Let's move on
15:39:57 <dustins> Well, if it's a duplicate and it's already fixed, do we want to -
15:40:01 <dustins> nevermind :D
15:40:05 <zhongjun_> Yeah
15:40:27 <dustins> #link https://bugs.launchpad.net/manila/+bug/1767430
15:40:29 <openstack> Launchpad bug 1767430 in Manila "host prefixes for access allow should conflict with /32 and /128 prefixes" [Undecided,New]
15:40:44 <bswartz> This bug is pretty straighforward
15:41:15 <bswartz> manila-api should realize that /32 for ipv4 and /128 for ipv6 are the same as an address literal with no netmask
15:41:53 <bswartz> I'm going to set the importance to High
15:42:05 <dustins> Makes sense to me
15:42:23 <bswartz> Just need an assignee here
15:42:48 <bswartz> I would suggest that we add some API tests here to avoid regressions
15:43:08 <dustins> Tempest and Unit tests should be required, yeah
15:44:03 <bswartz> No volunteer?
15:44:24 <gouthamr> i'll take this one..
15:44:27 <bswartz> It's possible tbarron was going to work on it -- we can check when he comes back
15:44:40 <bswartz> gouthamr: awesome
15:45:02 <bswartz> Last bug dustins?
15:45:22 <dustins> #link https://bugs.launchpad.net/manila/+bug/1755795
15:45:23 <openstack> Launchpad bug 1755795 in Manila "manila_tempest_tests.tests.scenario.test_share_basic_ops create share failed because share type not found" [Undecided,New]
15:45:35 <dustins> This seems familiar somehow
15:45:55 <dustins> Oh, because I wrote something in it
15:46:08 <bswartz> Yeah we discussed this before too
15:46:28 <bswartz> Tempest tests should not rely on the default share type -- they should create their own share types
15:46:31 <dustins> Yeah, gonna put this one in the "Follow Up" section
15:46:39 <dustins> 100% agreed
15:46:49 <bswartz> Except for tests specifically aimed at verifying that default share types work
15:46:51 <dustins> (unless they're testing the default share type)
15:46:59 <bswartz> Alright
15:47:09 <bswartz> #topic Open Discussion
15:47:16 <bswartz> Any other things for today?
15:47:19 <bswartz> We have a few minutes
15:48:33 <bswartz> Okay I guess you all get 12 minutes back
15:48:38 <bswartz> Thanks everyone
15:48:44 <bswartz> I may miss next week due to travel
15:48:45 <dustins> Thanks, bswartz
15:48:48 <bswartz> But I'll be around
15:48:55 <bswartz> And tbarron will be back
15:49:03 <dustins> bswartz: Heading to Vancouver?
15:49:04 <bswartz> #endmeeting