18:33:08 #startmeeting manila 18:33:08 Meeting started Tue Mar 19 18:33:08 2019 UTC and is due to finish in 60 minutes. The chair is tbarron. Information about MeetBot at http://wiki.debian.org/MeetBot. 18:33:09 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 18:33:11 The meeting name has been set to 'manila' 18:33:16 it works! 18:33:25 #topic rc1 bugs 18:34:21 o/ 18:34:25 As announced on openstack-discuss list we're doing a last minute triage of bugs targeted for rc1 18:34:40 The release team already proposed a release for us 18:35:35 #link https://bugs.launchpad.net/manila/ 18:35:57 It has a -1 because I figure we'll have a fix or two between now and Thursday 18:36:18 so we'll ask that the hash be updated or propose a separate review 18:36:26 Anyways 18:36:38 right now we have these bugs targeted for rc1 18:37:10 #link https://etherpad.openstack.org/p/manila-stein-rc-bugs 18:37:34 Let's consider each of them 18:37:51 1) is there a fix ready? 18:38:03 2) if not, would it block our release? 18:38:46 Also, if anyone has any others that they think should be considered, add them to the end of that etherpad 18:39:04 jgrosso: you here? 18:39:13 yeah 18:39:19 vkmc is in a conflicting meeting 18:39:25 I need to make a quick call 18:39:29 jgrosso: just getting your presence on record 18:39:29 O/ 18:39:31 here! 18:39:33 jgrosso: no prob 18:39:44 vkmc: great 18:40:12 I have to run get my step son be back in 20 minutes 18:40:49 courtesy ping for others that might want to join: bswartz amito carthaca ganso toabctl 18:41:03 courtesty ping xyang 18:41:22 *courtesy' 18:41:45 hey... 18:41:58 All: this is a semi-ad hoc meeting w.r.t. rc1 candidate bugs https://etherpad.openstack.org/p/manila-stein-rc-bugs 18:42:10 amito :) 18:42:21 not required of anyone :) 18:42:33 but public and open to all to participate 18:42:54 #link 18:42:54 https://bugs.launchpad.net/manila/+bug/1811680 18:42:55 Launchpad bug 1811680 in Manila "Manila allows share type deletion despite quota allocations" [Medium,Fix released] - Assigned to Goutham Pacha Ravi (gouthamr) 18:43:03 easy, done. 18:43:30 gouthamr: yeah, great 18:43:30 would like to backport this to stable/pike though, so working on it.. it makes sense for RC1 18:43:40 s/makes/made :) 18:44:40 * bswartz is in meeting 18:45:12 #link https://bugs.launchpad.net/manila/+bug/1820118 18:45:14 Launchpad bug 1820118 in Manila "Manila unexpectedly attempts to delete a share server when deleting a share network" [Medium,In progress] - Assigned to Carlos Eduardo (silvacarlose) 18:45:17 bswartz: ack 18:45:29 carlos_silva put up a fix this AM: https://review.openstack.org/644560 18:45:45 however, it's going to fail tempest tests 18:46:35 zuul's voted on it.. carlos_silva: do the failures make sense 18:47:16 carlos_silva: will you need to cleanup managed share servers on these tests? 18:48:21 gouthamr: do you know if it needs dummy driver changes or manila-tempest-plugin changes? 18:48:48 tbarron: looking at the fix it felt like it needed the tests to invoke share server cleanup at the end of the test 18:49:26 so that might not be a big deal 18:50:23 This is a Medium Importance bug though 18:50:30 Not a blocker. 18:50:58 so carlos_silva I'll leave it targeted for rc-1 but review priority will be best effort. 18:51:26 If you can get it passing tempest soon then there's a pretty good chance we can land it but 18:51:27 tbarron: ack... it does modify the behavior of the share network API, although only if a "managed share server" exists or a share has been unmanaged from it.. would be nice to get it in 18:51:54 if it's last minute then we'll bump it to train1 and aim for a post-release backport 18:52:06 s/share has been unmanaged from it/share has been unmanaged from an existing share server 18:52:16 gouthamr: i agree that it would be nice and we should try to help land it 18:52:48 but I'm not going to cut another rc for it 18:53:57 ok... I'm also looking at the tests that the fix crashed 18:54:10 carlos_silva: great, and thanks! 18:54:41 #link 18:54:42 https://bugs.launchpad.net/manila/+bug/1777551 18:54:43 Launchpad bug 1777551 in Manila "all_tenants value is not handled correctly" [Medium,In progress] - Assigned to zhangqing (zhang-qing) 18:54:58 There are two reviews up for this 18:55:12 #link https://review.openstack.org/#/c/620197/ 18:55:12 tbarron, gouthamr: would it be solved by modifying every test that unmanages a share, to delete the share server at the end of the test? 18:56:04 #link https://review.openstack.org/#/c/618991/ 18:56:24 We'll come back to this one in a moment 18:56:28 (I mean, every test that unmanages a share OR manages a share server) 18:56:52 lseki: depends, if the share network and share server was created by the test, sure.. else, i think you should handle it in the base class, because there are some test classes where we've implemented persisting the share network 18:57:27 lseki: yes, the latter case is straightforward - you're managing a share server that was created within a share network that is exclusive to the test 18:59:06 gouthamr: ok, I'll also check the base class 18:59:21 tbarron: you're welcome :) 18:59:35 :) 19:00:31 Any more on this one now? 19:00:36 lseki: hmm, just a sec, this can be better... in https://github.com/openstack/manila-tempest-plugin/blob/370569423eea5fad86efd646e7c5ea83e1337420/manila_tempest_tests/tests/api/base.py#L954 19:01:05 lseki: you could enumerate the share network's share servers and delete all share servers that have "is_auto_deletable=True" 19:02:29 reach out if you've any issues, i've been in that code path one too many times.. :) 19:02:35 and you have to enable cleanup_in_class 19:03:51 gouthamr: I'll give it a try, thanks! 19:03:54 vkmc: yeah :( therein lies the mess, just as with share types... 19:04:00 yes 19:04:12 I remember that :') 19:04:21 vkmc: oh, good point. Thanks :-) 19:04:56 any more on this one? 19:05:00 vkmc lseki: although the cleanup method i linked should be generic to instance and class cleanups 19:05:02 tbarron: nope 19:05:16 #link https://bugs.launchpad.net/manila/+bug/1777551 19:05:17 Launchpad bug 1777551 in Manila "all_tenants value is not handled correctly" [Medium,In progress] - Assigned to zhangqing (zhang-qing) 19:05:22 two reviews up for it 19:05:32 stuck for lack of a release note 19:05:53 tbarron: oh.. let's fix them up - i'll take a look 19:05:54 This is Medium Importance 19:06:24 gouthamr: I'm thinking maybe all that's needed is the release note but please make sure that the fix seems right. 19:06:34 At first blush it seemed correct. 19:06:35 tbarron: sure will do 19:06:59 gouthamr: if the fix is wrong we'll re-target this 19:07:05 ack 19:07:16 but if we just need the release note then let's get it done 19:07:19 gouthamr: thanks! 19:07:57 #link https://bugs.launchpad.net/manila/+bug/1804654 19:07:59 Launchpad bug 1804654 in Manila "netapp cdot volume efficiency status error" [Low,In progress] - Assigned to Maurice Escher (maurice-escher) 19:08:18 maybe we still have lseki and carlos_silva here 19:08:33 yep, I'm here 19:08:39 carthaca put up a fix for this one 19:08:47 and ganso gave it a +2 19:09:10 #link https://review.openstack.org/#/c/619570/ 19:09:27 It's also missing a release note 19:10:02 If NetApp wants this fix then one of you guys should add the release note, vote +1, and ping gouthamr or myself 19:10:11 tbarron: oh noes let me remove my +2 19:10:24 ganso: leave it there 19:10:36 I think the fix looks good 19:10:38 will need to add it back anyway on new patchset tbarron 19:10:44 tbarron: what about reno? 19:10:46 I can do a release note for this fix 19:10:50 ganso: ok, keep your reputation untarnished 19:11:14 carlos_silva: great, carthaca is on family leave so it's up to netapp 19:11:33 ganso: you are right 19:12:02 s/I can do/I can create 19:12:08 ok, let's turn this one around today if we all agree all it needs is a reno 19:12:53 #link 19:12:53 https://bugs.launchpad.net/manila/+bug/1810988 19:12:55 Launchpad bug 1810988 in Manila "[tempest] migration tests often fail with ssh timeouts " [High,In progress] - Assigned to Tom Barron (tpb) 19:13:08 I won't have a fix for this one in time. 19:13:29 so I plan to retarget it and then we'll have to backport the fixes. 19:13:47 Any discussion :) ? 19:14:14 nope, sounds good... although the problem seems to be in tempest 19:14:26 Yes 19:14:28 which isn't branched, although is tagged/released 19:14:39 you are right 19:14:47 so not a matter of backports 19:15:26 I don't know that I should have set it to High priority given that it's not broken functional code. 19:15:45 I just hate seeing red in gate because of it. 19:17:05 #link 19:17:05 https://bugs.launchpad.net/manila/+bug/1804654 19:17:06 Launchpad bug 1804654 in Manila "netapp cdot volume efficiency status error" [Low,In progress] - Assigned to Maurice Escher (maurice-escher) 19:17:18 wrong link 19:17:35 #link https://bugs.launchpad.net/manila/+bug/1808127 19:17:37 Launchpad bug 1808127 in Manila "intermittent tempest duplicate access rule failure" [Low,Confirmed] - Assigned to Tom Barron (tpb) 19:18:05 And I don't have a fix for this one yet either. Working on it led me to a more general issue ... 19:19:19 #link https://bugs.launchpad.net/manila/+bug/1818569 19:19:20 Launchpad bug 1818569 in Manila "access rule apply races allow duplicates" [Medium,Triaged] 19:19:41 I'll target both to Train-1 so jgrosso can keep them in our sights. 19:20:01 Any discussion? Disagreement, etc.? 19:20:50 ack, nope, wasn't introduced recently... sounds like something that can happen with rocky/queens as well 19:21:48 gouthamr: I added a PTG topic cause I think we may need another -ING database state for this but I digress .... 19:22:10 OK, that's the whole list from the etherpad. 19:22:33 Any other bugs that people think we *need* fixes for before rc1 ? 19:23:05 Hearing none, we have three still targeted. 19:23:18 #link https://bugs.launchpad.net/manila/+bug/1820118 19:23:19 Launchpad bug 1820118 in Manila "Manila unexpectedly attempts to delete a share server when deleting a share network" [Medium,In progress] - Assigned to Carlos Eduardo (silvacarlose) 19:23:38 #link https://bugs.launchpad.net/manila/+bug/1777551 19:23:39 Launchpad bug 1777551 in Manila "all_tenants value is not handled correctly" [Medium,In progress] - Assigned to zhangqing (zhang-qing) 19:24:26 #link https://bugs.launchpad.net/manila/+bug/1804654 19:24:26 Launchpad bug 1804654 in Manila "netapp cdot volume efficiency status error" [Low,In progress] - Assigned to Maurice Escher (maurice-escher) 19:25:11 None of these are release blockers, i.e. if we don't merge them by Thursday morning I will retarget them and we won't do an rc-2 because of them. 19:25:22 #link https://bugs.launchpad.net/manila/+bug/1804654 19:26:20 * gouthamr got disconnected for a sec 19:26:35 gouthamr: Are you figuring it's a low hanging fruit? 19:26:48 tbarron: the all_tenants one? 19:26:48 gouthamr: needs unit tests, release note, netapp endorsement 19:27:14 gouthamr: no, https://bugs.launchpad.net/manila/+bug/1804654 19:27:15 Launchpad bug 1804654 in Manila "netapp cdot volume efficiency status error" [Low,In progress] - Assigned to Maurice Escher (maurice-escher) 19:27:28 tbarron: oh.. no, sure they can take time to get it in.. 19:27:43 has review https://review.openstack.org/619570 19:28:12 if netapp wants to get that one then that's fine but they may have enough stuff to do by Thursday. 19:28:30 . 19:28:40 cool tbarron... I'm going to add a backport-potential on the following, since these aren't release blockers, but any fixes would be good to consider for stable branches: 19:28:59 Manila - Manage rule for CIFS share updates status from "error" to "active" for invalid users - https://bugs.launchpad.net/manila/+bug/1550258 19:29:01 Launchpad bug 1550258 in Manila "Manila - Manage rule for CIFS share updates status from "error" to "active" for invalid users" [Low,Triaged] 19:29:06 Hacking rule for underscore import doesn't work https://bugs.launchpad.net/manila/+bug/1541780. 19:29:08 Launchpad bug 1541780 in Manila "Hacking rule for underscore import doesn't work" [Low,In progress] - Assigned to Marc Koderer (m-koderer) 19:29:13 DB Deadlock on quota reserve https://bugs.launchpad.net/manila/+bug/1518936 19:29:13 Launchpad bug 1518936 in Manila "DB Deadlock on quota reserve" [Low,Incomplete] 19:29:18 requests to SSL wrapped sockets hang while reading using py3 https://bugs.launchpad.net/manila/+bug/1482633 19:29:20 Launchpad bug 1482633 in oslo.service "requests to SSL wrapped sockets hang while reading using py3" [High,Triaged] 19:29:24 Infinidat driver fails pylint https://bugs.launchpad.net/manila/+bug/1816646 19:29:26 Launchpad bug 1816646 in Manila "Infinidat driver fails pylint" [Medium,Confirmed] - Assigned to Amit Oren (amito) 19:29:29 scheduler falsely reports share service down https://bugs.launchpad.net/manila/+bug/1804208 19:29:29 Launchpad bug 1804208 in Manila "scheduler falsely reports share service down" [High,New] 19:29:33 manila scheduler does not filter storage protocol https://bugs.launchpad.net/manila/+bug/1783736 19:29:34 Launchpad bug 1783736 in Manila "manila scheduler does not filter storage protocol" [High,In progress] - Assigned to liushi (liu.shi) 19:29:42 Pagination related issues: 19:29:42 next share_links contains not supported marker field https://bugs.launchpad.net/manila/+bug/1819167 19:29:43 Launchpad bug 1819167 in Manila "next share_links contains not supported marker field " [Medium,Triaged] - Assigned to Goutham Pacha Ravi (gouthamr) 19:29:43 pagination does not speed up list queries https://bugs.launchpad.net/manila/+bug/1795463 19:29:44 Launchpad bug 1795463 in Manila "pagination does not speed up list queries" [Medium,Confirmed] 19:30:09 * gouthamr didn't get banned 19:30:15 gouthamr: :) 19:30:17 Regarding the infinidat issue 19:30:26 amito: ??? 19:30:49 Infinidat driver pylint issue 19:30:50 amito: you have dust and link in your driver 19:31:00 ? 19:31:06 I was afk, sorry 19:31:14 amito: I'm just messing with you :) 19:31:55 Is this bug critical for rc1? I can maybe suppress the pylint error as a temporary solution... 19:32:10 gouthamr was listing issues whose fixes we'll consider for backports but which are *not* critical for the release. 19:32:23 amito: just nice to have... since we'll be running the new pylint for stable/stein 19:32:24 amito: and yours was among these 19:32:40 amito: no reason to ruin your evening :) 19:33:03 Oh sorry, again, it's past my working hours here ;) 19:33:28 amito: I know, sorry to ping you on that one .... 19:33:43 * gouthamr mails a lint remover to amito, next-day-delivery 19:34:27 tbarron: no problem, sorry for only being half here ;) 19:34:58 So we'll look at doing new stable/branch releases more or less around the time we release Stein 19:35:27 and it will be good to get any serious issue backports in before then. 19:35:53 Also stable/pike will go EOM -- end of maintenance 19:36:10 gouthamr: you have a fix for stable/pike? 19:36:30 tbarron: i don't yet... backport for stable/queens hasn't merged yet 19:36:42 gouthamr: ack 19:37:07 I have https://review.openstack.org/#/c/635887/ for stable/pike 19:37:28 So in the next couple weeks it would be good to land it. 19:37:45 Anything else for today? 19:38:18 OK, thanks all! 19:38:23 #endmeeting