15:01:16 <tbarron> #startmeeting manila
15:01:17 <openstack> Meeting started Thu Jan  9 15:01:16 2020 UTC and is due to finish in 60 minutes.  The chair is tbarron. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:01:18 <lseki> o/
15:01:19 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:01:21 <openstack> The meeting name has been set to 'manila'
15:01:23 <kaisers> o/
15:01:27 <vkmc> o/
15:01:39 <tbarron> kaisers!!
15:01:51 <kaisers> o_O
15:01:53 <kaisers> :)
15:01:53 <vhari> o/
15:01:53 <tbarron> courtesy ping: xyang toabctl ganso vkmc amito jgrosso dviroel lseki carloss
15:01:57 <dviroel> o/
15:01:57 <amito> o/ hello
15:02:07 <tbarron> amito!
15:02:14 <tbarron> the year is starting well
15:02:19 <amito> tbarron! :)
15:02:24 <maaritamm> o/
15:02:28 <tbarron> gouthamr is out this week so I am filling in.
15:02:40 <tbarron> let's wait a couple more minutes ...
15:02:52 <tbarron> Agenda:
15:03:13 <tbarron> #link https://wiki.openstack.org/wiki/Manila/Meetings
15:03:25 <tbarron> feel free to make last-minute updates ...
15:03:53 <ganso> hello
15:03:59 <tbarron> ganso!
15:04:04 <lseki> \o/
15:04:06 <dviroel> ganso!
15:04:09 <lseki> ganso!
15:04:14 <ganso> lol
15:04:20 <amito> :D
15:04:24 * tbarron is saying hi to folks who haven't been here for a while ...
15:05:07 <tbarron> ok, let's get started
15:05:21 <tbarron> Hi all!
15:05:39 <tbarron> #topic announcements
15:05:56 <tbarron> I don't have any.  But as I mentioned
15:06:16 <tbarron> gouthamr is out for this week's meeting (and next).
15:06:35 <tbarron> He's doing upstream work but has some other responsibilities for a couple
15:06:43 <tbarron> weeks and  is working IST.
15:06:56 <tbarron> So don't despair, he'll be back!
15:07:10 <vkmc> D:
15:07:22 <tbarron> And you can email him or say something to him on IRC and you'll get a response I'm sure.
15:07:35 <tbarron> Anyone else have any announcements?
15:08:41 <tbarron> OK, our agenda today is mostly about tracking/calling attention to pending work.
15:08:47 <tbarron> #topic peding specs
15:09:02 <tbarron> #link https://review.opendev.org/#/c/692330/
15:09:47 <tbarron> This is about adding timestamp based queries of user messages.
15:10:09 <tbarron> lseki: thank you and carlos for reviewing.
15:10:20 <lseki> :-)
15:10:54 <dviroel> will take a look on this one soon
15:11:03 <tbarron> amito: ganso: dviroel: would you guys take a look and see if you have any concerns?
15:11:08 <tbarron> dviroel: jinx
15:11:12 <tbarron> thanks
15:11:31 <tbarron> ok, moving along
15:11:53 <amito> tbarron: ok
15:11:55 <tbarron> #link https://review.opendev.org/#/c/700776/
15:11:58 <tbarron> amito: ty
15:12:20 <tbarron> We carried this one forwards from Train, but there are a few revisions from
15:12:28 <tbarron> discussion at TOG
15:12:50 <tbarron> s/TOG/PTG/
15:13:00 <tbarron> didn't mean to invent a new conference
15:13:13 <dviroel> =)
15:13:42 <tbarron> amito: ganso: all please take a look at the changes and the PTG notes.
15:14:06 <tbarron> I don't expect any significant issues at this point but we need to review and approve it.
15:14:52 <tbarron> There are some tricky implementation matters with this one but I think we can settle them in the code review
15:15:04 <tbarron> so it would be good to get those underway.
15:15:19 <tbarron> Anything else on Pending Specs?
15:15:42 <tbarron> #topic Code Reviews
15:15:58 <tbarron> #link https://review.opendev.org/#/c/697957/
15:16:34 <tbarron> I've got a -1 on this but it has to do with small corrections.
15:16:48 <tbarron> lseki: thank you  for reviewing
15:16:54 <lseki> :-)
15:16:59 <tbarron> We need eyes on it though!!
15:17:24 <tbarron> It's a pretty important  change and it really needs review and familiarity by the whole team.
15:17:55 <tbarron> Also, haixin is doing great work so we don't want it to sit there and languish.
15:18:00 <tbarron> 'nuf said
15:18:08 <vkmc> haixin++
15:19:15 <tbarron> #link https://review.opendev.org/#/c/697957/
15:19:40 <tbarron> Here's another one that needs eyes.
15:20:13 <tbarron> Liron is changing the way we do test skips so that manila can be more in line
15:20:27 <lseki> tbarron: I think you sent the same link again
15:20:44 <tbarron> with expectations from OpenStack quality engineering about how to  assign uuids
15:20:57 <tbarron> to  test cases so they can be tracked run to run.
15:21:02 <tbarron> lseki: thanks
15:21:03 <vkmc> I believe this is the one
15:21:05 <vkmc> #link https://review.opendev.org/#/c/701340/
15:21:41 <tbarron> vkmc: thanks
15:22:00 <tbarron> Any questions or concerns about the motivation for this change?
15:22:50 <tbarron> There are a fair number of lines changed but for the most part it's the same pattern over and over.
15:23:29 <tbarron> We need to inpect the code  and also ensure that we aren't regressing on test results, including 3rd party jobs.
15:23:57 <tbarron> So everyone should pay special attention to the jobs for the back ends they care most about.
15:24:48 <tbarron> As an example, though the previous couple of runs passed all voting Jenkins jobs, there was a prblem with the way skips were done for CephFS-with-nfs.
15:25:00 <tbarron> Any discussion of  thi one?
15:25:09 <tbarron> Or the goal?
15:25:28 <tbarron> There may be some other changes needed to reach that  goal.
15:25:56 <tbarron> In particular, if anyone has experience with  tempest test case uuids and DDT we need your help!
15:26:37 <tbarron> ok, moving along ...
15:27:03 <tbarron> #link https://review.opendev.org/#/c/700833/
15:27:40 <tbarron> Liron discovered that we were sharing the same ssh key across test cases causing
15:27:54 <tbarron> fallback to password auth unnecessarily.
15:28:13 <tbarron> His change LGTM but we need other eyes to make sure.
15:28:36 <tbarron> It's a small change so even if you are working elsewhere now and know about this stuff
15:28:43 * tbarron looks at ganso
15:28:56 <tbarron> I'd be very interested in your opinion
15:29:28 * ganso ganso is in another meeting
15:29:51 <tbarron> he can run but he can't hide
15:29:58 <dviroel> lol
15:30:06 <tbarron> #link https://review.opendev.org/#/c/647538/
15:30:30 <tbarron> vkmc has had this review up for a long time, I thought it was ready last
15:30:55 <tbarron> cycle but we decided to carry it over so that we'd have it get "soak time" for
15:31:13 <tbarron> a good while in the new cycle to flush out any unanticipated issues.
15:31:30 <tbarron> So I'm asking for eyes on this one.
15:31:58 <tbarron> My personal target is to merge it in a week or so, so please look and see if you have any concerns.
15:32:41 <tbarron> #link https://review.opendev.org/#/c/698848/
15:33:10 <tbarron> maaritamm: vkmc this is I think the next step in our epic of
15:33:22 <tbarron> getting manila support into the openstack client
15:33:51 <tbarron> maaritamm: vkmc: right, this one is "up next"?
15:33:57 <vkmc> yas, I've reviewed that one already and also lseki
15:34:12 <vkmc> that one is ready (unless someone has more comments)
15:34:34 <vkmc> there is another patch in the queue that maaritamm has been working on, also would benefit from extra eyes
15:34:34 <tbarron> vkmc: are there any backwards compatability issues or do the old commands still work too?
15:34:52 <vkmc> tbarron, old commands still work as well, we have both clients living together
15:35:10 <tbarron> vkmc: ty for answering my rhetorical question :)
15:35:34 <vkmc> np
15:35:48 <tbarron> ok, the other patch is I think
15:35:53 <vkmc> share types :)
15:35:55 <tbarron> #link https://review.opendev.org/#/c/701229/
15:36:09 <tbarron> I didn't have it on the list today b/c it has Workflow -1
15:36:13 <vkmc> we added some reviewers to it considering they were interested on this feature
15:36:31 <tbarron> is there information/thoughts needed to unblock  this one?
15:36:35 <vkmc> yeah, it needs a bit more work, but we can actually start reviewing it
15:36:55 <vkmc> maaritamm, can you recall things you consider are missing for the share types implementation?
15:37:08 <vkmc> I'm not entirely sure which ones you already fixed and which ones are missing
15:37:31 <vkmc> output formatting was one I think
15:37:52 <vkmc> maaritamm was looking to make output look exactly the same as the manila client for backwards compatibility
15:38:02 <tbarron> well let's see if we can merge  https://review.opendev.org/#/c/698848/ first and revisit the share-types patch next week
15:38:07 <vkmc> sure
15:38:14 <maaritamm> share type list output needs formatting
15:38:18 <vkmc> yep, checking the code, I see some inline comments from maaritamm
15:38:53 <tbarron> ok folks, please look at that issue and advise.  maaritamm you can also pose that question in
15:39:06 <tbarron> #openstack-manila and solicit suggestions there
15:39:15 <tbarron> #topic Bugs
15:39:26 <tbarron> vhari: do you have anything for us today?
15:40:09 <vhari> tbarron, yes , https://bugs.launchpad.net/manila/+bug/1858024
15:40:09 <openstack> Launchpad bug 1858024 in Manila "ssh key mismatch occurred when booting more than one instance" [Undecided,New]
15:40:42 <vkmc> that one is confirmed and it's a patch ongoing that was mentioned earlier
15:40:49 <vkmc> I can triage that
15:40:52 <vhari> fix is in review - should we assign and update status?
15:41:01 <tbarron> vkmc: thanks
15:41:07 <vhari> vkmc, thanks
15:41:12 <tbarron> vhari: yeah :)
15:41:41 <vhari> tbarron, wondering if proposed fix would address #1810988 [tempest] migration tests often fail with ssh timeouts    HIGH?
15:41:52 <vhari> #1810988 [tempest] migration tests often fail with ssh timeouts
15:41:59 <vkmc> for some reason I cannot find Liron in the list... is it only me or the search in Launchpad is really bad?
15:42:06 <tbarron> I'd set Importance low on this but target it to a near milestone since the fix is imminent.
15:42:18 <tbarron> Low because tests don't actually break, just run slower.
15:43:01 <tbarron> vkmc: he's the reporter so ...
15:43:03 <vhari> tbarron, ack - do we think Liron's fix may address the ssh timeouts
15:43:14 <vkmc> tbarron, yep, maybe it's a privileges in launchpad thing
15:43:17 <tbarron> vhari: maybe, needs to be investigated
15:43:19 <vkmc> I cannot set the assignee or the importance
15:43:30 <tbarron> vhari: it can't hurt
15:43:36 <vhari> tbarron, :)
15:44:05 <tbarron> vkmc: talk to gouthamr (or maybe me still) afterwards and we'll get that fixed
15:44:12 <vkmc> tbarron, will do
15:44:32 <vhari> tbarron, otherwise looks we are in ok shape with recent bugs
15:44:33 <vkmc> in the meantime, you would need to triage that >:(
15:44:44 <tbarron> vkmc: done
15:44:49 <vkmc> \o/
15:45:04 <vhari> tbarron, :D
15:45:48 <tbarron> vhari: moar bugs?
15:46:07 <vhari> tbarron, that's it for today .. thanks
15:46:17 <tbarron> vhari: cool, thanks!
15:46:27 <tbarron> #topic Open Discussion
15:46:31 <vhari> tbarron, yw
15:47:20 <tbarron> I'll just mention that if you are interested in trying the manila-csi plugin for Kubernetes volumes
15:47:33 <tbarron> there is now a way to do that on a local machine or server instead of
15:47:47 <tbarron> haviing to run with VMs on an actual OpenStack cloud
15:48:19 <tbarron> https://github.com/tombarron/pocketmanilakube
15:48:48 <tbarron> The other way is still possible as well of course
15:49:27 <dviroel> tbarron++
15:49:43 <tbarron> via https://github.com/tombarron/manila-kube or
15:49:51 <tbarron> -- a bit more uptodate --
15:50:01 <tbarron> https://github.com/shiftstack/manila-kube
15:50:39 <tbarron> I've run on CentOS 7 and Fedoar 29-30, for other platforms file issues and we can do tweaks, etc.
15:50:50 <tbarron> Anything else today?
15:51:28 <tbarron> 29-31 actually
15:51:41 <tbarron> OK, let's get 9 minutes back.
15:51:59 <tbarron> Thanks everyone, see you in #openstack-manila!
15:52:08 <tbarron> #endmeeting