15:00:10 <dviroel> #startmeeting manila 15:00:12 <openstack> Meeting started Thu Sep 3 15:00:10 2020 UTC and is due to finish in 60 minutes. The chair is dviroel. Information about MeetBot at http://wiki.debian.org/MeetBot. 15:00:13 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 15:00:15 <openstack> The meeting name has been set to 'manila' 15:00:31 <tbarron> hi! 15:00:45 <carloss> o/ 15:00:56 <vhari> hello! 15:00:56 <dviroel> courtesy ping: ganso vkmc dviroel lseki andrebeltrami felipe_rodrigues 15:01:02 <vkmc> o/ 15:01:07 <vkmc> howdie 15:01:21 <andrebeltrami> hello 15:01:26 <felipe_rodrigues> o/ 15:01:36 <dviroel> hi all o/ 15:02:00 <dviroel> thank you for joining, and as you might know, our PTL took some days off this week 15:02:16 <dviroel> lets start with our agenda 15:02:17 <tbarron> slacker 15:02:31 <dviroel> #link https://wiki.openstack.org/wiki/Manila/Meetings#Next_meeting 15:02:52 <dviroel> #topic Announcements 15:02:54 <vkmc> tbarron++ 15:02:55 <lseki> o/ 15:03:20 <dviroel> Feature Freeze in 1 week from now 15:03:27 <dviroel> #link https://releases.openstack.org/victoria/schedule.html (victoria release schedule) 15:03:53 <dviroel> this means that we expect to have all proposed features reviewed and merged until next Thursday 15:04:29 <dviroel> also in this day is when we request our client libraries releases 15:05:05 <dviroel> i would like to discuss about our reviews in a bit, in another topic 15:05:40 <dviroel> next announcement: Wallaby schedule has been updated with Manila deadlines 15:05:50 <dviroel> #link https://releases.openstack.org/wallaby/schedule.html (wallaby release schedule) 15:06:09 <dviroel> as you can see, we already have our deadlines for the next release 15:06:30 <dviroel> so i want to ask you all to take a look on that schedule 15:07:18 <dviroel> and raise your concerns about it, if any, with gouthamr until the PTG (Oct 26) 15:07:58 <dviroel> it seems that we have a spec freeze christmas edition this time 15:08:02 <dviroel> :) 15:08:21 <lseki> 🎅 15:08:40 <dviroel> lseki: you should be on vacation too :P 15:08:49 <lseki> I am 15:08:58 <tbarron> lseki++ 15:09:38 <dviroel> so, thats what I have for now for announcements 15:09:52 <dviroel> anyone has any announcement for today? 15:10:22 <dviroel> ok, moving on.. 15:10:32 <dviroel> #topic Recap: Collaborative review meeting for Victoria release 15:10:49 <dviroel> #link http://lists.openstack.org/pipermail/openstack-discuss/2020-August/016873.html (Victoria Collab Review email thread) 15:11:23 <dviroel> as it was mentioned in the last meeting, we had our first collaborative review meeting for the Victoria cycle last Tuesday (Sep 1st) 15:11:56 <dviroel> imo it was a very productive meeting 15:12:13 <dviroel> that took longer than expected (sorry about that) 15:12:54 <dviroel> in this meeting, we went through the code of the proposed Share Server Migration feature 15:12:59 <tbarron> I am glad it went well and am sorry that I got pulled out of it part way through. 15:13:29 <dviroel> tbarron: np, we know that is complicated to fit a 2h meeting in any schedule 15:13:57 <dviroel> we also did a quick demo of this feature 15:14:20 <dviroel> if you missed, you still can watch the recording that was published in the Manila channel 15:14:28 <dviroel> #link https://www.youtube.com/watch?v=CCIhHVKPTx4 15:14:41 <dviroel> 3 hours of fun 15:15:07 <dviroel> and we were also taking notes in the meeting etherpad 15:15:18 <dviroel> #link https://etherpad.opendev.org/p/manila-victoria-collab-review (victoria collab review etherpad) 15:15:30 <tbarron> the scene with the sharks and snakes is at 2:37 15:15:39 <carloss> haha 15:16:38 <dviroel> we also have a Q&A session in this etherpad that you folks can still use to add new questions 15:16:54 <dviroel> we are always taking a look at this etherpad 15:17:34 <dviroel> I would like to thank everybody that attended to the meeting,it was great to share with you this feature that we have been working 15:18:36 <dviroel> ok, next topic 15:18:53 <dviroel> #topic Reviews needing attention 15:19:01 <dviroel> here is our review focus etherpad 15:19:11 <dviroel> #link https://etherpad.opendev.org/p/manila-victoria-review-focus (review focus ether pad) 15:19:33 <dviroel> lets go through each feature again and talk a little about them 15:20:00 <dviroel> and as mentioned before, we are 1 week away from Feature Freeze and client releases, so I would like to have your attention on this patches during this week 15:20:11 <dviroel> ok first one is 15:20:21 <dviroel> Share Server Migration 15:20:32 <dviroel> #link https://review.opendev.org/#/q/topic:bp/share-server-migration+(status:open) 15:21:00 <dviroel> no surprises, this is the one that we have been discussing in the collab meeting 15:21:17 <tbarron> Have you reached out for reviewers who have back ends that could use this feature? 15:21:39 <dviroel> tbarron: no until now 15:21:53 <tbarron> That is my main concern. It hopefully won't be only netapp and container and dummy driver forever. 15:22:16 <dviroel> i believe that at this moment, Dell can also benefit from this feature 15:22:30 <dviroel> since they still have active members in the community 15:22:40 <tbarron> Agree. But they should be reviewing at least the core code. 15:23:20 <tbarron> Goutham and I have a NetApp persoective on it given our backgrounds. 15:24:03 <dviroel> yes, for sure would be interesting to have other drivers perspective on that too 15:24:16 <dviroel> something that we don't have noe 15:24:41 <dviroel> we can tag them in the patch or try to reach them on irc/mail 15:24:52 <tbarron> dviroel++ 15:25:06 <dviroel> for now, we have gouthamr reviewing some patches, like core and client 15:25:29 <dviroel> for this one we also have a state diagram to help us identify all these state changes 15:25:57 <dviroel> that is in-progress since it can be changed due to implementation changes 15:26:03 <dviroel> #link https://docs.google.com/drawings/d/15b8AAjXTMoikyTdOevwOFTrxMyBF8We1qY8IuCwAv0w/edit 15:26:16 <dviroel> let me know if you can access the document 15:26:48 <tbarron> dviroel: I can, and thanks for sharing it 15:26:57 <dviroel> tks 15:27:24 <dviroel> so again, if you want to help on this review, add your name to etherpad :) 15:27:26 <tbarron> dviroel: I can help review but there's a lot of code and I am on PTO and offline after this meeting till next Wednesday 15:27:45 <tbarron> I'm OK with extending deadlines if we need to 15:28:25 <dviroel> tbarron: ok, tks. Yes, since its a lot of code, we may need a extension, but we'll try as we can to get it merged next week 15:28:26 <tbarron> Really would like Dell-EMC to take a look if only from the perspective - is it good enought in core and client that 15:28:36 <tbarron> we can wor with thhis in the future? 15:29:06 <dviroel> tbarron: sure, something that really make a difference on reviews 15:29:13 <dviroel> different perspectives 15:29:45 <dviroel> in the same line we have this one: [NetApp] Add support for share server migration 15:29:57 <dviroel> this is the 3rd party driver implementation of the share server migration feature 15:30:33 <dviroel> it is in a different bullet since it will not block the core patch to be merged, but at this moment we don't have any reviewers for that one too 15:30:49 <dviroel> and also has a lot of code to be reviewed 15:31:07 <dviroel> i believe that carloss can help us on this review too 15:31:10 <tbarron> I put my name on that one 15:31:16 <dviroel> tbarron: tks 15:31:18 <carloss> sure dviroel 15:31:59 <dviroel> felipe_rodrigues is also helping on validating this implementation we I should upload a new PS with some small fixes 15:32:14 <dviroel> next is [NetApp] Enables configuring NFS transfer limits 15:32:22 <dviroel> felipe_rodrigues patch 15:32:27 <dviroel> #link https://review.opendev.org/#/c/746568/ ([NetApp] Enables configuring NFS transfer limits) 15:32:48 <dviroel> it is a feature that uses scoped extra specs to configure transfer limits to share servers 15:32:58 <dviroel> and I want to ask our attentions to this one 15:33:24 <dviroel> since it has conflicts with the previous Share Server Migration patch, for NetApp driver 15:33:24 <tbarron> looks like SAP wants this one and carthaca is reviewing? 15:33:47 <dviroel> tbarron: yes! we already have some comments that are easy to fix 15:33:53 <tbarron> kk 15:34:12 <tbarron> That's another source of valuable reviewers -- consumers of these features :D 15:34:19 <dviroel> and would be good to merge this one first, in order to have time to fix the conflicts in the other one 15:35:26 <dviroel> tbarron: i don't think so 15:35:34 <dviroel> it would be great 15:35:44 <felipe_rodrigues> for sure, this patch configures servers, so migrating the servers would be affected by that.. 15:36:04 <felipe_rodrigues> they may conflict 15:36:15 <dviroel> and we can think on a way of bringing more reviewers 15:36:55 <dviroel> we know that we have at this moment lots of code to be reviewed and don't have too much reviewers to hold all that code 15:37:18 <dviroel> we need for sure try to bring more reviewers to our side 15:37:38 <dviroel> oh, and this patch also depends on a small 'fix' in the core, to enable share types to be provided to drivers at the moment that share servers are requested 15:37:52 <dviroel> felipe_rodrigues: ack 15:38:03 <dviroel> #link https://review.opendev.org/#/c/746361/(Add the share-type for the server setup metadata) 15:38:37 <dviroel> the correct link 15:38:41 <dviroel> #link https://review.opendev.org/#/c/746361/ (Add the share-type for the server setup metadata) 15:39:05 <dviroel> ok, next one 15:39:12 <dviroel> [NetApp] Adding support for Adaptive QoS 15:39:38 <dviroel> one more that is driver feature 15:39:44 <dviroel> #link https://review.opendev.org/#/c/740532/ ([NetApp] Adding support for Adaptive QoS in NetApp driver with dhss false) 15:40:01 <dviroel> this one is an initial implementation of NetApp Adaptive QoS for NetApp driver 15:40:15 <dviroel> will probably receive new update in the next releases 15:40:52 <dviroel> we already have some reviews on this one and we expect to have some minor concerns solved until next week in order to merge it 15:41:30 <tbarron> this one has no impact outside netapp back end, right? 15:41:53 <dviroel> tbarron: correct, it only uses scoped extra-specs 15:42:10 <dviroel> and also reuse part of the code that we already have for qos 15:42:26 <dviroel> I'm talking with Michael to help him to solve some issues that we might have with other operations rather than create/create from snapshot 15:42:26 <tbarron> I am happy to help review it rather than pushing you to look for partner reviewers since I'm familiar with that back end. 15:43:21 <dviroel> thanks tbarron, gouthamr already posted some concerns about this feature too 15:43:34 <dviroel> will be great to have your thoughts on this one too 15:44:14 <dviroel> and the last one is: Graduate share replication feature 15:44:23 <dviroel> #link https://review.opendev.org/#/q/topic:bp/graduate-share-replication-feature+(status:open+OR+status:merged) 15:44:45 <dviroel> we started graduating some features in the last release with share groups, and now its time for share replication 15:45:07 <dviroel> thanks again carloss for your effort on this 15:45:21 <carloss> dviroel: my plesure 15:45:27 <dviroel> will be good to have more eyes on this patch, so if you want to volunteer, please add your name to the etherpad 15:45:54 <dviroel> tbarron: you added your name to this one too 15:46:16 <dviroel> not sure if you want to review this one, or the one above 15:46:20 <dviroel> :) 15:46:22 <tbarron> I think this is pretty much ready 15:46:33 <dviroel> yes it is 15:46:39 <tbarron> didn't add it to -1 :D 15:47:01 <dviroel> will ask other reviewers to take a look on this one, andrebeltrami felipe_rodrigues 15:47:13 <andrebeltrami> ack 15:47:15 <felipe_rodrigues> ack 15:47:32 <dviroel> we can use the last patch for share group graduation to see if something is missing on this one 15:47:42 <dviroel> thanks 15:47:59 <dviroel> that's what we have for now on reviews :) 15:48:16 <dviroel> anything else on this topic? 15:48:49 <dviroel> ok 15:49:00 <dviroel> #topic Bugs (vhari) 15:49:17 <vhari> o/ 15:49:27 <vhari> #link https://bugs.launchpad.net/manila/+bug/1893718 15:49:28 <openstack> Launchpad bug 1893718 in OpenStack Shared File Systems Service (Manila) "Fixed the logic that determines whether a share exists before manage a share" [Undecided,In progress] - Assigned to haixin (haixin77) 15:49:44 <vhari> lets take a quick look at this one - 15:49:58 <vhari> haixin proposed a fx .. 15:49:59 <dviroel> oh, so it seems that we already have a fix proposed 15:50:03 <dviroel> yes 15:50:13 <vhari> need to add importance and other fields 15:50:58 <dviroel> something between low and medium 15:51:17 <carloss> I'd say low 15:51:36 <vhari> k agreed 15:51:39 <carloss> I have hit it myself but it was while I was testing the fix for another bug I'm helping to solve (https://bugs.launchpad.net/manila/+bug/1860061). 15:51:40 <openstack> Launchpad bug 1860061 in OpenStack Shared File Systems Service (Manila) "Totalcount returned by pagination query is wrong and filters should before pagination query " [Medium,In progress] - Assigned to MaAoyu (maaoyu) 15:52:10 <dviroel> carloss: is there a conflict between those fixes? 15:52:28 <carloss> yep 15:52:31 <dviroel> i'm ok with low too 15:52:51 <vhari> done .. next up 15:52:53 <vhari> #link https://bugs.launchpad.net/manila/+bug/1585241 15:52:54 <openstack> Launchpad bug 1585241 in OpenStack Shared File Systems Service (Manila) "File-based locks don't provide concurrency over multi-node/multi-AZ deployments" [Medium,Triaged] - Assigned to Goutham Pacha Ravi (gouthamr) 15:53:13 <vhari> looping this back out since target is victoria rc1 15:53:38 <dviroel> yes, gouthamr tag it for victoria rc1 some time ago 15:53:51 <dviroel> don't remember to see any patch related so far 15:54:17 <tbarron> it's pretty important, might ought to be a ptg topic 15:54:30 <dviroel> this is something that we might need for active/active too 15:54:40 <tbarron> it's easy to say we should use dlm for this and active/active 15:54:56 <tbarron> but that puts responsibility on deployers 15:55:11 <tbarron> so it's a bit of a wave our hands at the problem approach 15:55:35 <tbarron> not saying it's wrong, just that it's hard to actually solve for real deployments 15:55:57 <tbarron> but we could fix it in devstack pretty easily 15:56:30 <dviroel> tbarron: this is for sure a good topic for our PTG 15:56:39 <tbarron> vhari: anayways, we can't just time this one out and make it go away 15:56:47 <vhari> tbarron, ack 15:56:48 <dviroel> I am also interested on this 15:57:59 <dviroel> ok, we are a little out of time 15:58:01 <vhari> k, will keep it on the list 15:58:10 <dviroel> vhari: tks! 15:58:17 <vhari> dviroel, yw 15:58:29 <vhari> that's a wrap for bugs 15:58:33 <dviroel> tks, moving on 15:58:37 <dviroel> #topic Open Discussion 15:58:44 <dviroel> we have 2 min for it 15:59:17 <dviroel> :) 15:59:24 <dviroel> ok, thanks everyone for attending 15:59:32 <vhari> dviroel++ 15:59:36 <dviroel> lets try to focus on reviewing code this week 15:59:37 <andrebeltrami> dviroel++ 15:59:52 <dviroel> see you all on #openstack-manila 16:00:04 <dviroel> #endmeeting