15:00:57 <gouthamr> #startmeeting manila
15:00:57 <openstack> Meeting started Thu Sep 10 15:00:57 2020 UTC and is due to finish in 60 minutes.  The chair is gouthamr. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:58 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:01:00 <openstack> The meeting name has been set to 'manila'
15:01:04 <carloss> o/
15:01:04 <dviroel> o/
15:01:06 <maaritamm> o/
15:01:10 <carthaca> Hi
15:01:15 <andrebeltrami> o/
15:01:36 <gouthamr> courtesy ping: ganso vkmc lseki tbarron felipe_rodrigues
15:02:06 <tbarron> hi
15:02:08 <gouthamr> hello o/ everyone, thank you for joining, here's our agenda for today: https://wiki.openstack.org/wiki/Manila/Meetings#Next_meeting
15:02:20 <lseki> o/
15:02:22 <gouthamr> we've a few things to cover, so lets get started
15:02:31 <gouthamr> #topic Announcements
15:02:57 <gouthamr> let me begin with thanks to dviroel for chairing the weekly meeting last week!
15:03:21 <gouthamr> a few schedule announcements,
15:03:28 <gouthamr> today's feature freeze!
15:03:32 <gouthamr> #link https://releases.openstack.org/victoria/schedule.html (victoria release schedule)
15:03:39 <dviroel> :) anytime!
15:04:12 <gouthamr> all feature patches must be merged today - and we'll also be requesting a release for python-manilaclient
15:04:33 <gouthamr> we'll discuss pending changes in a bit
15:05:04 <gouthamr> as you're aware, the Wallaby cycle Virtual PTG is scheduled to Oct 26-Oct 30th 2020
15:05:25 <gouthamr> if you haven't already registered for this free virtual event, please do so
15:05:40 <gouthamr> #link https://www.eventbrite.com/e/project-teams-gathering-october-2020-tickets-116136313841 (Register for the Wallaby Cycle PTG)
15:06:22 <gouthamr> A planning etherpad is up, and i'll post it to the mailing list today
15:06:34 <gouthamr> #link https://etherpad.opendev.org/p/wallaby-ptg-manila-planning (Wallaby PTG Planning Etherpad)
15:06:47 <vkmc> o/
15:07:09 <gouthamr> please go ahead and indicate your name, nick, timezone and add topics to the proposed list for discussion
15:07:22 * gouthamr marks vkmc tardy
15:07:44 * vkmc puts on the shame hat
15:07:50 <gouthamr> i tried to request the same amount of time as we had last time
15:08:08 <gouthamr> #link https://ethercalc.openstack.org/7xp2pcbh1ncb (Draft Schedule for the Wallaby PTG)
15:08:30 <gouthamr> please take a look and call out any concerns
15:08:49 <tbarron> are we in two rooms at the same time on Tuesday?
15:09:02 <gouthamr> tehre you go :P
15:09:07 <tbarron> not any  more
15:09:10 <dviroel> lol
15:09:17 * tbarron stops his cloning operation
15:09:51 <vkmc> two rooms at the same time... I know we are good, but that is far optimistic gouthamr
15:10:06 <gouthamr> i suspect there will be some consolidation, don't read too much into the room names yet
15:10:27 <gouthamr> vkmc: use the force
15:10:59 <lseki> 🌵
15:11:19 <gouthamr> 🦘
15:11:21 <gouthamr> :P
15:11:44 <gouthamr> we will most likely end up with a zoom room as we did last time
15:12:27 <gouthamr> awesome, that's all i had in terms of announcements today
15:12:31 <gouthamr> anyone else got any?
15:12:54 <vkmc> 🦨
15:13:31 * gouthamr that didn't render on my irc client :(
15:13:36 <gouthamr> #topic Reviews needing attention
15:14:02 <gouthamr> alright lets get into the weeds
15:14:06 <gouthamr> #link https://etherpad.openstack.org/p/manila-victoria-review-focus (review focus ether pad)
15:14:54 <gouthamr> too many unmerged items at this point, and much of it is due to lack of reviewer attention :( something that has bitten us multiple times in the past
15:15:16 <gouthamr> but, we may have some things merged by EOD as planned - lets talk through them
15:15:27 <gouthamr> Share Server Migration
15:15:49 <gouthamr> dviroel can you give us a status update on this one?
15:16:09 <dviroel> we have 5 patches for this feature
15:16:47 <dviroel> the main patch already got some reviews and we fixed everything so far
15:17:01 <dviroel> we still need more reviews on that in order to merge
15:17:26 <dviroel> we have been fixing some py38 issues today, and we have a +1 on in
15:17:51 <dviroel> gouthamr: what do you think about this specific patch
15:17:54 <dviroel> ?
15:17:57 <gouthamr> +1 that certainly helps; not too happy with the CI churn at feature freeze :|
15:18:13 <gouthamr> i'll complete my review soon - i think we flushed out the important bits
15:18:17 <dviroel> me neither
15:18:27 <dviroel> gouthamr: awesome
15:18:47 <dviroel> the client patch is also in a good shape I think, all comments solved so far
15:19:30 <dviroel> then we have two first party drivers implementation, Dummy and Container
15:19:32 <gouthamr> ack, can you rebase the driver changes?
15:19:40 <dviroel> gouthamr: sure
15:20:03 <dviroel> tbarron already took a look on Dummy, no reviews yet in the container
15:20:05 <tbarron> i think the first party drivers are in pretty good shape but need rebase on the core patch
15:20:19 <tbarron> i've looked at container
15:20:26 <dviroel> tbarron: oh great, thanks
15:21:11 <tbarron> main thing is that all depend (whether or not they say depends-on) a 5-6000 line core patch and the tempest and client patches
15:21:34 <dviroel> true
15:21:42 <gouthamr> oh, i hope nothing depends on the tempest patch?
15:21:45 <tbarron> gouthamr has been working these and i'm pretty confident he's doing a great juob reviewing
15:21:54 <tbarron> gouthamr: knowing that they work  right
15:22:00 <tbarron> empirically
15:22:09 <tbarron> in addition to code inspection
15:22:19 <tbarron> so not 'depends-on', but confidence
15:22:26 <dviroel> gouthamr: no, there is no dependency on tempest
15:23:00 <dviroel> the tempest patch is posting the results for Dummy and Container, with the new share server migration tests
15:23:13 <tbarron> ^^^ that's my point
15:23:32 <tbarron> so we don't merge them until that and core are "settled"
15:23:33 <dviroel> andrebeltrami will provide a new PS for tempest soon, to address some changes in the core patch
15:23:50 <tbarron> but I think they look pretty good
15:25:05 <dviroel> we also updated the NetApp driver implementation and I'll wait the new tempest PS to trigger the CI again
15:25:05 <gouthamr> good stuff, not sounding like these are being rushed - the new patches are due to some changes to API responses that were discussed yesterday
15:25:50 <tbarron> i've been following along on the core stuff as best i'm able but the truth is that we're relying on gouthamr's review there
15:26:12 <tbarron> it's a shame we have no reviews from the other back ends who could use this
15:26:16 <tbarron> or customers
15:26:55 <gouthamr> +1
15:26:56 <tbarron> it's hard to get reviews for big patches from people who don't have 'skin in the game' and who have other demands
15:27:44 <tbarron> perhaps a ptg topic, will let us get back on topic
15:27:55 <dviroel> ++
15:28:09 <dviroel> lets set this as a ptg topic
15:28:36 <gouthamr> alright, any other concerns regarding this feature?
15:29:11 <dviroel> don't think so
15:29:26 <gouthamr> thanks, lets work on these rebases and final reviews
15:29:47 <gouthamr> we'll talk on #openstack-manila regarding any issues
15:30:00 <gouthamr> next set of changes are in the client, for OSC
15:30:12 <gouthamr> Implement the first half of OSC share snapshots commands: https://review.opendev.org/#/c/738691/
15:30:12 <gouthamr> Implement OSC share quota commands: https://review.opendev.org/#/c/703992/
15:30:23 <gouthamr> maaritamm has been doing some excellent work on this
15:30:37 <gouthamr> dviroel, ty for reviewing and workflowing https://review.opendev.org/#/c/703992/
15:31:07 <dviroel> maaritamm: tks, sorry for taking so long to review it again
15:31:13 <gouthamr> so we're left with https://review.opendev.org/#/c/738691/ ; and it has a couple of minor-ish comments
15:31:29 <maaritamm> hehe, np, thanks for the reviews :)
15:32:10 <maaritamm> gouthamr, I am working on that tonight so should be fixed today
15:33:10 <gouthamr> maaritamm: ack, thank you
15:33:12 <vkmc> maaritamm++
15:33:43 <gouthamr> maaritamm: i'll track it - i've tested your changes - we have atleast one bug in the "openstack share create" wrt create from snapshot, i'm yet to report it
15:34:05 <gouthamr> but your current changes work great! good work
15:35:10 <gouthamr> we will need another reviewer, and this needs to merge today as well in case we need it in the victoria release
15:35:11 <maaritamm> cool, thanks!
15:35:45 <gouthamr> bugfixes however can land later, and be backported - the bug i'm talking about has existed in the ussuri release as well
15:36:18 <gouthamr> :| so we'll fix that up right after and backport it
15:37:18 <gouthamr> i see vkmc and carloss on the etherpad
15:37:40 <gouthamr> can you folks take a look at this share snapshots patch?
15:38:06 <carloss> sure
15:38:18 <gouthamr> great, thanks
15:38:33 <gouthamr> next up: "[NetApp] Add support for share server migration"
15:38:59 <gouthamr> this needs a rebase and retesting, tbarron's been reviewing this change
15:39:36 <vkmc> sure
15:39:50 <gouthamr> i'll take a look once we have the other migration patches addressed
15:40:09 <dviroel> I sent a update yesterday, that fixes some issues found
15:40:28 <dviroel> will trigger CI again after andrebeltrami upload the tempest update
15:40:34 <gouthamr> okay, so just needs a recheck to get past the focal breakages?
15:40:57 <gouthamr> oh, sure
15:41:15 <dviroel> gouthamr: will do a rebase now
15:41:21 <gouthamr> dviroel: ack, ty
15:41:25 <gouthamr> [NetApp] Enables configuring NFS transfer limits
15:41:40 <dviroel> felipe_rodrigues: o/
15:41:56 <felipe_rodrigues> Y
15:42:04 <dviroel> felipe_rodrigues will upload a new PS in a few minutes
15:42:07 <gouthamr> looks like this one has several comments
15:42:12 <dviroel> to solve the ONTAP version issue
15:42:37 <dviroel> at the end, more code changed was needed to fix it, more than expected
15:43:41 <dviroel> I also made some tests here, and looks good
15:44:01 <gouthamr> okay, lets re-review the change once it has been updated
15:44:18 <dviroel> ack
15:44:20 <felipe_rodrigues> Ack
15:44:29 <gouthamr> [NetApp] Adding support for Adaptive QoS
15:44:46 <gouthamr> okay this one has a +2, needs a CI retrigger?
15:45:53 <dviroel> yes, we can retrigger the CI on this one too
15:46:17 <dviroel> I'll monitor those jobs on our side
15:46:40 <gouthamr> thanks, dviroel - you may see several patches with a -1 from zuul, we had a few issues yesterday
15:47:00 <gouthamr> thanks to gmann for the fixes
15:47:21 <gouthamr> we should be green now, so please recheck if you see any more tox failures
15:47:35 <dviroel> gouthamr: ack
15:47:52 <gouthamr> finally: Manila UI: User Messages Panel
15:48:17 <gouthamr> vkmc's been actively working on this, ty for the reviews carloss
15:48:17 <tbarron> interesting that coverage job is voting for ui
15:48:41 <tbarron> I hadn't noticed that
15:48:51 * gouthamr it was vponomaryov domain
15:49:04 <carloss> np :)
15:49:22 <tbarron> we lost .4% code coverage
15:49:25 <tbarron> .004
15:50:08 <tbarron> priorites :)
15:50:13 <gouthamr> ouch, absolutely
15:50:15 <tbarron> priorities
15:50:26 <tbarron> spelling is a priority
15:51:51 <gouthamr> quite weird that there are no branches in the file that its complaining about either
15:52:32 <gouthamr> our coverage calculations and the standards behind it are not perfect
15:52:42 <tbarron> Can we make this job novoting and merge this?
15:52:47 <tbarron> nonvoting
15:53:13 <tbarron> We can then pay attention to the coverage report when it fails as we do for the other manila components and
15:53:23 <tbarron> use human judgment.
15:53:26 <gouthamr> yeah, i agree
15:53:30 <dviroel> +1
15:53:32 <carloss> I agree with tbarron as well
15:53:52 <gouthamr> okay, tbarron will you make that change?
15:53:57 <tbarron> yes
15:54:14 <gouthamr> thank you
15:54:22 <gouthamr> although, we may have bought ourselves some more time with the UI by changing the release model
15:55:25 <gouthamr> i misremembered and thought we'd be doing a manila-ui release today; but, i'll check with smcginnis - i suspect one isn't needed until the week of the RC
15:55:39 <tbarron> +1
15:56:00 <gouthamr> cool, that's a wrap on the reviews, i'll let you know of changes in #openstack-manila
15:56:33 <gouthamr> we have a busy day as usual, lets be pragmatic however, no need to rush anything in that isn't ready
15:56:42 <tbarron> +1
15:57:06 <gouthamr> and lets be cognizant of reviewers' and contributors' time and time zones :)
15:57:24 <tbarron> I think we have a bunch of stuff that is real close but we should be deliberate
15:57:37 * gouthamr doesn't want to keep maaritamm from her sleep
15:57:54 <tbarron> we have a good PTL who can give a bit more time when needed.
15:58:15 <gouthamr> i've heard :P
15:58:25 <gouthamr> #topic Open Discussion
15:58:36 <gouthamr> we just have a couple of minutes today
15:58:55 <gouthamr> any other concerns today?
15:59:54 <gouthamr> great, lets take any to #openstack-manila
16:00:04 <gouthamr> thank you all for joining..
16:00:07 <gouthamr> #endmeeting