15:00:57 #startmeeting manila 15:00:57 Meeting started Thu Sep 10 15:00:57 2020 UTC and is due to finish in 60 minutes. The chair is gouthamr. Information about MeetBot at http://wiki.debian.org/MeetBot. 15:00:58 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 15:01:00 The meeting name has been set to 'manila' 15:01:04 o/ 15:01:04 o/ 15:01:06 o/ 15:01:10 Hi 15:01:15 o/ 15:01:36 courtesy ping: ganso vkmc lseki tbarron felipe_rodrigues 15:02:06 hi 15:02:08 hello o/ everyone, thank you for joining, here's our agenda for today: https://wiki.openstack.org/wiki/Manila/Meetings#Next_meeting 15:02:20 o/ 15:02:22 we've a few things to cover, so lets get started 15:02:31 #topic Announcements 15:02:57 let me begin with thanks to dviroel for chairing the weekly meeting last week! 15:03:21 a few schedule announcements, 15:03:28 today's feature freeze! 15:03:32 #link https://releases.openstack.org/victoria/schedule.html (victoria release schedule) 15:03:39 :) anytime! 15:04:12 all feature patches must be merged today - and we'll also be requesting a release for python-manilaclient 15:04:33 we'll discuss pending changes in a bit 15:05:04 as you're aware, the Wallaby cycle Virtual PTG is scheduled to Oct 26-Oct 30th 2020 15:05:25 if you haven't already registered for this free virtual event, please do so 15:05:40 #link https://www.eventbrite.com/e/project-teams-gathering-october-2020-tickets-116136313841 (Register for the Wallaby Cycle PTG) 15:06:22 A planning etherpad is up, and i'll post it to the mailing list today 15:06:34 #link https://etherpad.opendev.org/p/wallaby-ptg-manila-planning (Wallaby PTG Planning Etherpad) 15:06:47 o/ 15:07:09 please go ahead and indicate your name, nick, timezone and add topics to the proposed list for discussion 15:07:22 * gouthamr marks vkmc tardy 15:07:44 * vkmc puts on the shame hat 15:07:50 i tried to request the same amount of time as we had last time 15:08:08 #link https://ethercalc.openstack.org/7xp2pcbh1ncb (Draft Schedule for the Wallaby PTG) 15:08:30 please take a look and call out any concerns 15:08:49 are we in two rooms at the same time on Tuesday? 15:09:02 tehre you go :P 15:09:07 not any more 15:09:10 lol 15:09:17 * tbarron stops his cloning operation 15:09:51 two rooms at the same time... I know we are good, but that is far optimistic gouthamr 15:10:06 i suspect there will be some consolidation, don't read too much into the room names yet 15:10:27 vkmc: use the force 15:10:59 🌵 15:11:19 🦘 15:11:21 :P 15:11:44 we will most likely end up with a zoom room as we did last time 15:12:27 awesome, that's all i had in terms of announcements today 15:12:31 anyone else got any? 15:12:54 🦨 15:13:31 * gouthamr that didn't render on my irc client :( 15:13:36 #topic Reviews needing attention 15:14:02 alright lets get into the weeds 15:14:06 #link https://etherpad.openstack.org/p/manila-victoria-review-focus (review focus ether pad) 15:14:54 too many unmerged items at this point, and much of it is due to lack of reviewer attention :( something that has bitten us multiple times in the past 15:15:16 but, we may have some things merged by EOD as planned - lets talk through them 15:15:27 Share Server Migration 15:15:49 dviroel can you give us a status update on this one? 15:16:09 we have 5 patches for this feature 15:16:47 the main patch already got some reviews and we fixed everything so far 15:17:01 we still need more reviews on that in order to merge 15:17:26 we have been fixing some py38 issues today, and we have a +1 on in 15:17:51 gouthamr: what do you think about this specific patch 15:17:54 ? 15:17:57 +1 that certainly helps; not too happy with the CI churn at feature freeze :| 15:18:13 i'll complete my review soon - i think we flushed out the important bits 15:18:17 me neither 15:18:27 gouthamr: awesome 15:18:47 the client patch is also in a good shape I think, all comments solved so far 15:19:30 then we have two first party drivers implementation, Dummy and Container 15:19:32 ack, can you rebase the driver changes? 15:19:40 gouthamr: sure 15:20:03 tbarron already took a look on Dummy, no reviews yet in the container 15:20:05 i think the first party drivers are in pretty good shape but need rebase on the core patch 15:20:19 i've looked at container 15:20:26 tbarron: oh great, thanks 15:21:11 main thing is that all depend (whether or not they say depends-on) a 5-6000 line core patch and the tempest and client patches 15:21:34 true 15:21:42 oh, i hope nothing depends on the tempest patch? 15:21:45 gouthamr has been working these and i'm pretty confident he's doing a great juob reviewing 15:21:54 gouthamr: knowing that they work right 15:22:00 empirically 15:22:09 in addition to code inspection 15:22:19 so not 'depends-on', but confidence 15:22:26 gouthamr: no, there is no dependency on tempest 15:23:00 the tempest patch is posting the results for Dummy and Container, with the new share server migration tests 15:23:13 ^^^ that's my point 15:23:32 so we don't merge them until that and core are "settled" 15:23:33 andrebeltrami will provide a new PS for tempest soon, to address some changes in the core patch 15:23:50 but I think they look pretty good 15:25:05 we also updated the NetApp driver implementation and I'll wait the new tempest PS to trigger the CI again 15:25:05 good stuff, not sounding like these are being rushed - the new patches are due to some changes to API responses that were discussed yesterday 15:25:50 i've been following along on the core stuff as best i'm able but the truth is that we're relying on gouthamr's review there 15:26:12 it's a shame we have no reviews from the other back ends who could use this 15:26:16 or customers 15:26:55 +1 15:26:56 it's hard to get reviews for big patches from people who don't have 'skin in the game' and who have other demands 15:27:44 perhaps a ptg topic, will let us get back on topic 15:27:55 ++ 15:28:09 lets set this as a ptg topic 15:28:36 alright, any other concerns regarding this feature? 15:29:11 don't think so 15:29:26 thanks, lets work on these rebases and final reviews 15:29:47 we'll talk on #openstack-manila regarding any issues 15:30:00 next set of changes are in the client, for OSC 15:30:12 Implement the first half of OSC share snapshots commands: https://review.opendev.org/#/c/738691/ 15:30:12 Implement OSC share quota commands: https://review.opendev.org/#/c/703992/ 15:30:23 maaritamm has been doing some excellent work on this 15:30:37 dviroel, ty for reviewing and workflowing https://review.opendev.org/#/c/703992/ 15:31:07 maaritamm: tks, sorry for taking so long to review it again 15:31:13 so we're left with https://review.opendev.org/#/c/738691/ ; and it has a couple of minor-ish comments 15:31:29 hehe, np, thanks for the reviews :) 15:32:10 gouthamr, I am working on that tonight so should be fixed today 15:33:10 maaritamm: ack, thank you 15:33:12 maaritamm++ 15:33:43 maaritamm: i'll track it - i've tested your changes - we have atleast one bug in the "openstack share create" wrt create from snapshot, i'm yet to report it 15:34:05 but your current changes work great! good work 15:35:10 we will need another reviewer, and this needs to merge today as well in case we need it in the victoria release 15:35:11 cool, thanks! 15:35:45 bugfixes however can land later, and be backported - the bug i'm talking about has existed in the ussuri release as well 15:36:18 :| so we'll fix that up right after and backport it 15:37:18 i see vkmc and carloss on the etherpad 15:37:40 can you folks take a look at this share snapshots patch? 15:38:06 sure 15:38:18 great, thanks 15:38:33 next up: "[NetApp] Add support for share server migration" 15:38:59 this needs a rebase and retesting, tbarron's been reviewing this change 15:39:36 sure 15:39:50 i'll take a look once we have the other migration patches addressed 15:40:09 I sent a update yesterday, that fixes some issues found 15:40:28 will trigger CI again after andrebeltrami upload the tempest update 15:40:34 okay, so just needs a recheck to get past the focal breakages? 15:40:57 oh, sure 15:41:15 gouthamr: will do a rebase now 15:41:21 dviroel: ack, ty 15:41:25 [NetApp] Enables configuring NFS transfer limits 15:41:40 felipe_rodrigues: o/ 15:41:56 Y 15:42:04 felipe_rodrigues will upload a new PS in a few minutes 15:42:07 looks like this one has several comments 15:42:12 to solve the ONTAP version issue 15:42:37 at the end, more code changed was needed to fix it, more than expected 15:43:41 I also made some tests here, and looks good 15:44:01 okay, lets re-review the change once it has been updated 15:44:18 ack 15:44:20 Ack 15:44:29 [NetApp] Adding support for Adaptive QoS 15:44:46 okay this one has a +2, needs a CI retrigger? 15:45:53 yes, we can retrigger the CI on this one too 15:46:17 I'll monitor those jobs on our side 15:46:40 thanks, dviroel - you may see several patches with a -1 from zuul, we had a few issues yesterday 15:47:00 thanks to gmann for the fixes 15:47:21 we should be green now, so please recheck if you see any more tox failures 15:47:35 gouthamr: ack 15:47:52 finally: Manila UI: User Messages Panel 15:48:17 vkmc's been actively working on this, ty for the reviews carloss 15:48:17 interesting that coverage job is voting for ui 15:48:41 I hadn't noticed that 15:48:51 * gouthamr it was vponomaryov domain 15:49:04 np :) 15:49:22 we lost .4% code coverage 15:49:25 .004 15:50:08 priorites :) 15:50:13 ouch, absolutely 15:50:15 priorities 15:50:26 spelling is a priority 15:51:51 quite weird that there are no branches in the file that its complaining about either 15:52:32 our coverage calculations and the standards behind it are not perfect 15:52:42 Can we make this job novoting and merge this? 15:52:47 nonvoting 15:53:13 We can then pay attention to the coverage report when it fails as we do for the other manila components and 15:53:23 use human judgment. 15:53:26 yeah, i agree 15:53:30 +1 15:53:32 I agree with tbarron as well 15:53:52 okay, tbarron will you make that change? 15:53:57 yes 15:54:14 thank you 15:54:22 although, we may have bought ourselves some more time with the UI by changing the release model 15:55:25 i misremembered and thought we'd be doing a manila-ui release today; but, i'll check with smcginnis - i suspect one isn't needed until the week of the RC 15:55:39 +1 15:56:00 cool, that's a wrap on the reviews, i'll let you know of changes in #openstack-manila 15:56:33 we have a busy day as usual, lets be pragmatic however, no need to rush anything in that isn't ready 15:56:42 +1 15:57:06 and lets be cognizant of reviewers' and contributors' time and time zones :) 15:57:24 I think we have a bunch of stuff that is real close but we should be deliberate 15:57:37 * gouthamr doesn't want to keep maaritamm from her sleep 15:57:54 we have a good PTL who can give a bit more time when needed. 15:58:15 i've heard :P 15:58:25 #topic Open Discussion 15:58:36 we just have a couple of minutes today 15:58:55 any other concerns today? 15:59:54 great, lets take any to #openstack-manila 16:00:04 thank you all for joining.. 16:00:07 #endmeeting