15:00:20 <gouthamr> #startmeeting manila
15:00:21 <openstack> Meeting started Thu Sep 24 15:00:20 2020 UTC and is due to finish in 60 minutes.  The chair is gouthamr. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:22 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:24 <openstack> The meeting name has been set to 'manila'
15:00:38 <gouthamr> courtesy ping: ganso vkmc dviroel lseki carloss tbarron andrebeltrami felipe_rodrigues
15:00:39 <dviroel> o/
15:00:43 <vkmc> o/
15:00:47 <andrebeltrami> hello
15:00:53 <vhari> o/
15:00:57 <carthaca> Hi
15:01:07 <felipe_rodrigues> Hi all
15:01:13 <maaritamm> o/
15:01:13 <tbarron> hi
15:01:17 <gouthamr> hello everyone o/
15:01:45 <gouthamr> thanks for joining, here's the meeting agenda for today: https://wiki.openstack.org/wiki/Manila/Meetings#Next_meeting
15:02:01 <gouthamr> #topic Announcements
15:02:27 <gouthamr> the victoria cycle release candidate is due today
15:02:50 <gouthamr> we've already published one for manila-ui, and we'll discuss what's needed for manila in a bit
15:02:54 <gouthamr> #link https://releases.openstack.org/victoria/schedule.html (victoria release schedule)
15:03:54 <gouthamr> after we publish this RC; we'll officially open up the wallaby development cycle, and un-wip any patches we may be holding off
15:04:39 <gouthamr> 'ts also election season in openstack land
15:04:42 <gouthamr> #link http://lists.openstack.org/pipermail/openstack-discuss/2020-September/017306.html
15:05:36 <gouthamr> if you're interested in contesting to the TC and the manila PTL roles, this is your opportunity to do so!
15:05:38 <gouthamr> #link http://lists.openstack.org/pipermail/openstack-discuss/2020-September/017493.html
15:07:06 <gouthamr> if you're considering running for PTL, please do let me know :) i don't feel tired of it yet, but i don't want to assume a permanent role either :D
15:07:53 <gouthamr> ofcourse we have the option of switching leadership to the newly published guidance on distributed project leadership -
15:08:06 <gouthamr> #link https://review.opendev.org/744995/ (Resolution to define distributed leadership for projects)
15:08:26 <vhari> gouthamr++ :)
15:09:44 <gouthamr> as you're reviewing and committing RC changes, you may be aware that our voting LVM job is broken
15:10:23 <gouthamr> we discussed this here in the past - the base job that it depends on has been switched to focal fossa - and there are a number of issues identified
15:10:40 <gouthamr> we have a high
15:10:45 <gouthamr> prio bug:
15:10:55 <gouthamr> #link https://bugs.launchpad.net/bugs/1896672
15:10:56 <openstack> Launchpad bug 1896672 in OpenStack Shared File Systems Service (Manila) "Ubuntu Focal: manila-tempest-plugin-lvm | zfsonlinux | cephfs-nfs | generic | glusterfs-nfs jobs failing" [High,New]
15:11:49 <gouthamr> the bug has a fix, but is stuck due to dependency issues
15:11:55 <gouthamr> #link https://review.opendev.org/743134/
15:12:00 <gouthamr> s/fix/workaround
15:13:13 <gouthamr> hold off from workflowing or rechecking failing patches while this hasn't merged..
15:13:17 <gouthamr> lets wrap up announcements and discuss this alongside reviews
15:13:26 <gouthamr> does anyone else have any announcements to make?
15:14:52 <gouthamr> lets move on to the reviews
15:14:56 <gouthamr> #topic Reviews needing attention
15:15:20 <gouthamr> first off, i'd like to acknowledge a few things
15:15:39 <gouthamr> thanks to vhari and vkmc for putting together and driving the bugsquash early this week
15:16:05 <gouthamr> and to everyone that toiled through the week to fix bugs and commit reviews
15:16:47 <gouthamr> i know a few things got pushed to wallaby - but i had a good feeling knowing that each bug was carefully deliberated upon!
15:17:11 <dviroel> vhari++ vkmc++
15:18:34 <gouthamr> no high prio bugs are pushed out, and many of the issues we're retargeted might eventually be backported to the victoria release
15:18:54 <gouthamr> anything else to add to the bugsquash?
15:19:02 <gouthamr> s/to/regarding
15:20:01 <gouthamr> cool, lets bring out our review focus etherpad
15:20:04 <gouthamr> #link https://etherpad.opendev.org/p/manila-victoria-review-focus
15:20:48 <gouthamr> we'll try and get the gate issue addressed asap - but, lets take a look at these changes
15:21:08 <gouthamr> and i'd like to discuss if they're ready or will need some more work
15:21:45 <gouthamr> Totalcount returned by pagination query is wrong
15:21:53 <gouthamr> #link https://review.opendev.org/#/c/703025/
15:22:16 <gouthamr> the last update didn't pass CI
15:23:20 <gouthamr> and honestly, i misunderstood the author's original intent - i'll take a look at why the unit tests are failing; it's possible there are some mocks that are now incorrect due to changes
15:25:10 <dviroel> gouthamr: ping me if you need any help on this one
15:25:13 <gouthamr> we do intend to backport this change to older supported branches
15:25:29 <gouthamr> dviroel: ack, will do right after this meeting
15:26:42 <gouthamr> it feels like it touches more than the "with_count" query of the /shares API - so we might need to drop unrelated modifications in this patch if they still remain
15:27:18 <gouthamr> so we'll follow up on this one today
15:27:30 <gouthamr> Add generic fuzzy matching logic to the database layer
15:27:37 <gouthamr> #link https://review.opendev.org/#/c/734041/
15:29:30 <gouthamr> as the commit message suggests it alters the "like" and "in" queries
15:30:23 <gouthamr> and there's changes mixed in here too - pagination optimization for the snapshots API is being committed in the same change
15:31:25 <gouthamr> it's extremely helpful if changes were either more atomic, or complete
15:31:42 <gouthamr> both these that we've discussed so far are neither
15:31:57 <gouthamr> and that's a challenge to reviewers (and possibly the authors as well)
15:32:51 <gouthamr> any thoughts on this?
15:34:12 <gouthamr> i'll round up on this one as well once we've fixed our gate issues
15:34:25 <gouthamr> #link https://review.opendev.org/#/c/753315/  ([NetApp] Improve Adaptive QoS functionality)
15:34:36 <gouthamr> ^ nothing to discuss here, it's stuck at the gate
15:34:43 <dviroel> :)
15:34:51 <gouthamr> #link https://review.opendev.org/#/c/749173/ (Fix logic that determines a share exists before manage)
15:34:54 <gouthamr> ^ same status
15:35:09 <gouthamr> #link https://review.opendev.org/#/c/741588/ (fix delete/unmange share with manage_error status will lead to quota error)
15:36:08 <gouthamr> this one hasn't gotten reviews
15:37:29 <gouthamr> i see state changes, we'll need to evaluate it thoroughly
15:38:15 <gouthamr> any thoughts here?
15:38:49 <gouthamr> ah, the state changes will fail tempest
15:38:53 <gouthamr> https://review.opendev.org/#/c/741929/
15:40:12 <gouthamr> i think we can push this one out and note the lack of review attention - the API changes for one will need to be vetted
15:40:40 <gouthamr> any objections?
15:40:54 <dviroel> no, agree
15:41:38 <gouthamr> okay, lets hold off on this -
15:41:53 <dviroel> I'd like to see a new tempest test for this change also, not only deleted a test..
15:41:59 <gouthamr> +1
15:41:59 <dviroel> if possible
15:42:23 <gouthamr> no i agree, we should be testing this end to end
15:42:52 <dviroel> yes
15:43:16 <gouthamr> that's the end of the list
15:43:31 <gouthamr> #link https://launchpad.net/manila/+milestone/victoria-rc1 (bugs targeted to RC1)
15:44:20 <gouthamr> a few doc bugs interspersed in there, if you see any that's assigned to you and you have no patch in progress
15:44:27 <gouthamr> please retarget it to wallaby-1
15:45:22 <gouthamr> great, we've some things to follow up on, i'll be pinging people to review stuff when the gate is in a better shape
15:46:17 <gouthamr> okay, any other concerns regarding the RC?
15:46:58 <gouthamr> great, lets move on ..
15:47:08 <gouthamr> #topic Bugs (vhari)
15:47:23 <vhari> o/
15:47:24 <gouthamr> o/ vhari - anything we need to look at today?
15:47:33 <vhari> gouthamr, have one bug to triage today
15:47:35 <vhari> #link https://bugs.launchpad.net/manila/+bug/1896949
15:47:36 <openstack> Launchpad bug 1896949 in OpenStack Shared File Systems Service (Manila) "NetApp driver is not applying the access rules for the promoted replica using CIFS" [Undecided,New]
15:48:04 <dviroel> oh
15:49:16 <dviroel> i would say wallaby-1 to this one
15:49:17 <gouthamr> okay, there's a sane (but annoying) workaround
15:49:48 <dviroel> which one?
15:50:22 <dviroel> reapply the rules?
15:50:30 <gouthamr> since netapp supports DR, users will be able to mount the secondary only after a promotion - so the workaround that felipe's posted shouldn't be too hard to do
15:50:32 <gouthamr> yes
15:51:27 <gouthamr> i don't debate the bug, it breaks the optimization that we had: replication preserves access rules and applies them automatically on promotion
15:51:53 <dviroel> the fix is also very simple
15:52:11 <dviroel> but we still have the CI and QA to do
15:52:28 <gouthamr> so i think this is a low; can bump to medium if you think this breaks something huge - i can't see what
15:52:50 <dviroel> yes can be low
15:52:58 <gouthamr> great, ty dviroel
15:53:14 <vhari> gouthamr, that's a wrap for bugs
15:53:29 <gouthamr> felipe_rodrigues: feel free to assign to yourself (or to dviroel)
15:53:35 <gouthamr> vhari++ thank you, vida
15:53:42 <gouthamr> #topic Open Discussion
15:53:44 <felipe_rodrigues> Ok. Ty!
15:54:07 <dviroel> gouthamr: already did
15:54:11 <gouthamr> felipe_rodrigues: any update on https://review.opendev.org/753448/ ?
15:54:12 <dviroel> for felipe_rodrigues  :)
15:54:44 <gouthamr> felipe_rodrigues: is it something you were working on for wallaby?
15:55:15 <gouthamr> also is it only python3.7?
15:56:00 <felipe_rodrigues> Yeah.. it is only for 3.7 and higher
15:56:07 <tosky> just quick reminder for the only remaining legacy job (build images); it is not based on devstack-gate, so less critical, but still :)
15:56:54 <gouthamr> felipe_rodrigues: ah - so were you expecting to get it merged today?
15:57:15 <felipe_rodrigues> The idea is leaving this change for future.. I upload the patch to see running on CI
15:57:17 <gouthamr> tosky: ty for the reminder, haven't looked at it in a while, will have tbarron help with that
15:57:37 <tbarron> heh
15:57:46 <tbarron> sure
15:58:01 <gouthamr> felipe_rodrigues: okay, ty for the update
15:59:04 <gouthamr> tbarron: https://review.opendev.org/#/c/746565/
15:59:58 <gouthamr> tbarron: i didn't check why the build broke - i'm investigating here: https://review.opendev.org/#/c/754126/
16:00:11 <gouthamr> --time check---
16:00:19 <tbarron> gouthamr: cool, this one wasn't on my radar
16:00:31 <gouthamr> thanks all for joining, and for your hard work on the RC - we'll chat on #openstack-manila
16:00:39 <gouthamr> and get this wrapped up :)
16:00:47 <gouthamr> see you all here next week.
16:00:50 <gouthamr> #endmeeting