15:01:01 #startmeeting manila 15:01:01 Meeting started Thu Nov 18 15:01:01 2021 UTC and is due to finish in 60 minutes. The chair is gouthamr. Information about MeetBot at http://wiki.debian.org/MeetBot. 15:01:01 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 15:01:01 The meeting name has been set to 'manila' 15:01:05 o/ 15:01:08 o/ 15:01:09 o/ 15:01:14 hi 15:01:26 o/ 15:01:27 o/ 15:01:35 courtesy ping: ganso vkmc dviroel tbarron felipe_rodrigues ecsantos 15:01:38 o/ 15:01:41 o/ 15:01:42 o/ 15:01:54 \o 15:01:54 o/ 15:02:00 o/ 15:02:25 hello everyone, thank you for joining 15:02:35 here's our agenda: https://wiki.openstack.org/wiki/Manila/Meetings#Next_meeting 15:02:51 lets begin with : 15:02:55 #topic Announcements 15:03:15 o/ 15:03:27 we're at M-1! 15:03:53 o/ 15:03:56 its been a breeze, but we're already a quarter of the way through this development cycle 15:04:27 if you had any targeted items that won't merge by the end of the week, please move these to m-2 15:04:48 #link https://launchpad.net/manila/+milestone/yoga-1 15:05:46 a lot of in-progress patches there; if your patch is stuck waiting on reviews, please gather some reviewers and reach out to them on #openstack-manila 15:07:00 next week is a holiday week in some countries, so i was wondering if there's any interest in having a meeting? 15:07:36 if not, we could skip the irc meeting and keep in touch over the IRC channel or the mailing list 15:08:04 any objections? 15:09:19 awesome :) Happy thanksgiving in advance; don't count calories 15:09:38 that's the couple of announcements i had for today, anyone else got any? 15:10:42 Hi goutham and all! 15:10:46 woah 15:11:02 andrebeltrami :D 15:11:19 I would like to say that I back to FIT/Netapp, it's a pleasure to be here again :D 15:11:34 Welcome back, andrebeltrami :) 15:11:34 *pumps fist in air* 15:11:37 good to have you back 15:11:39 welcome back, andrebeltrami 15:11:56 welcome back andre, glad to have you back with us! :D 15:11:59 we've missed you 15:12:21 thank you guys, I missed all of you also! 15:12:26 welcome back 15:12:28 * gouthamr nobody tell him about us blaming all the broken code on him, we'll do it slowly 15:12:44 omg hahaha 15:13:12 hi 15:13:28 we've missed you also, tbarron :D 15:13:34 :) 15:13:50 andrebeltrami++ 15:14:09 welcome!!! 15:15:03 thanks tbarron and caiquemello o/ 15:15:40 great, thanks for popping in and sharing the good news andrebeltrami 15:15:43 any other announcements? 15:16:14 #topic Bugsquash! 15:16:57 carloss introduced the bug squash to you all last week; vhari and him have been making some more plans 15:18:18 gouthamr, ack there is a list of bugs for preview 15:18:35 here https://ethercalc.openstack.org/wvb2oa23rxbb 15:18:38 vhari++ 15:19:36 we like to focus on new bugs first and work our way down to 'in progress' 15:19:37 vhari++ 15:20:31 great; that's a pretty neat list 15:20:42 thanks for putting it together vhari 15:20:43 cool .. may need to reassign some of carloss bugs 15:20:53 gouthamr, yw 15:21:44 cool; yes - might apply to the others on the list as well 15:22:12 i'm hoping we can each tackle just one/two bugs and drive the patches to completion during the week 15:22:28 ++ 15:22:40 so, if you see your name on the list, and would like to unassign the bug, please advertise it so you can have someone else pick the bug up 15:23:08 or, if you would like to bring your own bug, feel free 15:23:46 carloss: do we have tentative dates for this? 15:24:46 29-3rd December sounds like a good timeframe 15:25:18 29th Nov - 3rd Dec * 15:26:05 I believe we'd have most of the audience in that week 15:26:16 agreed, should give folks something to look forward to after the break! 15:27:13 any objections? 15:28:13 hearing none; lets do this :) 15:28:17 so, the idea is to do a sync meeting on 29th Nov and 2nd Dec as we've done in the past? 15:28:51 or are you planning differently? 15:29:42 yes, it makes sense 15:29:45 and worked out just fine in the past 15:30:17 we could have a review part for it too... either a collab review or something different 15:30:22 but focused on reviews :) 15:30:51 ++ i think that worked great in the past, and some folks here would appreciate it :) 15:32:10 carloss: lets brainstorm on #openstack-manila and post info to the ML for greater visibility 15:32:50 sure thing gouthamr 15:32:55 thanks, anything else to be said here on $topic? 15:33:51 #topic Reviews needing attention 15:33:59 #link https://etherpad.opendev.org/p/manila-yoga-review-focus 15:34:42 Share and share replica scheduler-hints support along-with new filter (onlyhostFilter) 15:34:42 #link https://review.opendev.org/c/openstack/manila/+/813293 15:34:49 #link https://review.opendev.org/c/openstack/manila/+/817379 15:35:12 thanks for looking haixin; it looks like we're being voluntold for this carloss 15:35:29 :D 15:35:44 oh yes 15:36:09 ashrodri: can you help with these reviews as well? 15:37:47 looks like one of the patches in "Security service update documentation" is WIP 15:38:04 sure! I can take a look 15:38:17 yes, there's actions on me to be taked 15:38:24 thanks to the reviewers 15:38:30 I'll work on the comments asap 15:38:33 thanks ashrodri, carloss 15:39:59 #link https://review.opendev.org/c/openstack/manila/+/784449 (Check project permissions for share replicas) 15:40:03 could use a unit test 15:40:33 early return for _share_replica_update() if there is no active replica --- still WIP 15:40:46 Recyle bin support 15:40:46 #link https://review.opendev.org/q/topic:%22bp%252Fmanila-share-support-recycle-bin%22+(status:open%20OR%20status:merged) 15:41:18 carloss dviroel|lunch: this one is on us 15:41:57 * gouthamr goes well with the pasta dviroel's having for lunch 15:42:26 xD 15:43:17 #link https://review.opendev.org/c/openstack/python-manilaclient/+/816095 (816095: [OSC] Implement share network subnet commands) 15:43:37 thanks for the reviews here fabiooliveira carloss - looks like the next patch is up 15:43:46 * fabiooliveira 👀 15:44:06 ack gouthamr... will do another pass :0 15:44:09 :) * 15:44:23 ++ 15:44:31 #link https://review.opendev.org/c/openstack/python-manilaclient/+/788060 (788060: [OSC] Add missing waiters) 15:44:46 archanaserver ashrodri vkmc: can i assign this to you? :) 15:45:17 sure 15:45:35 sure 15:45:44 great, thank you! 15:46:13 felipe_rodrigues: you've a comment on https://review.opendev.org/c/openstack/python-manilaclient/+/805466 15:46:44 I see 15:46:55 maaritamm's asking if we can make progress and create a new patch for the share group and share group snapshot quotas 15:47:06 so that's your call; let me know 15:47:35 great, we're at the end of the list 15:47:40 ok, I'll take a look 15:47:44 thanks felipe_rodrigues 15:47:56 if i skipped your patch, please speak up now 15:47:58 :) 15:48:20 I could use some reviews on this: https://review.opendev.org/c/openstack/manila/+/806647/9 15:48:45 Ive got another patch in the chamber for some nitpicks, but aside from that Its ready to go 15:49:30 will take a look ashrodri :) 15:49:48 good stuff, feel free to track it with the etherpad 15:50:00 any others? 15:50:15 Add unstable tag on some replication tests | https://review.opendev.org/c/openstack/manila-tempest-plugin/+/814202 15:50:21 already has a +2 15:51:23 vhari lkuchlan perhaps you can help with this? 15:52:02 gouthamr, sure, will take a look 15:52:11 thank you 15:52:33 alright, final minutes of the meeting, lets see if we can triage a bug or two with vhari :) 15:52:35 #topic Bug Triage (vhari) 15:52:58 gouthamr, we had no new bugs this week! 15:53:16 👏 15:53:17 looping this out in case any one wants to take it 15:53:18 #link https://bugs.launchpad.net/manila/+bug/1475351 15:54:02 woah a super old one 15:55:35 but the issue still exists in the main branch https://github.com/openstack/manila/blob/91e7430d97b9f7c427d7a90719f0097d7f0b867a/manila/share/api.py#L1369 15:56:06 https://github.com/openstack/manila/blob/master/manila/db/sqlalchemy/api.py has no method called "snapshot_delete" 15:56:33 * dviroel finished lunch, busy day :P 15:56:46 so this rollback would fail in case the db got deadlocked during the quota creation 15:57:25 reservation* 15:57:35 vhari: this is a fine candidate for the bugsquash 15:57:55 the fix seems simple - if the db object exists, delete it using the right db interface 15:58:03 sweet! will add it to the list 15:58:04 dviroel: hope you saved us some 15:58:27 gouthamr, that's all we have for bugs today 15:58:37 gouthamr: fviroel don't let 15:58:37 awesome ty 15:58:45 #topic Open Discussion 15:59:06 fviroel is a growing boy, can't compete 15:59:52 ++ 16:00:00 alright, lets wrap up here, thank you all for attending! 16:00:10 i'll send the note to the ML regarding not having a meeting next week 16:00:11 andrebeltrami: o/ welcome back, there still some patch that you left open 16:00:24 haha ty dviroel 16:00:38 carloss will share more news on the bug squash 16:00:42 thanks everyone! 16:00:46 #endmeeting