15:00:07 <carloss> #startmeeting manila
15:00:07 <opendevmeet> Meeting started Thu May 12 15:00:07 2022 UTC and is due to finish in 60 minutes.  The chair is carloss. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:07 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:07 <opendevmeet> The meeting name has been set to 'manila'
15:00:24 <gouthamr> o/
15:00:33 <haixin> o/
15:00:34 <carloss> courtesy ping: ganso vkmc dviroel felipe_rodrigues ecsantos vhari fabiooliveira
15:00:39 <vhari> hi
15:00:40 <fabiooliveira> o/
15:00:45 <ckolod> o/
15:01:03 <vkmc> o/
15:01:10 <archanaserver> o/
15:01:40 <felipe_rodrigues> hi
15:01:47 <carloss> Hello everyone! It's good to have you here :D
15:01:55 <carloss> Today's meeting agenda:
15:02:00 <carloss> #link https://wiki.openstack.org/wiki/Manila/Meetings#Next_meeting
15:02:14 <carloss> but before we start with the regular agenda items:
15:02:31 <carloss> I would like to thank you for last week's bugsquash!
15:02:45 <gouthamr> ++
15:02:50 <carloss> we ended up with a couple of patches submitted as well as closure to some stale bugs
15:02:51 <dviroel> o/
15:03:17 <carloss> o/ dviroel :)
15:03:47 <carloss> we still have a couple of changes open for reviews... all of the changes on this list are targeted to z-1
15:03:55 <carloss> #link https://ethercalc.net/41lb87ry2kol
15:04:17 * carloss moved the content to ethercalc.net just in case ethercalc.openstack.org went down in this week interval
15:04:51 <carloss> turns out is still up but will be down in a couple of weeks :/
15:05:28 <gouthamr> RIP ethercalc
15:05:53 <carloss> RIP ethercalc.openstack.org - you've were a good friend
15:06:27 <carloss> now getting back to the regular agenda topics, starting with:
15:06:33 <carloss> #topic Announcements
15:06:34 <gouthamr> unreliable friend
15:06:47 <carloss> hahaha, ++ gouthamr :D
15:06:48 <fabiooliveira> haha
15:06:58 <caiquemello[m]> 0/
15:07:15 <carloss> Z1 Milestone is right around the corner!
15:07:21 <carloss> now for realsies
15:07:26 * carloss isn't willing to scare anyone today
15:07:54 * fabiooliveira isn't he?
15:07:58 <carloss> #link https://releases.openstack.org/zed/schedule.html
15:08:25 <carloss> and with Z-1, we get to the second event we have scheduled for the Zed cycle!
15:08:36 <carloss> our exciting hackaton is back next week! :D
15:08:52 <carloss> Manila Hackathon (May 16th - May 23rd)
15:09:10 <carloss> over PTG we discussed it would be nice to host a hackaton, but the idea was to make it earlier in the cycle
15:09:28 <carloss> the date we came to a conclusion was the Z-1 milestone week
15:09:46 <carloss> the primary focus of this hackaton will be functional testing with OSC
15:10:19 <carloss> maaritamm has groomed some tasks for us and they are available here:
15:10:21 <carloss> #link https://tree.taiga.io/project/gouthampacha-openstack-manila-osc-integration-with-python-manilaclient/kanban
15:11:28 <gouthamr> maaritamm++
15:11:36 <carloss> the new column holds the new tasks - we can distribute the workload over the next week... the idea is to get the most unit tests we can :)
15:11:42 <carloss> it's a huge list as you see
15:12:02 <carloss> we have few examples that can be used as basis for implementation, but I'll be working on more before next week
15:12:09 <carloss> #link https://review.opendev.org/c/openstack/python-manilaclient/+/836834
15:12:25 <carloss> maaritamm++ - thank you for helping to gather the list and create the tasks :)
15:13:00 <carloss> so in the date you can see a peculiarity: it starts in a Monday and ends in a Monday
15:13:09 <carloss> you may ask why
15:13:24 <carloss> this time the idea is to have a different format than we are used to
15:13:47 <carloss> one of the reasons is that most Red Hatters will be off next friday (20th)
15:14:04 <carloss> so we can wrap up on the following Monday
15:14:20 <carloss> the idea for dates I had is:
15:14:27 <carloss> A kick-off on Monday, 15UTC
15:14:38 <carloss> Use the next week's manila meeting slot for a mid-term checkpoint
15:14:54 <carloss> And 30 more minutes on the 23rd (15-15:30 UTC) just to wrap up
15:15:01 <carloss> how does that sound to you?
15:15:14 <felipe_rodrigues> +1
15:15:41 <gouthamr> +1 lets try to do some reviews at the meeting
15:15:42 <fabiooliveira> sounds good
15:15:54 <gouthamr> midpoint meeting*
15:16:11 <caiquemello[m]> +1
15:16:18 <carloss> ++ gouthamr :)
15:17:28 <carloss> great! so I'll send out an email to the mailing list today
15:17:57 <carloss> thank you for the input
15:18:13 <carloss> on to the next topic...
15:18:18 <carloss> oops
15:18:22 <carloss> before I move to the next topic :)
15:18:25 <vkmc> maaritamm++ :) always
15:18:33 <carloss> anyone else has an announcement today?
15:19:53 * carloss taking silence as a no :)
15:20:01 <carloss> now moving to the next topic
15:20:07 <carloss> #topic NDSU/Manila-UI internship wrap up
15:20:26 <carloss> o/ ckolod, shkoh1, sdailey, JonahFisher
15:20:32 <ckolod> o/
15:20:39 <gouthamr> \o/ so we're at the close of the Capstone project internship at NDSU
15:21:01 <gouthamr> and the end of term for these guys, first off, congratulations!
15:21:42 <ckolod> thank you! it's been a long semester
15:21:54 <gouthamr> we had numerous meetings and pair programming sessions through the last three months, and we enjoyed the mentoring experience!
15:22:35 <gouthamr> there are a couple of WIP patches: https://review.opendev.org/c/openstack/manila-ui/+/840326 and https://review.opendev.org/c/openstack/manila-ui/+/839232
15:23:37 <gouthamr> most of the work is complete, need to get zuul happy with some unit tests and such.. thanks for working on these ckolod shkoh1, sdailey, JonahFisher
15:25:14 <ckolod> I've yet to finish cleaning up 840326 due to finals, but I'll get to it
15:25:22 <gouthamr> ++
15:25:23 <ckolod> thanks for mentoring us along the way
15:25:39 <vkmc> ++!
15:25:56 <gouthamr> you're welcome.. i learned many manila-ui things afresh too
15:26:04 <carloss> thank you ckolod, shkoh1, sdailey, JonahFisher for your efforts to implement this change and collaborating with us
15:26:11 <carloss> > you're welcome.. i learned many manila-ui things afresh too
15:26:11 <carloss> ++++
15:26:36 <carloss> I hope this has been a positive experience for you
15:26:45 <carloss> I wish you all the best in your future and be sure that you'll always be welcome in this community!
15:27:33 <ckolod> on behalf of the team, thank you carloss gouthamr vkmc ashrodri
15:27:34 <gouthamr> indeed
15:29:16 <gouthamr> awesome, that's all i had about $topic carloss
15:29:50 <carloss> great, thank you! :)
15:30:48 <carloss> okay, going to the next topic...
15:30:52 <carloss> #topic Review Focus
15:30:56 <carloss> #link https://etherpad.opendev.org/p/manila-zorilla-review-focus (Review Focus Etherpad)
15:31:22 <carloss> I see a couple of changes in the list requiring some reviews
15:31:42 <carloss> but I would like to highlight some that have been up for a while today:
15:31:46 <carloss> Add config option reserved_share_extend_percentage
15:31:50 <carloss> #link https://review.opendev.org/c/openstack/manila/+/832843
15:32:05 <carloss> it is waiting for reviews and we also mentioned this change in last week's bugsquash
15:32:13 <carloss> can I have some volunteers?
15:32:14 <carloss> :)
15:32:45 <felipe_rodrigues> o/
15:33:54 <fabiooliveira> i can take a look also
15:34:01 <felipe_rodrigues> we also need some core reviewers there
15:34:11 <gouthamr> i can take a look
15:34:50 <haixin> i will too :)
15:35:02 <carloss> thank you felipe_rodrigues fabiooliveira gouthamr haixin :)
15:35:25 <carloss> next one I'd like to highlight is:
15:35:28 <carloss> [OSC] Implement Share Server Commands
15:35:34 <carloss> #link https://review.opendev.org/c/openstack/python-manilaclient/+/805107
15:35:47 <carloss> this had a couple of reviews in the past
15:35:57 <carloss> thank you archanaserver for working on this change!
15:36:18 <carloss> I had some time to work on this change over this week and posted some updates, as I promised in the PTG :)
15:36:43 <carloss> addressed reviewers' comments and also fixed other few issues I found
15:37:05 <carloss> CI is green, I did lots of manual testing and didn't catch other issues - but it would be good to have some more eyes looking into this again
15:37:30 * fabiooliveira 👀
15:37:59 <carloss> ecsantos[m] fabiooliveira vkmc can I have your eyes on this again? :)
15:38:30 <fabiooliveira> yes :)
15:38:40 <carloss> maaritamm/gouthamr too if possible :D
15:38:48 <vkmc> carloss, aye
15:39:13 <carloss> > maaritamm/gouthamr too if possible :D
15:39:13 <carloss> as we'll need 2 +2s on that and I became a co-author
15:40:25 <carloss> tyvm fabiooliveira vkmc
15:40:48 <fabiooliveira> my pleasure, caloss
15:40:54 <gouthamr> ack, will take a look at this too
15:41:06 <carloss> thank you gouthamr :)
15:41:18 <carloss> there are a couple more in the queue... I'll recheck them and I can bring up in the next meetings or ping in the change itself :)
15:41:48 <carloss> okay, so those were the changes I wanted to highlight today
15:42:06 <carloss> any other change you'd like to bring our attention to in this meeting? :)
15:43:33 <carloss> taking silence as a no
15:43:44 <carloss> next topic is:
15:43:47 <carloss> #topic Bug Triage (vhari)
15:43:52 <carloss> #link https://etherpad.openstack.org/p/manila-bug-triage-pad-new (Bug Triage etherpad)
15:43:58 <carloss> vhari, floor is yours
15:44:07 <vhari> ty carloss
15:44:21 <vhari> so we had 4 new bugs
15:44:36 <vhari> 1 was fixed, 2 are in progress :)
15:44:44 <vhari> carthaca++ gouthamr++
15:45:12 <vhari> and there is one new bug to triage for today
15:45:22 <vhari> #link https://bugs.launchpad.net/manila/+bug/1972867
15:46:25 <gouthamr> hmm, i do like the solution in https://review.opendev.org/c/openstack/neutron/+/770935
15:47:00 <gouthamr> i thought the intent was different, with every new migration test, we're compounding the number of upgrades/downgrades we're doing
15:47:18 <gouthamr> so bumping timeouts has been a bandaid
15:47:54 <gouthamr> https://review.opendev.org/c/openstack/neutron/+/834746 is super cool too
15:48:24 <gouthamr> although i'll steal that idea for something else; i am not sure we need it for the db tests, uet
15:48:25 <gouthamr> yet*
15:49:10 <gouthamr> i think this is a medium... can be convinced if folks want to go to high because we're wasting CI resources
15:49:16 <carloss> yes - we haven't been hitting this issue much lately
15:49:44 <carloss> > can be convinced if folks want to go to high because we're wasting CI resources
15:49:44 <carloss> ++
15:49:50 <gouthamr> perhaps one in ten test runs?
15:50:00 <vkmc> ++
15:50:08 <gouthamr> which may be annoying since these tests aren't run in isolation... every job has to be re-run
15:50:44 <carloss> > perhaps one in ten test runs?
15:50:44 <carloss> yes, I would say so
15:51:08 <gouthamr> any volunteers that want to evaluate https://review.opendev.org/c/openstack/neutron/+/770935 with our db migration test code?
15:51:24 <felipe_rodrigues> it seems that the fix is given
15:51:27 <felipe_rodrigues> right ?
15:51:53 <carloss> in a sense yes felipe_rodrigues - we'd need to adapt to our scenario
15:52:18 <gouthamr> neutron and manila pioneered with these tests iirc, so the code's a lot similar
15:52:19 <gouthamr> https://opendev.org/openstack/manila/src/branch/master/manila/tests/db/migrations/alembic/test_migration.py#L118
15:52:33 <felipe_rodrigues> I see
15:52:50 <felipe_rodrigues> I can try to fix it
15:53:01 <gouthamr> thanks felipe_rodrigues
15:53:05 <carloss> felipe_rodrigues++ thank you
15:53:20 <felipe_rodrigues> :)
15:53:52 <vhari> ty felipe_rodrigues++
15:53:56 <vhari> next up
15:53:58 <gouthamr> also ralonsoh++ thanks for the pointers
15:54:08 <vhari> #link https://bugs.launchpad.net/manila/+bug/1970649
15:54:35 <gouthamr> ah looks familiar..
15:54:50 <vkmc> felipe_rodrigues++ yay
15:55:40 <gouthamr> the scheduler assumes netapp pools to always be thin provisioned... so it'll _always_ oversubscribe them (unless max_over_subscription_ratio = 1)
15:56:22 <gouthamr> but, the creation request might be a thick provisioning request
15:56:39 <gouthamr> so i think this confuses operators
15:56:54 <gouthamr> why oversubscribe, and then potentially end up failing in the share manager?
15:57:18 <felipe_rodrigues> yeah.. If I remember correctly, there is a customer complaining in the past about it.. And we provide a patch (at least from my mind) covering this issue
15:57:28 <gouthamr> oh?
15:57:52 <gouthamr> felipe_rodrigues: this bug comes from stable/train
15:58:22 <felipe_rodrigues> I need to recheck the patch that we have related to the thin provisioning and the customer email..
15:58:27 <carloss> https://review.opendev.org/c/openstack/manila/+/811417 - wouldn't it be this one felipe_rodrigues
15:58:28 <felipe_rodrigues> you can add me
15:58:31 <gouthamr> would you/anyone from netapp take a look and lets discuss what a good solution should be here.. i think this is more than a UX concern..
15:58:44 <gouthamr> the problem occurs when you have multiple pools
15:59:10 <felipe_rodrigues> Thanks carloss.. that one!
15:59:16 <gouthamr> and the request ends up in the "wrong" pool because of this unneeded oversubscription calculation --- the "wrong" pool has no space, where as there are other pools with capacity
15:59:18 <felipe_rodrigues> yeah it's a different problem here
15:59:43 <gouthamr> time check
16:00:23 <gouthamr> can we tag it medium (because its a netapp issue as of now - other backends don't support "True/False" in the same pool), and assign to you, felipe_rodrigues?
16:00:42 <carloss> ++ on medium
16:00:44 <gouthamr> --time-check--
16:00:46 <felipe_rodrigues> ++ medium
16:01:01 <carloss> we can add a topic for it on next weekly meeting too
16:01:03 <carloss> if needed
16:01:04 <felipe_rodrigues> please, add me.. we'll discuss internally and provide a fix
16:01:13 <carloss> alright folks, thank you for participating on this meeting today!
16:01:25 <carloss> see you in #openstack-manila
16:01:34 <gouthamr> thanks carloss
16:01:45 <carloss> #endmeeting