15:00:38 <carloss> #startmeeting manila
15:00:38 <opendevmeet> Meeting started Thu Jun 30 15:00:38 2022 UTC and is due to finish in 60 minutes.  The chair is carloss. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:38 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:38 <opendevmeet> The meeting name has been set to 'manila'
15:01:15 <gouthamr> o/
15:01:15 <carloss> courtesy ping: ganso vkmc dviroel felipe_rodrigues ecsantos vhari fabiooliveira gouthamr
15:01:16 <felipe_rodrigues> o/
15:01:24 <fabiooliveira> o/
15:01:56 <luizsantos[m]> o/
15:02:00 <nahimsouza[m]> oi
15:02:28 <caiquemello[m]> o/
15:03:10 <dviroel_> o/
15:03:18 <vkmc> o/
15:04:19 <carloss> o/ hi all
15:04:24 <carloss> great to have you here today
15:04:35 <carloss> let's get started with our meeting agenda
15:04:40 <ashrodri> o/
15:04:42 <carloss> #link https://wiki.openstack.org/wiki/Manila/Meetings#Next_meeting
15:05:29 <carloss> #topic Announcements
15:05:40 <carloss> Schedule and Deadlines:
15:05:44 <carloss> #link https://releases.openstack.org/zed/schedule.html
15:06:13 <carloss> we are ~1 month away from our driver deadline
15:07:20 <carloss> and we have one candidate for this release:
15:07:34 <carloss> #link https://review.opendev.org/c/openstack/manila/+/825429
15:08:18 <carloss> fzzf[m] has been working on the driver and the CI
15:09:31 <carloss> the CI seems to be reporting success and the logs are posted there, but apparently the tests are being skipped
15:09:35 <carloss> I'll ask the author
15:10:09 <carloss> but it would be nice if we could start giving some attention to this driver now, to have some anticipated feedback
15:10:31 <dviroel_> +1
15:11:49 <gouthamr> ++
15:12:37 <carloss> I have added it to our review focus etherpad
15:12:46 <carloss> can I have some eyes on this?
15:13:03 <carloss> I can be one of the reviewers
15:13:38 <carloss> gouthamr, dviroel_
15:13:51 <carloss> also would be nice to have some NetAppers eyes
15:14:01 <carloss> to help with other third party driver being added
15:14:13 <carloss> felipe_rodrigues ecsantos[m] sfernand
15:14:39 <gouthamr> carloss: ack, can do
15:14:46 <felipe_rodrigues> ack
15:16:37 <dviroel_> me too
15:18:06 <carloss> thank you folks
15:18:45 <carloss> that's all I had for announcements
15:18:55 <carloss> is there any other announcement you would like to share with us today?
15:20:27 * carloss will take that as a no
15:20:39 <carloss> #topic Rechecks without reason/comments
15:21:10 <carloss> I briefly talked about this over the PTG where in a call the TC was chatting with the community about some rechecks without further comments
15:21:44 <carloss> they were trying to get us to spread with the community that it is important to add a comment to our rechecks
15:22:30 <carloss> it helps to make a bit more understandable why we are doing some rechecks
15:23:18 <carloss> and thinking more before actually triggering it
15:23:55 <carloss> this surfaced because we have lots and lots of jobs being run for every repository and sometimes our jobs fail due to lack of memory
15:24:23 <carloss> lack of memory which causes rabbit and mysql to fail as side effect
15:24:56 <carloss> so the whole point is to try to reduce the amount of jobs being run so everyone can get clean runs and CI won't have that many jobs running at the same time
15:25:29 <carloss> you may have seen an email from the openstack-discuss mailing list earlier today
15:25:33 <gouthamr> the stats are interesting
15:25:34 <carloss> #link http://lists.openstack.org/pipermail/openstack-discuss/2022-June/029342.html
15:25:41 <carloss> they shared some stats with us :)
15:25:53 <gouthamr> apparently we had 160 rechecks in the last 30 days
15:27:12 <gouthamr> and 108 of them we didn't provide a reason..
15:27:13 <carloss> yep - that leaves us with a 67.5 rate of what they call "bare rechecks"
15:28:01 <gouthamr> i doubt this number a bit, but a bunch of this is probably our current issues with the stable branches
15:29:27 <gouthamr> but, point taken - we should triage the failure and recheck with reason
15:29:48 <felipe_rodrigues> I have never added the reason, btw :/
15:30:01 <gouthamr> fire this guy ^
15:30:11 <carloss> lol
15:30:25 <felipe_rodrigues> sorry
15:30:31 <caiquemello[m]> hahaha
15:31:32 <carloss> no problem, felipe_rodrigues - I have to confess that I used to do not add messages to the rechecks
15:31:37 <carloss> I've been doing it lately
15:32:04 <carloss> the only type of rechecks with messages that won't work are the experimental ones (I hit that issue some times)
15:33:01 <carloss> but yeah, only wanted to bring that up today to talk a bit again about those stats and the reasons why people are caring about those rechecks
15:33:51 <carloss> on to the next topic...
15:33:57 <carloss> #topic Review Focus
15:34:02 <carloss> #link https://etherpad.opendev.org/p/manila-zorilla-review-focus (Review Focus Etherpad)
15:34:19 <carloss> one of the changes of the review focus we have already talked about (the new driver)
15:34:45 <carloss> we have recently merged some code for OSC functional tests as well, so other changes may need a rebase
15:36:01 <carloss> we also have ashrodri's metadata api changes
15:36:22 <carloss> #link https://review.opendev.org/c/openstack/manila/+/825008 (Metadata for Share Snapshots Resource)
15:36:35 <carloss> thank you for the reviews felipe_rodrigues
15:36:46 <gouthamr> felipe_rodrigues++ thanks; /me will review this one today
15:36:50 <carloss> I will get back to that change, but as far as I've seen, it was looking good on the last time
15:37:02 <ashrodri> hey! yeah the snapshots metadata changes are still up for review. I recently added some share access rules ones im working though test failures on
15:37:21 <felipe_rodrigues> I promise review until Friday
15:37:42 <gouthamr> felipe_rodrigues: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/827925 -- you asked about the tests on your review; they're here
15:37:56 <felipe_rodrigues> all.. that's too long away
15:38:18 <felipe_rodrigues> I thought is another patch
15:39:09 <felipe_rodrigues> I already gave my +1.. I just asked to know
15:39:22 <felipe_rodrigues> it's fine to me!
15:39:28 <carloss> cool :)
15:39:37 <carloss> thanks
15:39:47 <carloss> is there any other change you would like to highlight?
15:39:55 <gouthamr> yes
15:40:09 <gouthamr> i wanted to see if we could review-jam some of the OSC changes
15:40:28 <gouthamr> #link https://review.opendev.org/c/openstack/python-manilaclient/+/836239
15:40:28 <gouthamr> #link https://review.opendev.org/c/openstack/python-manilaclient/+/838233
15:40:28 <gouthamr> #link https://review.opendev.org/c/openstack/python-manilaclient/+/802791
15:40:28 <gouthamr> #link https://review.opendev.org/c/openstack/python-manilaclient/+/816401
15:40:28 <gouthamr> #link https://review.opendev.org/c/openstack/python-manilaclient/+/805107
15:41:23 <gouthamr> and ashrodri carloss maaritamm ecsantos[m] felipe_rodrigues, fix the merge conflicts here: https://review.opendev.org/q/topic:osc-functional-tests+status:open
15:42:25 <felipe_rodrigues> ack
15:42:40 <carloss> sure gouthamr
15:42:56 <ashrodri> will do :)
15:44:05 <carloss> awesome
15:44:29 <gouthamr> ++ thank you
15:44:39 <carloss> thanks for sharing these, the OSC parity is quite close, let's make this final push to get the remaining commands
15:44:46 <gouthamr> i guess we spoke about co-authors and reviewers for the code patches above
15:44:59 <carloss> ++ - we have that on the PTG notes
15:46:01 <gouthamr> ah true
15:46:10 <gouthamr> thanks for the pointer, i'd forgotten where we'd noted these
15:46:12 <gouthamr> #link https://etherpad.opendev.org/p/zorilla-ptg-manila-osc
15:46:33 <carloss> yep, this one
15:46:34 <carloss> thanks
15:46:39 <gouthamr> so its mostly myself, carloss vkmc and maaritamm
15:47:00 <gouthamr> guess we certainly could use some help!
15:47:33 <gouthamr> so if you've some bandwidth this week, please help..
15:49:08 <carloss> ++
15:50:06 <gouthamr> that's all i wanted to highlight
15:50:10 <carloss> thanks gouthamr :D
15:50:16 <gouthamr> nope, thanks for the reviews!
15:50:57 <carloss> #topic Bug Triage
15:51:05 <carloss> I think we still have some minutes for some bug triage
15:51:20 <carloss> #link https://etherpad.openstack.org/p/manila-bug-triage-pad-new (Bug Triage etherpad)
15:51:37 <carloss> vhari couldn't be here with us today, but kindly gathered the list for us to talk
15:51:44 <carloss> we have two stale bugs to talk about today
15:51:46 <carloss> #1
15:52:06 <carloss> #link https://bugs.launchpad.net/manila/+bug/1585241 (Share Replication: File-based locks don't provide concurrency control in multi-node/multi-AZ deployments Edit)
15:52:28 * carloss : please ignore the edit at the end of the title
15:53:07 <carloss> this has been up for a while - is this in your future plans gouthamr?
15:53:38 <gouthamr> ah, this one is still an issue … we could bump down the importance; the fix is relatively simple but hasn’t been a priority
15:54:19 <gouthamr> We need to switch out the Oslo concurrency locks in the share manager with tooz locks (which we have the code for)
15:54:37 <gouthamr> hasn’t been a user concern though - just tech debt
15:55:10 <gouthamr> let’s bump this down to low and set a target - perhaps z3
15:55:20 <carloss> sure gouthamr - thanks
15:55:34 <carloss> done
15:55:41 <carloss> agree with you on that
15:56:06 <carloss> cool, bug #2
15:56:26 <carloss> #link https://bugs.launchpad.net/manila/+bug/1866951 ([db] default value for project_only allows non-secure access )
15:57:51 <gouthamr> haha - both that im procrastinating on
15:58:40 <gouthamr> So this is a wishlist bug … we had a CVE that allowed cross project resource access; and someone suggested this as an alternative
15:59:24 <gouthamr> we could change the default and see if any existing regression tests catch anything
16:00:09 <gouthamr> anyone interested in picking this up as a low-hanging-fruit?
16:00:32 <carloss> cool one to work on :)
16:01:15 * carloss checks time
16:01:45 <carloss> thanks for mentioning the context on the issue gouthamr
16:01:51 <carloss> we can link the minutes of this call to  the bug too
16:02:01 <carloss> and if there is someone willing to pick it up, pleas let us know
16:02:07 <gouthamr> ++
16:02:10 <carloss> or just update the assignee on launchpad :p
16:02:15 <carloss> alright, we are 2 minutes over
16:02:21 <carloss> thank you all for joining this meeting today
16:02:33 <carloss> let's continue on #openstack-manila
16:02:35 <carloss> o/
16:02:39 <gouthamr> thanks carloss
16:02:41 <carloss> #endmeeting