15:00:41 <carloss> #startmeeting manila
15:00:41 <opendevmeet> Meeting started Thu Sep  1 15:00:41 2022 UTC and is due to finish in 60 minutes.  The chair is carloss. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:41 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:41 <opendevmeet> The meeting name has been set to 'manila'
15:00:55 <dviroel> o/
15:00:58 <felipe_rodrigues> hi
15:01:03 <carloss> courtesy ping: vkmc ecsantos vhari
15:01:25 <vkmc> o/
15:02:02 <haixin> o/
15:02:07 <vhari> o/
15:02:13 <chuanm> o/
15:02:32 <sfernand> hi
15:02:33 <ecsantos[m]> o/
15:02:39 <HelenaDantas[m]> hi
15:03:20 <nahimsouza[m]> o/
15:03:39 <carloss> o/
15:03:44 <carloss> hello everyone
15:04:06 <carloss> happy feature freeze day! xD
15:04:22 <carloss> let's get started
15:04:28 <carloss> #link https://wiki.openstack.org/wiki/Manila/Meetings#Next_meeting
15:04:36 <carloss> ^ our agenda for today's meeting
15:05:34 <carloss> let's start with our announcements
15:05:39 <carloss> #topic Announcements
15:05:48 <carloss> Schedule and Deadlines:
15:05:54 <carloss> #link https://releases.openstack.org/zed/schedule.html
15:06:19 <carloss> this is feature freeze week
15:06:48 <carloss> we have a couple of changes that have the review process ongoing, but we will get to them
15:06:59 <carloss> for the manila core changes, we can discuss feature freeze exceptions
15:07:09 <carloss> for the client ones, is a bit more complicated :)
15:07:51 <carloss> the idea we have is to have all of the client changes merging by EOD and we can get our *already kind of late* release patch merged tomorrow
15:08:01 <caiquemello[m]> o/
15:08:58 <carloss> so you might be seeing some movement in a bunch of changes
15:09:15 <carloss> that's basically us in a hurry to try to get everything in and finally claim feature parity in our OSC
15:09:32 <carloss> we'll discuss further the reviews in a bit
15:09:48 <carloss> and the changes that might need a feature freeze exception
15:10:21 <carloss> and I would like to thank ashrodri for running last week's meeting when I was on PTO!
15:10:23 <carloss> ashrodri++
15:10:41 <carloss> and also, thank you for bringing up the details on the upcoming bugsquash
15:11:04 <carloss> that's all I had for $topic
15:11:13 <carloss> do you have an announcement to share with us today? :)
15:13:18 <ecsantos[m]> I have one o/
15:13:30 <carloss> please go ahead ecsantos[m]
15:13:38 <ecsantos[m]> Today I joined the cloud build team at Red Hat :)
15:13:45 <ecsantos[m]> Which unfortunately means that I'll be no longer as active here as I once was :/
15:13:56 <ecsantos[m]> Working with Caique, Carlos, Douglas, Felipe, Fernando and co. was an amazing experience, and I'll be forever grateful to this community for everything I learned while here, I really felt welcome here in the Manila project
15:14:01 <ecsantos[m]> I hope I can help out with some reviews once I'm all set up in the new job. I'll try to always keep an eye here and keep in touch! ;)
15:14:35 <carloss> congratulations ecsantos[m]! and welcome to RH
15:14:51 <carloss> the best of luck for you in your new role
15:15:03 <dviroel> ecsantos[m]: awesome, wish you all the best o/
15:16:40 <nahimsouza[m]> congratulations Eduardo, good luck in your new role :)
15:17:25 <caiquemello[m]> ecsantos: congratulations, and good luck!
15:18:35 <carloss> alright, is there another announcement to be shared today?
15:18:49 <sfernand> wish you the best eduardo! Good look on your new job.
15:19:02 <sfernand> :)
15:19:59 <carloss> cool, on to the next topic
15:20:07 <carloss> #topic Review Focus
15:20:14 <carloss> #link https://etherpad.opendev.org/p/manila-zorilla-review-focus (Review Focus Etherpad)
15:20:43 <carloss> so there has been some reorganization on this etherpad
15:21:20 <carloss> with that I mean: I tried to move changes around and at the top are the changes that would be eligible for feature freeze and that needs our attention now
15:22:27 <carloss> the changes on "Eligible for feature freeze" are either the client ones or new features being added
15:22:40 <carloss> all of those at the top would be eligible for feature freeze if needed
15:24:06 <carloss> looking at changes one by one:
15:24:32 <carloss> https://review.opendev.org/c/openstack/manila/+/825008 - Metadata API
15:25:07 <carloss> ashrodri has been working on this change and some comments were addressed recently. The filters issue seem to be fixed now but I see pep failing on zuul
15:25:21 <carloss> we need more eyes on this change, but the comments present there were addressed since yesterday
15:25:46 <carloss> the client is pending a rebase, and in this case we should not merge the client without merging the core feature
15:27:43 <carloss> the client changes should be merged tomorrow tops
15:28:31 <carloss> so I'm in favor of giving the core change a couple of extra days so we can have even more eyes and close the final bits
15:28:53 <carloss> and the client change will possibly need to slip for next cycle
15:29:12 <carloss> I think the same goes for share transfer
15:29:32 <carloss> #link https://review.opendev.org/c/openstack/manila/+/843832 Share transfer between projects
15:29:55 <carloss> the client is still WIP
15:30:41 <carloss> we have taken this approach before with other changes. Of course is not ideal, but it allows us to at least ship the changes from the core and then people can consume the client in later versions
15:30:51 <carloss> the APIs will be there and the feature will be usable
15:30:52 <haixin> client can be used to test transfer now, just miss unit test.
15:31:10 <carloss> thanks for the changes and for being so responsive haixin
15:32:41 <carloss> so, what I'd say is: the client for share transfer and metadata API will only be merged over the next release
15:33:01 <carloss> but we will make an effort for the core changes to get in this cycle
15:33:28 <carloss> we can buy one more week for the core of those
15:33:49 <carloss> does anyone oppose to this approach?
15:35:12 <felipe_rodrigues> +1
15:36:54 <carloss> okay, let's follow with this approach then
15:37:06 <carloss> another candidate for FFE:
15:37:29 <carloss> #link https://review.opendev.org/c/openstack/manila/+/848987 CephFS/NFS: Refactor the Ceph NFS driver to use Cephadm NFS
15:38:12 <carloss> vkmc has responded to gouthamr's latest comments and I like the direction of the change and expressed my intention to merge with a +2
15:38:44 <carloss> though I would say that the people with the most knowledge on the CEPH drivers are vkmc herself and gouthamr :p
15:39:22 <vkmc> :D
15:39:30 <carloss> the change is not too big in terms of lines of code. It brings good advantages and would be great to have this in
15:40:20 <carloss> gouthamr expressed he'd be in favor of an FFE for this in the etherpad
15:41:16 <carloss> I'd vote for it as well, but I think this is really close
15:41:32 <carloss> I see a WIP in the commit message for coverage, and I'm fine with it
15:41:36 <vkmc> I want to add some more extra tests to get the cover gate passing
15:41:48 <vkmc> run locally the integration suite (both api and scenario) and is passing
15:41:57 <vkmc> and do a bunch of manual testing and is working as expected
15:42:29 <carloss> even in case the code coverage doesn't come until the next week, we can address this kind of thing in a follow-up change
15:42:32 <carloss> we have done this in the past
15:42:36 <vkmc> given this is adding a new helper, we can continue testing and add fixes during RC
15:42:51 <vkmc> but this won't impact on current driver implementation
15:43:04 <vkmc> so I'd say is a low risk to get this in
15:43:27 <carloss> I agree vkmc
15:43:40 <carloss> thanks for pursuing the coverage for both code and functional :)
15:43:55 <carloss> and even if we come to find a small bug, that can be addressed before RC
15:43:58 <carloss> so no worries
15:45:21 <carloss> okay, so we have three candidates for FFEs
15:45:21 <carloss> Snapshot Metadata APIs from ashrodri
15:45:21 <carloss> Share transfer from haixin
15:45:21 <carloss> And the CEPH driver changes from vkmc
15:45:56 <vkmc> thanks for following up carloss :)
15:46:05 <carloss> the normal procedure would be to have the emails requesting the FFEs to openstack-discuss
15:46:44 <carloss> I've seen our neighbors taking a different approach (sending an email to extend FF deadline by 1 week)
15:48:14 <carloss> I can write up an email mentioning this three changes and buying us one extra week
15:48:39 <carloss> so we avoid a zorilla takeover in the openstack-discuss mailing list :p
15:49:13 <carloss> one change I have not mentioned as it is not introducing actual new features:
15:49:58 <carloss> NetApp's ZAPI -> REST change. There are no new functionalities being  implemented on it
15:50:22 <carloss> there has been some reviews and we're waiting on the author's response
15:51:10 <carloss> aaaand for the core changes that's it
15:51:12 <felipe_rodrigues> I'm having a look at them
15:52:19 <felipe_rodrigues> thanks carloss and dviroel for  the reviews
15:52:19 <carloss> for OSC that needs to merge today, there are these:
15:52:19 <carloss> https://review.opendev.org/q/topic:bp/openstack-client-support+status:open and https://review.opendev.org/c/openstack/python-manilaclient/+/826928/
15:52:47 <carloss> on the latter link, dviroel addressed a concern with a microversion that was supposed to be 2.70 instead of 2.69 in the code
15:53:14 <felipe_rodrigues> he is right
15:53:22 <felipe_rodrigues> I'll fix
15:53:30 <carloss> thanks felipe_rodrigues!
15:53:59 <dviroel> ;)
15:53:59 <felipe_rodrigues> yw
15:54:11 <carloss> the other changes are also reaaally close
15:54:31 <carloss> and the intention is to merge them today
15:54:44 <carloss> so we can update the release patch and give it a go by tomorrow
15:54:58 <carloss> so that's the priorities I wanted to highlight in today's meeting
15:56:39 <carloss> I'll be sending the email to grant the exceptions today!
15:57:09 <carloss> next topic would be bug triage, but we have only 3 minutes
15:57:41 <vhari_> :)
15:57:52 <carloss> sorry vhari_
15:57:52 <vhari_> carloss, we can discuss next time
15:58:02 <carloss> yep, thanks for putting the list together though
15:58:09 <carloss> alright, we can wrap up here then
15:58:10 <vhari_> carloss, np, ofc
15:58:19 <carloss> thank you all for joining this meeting
15:58:25 <carloss> let's continue the chatter on the reviews!
15:58:40 <carloss> #endmeeting