15:00:35 <carloss> #startmeeting manila
15:00:35 <opendevmeet> Meeting started Thu Feb 16 15:00:35 2023 UTC and is due to finish in 60 minutes.  The chair is carloss. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:35 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:35 <opendevmeet> The meeting name has been set to 'manila'
15:00:53 <carthaca> hi
15:00:56 <vhari> o/
15:01:27 <thiagoalvoravel> o/
15:01:36 <gouthamr> o/
15:01:41 <caiquemello[m]> 0/
15:01:42 <nahimsouza[m]> o/
15:02:19 <felipe_rodrigues> hi
15:02:51 <MatheusAndrade[m]> o/
15:03:28 <haixin> o/
15:03:41 <carloss> today's meeting agenda:
15:03:43 <carloss> #link https://wiki.openstack.org/wiki/Manila/Meetings#Next_meeting
15:04:05 <carloss> courtesy ping: dviroel
15:04:34 <HelenaDantas[m]> o/
15:04:56 <dviroel> o/
15:05:06 <ashrodri> o/
15:05:50 <carloss> o/ hello everyone! great quorum
15:05:57 <luizsantos[m]> o/
15:05:58 <carloss> let's get started with our meeting agenda for today :)
15:06:27 <carloss> the agenda is short. I want to focus on reviews for today.
15:06:31 <carloss> #topic Announcements
15:06:39 <carloss> Schedule and deadlines:
15:06:44 <carloss> #link https://releases.openstack.org/antelope/schedule.html
15:06:59 <carloss> this is feature freeze week!
15:07:13 <carloss> and also client release week. we need to ship our client tomorrow tops.
15:09:02 <carloss> one extra announcement:
15:09:11 <carloss> the schedule for the OpenInfra summit in vancouver is live!
15:09:12 <carloss> #link https://vancouver2023.openinfra.dev/a/schedule?_ga=2.76639381.1243381063.1676560116-1124383034.1671025814
15:09:55 <carloss> we had one manila talk accepted as a lightning talk!
15:10:07 <carloss> and a lot of interesting things there :)
15:10:15 <carloss> please check it out!
15:10:29 <carloss> that's all I had for announcements. Do you have something else you'd like to share with us today?
15:12:38 <carloss> taking silence as no :)
15:13:23 <carloss> #topic Review Focus
15:13:36 <carloss> so for today I want to do a check on a couple of changes:
15:14:39 <gouthamr> o/ just remembered something :)
15:15:07 <carloss> sure gouthamr
15:15:08 <carloss> please go ahead
15:15:10 <gouthamr> sorry for the interrupt
15:15:32 <carloss> no worreis
15:15:35 <gouthamr> but congratulations and thank you for becoming our PTL through the Bobcat release
15:16:29 <dviroel> carloss++
15:16:36 <ashrodri> carloss++
15:16:38 <caiquemello[m]> carloss ++
15:16:52 <gouthamr> it’s a hard job herding cats and churning oceans - but we love that you are doing this for us :)
15:19:36 <carloss> haha, thanks guys! really appreciated. I really think I have learned a lot in the role and that there is still motivation to continue. I love being a part of this community (many of you know I really do :)), so that makes the task more pleasant
15:19:59 <gouthamr> ++
15:20:31 <carloss> and you have a huge part on this! so I'm happy to continue
15:21:05 <carloss> and if you feel like being PTL some day, I am pretty sure we are open for a change of leadership, as they are very healthy!
15:21:19 <carloss> I'd be happy to help you to get there!
15:21:35 <vhari> carloss++
15:21:53 <carloss> thanks!
15:21:59 <carloss> moving on...
15:22:34 <carloss> #link https://etherpad.opendev.org/p/manila-antelope-review-focus (review focus etherpad)
15:22:42 <carloss> so for today I want to do a check on a couple of changes:
15:24:22 <carloss> #link https://review.opendev.org/c/openstack/manila/+/843832 (Share transfer between projects)
15:24:43 <carloss> gouthamr and I have been reviewing this change lately and haixin has been solving comments in a blink of an eye
15:24:56 <carloss> there are a couple of things we discovered on the reviews though: an issue when we have multiple share replicas and re-applying access rules to them
15:25:17 <carloss> after some discussion, the three of us agreed on: blocking share transfers for replicated shares and redesign this on the upcoming PTG
15:25:28 <carloss> I see some changes haixin made to the code, but I think we could fail earlier in the API and I have detailed it here:
15:25:32 <carloss> #link https://review.opendev.org/c/openstack/manila/+/843832/comments/78f1849d_e067739a
15:26:58 <carloss> but after discussing it with haixin a few minutes ago, we realized that only item 1 would fit, as we don't allow people creating replicas from shares that are not available, and the transfer leaves the share in a different status
15:26:59 <haixin> i am working on it
15:27:36 <carloss> I really think we can get this merged for this release. We are getting there, and if we need a feature freeze exception, I feel we can do it!
15:28:01 <gouthamr> +1
15:28:02 <carloss> I am not very confident that the client will make it because we need to have the core merged +  merge the client today
15:28:26 <haixin> We also don't need to worry about the replicas quota when accept transfer.
15:29:12 <carloss> ah, true - as we won't allow replicated shares to be transferred for now, it makes sense
15:29:24 <carloss> so in the worst case scenario we merge the client next release, which happened a couple of times in the past
15:30:01 <haixin> that is ok for me if have to merge next release.
15:30:23 <carloss> awesome! thanks haixin
15:30:40 <carloss> many thanks to the reviewers too!
15:31:07 <ashrodri> haixin++ thanks for all your hard work on this!
15:31:14 <carloss> haixin++ :)
15:32:42 <carloss> next on the list:
15:32:50 <carloss> #link https://review.opendev.org/c/openstack/manila/+/869707/ (Metadata share network subnet)
15:32:50 <carloss> #link https://review.opendev.org/c/openstack/manila/+/869708/ (NetApp Driver modification)
15:32:50 <carloss> #link https://review.opendev.org/c/openstack/python-manilaclient/+/869709 (Client)
15:32:58 <carloss> this has received a couple of reviews
15:33:20 <carloss> CI is not playing nice on the core change. felipe_rodrigues: this is open to a feature freeze exception, even though I think there's a chance we won't need it if reviewers are okay in the next pass
15:33:45 <felipe_rodrigues> Thanks everyone for the reviews
15:34:20 <carloss> the client change though: comments are there for some time. I *must* update the client release patch by EOD for me tops, so I can get at least one day for the release to happen. I believe there's a chance this will not make it in this client release too, so we will need to merge the client in the next release
15:35:30 <felipe_rodrigues> I'm fine to merge the client in next release.. I can talk to customer about applying the patch .. it's much easier than server code
15:35:43 <carloss> ack felipe_rodrigues
15:35:52 <carloss> I would also like to ask: what are your plans on adding tests to this change, felipe_rodrigues? Asking because we don't have any functional tests coverage yet
15:36:51 <felipe_rodrigues> Good point.. we can work on some functional tests as we did with snapshot metadata later
15:37:51 <carloss> yep - snapshot metadata had the tests proposed with the change but took some time to get in. We have tested most scenarios manually. We can try to have some sort of focus on testing this before RC1 so we ensure we are not shipping any bugs
15:38:03 <carloss> if issues are encountered, we can file bugs and propose as bugfixes
15:38:28 <carloss> s/ We have tested most scenarios manually/ We have tested most scenarios manually for subnet metadata though
15:38:50 <felipe_rodrigues> perfect!
15:39:02 <carloss> thanks
15:39:07 <felipe_rodrigues> yw
15:39:15 <carloss> #link https://review.opendev.org/q/topic:bug%252F2000171 (Add quiesce_wait_time option to share replica promote API)
15:39:25 <carloss> core change has landed
15:39:37 <carloss> kpdev was quick on solving comments too :)
15:39:47 <carloss> I believe the client is close and is a candidate for this release
15:40:38 <carloss> to the reviewers: could you please circle back on this change and provide some feedback today?
15:41:08 <carloss> also:
15:41:15 <carloss> #link https://review.opendev.org/q/topic:bug%252F1988146 (Add default datasite to security service)
15:41:44 <carloss> just saw the workflow on the core - thanks gouthamr
15:41:56 <carloss> so we will have the client and the NetApp change for now
15:42:17 <carloss> I think we are fine in terms of FFE
15:42:38 <carloss> and last change from kpdev:
15:42:42 <carloss> #link https://review.opendev.org/c/openstack/manila/+/859301 (Add 'state' column in 'services' table)
15:43:05 <felipe_rodrigues> About quiesce_wait_time, I think we agreed functional tests to be added later..
15:43:15 <carloss> felipe_rodrigues: yes
15:44:49 <carloss> good point - I'll ping kpdev on that later too
15:45:01 <felipe_rodrigues> nice
15:45:23 <carloss> continuing on the state column to the services table: even though the above it does not change the API, it does a db bump. Thanks for the reviews gouthamr - I am taking this as a temptative, but unsure if we would pursue a feature freeze exception
15:45:59 <gouthamr> think we can; there's a little bit of an API impact -- i.e., introduction of a new "stopped" state
15:46:46 <gouthamr> but, no change to the request/response schema or hence the clients
15:49:25 <carloss> sure
15:49:39 <carloss> okay - let's continue to give it a try
15:49:56 <carloss> #link https://review.opendev.org/q/topic:bp/netapp-ontap-rest-api-client+status:open (NetApp ONTAP - REST API transition)
15:50:11 <carloss> Now the biggest changes of this cycle. We had a collab review earlier this week and here's a link to the recordings:
15:50:15 <carloss> #link https://www.youtube.com/watch?v=zCOm_g7HGWU (NetApp ZAPI -> Rest Collab Review)
15:51:10 <carloss> The Structure change has merged but there are still 3 *major* changes under review. I am sure this will need a feature freeze exception.
15:53:58 <carloss> for the features we are pursuing an FFE: I would like to target them to next Thursday tops
15:55:46 <carloss> all of the changes we mentioned are features that qualify for feature freeze/client freeze.
15:56:03 <carloss> we have a couple of bug fixes that can land after the freeze
15:56:15 <carloss> is there something else you would like to bring up?
15:57:12 <felipe_rodrigues> Do I need to send an email requesting the FFE for REST transition feature ?
15:58:13 <carloss> usually we would ask everyone to send the emails, but I can just send the emails wrt the changes that are yet to merge and qualify for the exception
15:58:45 <carloss> so: let's do our best to get the changes that are close to get merged today/tomorrow
15:58:46 <felipe_rodrigues> thank you carloss
15:58:54 <carloss> and I can send the email for the request, as I did last cycle
15:58:59 <felipe_rodrigues> nice
15:59:00 <carloss> np felipe_rodrigues
16:00:16 <carloss> okay, we are at the top of the hour
16:00:32 <carloss> sorry for not leaving time for bug triaging vhari :(
16:00:36 <carloss> we can compensate next week :)
16:00:46 <carloss> thank you everyone for joining today and for helping with reviews
16:00:56 <carloss> let's continue chatting on the changes and on #openstack-manila!
16:01:00 <carloss> #endmeeting