15:00:47 <ashrodri> #startmeeting manila
15:00:47 <opendevmeet> Meeting started Thu Aug 10 15:00:47 2023 UTC and is due to finish in 60 minutes.  The chair is ashrodri. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:47 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:47 <opendevmeet> The meeting name has been set to 'manila'
15:00:58 <ashrodri> courtesy ping dviroel felipe_rodrigues vhari gouthamr carthaca
15:01:01 <gouthamr> o/
15:01:04 <carthaca> hi
15:01:06 <ashrodri> o/ hello everyone
15:01:10 <dviroel> o/
15:01:13 <thiagoalvoravel> o/
15:01:24 <ashrodri> carloss is on PTO this week, I'll be leading today's meeting
15:01:24 <haixin> o/
15:01:42 <ashrodri> today's meeting agenda: #link https://wiki.openstack.org/wiki/Manila/Meetings
15:01:51 <felipe_rodrigues> o/
15:02:06 <caiquemello[m]> o/
15:02:10 <jayaanand> hi
15:04:47 <ashrodri> welcome, let's get started
15:04:49 <ashrodri> #topic Announcements
15:04:55 <ashrodri> #link https://releases.openstack.org/bobcat/schedule.html
15:05:05 <ashrodri> It is now R-8, and feature proposal freeze is now in effect.
15:05:27 <ashrodri> Also, reminder that PTG registration is now open for Caracal here: #link https://ptg2023.openinfra.dev/
15:05:41 <ashrodri> Does anyone have an announcement to bring to our attention?
15:07:12 <ashrodri> okay, moving on...
15:07:20 <ashrodri> #topic Review Focus
15:07:26 <ashrodri> #link https://etherpad.opendev.org/p/manila-bobcat-review-focus
15:07:40 <ashrodri> Feature freeze is coming up in R-5 along with client release
15:07:51 <ashrodri> Lets work towards reviewing and merging these patches, starting with...
15:08:21 <ashrodri> share backups #link https://review.opendev.org/c/openstack/manila/+/343980
15:08:29 <ashrodri> and cli patch: #link https://review.opendev.org/c/openstack/python-manilaclient/+/344671
15:08:49 <ashrodri> api changes look to be in good condition to me, could use some more eyes on the cli patch.
15:08:53 <ashrodri> I will take a look after this meeting, anyone else volunteering?
15:10:43 <gouthamr> I’m hoping to defer any more changes to the API patch to follow ups and go ahead with merging this; it’s got a good amount of soak time and plenty reviews…
15:11:10 <gouthamr> any opposition to this?
15:11:53 <ashrodri> not from me, api changes look good to merge
15:12:41 <gouthamr> tempest tests and CLI are shaping up; we can merge them as soon as they’re reviewed to the same level and passing CI etc
15:13:24 <ashrodri> ++
15:14:12 <gouthamr> +1 I’ll act on this; with haixin - if you’ve reviewed this, please +1 the latest patch if you’re good with it… feel free to suggest changes; if they are minor, kpdev can address them in a follow up patch
15:15:06 <haixin> I'll review it again tomorrow :)
15:15:37 <gouthamr> ack thank you haixin
15:16:47 <ashrodri> thanks gouthamr haixin, moving on to the next patch...
15:17:06 <ashrodri> #link https://review.opendev.org/c/openstack/manila/+/890291 (Add NetApp Active IQ scheduler weigher)
15:17:08 <ashrodri> is ready for review
15:18:33 <gouthamr> +1; will take a look
15:18:58 <ashrodri> thanks gouthamr
15:19:54 <gouthamr> felipe_rodrigues: is this enabled in the NetApp CI ?
15:20:38 <felipe_rodrigues> Not yet, we are testing it manually and internally.. we can add a job for it, if you want
15:22:19 <gouthamr> or enable it in existing jobs?
15:23:22 <gouthamr> afair, you’re enabling multiple backends in these jobs - so it can be tested well? your multisvm job must be multi cluster as well iirc
15:23:49 <felipe_rodrigues> it is an option..
15:24:55 <felipe_rodrigues> we are thinking as multi cluster env
15:25:45 <gouthamr> ack
15:25:46 <felipe_rodrigues> Since there are some extra API calls, I dont know how it would affect the execution time...
15:26:17 <gouthamr> you’ve to worry about that for prod deployments too, no? :)
15:26:21 <felipe_rodrigues> ok.. only for tests that depend on scheduler weigher.. there aren't many
15:27:27 <felipe_rodrigues> I mean.. my problem is making our development cycle lazy..
15:27:49 <gouthamr> every backend test will run through the weigher..
15:27:57 <felipe_rodrigues> I see
15:28:24 <felipe_rodrigues> I will add a non voting job first. as part of our upstream pipeline.. let see how it works...
15:28:27 <felipe_rodrigues> wdyt ?
15:29:15 <gouthamr> sure thing
15:29:32 <felipe_rodrigues> We can add it to the community dummy job
15:29:36 <felipe_rodrigues> wdyt ?
15:29:53 <felipe_rodrigues> it is skipped in that scenario.. it should not affect the job in anyway
15:30:31 <gouthamr> that’s an option
15:30:34 <felipe_rodrigues> the weigher votes as "0.0" for all hosts when there is at least one non netapp host (as we agreed during PTG)
15:31:16 <gouthamr> but, why would you besides seeing the negative testing? I mean to see the functionality of the weigher
15:32:43 <gouthamr> hmm, probably good enough reason - feel free to enable it in the same patch or as a dependent manila-tempest-plugin change; where the parent dummy driver job is defined
15:33:24 <felipe_rodrigues> nice
15:36:20 <ashrodri> thanks gouthamr felipe_rodrigues. next...
15:36:36 <ashrodri> #link https://review.opendev.org/c/openstack/manila/+/889737 (NetApp SVM migration get progress)
15:36:41 <ashrodri> is also ready for review
15:38:34 <gouthamr> ack; I’m taking a look
15:38:48 <gouthamr> felipe_rodrigues: could you re-review?
15:39:11 <felipe_rodrigues> thanks caiquemello[m] for the patch.. I already reviewed, we need more eyes
15:39:33 <felipe_rodrigues> oh, sure! I'll take a look again
15:40:02 <gouthamr> perhaps a good patch to review for new netappers as well
15:40:38 <msaravan> yes, we started to review.. will review these patches definitely..
15:40:52 <gouthamr> ++
15:40:55 <felipe_rodrigues> I'd like more eyes specially about this point: https://review.opendev.org/c/openstack/manila/+/889737/4..5/manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py#b2048
15:41:14 <msaravan> sure
15:41:39 <felipe_rodrigues> thks :)
15:43:35 <ashrodri> thanks for volunteering to review! next, some new Dell drivers: ...
15:43:50 <ashrodri> #link https://review.opendev.org/c/openstack/manila/+/880527 (Adds a new Manila driver for Dell PowerFlex storage backend)
15:43:53 <ashrodri> this looks to be in good condition, only missing a +2.
15:44:03 <ashrodri> and #link https://review.opendev.org/c/openstack/manila/+/885974 (Adds a new Manila driver for Dell PowerStore storage backend)
15:44:10 <ashrodri> has a review from gouthamr to be addressed, needs more eyes, any takers?
15:45:54 <felipe_rodrigues> I can review it
15:48:03 <ashrodri> ++ felipe_rodrigues thanks!
15:48:11 <ashrodri> is there another patch we would like to bring attention to here today?
15:49:32 <gouthamr> I think the resource locks patches have had some attention, thank you for looking!
15:50:17 <gouthamr> I’ll rebase the changes on top of the share backup patch and update microversion
15:50:41 <gouthamr> #link https://review.opendev.org/q/topic:bp%252Fallow-locking-shares-against-deletion (Resource Locks)
15:50:59 <ashrodri> great! thanks for adding that to review etherpad, missed it earlier
15:51:15 <gouthamr> nah, it was missing - my bad
15:51:39 <ashrodri> no worries, moving on...
15:51:50 <ashrodri> #topic Bug Triage
15:51:57 <ashrodri> vhari has a scheduling conflict, and asked me to lead this part as well
15:52:03 <ashrodri> #link https://etherpad.openstack.org/p/manila-bug-triage-pad-new
15:52:11 <ashrodri> first, #link https://bugs.launchpad.net/manila/+bug/2030969
15:52:20 <ashrodri> bug is listed as in progress, but is unassigned and shows no related patch.
15:52:27 <ashrodri> his is actually the SVM RFE we spoke about earlier. Wonder why the patch isn't being tracked... gouthamr, thoughts?
15:53:27 <gouthamr> we’d have to update the patch on the tracker manually
15:54:09 <ashrodri> ah, okay. will do thanks
15:54:09 <felipe_rodrigues> the patch came earlier than the but report
15:54:24 <felipe_rodrigues> bug*
15:54:35 <ashrodri> ah yes that makes sense
15:55:28 <gouthamr> the openstackci bot that does gerrit updates only looks at the first patch to make up a comment with a link to the patch - weird; so if you’re missing a clearly formatted “Closes-Bug” in the commit message of the first patch, it’ll miss the update
15:56:30 <ashrodri> okay, last one: #link https://bugs.launchpad.net/manila/+bug/1970649
15:56:39 <ashrodri> vhari asked us to revisit this bug, felipe_rodriguez is the assignee, from about 1 year ago. do you need anything to proceed? we can always change back to unassigned if necessary .
15:56:59 <ashrodri> sorry, felipe_rodrigues
15:59:00 <gouthamr> felipe_rodrigues: this feels like deja vu; I think we discussed this.. your concern is that oversubscription calculations are kicking in even when allocating a thick volume?
16:01:15 <felipe_rodrigues> yeah.. we have a problem that AFF NetApp ONTAP creates volume as thin while FAS as thick (unless you request a different mode).. this bug has been deprioritized on our list.. However, we should have a open window soon
16:01:40 <felipe_rodrigues> I will find an assignee internally
16:02:11 <gouthamr> okay good stuff
16:02:14 <gouthamr> thanks
16:02:20 <gouthamr> time check, ashrodri
16:02:50 <ashrodri> yep, we're reaching a little past our usual hour so lets wrap up...
16:02:55 <ashrodri> #topic Open discussion
16:03:00 <ashrodri> Anything more to bring up today?
16:03:31 <gouthamr> great job running this meeting… thanks ashrodri
16:03:51 <ashrodri> happy to help, thanks for joining us, have a great rest of your day!
16:03:58 <ashrodri> #endmeeting