15:00:19 <carloss> #startmeeting manila
15:00:19 <opendevmeet> Meeting started Thu Aug 17 15:00:19 2023 UTC and is due to finish in 60 minutes.  The chair is carloss. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:19 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:19 <opendevmeet> The meeting name has been set to 'manila'
15:00:36 <felipe_rodrigues> hi
15:00:46 <gouthamr> o/
15:00:50 <gireesh> hi
15:00:54 <Saikumar> o/
15:00:56 <carthaca> hi
15:01:49 <thiagoalvoravel> o/
15:02:36 <haixin> o/
15:03:05 <vhari> o/
15:03:17 <dviroel> o/
15:04:35 <carloss> o/ hello everyone
15:04:53 <carloss> first, special thanks to ashrodri for running this meeting last week :)
15:05:30 <carloss> today's meeting agenda:
15:05:32 <carloss> #link https://wiki.openstack.org/wiki/Manila/Meetings#Next_meeting
15:06:25 <carloss> first topic:
15:06:28 <carloss> #topic Announcements
15:06:38 <caiquemello[m]> o/
15:06:43 <carloss> Schedule and Deadlines:
15:06:44 <carloss> #link https://releases.openstack.org/bobcat/schedule.html
15:07:15 <carloss> we are ~2 weeks away from feature freeze
15:08:06 <carloss> and the core part for one of the big changes has already merged
15:09:21 <carloss> gouthamr haixin felipe_rodrigues thiagoalvoravel nahimsouza[m] thanks for the reviews
15:10:08 <carloss> so now it is important to continue the push on the osc and manila-tempest-plugin changes... the featureful client patches should be merged by the feature freeze week
15:10:51 <carloss> other announcement is:
15:11:09 <carloss> our PTG planning etherpad is up
15:11:37 <carloss> #link https://etherpad.opendev.org/p/caracal-ptg-manila-planning (Caracal PTG planning etherpad)
15:12:07 <carloss> so if you intend to participate, please add your name under the list of attendees, and feel free to add topics for discussion with the community
15:12:28 <carloss> if you haven't registered on the PTG yet, please do so:
15:12:32 <carloss> #link https://openinfra.dev/ptg/
15:12:48 <carloss> it is virtual and cost-free for attendees!
15:14:18 <carloss> that's all I had for announcements. Is there an announcement you would like to share?
15:16:31 * carloss taking silence as no
15:16:48 <carloss> #topic Review focus
15:16:54 <carloss> #link https://etherpad.opendev.org/p/manila-bobcat-review-focus (Review focus etherpad)
15:18:07 <carloss> so we have a couple of features requiring attention now, and I would like to take the opportunity to "voluntell" some reviewers :D
15:19:53 <carloss> we don't have many reviewers yet on the following changes:
15:19:55 <carloss> #link https://review.opendev.org/q/topic:bp%252Fallow-locking-shares-against-deletion
15:22:11 <carloss> haixin dviroel: can I have your eyes on this two features? gouthamr is working on resource locks and I am working on access rules restrictions
15:22:38 <carloss> if you need some more context, we had a collab review session some weeks ago:
15:22:40 <carloss> #link https://www.youtube.com/watch?v=kL2V_5ay4jw&t
15:23:14 <dviroel> carloss: sure
15:24:03 <carloss> tyvm, that will be very helpful
15:25:30 <carloss> Saikumar jayaanand gireesh msaravan - it would be good to have your eyes on it as well, if you have the chance... these are good changes to get more familiar with APIs, database and unit testing in the manila code base :)
15:26:31 <haixin> ok
15:26:49 <carloss> thanks! :D
15:27:19 <jayaanand> ok
15:27:25 <msaravan> sure @carloss, we are on it ..
15:27:31 <Saikumar> Sure Carloss. We will take a look the reviews. Thanks.
15:27:44 <carloss> thanks, folks!
15:28:05 <carloss> on to the next topic...
15:28:10 <carloss> #topic Bug Triage
15:28:21 <vhari> o/ everyone
15:28:22 <carloss> #link https://etherpad.openstack.org/p/manila-bug-triage-pad-new (Bug Triage etherpad)
15:28:27 <carloss> o/ hey vhari :D
15:28:57 <vhari> got a few bugs slated for minor triage - so lets roll up our sleeves :)
15:29:06 <vhari> #link https://bugs.launchpad.net/manila/+bug/2031194
15:30:08 <carloss> "It's possible that these tests aren't mocking "sleep""
15:30:17 <carloss> that makes sense
15:30:59 <carloss> I'd say low prio for this. Seems easy to reproduce, doesn't break any workflow
15:31:01 <gouthamr> yeah, this might have existed in the past couple of releases; just that the REST API test takes 60s :/
15:31:31 <carloss> worth taking a look. gouthamr: thanks for the bug report
15:33:06 <carloss> any netapper willing to give it a shot?
15:33:08 <msaravan> will add this to the backlog
15:33:28 <carloss> ack, thanks msaravan
15:34:04 <vhari> msaravan++
15:34:09 <msaravan> will prioritize it .. thanks carloss
15:34:18 <vhari> next up #link https://bugs.launchpad.net/manila/+bug/2031311
15:36:02 <carloss> I'd say medium prio... apparently kpdev is already working on this
15:36:19 <gouthamr> medium prio; the fix is in progress: https://review.opendev.org/c/openstack/manila/+/891613 ; alongside other changes reacting to the final reviews on the core patch
15:36:19 <carloss> the bot didn't pick up change and set it to in progress because the change is missing the Closes-Bug tag
15:36:20 <carloss> #link https://review.opendev.org/c/openstack/manila/+/891613
15:37:15 <vhari> ack carloss - update the bug status
15:37:29 <vhari> next #link https://bugs.launchpad.net/manila/+bug/2031191
15:37:53 <vhari> yeah fix proposed as well
15:38:01 <vhari> https://review.opendev.org/c/openstack/manila-tempest-plugin/+/891239
15:38:34 <vhari> will assign it to gouthamr++
15:38:36 <gouthamr> not a fix; the patch in the bug was to prove that the driver had a problem with glance's SRBAC enforcement
15:39:52 <vhari> gouthamr, ack, ok to assign it to you?
15:39:55 <gouthamr> sure; rc1 can be the target; i'll submit that patch as a workaround for the CI because we're permafailing
15:40:31 <carloss> thanks gouthamr
15:41:06 <vhari> k, lets jump to #link https://bugs.launchpad.net/manila/+bug/2031106
15:43:01 <gouthamr> this isn't a manila bug
15:44:25 <gouthamr> i'd set it to invalid with that comment ^; fmount and manojkatari will follow up wrt tripleo
15:45:27 <vhari> ack, will make a note on this bug
15:46:18 <vhari> one more to look at for today's session #link https://bugs.launchpad.net/manila/+bug/2031669
15:46:58 <gouthamr> carthaca what are you trying to do :D
15:47:09 <carthaca> serving this fresh out of production, first seen today!
15:48:10 <gouthamr> 27 shares in the affinity hints is  https://paste.openstack.org/show/boPeJdGjzRxB51jJgmt6/
15:48:12 <carthaca> I did not double check the use-case, yet. But either way some proper client error would be nice ^^
15:48:59 <gouthamr> > But either way some proper client error would be nice
15:49:01 <gouthamr> yes
15:49:05 <carthaca> no ,27 is fine, it breaks if you add another :P
15:49:36 <gouthamr> (╯°□°)╯︵ ┻━┻
15:50:15 <gouthamr> jokes apart; yes. HTTP 500 is bad user experience, we should handle that error
15:52:26 <gouthamr> carthaca presume they used "different_host"?
15:53:33 <carthaca> no, same host
15:53:54 <carthaca> we don't have that many different hosts in any AZ
15:54:16 <gouthamr> hmmm; and the reason they were adding multiple shares in the hints is to ensure the hint remains even if they cleanup some of the shares?
15:54:57 <carthaca> the code is doing this
15:55:47 <carthaca> if you reference share A in same host affinity when creating share B, share B gets added to the internal metadata of share A
15:57:14 <gouthamr> yes, sure, but i'm wondering how we ended up with those many uuids
15:58:43 <carloss> D:
15:58:47 <carthaca> they are legit
15:59:03 <gouthamr> carthaca: worth adding the user's request to the bug so we can triage this.. i thought this was a user error..
15:59:04 <carthaca> no duplicates or already deleted entries
15:59:09 <gouthamr> ack
15:59:46 <gouthamr> ah wait
15:59:52 <carthaca> they really have that many shares in the same share network and apparently want to place tbem next to each other
15:59:53 <gouthamr> ignore me; i read the code now
16:00:08 <gouthamr> so you keep using share A as the same host hint
16:00:22 <gouthamr> in as many shares as you create
16:00:31 <carthaca> ack
16:00:58 <carthaca> I should have written out the loop one more time probably
16:01:27 <carthaca> f you reference share A in same host affinity when creating share C, share C gets added to the internal metadata of share A - on top
16:01:29 * carloss time check
16:02:02 <gouthamr> ack
16:02:38 <carloss> good discussion guys
16:02:45 <carloss> thanks for the bug report carthaca
16:02:53 <carloss> let's continue on #openstack-manila
16:03:03 <carloss> and thanks for putting the bug list together
16:03:11 <carloss> see you in the manila channel :)
16:03:16 <carloss> #endmeeting