15:00:01 <carloss> #startmeeting manila
15:00:01 <opendevmeet> Meeting started Thu Aug  8 15:00:01 2024 UTC and is due to finish in 60 minutes.  The chair is carloss. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:01 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:01 <opendevmeet> The meeting name has been set to 'manila'
15:00:32 <jayaanand> hi
15:00:51 <carloss> courtesy ping: dviroel vhari gouthamr carthaca msaravan pulluri ashrodri
15:01:01 <haixin> o/
15:01:07 <gireesh> hi
15:02:20 <carthaca> hi
15:02:39 <msaravan> hi
15:02:42 <vhari> o/
15:02:52 <gouthamr> o/
15:03:17 <kpdev> hi
15:03:31 <dviroel> o/
15:03:44 <carloss> hello everyone :D
15:03:49 <carloss> our meeting agenda for today:
15:03:51 <carloss> #link https://wiki.openstack.org/wiki/Manila/Meetings
15:05:06 <carloss> first up:
15:05:08 <carloss> #topic Announcements
15:05:13 <carloss> Schedule and Deadlines
15:05:35 <ccokeke[m]> Hello
15:06:27 <carloss> we're past feature proposal freeze and feature freeze is in ~20 days :)
15:07:20 <carloss> we are having our collab reviews next week in our mid-cycle
15:07:45 <carloss> plenty of features being proposed for this cycle
15:08:27 <carloss> we'll get to mid-cycle in a bit
15:08:32 <carloss> but that's all I had for announcements
15:08:41 <carloss> is there an announcement you would like to share with us?
15:10:38 <carloss> taking silence as no
15:10:44 <carloss> #topic Mid-cycle
15:11:01 <carloss> #link https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/5UMH5BI55STHTMEV4W7JHWAOTURFMX3U/ (Mid-cycle announcement)
15:11:18 <carloss> It will happen next week, on Monday and Tuesday
15:11:53 <carloss> as suggested in the PTG, we will talk about the progress of the features we have discussed
15:12:19 <carloss> but also use some time for our collab reviews
15:12:35 <carloss> #link https://etherpad.opendev.org/p/manila-dalmatian-mid-cycle-notes (Dalmatian mid-cycle etherpad)
15:13:24 <carloss> I have added only a few topics
15:13:37 <carloss> and I believe that our collab reviews will need a bunch of time
15:14:15 <carloss> so please also add the collab review topics for the features you are working on
15:14:25 <carloss> so we can try to speed up the reviews
15:14:56 <carloss> the etherpad has the meeting room info, as well as as the dates and time slots
15:15:48 <carloss> do you have any questions with regards to the bugsquash?
15:19:15 <gouthamr> is this a trick question? :)
15:19:26 <vhari> :)
15:19:58 <gouthamr> since its a couple of days; the collab reviews should keep us quite busy
15:20:06 <carloss> :D
15:20:42 <carloss> not a tricky question
15:20:53 <carloss> my head keeps mixing up event names :D
15:21:08 <vhari> carloss++
15:21:10 <carloss> sorry :p
15:21:15 <vhari> we got your drift
15:21:31 <carloss> xD
15:21:49 <vhari> phew .. you got me on that one :)
15:21:55 <carloss> alright, next topic:
15:21:57 <carloss> #topic Review focus
15:22:22 <carloss> #link https://etherpad.opendev.org/p/manila-dalmatian-review-focus (Dalmatian review focus etherpad)
15:23:29 <carloss> so I have added some updates to the etherpad
15:23:39 <carloss> I see things were added there
15:23:40 <carloss> thank you
15:23:54 <carloss> I intend to keep updating the changes status
15:24:07 <carloss> most of the changes could use more eyes
15:24:26 <carloss> but I also see that most of the features there will be proposed as review collabs
15:25:55 <carloss> kpdev also highlighted some other features in #openstack-manila
15:26:02 <carloss> and I pinged some reviewers
15:28:38 <carloss> #link https://review.opendev.org/c/openstack/manila/+/924064 (Pass metadata to backend drivers)
15:28:38 <carloss> has a +2 from haixin, but we need more reviewers
15:28:48 <carloss> I looked at the change a week or two ago and it was looking close
15:28:53 <carloss> will circle back
15:29:11 <carloss> asked for some reviews on this in #openstack-manila, I think we can wait on reviews now
15:29:38 <carloss> #link Update share/snapshot instance deferred deletion (Update share/snapshot instance deferred deletion)
15:29:50 <carloss> also has a +2 from haixin and needs more eyes
15:30:34 <carloss> #link https://review.opendev.org/q/topic:%22bp/share-encryption%22 (Share type encription)
15:30:44 <gouthamr> I will take a look; I was hoping to test this
15:30:53 <gouthamr> (at both of the above)
15:31:13 <carloss> had some eyes, bigger feature
15:31:32 <carloss> kpdev: I noticed there is no tempest change for this yet. Please propose some tests for it
15:31:50 <carloss> s/tempest/manila-tempest-plugin
15:32:15 <carloss> also don't see this in the collab review topics. I think this would be a very good feature to have a collab review
15:32:21 <carloss> could you please add it?
15:32:25 <kpdev> encryption ?
15:32:27 <carloss> yes
15:32:30 <kpdev> ok
15:32:53 <carloss> tyvm
15:33:45 <carloss> we talked about the metadata change having or not a collab review, and it is a smaller change, already had a couple of reviews, so I think the review iterations will be easier for it
15:33:55 <carloss> for share encryption, I believe the collab review will help us to speed up
15:34:11 <kpdev> ack
15:34:15 <carloss> tyvm :)
15:37:09 <carloss> #link https://review.opendev.org/c/openstack/manila/+/920382 (Fix share revert to snapshot for specific scenario)
15:37:09 <carloss> had a review from gouthamr, and I see the discussion going on. kpdev: are you applying to changes that gouthamr is suggesting?
15:37:29 <carloss> #link https://review.opendev.org/q/topic:%22metadata-export-location%22 (Export location metadata)
15:37:38 <kpdev> waiting for NetApp engineers to comment
15:37:43 <carloss> ack, ty
15:37:59 <carloss> msaravan gireesh jayaanand: could you please follow-up?
15:38:17 <gireesh> @kpdev and @carloss, will add my comment soon
15:38:24 <msaravan> Gireesh is on it, and I'll also look at it.
15:38:35 <carloss> on export location metadata: work from a former an intern, and ashrodri has been working on getting it done. We also need some reviewers here
15:38:50 <carloss> kpdev gireesh gouthamr: could you please take a look?
15:39:01 <gireesh> sure
15:39:19 <carloss> msaravan gireesh: thank you!
15:39:31 <carloss> two to go in the list of review focus
15:39:36 <gouthamr> sure thing
15:39:39 <carloss> tyvm :D
15:39:49 <carloss> #link https://review.opendev.org/c/openstack/manila/+/924773 (Manage/unmanage for CephFS drivers)
15:40:04 <carloss> one of the features I am pursuing for this release
15:40:24 <carloss> testing for manage/unmanage for shares is already passing in a job, but now I am testing manage/unmanage with snapshots
15:40:28 <carloss> some eyes would be welcome too
15:41:06 <carloss> haixin gouthamr kpdev: not quite ready for reviews yet, but can I have your eyes on it? as soon as I test snapshot updates, will add you to reviewers if that's okay :)
15:41:25 <carloss> and last on the list
15:41:32 <carloss> #link https://review.opendev.org/c/openstack/manila/+/924279 (Ensure shares APIs)
15:41:47 <haixin> ok
15:41:56 <carloss> same thing: still under manual testing, but client and API changes are being worked on
15:42:11 <carloss> that's all I had for review focus
15:42:21 <carloss> if there's a change you'd like some attention and that is not on the list
15:42:28 <carloss> please add it
15:42:32 <carloss> :)
15:43:31 <carloss> #topic Bug Triage (vhari)
15:43:37 <carloss> #link https://etherpad.openstack.org/p/manila-bug-triage-pad-new (Bug Triage etherpad)
15:43:52 <vhari> ty carloss
15:44:06 <vhari> we have a backlog from last week
15:44:08 <vhari> #link https://bugs.launchpad.net/manila/+bug/2074114
15:44:25 <vhari> looking for minor triage atm
15:44:44 <carloss> ganso: thanks for the bug report
15:46:12 <gouthamr> hmmm, makes sense; there are a bunch of pool--->host fall backs; but we may have missed it for these filter and goodness functions
15:47:50 <carloss> yep, good find
15:47:59 <carloss> I think it's a medium prio
15:48:13 <carloss> is there someone willing to work on it?
15:48:19 <carloss> I can ask ganso if he has the plans to
15:48:44 <vhari> carloss, ack good thought
15:48:45 <carloss> to remember his glorious manila days
15:48:56 <carloss> but he's been busy with other things for the past years
15:49:22 <vhari> next up #link https://bugs.launchpad.net/manila/+bug/2075967
15:50:25 <gouthamr> nova should be locking share deletion too..
15:50:26 <vhari> good catch gibi++
15:52:04 <carloss> exactly
15:52:20 <carloss> we don't prevent the deletion of shares because they have access rule
15:52:23 <carloss> we don't prevent the deletion of shares because they have access rules
15:52:51 <carloss> so we don't do that check regardless if it is locked or not
15:53:05 <carloss> if the share was also locked, then I believe we wouldn't run into this issue
15:53:28 <carloss> the admin can also place the lock in the share
15:53:28 <gouthamr> yes, Gibi notes that in the bug
15:53:49 <gouthamr> i wonder if their design changed and we didn't hear of it..
15:54:30 <gouthamr> i'd expect the workflow to be: 1) lock the share because its mounted somewhere 2) lock the access rule each time the share is mounted
15:54:42 <gouthamr> 3) unlock the access rule when the share is being unmounted
15:54:57 <gouthamr> 4) delete the share lock if its not being mounted anywhere
15:56:02 <gouthamr> if this isn't done, it'll break nova the same way as originally feared - the share could be deleted from underneath it and hard mounts could make the host go unresponsive
15:57:14 <gouthamr> adding a check in the share delete/unmanage/soft-delete logic to prevent deletion if there are any locked access rules may be okay; just a bit of a performance hit to make some database calls
15:57:42 <gouthamr> if there's a problem with the existing design, that might be our only recourse though
15:58:11 <carloss> ++
15:58:46 <carloss> if we end up needing to do the check too
15:58:49 <carloss> I can work on the fix
15:59:23 <carloss> but we can share that we initially thought that the share should be locked
16:00:34 <vhari> carloss++
16:00:48 <vhari> that's a wrap for bugs .. out of time :)
16:01:00 <carloss> vhari: thank you!
16:01:07 <vhari> yw
16:01:14 <carloss> thank you everyone for participating
16:01:19 <carloss> let's get back to #openstack-manila
16:01:23 <carloss> #endmeeting