15:00:14 <carloss> #startmeeting manila
15:00:14 <opendevmeet> Meeting started Thu Jun 26 15:00:14 2025 UTC and is due to finish in 60 minutes.  The chair is carloss. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:14 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:14 <opendevmeet> The meeting name has been set to 'manila'
15:00:17 <Sai> o/
15:00:27 <carloss> courtesy ping: dviroel carloss vhari gouthamr carthaca msaravan Sai ashrodri gireesh
15:00:30 <vhari> hi
15:00:39 <dviroel> o/
15:00:42 <gireesh> hi
15:00:48 <gouthamr> o/
15:04:06 <carloss> o/ hello everyone
15:04:26 <carloss> #link https://wiki.openstack.org/wiki/Manila/Meetings#Next_meeting (Meeting agenda)
15:04:29 <carloss> let's get started
15:04:50 <carloss> #topic Announcements
15:04:56 <carloss> Schedule and Deadlines
15:05:01 <carloss> #link https://releases.openstack.org/flamingo/schedule.html (Flamingo Schedule)
15:05:23 <carloss> we're one week away from our hack-a-ton
15:05:39 <carloss> even less
15:05:53 <carloss> and one month away from the feature proposal freeze
15:07:16 <carloss> we're one week past spec freeze and two specs merged for the time being: share encryption and out of place backup restores
15:08:59 <carloss> on the hack-a-ton, I was just debugging some issues in the example environment with vhari
15:09:06 <carloss> we are close to having the documentation ready
15:09:27 <carloss> vhari did an excellent job on documenting everything and updating the taiga board
15:10:02 <vhari> carloss++
15:10:17 <carloss> will be a fun week
15:10:32 <carloss> I'm also inviting some students from VC to join us
15:13:08 * carloss got distracted, sorry
15:13:26 <carloss> about the format, as we suggested, we'll start on Monday and finish at the end of the week
15:13:48 <carloss> we can have the kick-off call at the same time slot as this meeting
15:14:53 <carloss> in the very first day, we'll walk through the documentation that was prepared for this and show how the implementation is done
15:15:08 <carloss> and how you will be able to run the functional tests
15:16:26 <carloss> I'll share the bridge details and an ics
15:16:35 <carloss> do you have any questions on the hackaton?
15:17:58 <gouthamr> do we have completion criteria or just as much as we can get done?
15:19:07 <carloss> gouthamr: good question. ideally each would get one or more resource (shares, share snapshots, etc) and implement the testing related to it
15:19:21 <carloss> at the end, as much as we can get done also helps a lot with the cause
15:20:54 <gouthamr> ++
15:21:03 <gouthamr> yeah the goal would be to remove the “manila” CLI after finding and fixing bugs in the OSC part
15:21:13 <gouthamr> but we can go endlessly with testing :)
15:23:21 <carloss> ++
15:23:41 <carloss> that's all I had for announcements. Is there an announcement you'd like to share today?
15:26:34 <carloss> #topic Review Focus
15:26:42 <carloss> #link https://etherpad.opendev.org/p/manila-flamingo-review-focus (Review focus etherpad)
15:26:49 <carloss> I was looking at the list of fixes today
15:26:59 <carloss> kpdev: thanks for helping to maintain this list of fixes
15:27:32 <kpdev> ack
15:27:59 <carloss> i see a handful of fixes added to the list
15:28:08 <carloss> and I was trying to keep up with the reviews this week
15:29:29 <carloss> we'll need netappers' eyes on most of them
15:29:57 <carloss> gireesh Sai: can you tag team on the reviews for those changes?
15:30:16 <carloss> also, I am planning to start my reviews on the share encryption series this week
15:31:33 <gireesh> sure, I requested to my team member also to review the code
15:32:13 <carloss> gireesh: ack, thank you
15:32:31 <gireesh> we will speedup the code review in upcoming weeks
15:32:39 <carloss> gireesh++
15:32:52 <carloss> as for the testing of share encryption, kpdev I saw you proposed one change that is focusing on negative tests
15:32:53 <kpdev> thanks
15:33:05 <carloss> thanks for working on it
15:33:24 <carloss> are you planning to work on positive tests as well? or would netappers be involved in that part?
15:34:15 <kpdev> yes, Sai has done end to end testing and also shipped with some customers. For positive tests, I am not sure about barbican integration. I can work on positive tests via separate PR in future after approval for time allocation.
15:35:14 <carloss> ack
15:35:33 <carloss> kpdev: positive tests will be also as important for merging this feature and I think we should do this before we merge, otherwise we won't have any testing reaching the back ends
15:35:43 <carloss> and I would expect that we are able to run such tests with the netapp CI
15:35:51 <carloss> and manila-tempest-plugin
15:37:15 <carloss> the path would be similar: we'd need to add some code to manila-tempest-plugin to go talk to barbican and request the creation of  the key in the beginning of the test
15:37:22 <carloss> and send that key as part of the share creation
15:37:29 <carloss> we can't have this piece untested
15:37:35 <gouthamr> +1
15:37:37 <kpdev> This will block for long-time as I said for approval of time. I had lost earlier on previous spec version and PRs related to share-type.
15:39:45 <kpdev> there will be two steps I assume. first update devstack installation to install barbican as well and add respective entries in manila.conf
15:39:55 <kpdev> then add manila-tempest-tests for the same
15:40:37 <kpdev> can we have/help someone working on 1st one ?
15:40:39 <carloss> kpdev: I get that we took some time in the spec reviews and the other patches, but the whole backend approach changed from when we started talking about this, so the spec needing updates is the natural course of action while designing this feature
15:40:55 <carloss> > there will be two steps I assume. first update devstack installation to install barbican as well and add respective entries in manila.conf
15:40:55 <carloss> agreed
15:41:32 <carloss> gireesh, Sai: could you please help with that?
15:41:43 <carloss> or someone in the NetApp team?
15:43:26 <Sai> I will discuss with the team and Kiran as well offline carloss
15:45:31 <carloss> Sai: ack, but please bring it up and get back to us on that. The community can help with the steps for adding barbican as a plugin and the entries to the manila.conf
15:46:01 <carloss> ^ that in case you need help
15:46:19 <carloss> you'll need a new enabled_plugin entry as part of the local.conf
15:47:30 <carloss> anything else you'd like to bring up for $topic
15:47:32 <carloss> ?
15:48:56 <carloss> taking silence as no
15:48:57 <carloss> #topic Bug Triage (vhari)
15:49:02 <carloss> #link https://etherpad.openstack.org/p/manila-bug-triage-pad-new (Bug Triage etherpad)
15:49:04 <vhari> ty carloss
15:49:15 <vhari> let's jumpin for a quick triage
15:49:18 <vhari> #link https://bugs.launchpad.net/manila/+bug/2115424
15:49:54 <Sai> Ack, sure carloss. Thank you.
15:50:08 <vhari> ty for the rfe kpdev
15:50:35 <vhari> can you suggest importance and milestone at this time?
15:50:56 <gouthamr> there was an adaptive-qos blueprint that we can attach this to
15:51:05 <vhari> or any other discussions
15:51:15 <vhari> gouthamr, ack
15:51:47 <kpdev> https://docs.netapp.com/us-en/ontap-restmap/qos.html#qos-adaptive-policy-group-create this is API which needs to implement and remove dhss=false criteria
15:54:21 <gouthamr> the only way we can see that this is a bug is if the functionality existed and is broken… I’d say let’s just copy this over to the existing blueprint and target it appropriately
15:54:49 <gouthamr> we won’t be back porting any of this, or assigning a bug “priority”
15:55:30 <kpdev> ok, so there is spec for that which was merged ?
15:55:35 <gouthamr> is someone actively looking at this, kpdev? Or were you stating the need for someone from NetApp To look at this?
15:56:24 <gouthamr> no spec, theres very little API implementation here - a blueprint was filed to add adaptive qos to the NetApp driver
15:56:44 <gouthamr> #link https://opendev.org/openstack/manila/commit/2f0981602bbbcd8e2d300d6e80ef6667f999b14d
15:57:12 <kpdev> yes, I have asked Netapp to give comments about implementation and handling corner cases.  I have already started looking at APIs
15:58:40 <gouthamr> I can’t seem to find the blueprint
15:59:23 <gouthamr> #link https://review.opendev.org/c/openstack/manila/+/740532
16:00:10 <kpdev> yes, bp link does not work there
16:00:34 <gouthamr> maybe it got archived somehow, nvm
16:00:57 <kpdev> https://blueprints.launchpad.net/cinder/+spec/netapp-ontap-dynamic-adaptive-qos
16:01:10 <carloss> found this too, but this is the cinder one
16:01:14 <carloss> but same purpose
16:01:39 * carloss checks time
16:01:52 <carloss> we're 1 minute past the time
16:02:11 <carloss> let's wrap up the meeting and continue in #openstack-manila
16:02:18 <carloss> thanks for participating
16:02:22 <carloss> see you in #openstack-manila
16:02:24 <carloss> #endmeeting