04:00:17 <samP> #startmeeting masakari
04:00:18 <openstack> Meeting started Tue Apr 17 04:00:17 2018 UTC and is due to finish in 60 minutes.  The chair is samP. Information about MeetBot at http://wiki.debian.org/MeetBot.
04:00:19 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
04:00:21 <openstack> The meeting name has been set to 'masakari'
04:00:27 <samP> Hi all for masakari
04:00:30 <tpatil> Hi
04:00:32 <niraj_singh> hi
04:00:44 <samP> tpatil: niraj_singh: hi
04:00:55 <samP> Let's start,
04:01:09 <samP> #topic Bugs/Patches
04:01:22 <samP> Any bugs or patches need to discuss?
04:02:20 <samP> #link https://review.openstack.org/#/c/487430/
04:02:21 <patchbot> patch 487430 - masakari - Add db purge support
04:02:55 <samP> LGTM, please address the latest comments. Then we can merge this.
04:03:27 <tpatil> all comments are addressed
04:03:31 <tpatil> I have voted +2
04:03:39 <tpatil> need another +2
04:05:06 <tpatil> should the max rows is zero instead?
04:05:11 <samP> tpatil: It seems to me, there are some minor comments from Abhishek and Kwan
04:05:31 <samP> tpatil: yep, are those addressed?
04:05:56 <tpatil> Abhishek comments are trivial. Since the patch was uploaded in 2017, since in the copyright 2017 is mentioned
04:06:13 <tpatil> hence in the copyright 2017 is mentioned
04:06:36 <tpatil> Another comment from Louis is comparing with line 183, should the max rows is zero instead?
04:07:18 <tpatil> IMO, max_rows -1 will delete all records based on age_in_days
04:07:23 <samP> tpatil: agree on abhishek's comment.
04:07:54 <tpatil> you mean 2018 is correct?
04:09:10 <samP> tpatil: My understanding is 2017 is correct in this case, cause patch was submitted on 2017/
04:09:28 <tpatil> samP: OK
04:10:01 <tpatil> max_rows zero is invalid value
04:10:37 <samP> tpatil: you are correct about second comment
04:10:46 <samP> tpatil: -1 is LGTM
04:10:52 <samP> tpatil: thanks
04:11:13 <tpatil> I will request Pooja to reply to these comments and then someone should review the patch again
04:12:10 <samP> tpatil: since we discussed here, I will put +2 and link to this discussion. That will merge the patch
04:12:46 <tpatil> samP: Sounds good to me. Thank you
04:13:02 <samP> tpatil: NP.
04:13:11 <tpatil> another patch : https://review.openstack.org/#/c/560237/
04:13:11 <patchbot> patch 560237 - masakari-specs - Add Rocky specs repo
04:13:41 <tpatil> Is it ok to move the template.rst from respective releases folder to specs folder?
04:14:03 <tpatil> For example, https://review.openstack.org/#/c/560237/1/doc/source/specs/queens/implemented/queens_template.rst
04:14:03 <patchbot> patch 560237 - masakari-specs - Add Rocky specs repo
04:14:16 <samP> tpatil:  it used to be a symbolic link
04:14:16 <tpatil> should be placed inside https://review.openstack.org/#/c/560237/1/doc/source/specs/queens_template.rst
04:14:17 <patchbot> patch 560237 - masakari-specs - Add Rocky specs repo
04:15:01 <tpatil> yes, it should be a symbolic link
04:15:20 <Dinesh_Bhor_> samP: Yes, you are right. I will fix this.
04:15:32 <tpatil> Dinesh_Bhor: Thank you
04:15:39 <samP> Dinesh_Bhor_: thans
04:15:49 <samP> s/thans/thanks
04:18:04 <samP> sorry, little disruption..
04:19:25 <samP> tpatil: Dinesh_Bhor_ : replace the *template.rst in implemented/ with symbolic link to *template.rst in /spec/queens
04:19:46 <samP> ^^ am I correct/
04:20:10 <tpatil> or we can simple put actual queens template.rst inside specs instead of specs/queens
04:20:33 <tpatil> s/simple/simply
04:20:49 <tpatil> What do you guys prefer?
04:21:11 <Dinesh_Bhor_> There should have respective template for each release if we decide to add/remove any tags to format.
04:21:35 <Dinesh_Bhor_> s/format/spec format.
04:21:42 <samP> tpatil: well, nova have templates in nova-specs/specs and link them to other places
04:22:10 <tpatil> I'm asking to follow on nova path itself
04:22:49 <samP> tpatil: I prefer nova way of handling things
04:23:17 <Dinesh_Bhor_> okay. I will fix this similar to nova
04:23:23 <samP> Dinesh_Bhor_: thanks
04:24:37 <samP> Any other bug/patches need to discuss?
04:25:48 <tpatil> Talking about openstaacksdk release, we will need to submit patch to release newer version of openstacksdk by ourselves
04:26:09 <tpatil> under openstack/releases
04:26:21 <samP> tpatil: Sorry, I couldn't discuss this with release team yet..
04:26:47 <samP> tpatil: do we have do it our self??
04:27:23 <tpatil> https://review.openstack.org/#/q/project:openstack/releases+message:openstacksdk
04:27:55 <tpatil> We can push patch similar to this one : https://review.openstack.org/#/c/533624/
04:27:56 <patchbot> patch 533624 - releases - Release python-openstacksdk 0.10.0 (MERGED)
04:29:04 <samP> tpatil: Normally, some one form release liaison of the project or PTL submit those patches...AFAIK
04:29:32 <samP> tpatil: May be it is different in sdk project.
04:30:26 <samP> and Motoki san is a SDK core. (I think)
04:30:46 <samP> Any way I will ask right after this meeting.
04:30:58 <tpatil> samP: Thank you
04:31:17 <amotoki> samP: I am OSC core. I am not a core of SDK bu helping SDK project.
04:31:33 <samP> amotoki: Hi, motoki-san
04:31:40 <amotoki> hi
04:32:17 <samP> amotoki: We need a new version of sdk to released
04:32:40 <amotoki> samP: with masakari support?
04:33:32 <samP> amotoki: No, with latest fix for proxy
04:33:32 <amotoki> samP: mordred is the PTL of OpenStackSDK. he is the right contact.
04:34:07 <samP> amotoki: sure, I will contact him right after this meeting with details. Thanks
04:34:46 <amotoki> samP: if you have questions, I can help.
04:35:32 <samP> amotoki: sure, That's really nice. I will tag you
04:36:09 <samP> tpatil: I will get back to you with details.
04:36:30 <tpatil> samP: OK
04:37:12 <samP> amotoki: Thank you in advance..!
04:37:38 <samP> #topic Discussion Points
04:38:12 <samP> tpatil: Any update on ansible support?
04:38:37 <tpatil> niraj_singh is working on it
04:38:42 <tpatil> #link : https://github.com/NirajSingh90/openstack-ansible-os_masakari
04:38:51 <niraj_singh> masakari ansible specs merged. https://review.openstack.org/#/c/556756/
04:38:51 <patchbot> patch 556756 - openstack-ansible-specs - Add specs to create masakari role (MERGED)
04:39:37 <samP> tpatil: niraj_singh: Thanks.
04:39:59 <tpatil> so far, it's possible to install masakari-api and masakari-engine
04:40:22 <tpatil> Niraj is working on deploying masakari-monitors on compute node
04:41:08 <samP> tpatil: niraj_singh: great news! Thanks for implementing this.
04:41:14 <niraj_singh> Currently Evrar form ansible want to include this github repo into openstack-ansible this week.
04:42:01 <niraj_singh> means openstack namespace
04:42:10 <samP> niraj_singh: got it.
04:42:37 <niraj_singh> so currently i am working on the docs and other files.
04:42:54 <niraj_singh> so that they can review it.
04:43:42 <samP> niraj_singh: understand. Thanks.
04:43:43 <tpatil> Even if the docs are not complete, it should be possible to move your GitHub repo code into open stack GitHub repo
04:44:21 <samP> tpatil: correct. Is it become a sub repo of OSA project?
04:45:15 <tpatil> I think it will be separate project similar to https://github.com/openstack/openstack-ansible-os_nova
04:45:46 <niraj_singh> yes
04:46:54 <samP> tpatil: niraj_singh: yep, it is a separate repo as you said. But it repo owns to OSA team
04:48:15 <samP> #link https://github.com/openstack/releases/blob/master/deliverables/rocky/openstack-ansible.yaml
04:48:37 <tpatil> That's correct. All patches will be reviewed by OSA team. We cannot approve any patches
04:49:32 <samP> tpatil: yep, but we could review them from Masakari prospective
04:49:54 <samP> niraj_singh: Let us know if you need any help on this.
04:49:58 <Dinesh_Bhor_> yes, we need to.
04:50:25 <niraj_singh> samP: We also need to add pacemaker for this role.
04:50:39 <tpatil> approve meaning +2/-2, we will definitely review patches
04:50:56 <niraj_singh> i will need help on that part.
04:51:01 <samP> tpatil: thanks. got it.
04:51:16 <tpatil> niraj_singh: There is already a pacemaker role that we can reused, correct?
04:51:33 <niraj_singh> yes.
04:51:49 <tpatil> s/reused/reuse
04:51:50 <samP> can you please send the link to that?
04:52:26 <niraj_singh> https://github.com/leucos/ansible-pacemaker-corosync
04:52:34 <samP> niraj_singh: ah..OK
04:53:38 <samP> niraj_singh: seems like we need to update this role a bit for latest
04:53:53 <tpatil> it's not part of openstack git repo
04:54:03 <samP> tpatil: yep, it is not.
04:54:40 <niraj_singh> there is another one https://github.com/devgateway/ansible-role-pacemaker
04:54:41 <samP> since I could not find any Licence for above code, we can only refer this code.
04:54:54 <tpatil> Is it used by any of the projects from OpenStack?
04:55:35 <samP> AFAIK, we dont have pacemaker role in OSA.
04:56:08 <samP> or you could ask cluster LAB ML
04:57:20 <samP> I think it is better to ask in cluster LAB ML for any details about ansible role for pacemaker and corosync
04:57:29 <niraj_singh> ok
04:57:42 <tpatil> https://clusterlabs.org
04:58:01 <samP> #link https://clusterlabs.org/
04:58:16 <samP> tpatil: thanks. same above
04:58:24 <tpatil> samP: OK
04:58:29 <samP> We only have 2 mins left.
04:58:57 <samP> I am planning to submit patches for RPM packaging and Ubuntu packaging
04:59:11 <samP> Will let you know more details.
04:59:24 <samP> nee to finish this meeting...
05:00:00 <samP> Please use #openstack-masakari on Freenode or openstack-dev ML with [masakari] for further discussions
05:00:07 <samP> Thanks all
05:00:10 <samP> #endmeeting