04:01:20 <samP> #startmeeting masakari
04:01:21 <openstack> Meeting started Tue Feb 26 04:01:20 2019 UTC and is due to finish in 60 minutes.  The chair is samP. Information about MeetBot at http://wiki.debian.org/MeetBot.
04:01:22 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
04:01:24 <openstack> The meeting name has been set to 'masakari'
04:01:31 <samP> Hi all for masakari
04:01:34 <tpatil> Hi
04:01:43 <samP> tpatil: hi
04:01:46 <ShilpaSD> Hi all
04:02:01 <samP> #topic critical bugs and patches
04:02:39 <tpatil> LP Bug : 1816941
04:02:53 <tpatil> #link : https://bugs.launchpad.net/masakari/+bug/1816941
04:02:55 <openstack> Launchpad bug 1816941 in masakari "Incorrect service_type passed for parsing micro-version from OpenStack-API-Version request header" [Critical,In progress] - Assigned to Shilpa Devharakar (shilpasd)
04:03:08 <tpatil> Patch up for review:https://review.openstack.org/#/c/638352/
04:03:51 <tpatil> basically sdk and masakariclient doesn't have provision to send x-openstack-api-version request headers
04:04:05 <tpatil> also the service type should be instance-ha instead of masakari
04:04:11 <tpatil> the above patch fixes this issue
04:04:24 <samP> tpatil: agree. patch is lgtm
04:05:01 <samP> tpatil: approved
04:05:16 <tpatil> and patch https://review.openstack.org/#/c/638346/ adds support to send X-OpenStack-API-Version request header
04:05:17 <samP> tpatil: thanks for bringing that up
04:06:16 <tpatil> for notification progress details feature, we want to add a new micro version 1.1
04:06:58 <tpatil> during adding this micro version supports , we found out the above problem
04:07:34 <samP> tpatil: thanks for fixing those.
04:08:05 <samP> I've just +2 the above patch.
04:08:21 <tpatil> samP: Ok, Thanks
04:08:35 <tpatil> Run all jobs by default using python3
04:08:43 <tpatil> #link : https://review.openstack.org/#/c/637714/
04:08:53 <tpatil> already voted +2, need another
04:09:19 <tpatil> and this one as well :https://review.openstack.org/#/c/637712/
04:09:20 <samP> tpatil: yep, I already did
04:09:52 <samP> tpatil: done.
04:10:08 <tpatil> for the remaining two patches, we will upload new PS soon
04:10:25 <samP> tpatil: Thanks
04:11:19 <tpatil> #link : https://review.openstack.org/#/c/636749/
04:11:32 <tpatil> The above patch fails on py3.6
04:11:58 <tpatil> Neha has set above patch as dependent on one of her patch and you can see the py3.6 job is failing
04:12:02 <tpatil> Neha's patch : https://review.openstack.org/#/c/637711/2
04:12:56 <tpatil> I will look into this issue sometime in this week
04:13:31 <samP> tpatil: I tried this patch in 18.04 and couldn't find a problem.
04:13:42 <samP> I will wait for your feedback
04:13:57 <tpatil> it runs fine on 3.5 but it fails on 3.6
04:14:37 <tpatil> In review 637711: we have added py3.6 env in tox
04:15:14 <tpatil> samP: Ok I will add a comment on the patch
04:17:03 <samP> tpatil: put a remark on the patch
04:17:42 <tpatil> samP: doing it right away
04:18:09 <tpatil> samP: Done
04:18:22 <samP> tpatil: thanks
04:19:55 <samP> This is a blocker for ubuntu people to do the packaging. We better solve this sooner
04:20:09 <samP> tpatil: thanks for the support
04:20:10 <tpatil> samP: yes
04:22:45 <samP> any other patches or bugs?
04:23:01 <tpatil> No
04:23:08 <samP> tpatil: Thanks
04:23:15 <samP> #topic Stein work Items
04:23:25 <samP> Any update on Stein work items
04:23:47 <samP> I have already approved the 2 spes
04:24:06 <tpatil> samP: Thank you
04:24:30 <tpatil> need review for patches : https://review.openstack.org/#/q/status:open+project:openstack/masakari+branch:master+topic:bp/notifications-in-masakari
04:25:56 <tpatil> Functional tests in Masakari
04:25:59 <samP> tpatil: I will do that. sorry for the delay
04:26:07 <tpatil> samP: Ok
04:26:16 <tpatil> First patch is up: https://review.openstack.org/#/c/633663/
04:26:31 <tpatil> since I have uploaded that patch, not voted +2
04:26:39 <tpatil> request other core reviewers to take a look at it
04:26:57 <samP> tpatil: thanks, I will do my review too
04:27:04 <tpatil> in that patch ,we have added CI jobs and tests for segments
04:27:48 <tpatil> working on adding tests for hosts and notifications
04:27:57 <samP> tpatil: thanks
04:28:05 <tpatil> for notifications, we will need tests for process and instance notifications
04:28:19 <tpatil> host notification will be done in the next cycle
04:28:33 <samP> tpatil: got it. thanks
04:28:57 <tpatil> Add progress details for recovery workflow
04:29:16 <tpatil> Implementation is in progress
04:29:32 <tpatil> masakari side changes are done but internal review is in progress
04:29:43 <tpatil> masakari-dashboard changes are done
04:30:02 <samP> tpatil: thanks
04:30:43 <tpatil> except one issue
04:30:54 <tpatil> some UI issue that needs to be resolved
04:32:08 <tpatil> Add devstack support for masakari-monitors
04:32:18 <tpatil> patch is up for review : https://review.openstack.org/#/c/638577/
04:33:00 <tpatil> I have updated Neha verbally to fix some issue. I will post those issues on the patch as well
04:33:15 <tpatil> once she upload patch , I will review that patch soon
04:33:38 <samP> tpatil: sure, thanks
04:33:45 <tpatil> except host-monitors, all other monitors will be installed by the masakari devstack plugin
04:34:53 <tpatil> That's all update from my side about Stein work items
04:35:18 <samP> tpatil: thanks. I will do the pending reviews
04:35:27 <samP> #topic AOB
04:36:00 <samP> This week is the final release for non-client libraries
04:36:10 <samP> #link https://releases.openstack.org/stein/schedule.html#s-final-lib
04:37:30 <tpatil> masakari-monitors?
04:38:08 <samP> tpatil: masakari-monitors is cycle-with-rc type
04:38:45 <tpatil> ok, then we don't need to worry about anything in this week, correct?
04:38:55 <samP> tpatil: correct
04:39:17 <samP> However, next week is the final release for python-masakariclient
04:39:48 <tpatil> we will need to add microversion 1.1 in python-masakariclient
04:39:55 <samP> before that or in same time, I would like to release a new version for masakari-dashboard too
04:40:08 <tpatil> but we cannot add that support until masakari support 1.1
04:40:57 <tpatil> we will upload patches by end of this week for notification progress details feature
04:41:28 <tpatil> changes are required in masakari, python-masakariclient and masakari-dashboard
04:42:08 <samP> tpatil: got it.
04:42:10 <tpatil> so we have only one week for review, will need your support in reviewing those patches
04:43:04 <samP> tpatil: sure, please push the patches for python-masakariclient at your earliest
04:43:55 <tpatil> samP: will do, actually it's one line change
04:44:40 <samP> tpatil: got it.
04:45:13 <tpatil> but I was holding those changes becoz masakari doesn't yet support 1.1 version, in that case it will give an error which I think is right thing to do. So will push that patch today
04:46:05 <tpatil> I mean if you pass ha-api-version as 1.1 and if it's not supported masakari, it will give an error
04:46:43 <tpatil> ideally once the micro-version is support in services, it should be made available in client
04:46:55 <tpatil> s/support/supported
04:48:14 <tpatil> we will set depends-on tag in python-masakariclient patch
04:48:35 <samP> tpatil: agree. I thought python-masakariclient change is a huge one. That's why I asked to upload it first. However it is not. So we may follow the normal work flow
04:48:40 <tpatil> but it's not possible to merge python-masakariclient before masakari patch
04:48:50 <tpatil> samP: Ok
04:49:08 <samP> tpatil: sure
04:49:23 <tpatil> That's all from my end
04:49:43 <samP> tpatil: thanks
04:49:58 <samP> Here is the release schedule for Stein.
04:50:04 <samP> #link https://releases.openstack.org/stein/schedule.html
04:50:26 <tpatil> MAr 04 - Mar 08
04:51:05 <samP> If no other items to discuss, we may finish today's meeting
04:51:14 <tpatil> samP: Ok
04:51:31 <samP> OK then. Thank you!
04:51:49 <tashiromt> thank you
04:51:51 <ShilpaSD> thank you all
04:53:16 <samP> please use #openstack-masakari on IRC @freenode or openstack-discuss@lists.openstack.org for further discussions
04:53:20 <samP> #endmeeting