06:02:47 <yoctozepto> #startmeeting masakari
06:02:47 <opendevmeet> Meeting started Tue Aug 17 06:02:47 2021 UTC and is due to finish in 60 minutes.  The chair is yoctozepto. Information about MeetBot at http://wiki.debian.org/MeetBot.
06:02:47 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
06:02:47 <opendevmeet> The meeting name has been set to 'masakari'
06:02:59 <yoctozepto> will be late (bad traffic)
06:04:25 <jopdorp> Ok
06:04:30 <suzhengwei> Take your time. Safety is the most important
06:16:53 <yoctozepto> ok, I'm ready :-)
06:17:10 <yoctozepto> #topic agenda
06:17:16 <yoctozepto> * CI status
06:17:16 <yoctozepto> * Important pending reviews (important bugfixes, backports)
06:17:16 <yoctozepto> * Next release planning
06:17:16 <yoctozepto> * Open discussion
06:17:20 <yoctozepto> #topic CI status
06:17:49 <yoctozepto> unfortunately, CI is broken on the masakari repo due to pip failing to reinstall libvirt-python
06:17:54 <yoctozepto> other repos are green
06:18:07 <yoctozepto> also, stable branches on masakari repo are green
06:18:18 <yoctozepto> only the masakari repo master branch is red
06:18:55 <yoctozepto> I will fix it later but there is no ultimate urgency at the moment
06:19:08 <yoctozepto> #topic Important pending reviews (important bugfixes, backports)
06:20:46 <yoctozepto> thanks suzhengwei for merging a chunk of those
06:21:01 <yoctozepto> only one left for backports: https://review.opendev.org/q/(project:openstack/masakari+OR+project:openstack/masakari-monitors+OR+project:openstack/python-masakariclient+OR+project:openstack/masakari-dashboard)+status:open+-branch:master
06:23:11 <yoctozepto> #topic Next release planning
06:23:34 <yoctozepto> Xena's taking big steps, we are very close to client lib freeze
06:23:43 <yoctozepto> (03 Sep)
06:24:39 <yoctozepto> this week we are freezing non-client-libs, which, for some reason, includes openstacksdk, but I will be fighting to include masakari additions should they arrive :-)
06:25:53 <yoctozepto> how are we with respect to new features?
06:26:01 <yoctozepto> I did not have time this week yet
06:27:11 <suzhengwei> I update the monitor driver by consul. It has a releasenote and doc descriptions.
06:27:24 <yoctozepto> ok, great
06:29:18 <suzhengwei> Some patches already has my +2. If you have time, please give a review.
06:29:52 <suzhengwei> patches mainly about doc.
06:36:01 <yoctozepto> mhm, yeah, I'll keep that one tabbed
06:36:08 <yoctozepto> approved some others thanks to your +2
06:36:46 <yoctozepto> please take some time to respond to final comments on https://review.opendev.org/c/openstack/masakari-specs/+/734017
06:37:02 <yoctozepto> I think it's easy to merge it like tomorrow
06:37:26 <yoctozepto> if you can't reproduce the image, then I guess we can just leave a comment that it has to be interpreted differently
06:37:30 <suzhengwei> thanks
06:38:58 <yoctozepto> ok, regarding specs themselveves, that's basically it
06:39:40 <yoctozepto> I will have a look at the implementation of the consul-based monitor
06:39:48 <yoctozepto> I saw you already refactored the driver, good
06:40:48 <yoctozepto> and good job excavating that old commit https://review.opendev.org/c/openstack/masakari/+/518653
06:41:21 <yoctozepto> I somehow missed it when I was applying archeology on the proposals :-)
06:41:46 <opendevreview> Merged openstack/masakari-monitors master: Remove conditionals for an ancient openstacksdk  https://review.opendev.org/c/openstack/masakari-monitors/+/802800
06:42:45 <suzhengwei> https://review.opendev.org/q/topic:%22add-docs%22+(status:open%20OR%20status:open)
06:43:15 <suzhengwei> I give +2 to one of them.
06:43:25 <yoctozepto> yeah https://review.opendev.org/c/openstack/masakari-monitors/+/789248
06:44:11 <yoctozepto> it needs addressing my previous comments
06:44:37 <yoctozepto> the basics are fine but we, e.g., should not be merging the autogenerated sample
06:45:40 <yoctozepto> if you want to address them, then please go ahead; if not, I can take care of them
06:45:50 <yoctozepto> still, thanks for rebasing :-)
06:48:32 <yoctozepto> #topic Open discussion
06:48:40 <yoctozepto> open to discuss anything
06:50:30 <suzhengwei> Would some one give one guide to install pacemaker?
06:50:52 <suzhengwei> I haven't seen it in the monitor doc.
06:52:30 <yoctozepto> it was proposed long time ago in https://review.opendev.org/c/openstack/masakari-monitors/+/489095
06:53:28 <yoctozepto> in kolla ansible, the hacluster role provides pacemaker; it's what can be consulted for correctness as it works fine
06:53:40 <yoctozepto> well, without any fencing at the moment
06:53:47 <yoctozepto> but fine otherwise
06:54:03 <suzhengwei> thanks
06:54:38 <suzhengwei> I added my reviewer to it.
06:55:45 <yoctozepto> thanks
06:55:55 <suzhengwei> The commit is partly duplicates of what the doc is now. So I plan to recommit it based on current docs.
06:56:11 <yoctozepto> yeah, that needs to be done
06:56:15 <yoctozepto> thanks for undertaking this
06:58:28 <yoctozepto> I have also seen new patchset from shenxinxin https://review.opendev.org/c/openstack/masakari/+/789460
06:58:32 <yoctozepto> but pep8 does not like it
06:59:31 <shenxinxin> yes,I konw. I will update these days.
06:59:37 <yoctozepto> please make sure all jobs pass (except for functional as they are broken at least at the moment - I will look for the best way to fix the gate)
06:59:41 <yoctozepto> ok,thanks
06:59:55 <yoctozepto> ok, everyone knows how to proceed
07:00:00 <yoctozepto> thank you for meeting today
07:00:07 <yoctozepto> #endmeeting