16:01:03 #startmeeting Mistral 16:01:03 Meeting started Mon Feb 13 16:01:03 2017 UTC and is due to finish in 60 minutes. The chair is rakhmerov. Information about MeetBot at http://wiki.debian.org/MeetBot. 16:01:05 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 16:01:07 The meeting name has been set to 'mistral' 16:01:09 Hey! 16:01:12 o/ 16:01:13 o/ 16:01:22 hi everyone ) 16:01:52 as you may guess we won't have a meeting next week 16:01:59 and the week after 16:02:21 ok, let's start 16:02:30 #topic Review Action Items 16:02:33 no action items 16:02:42 #topic Current Status 16:03:59 my status: completed refactoring of RPC serialization together with Dawid (https://review.openstack.org/#/c/429643/), fixed one simple bug with workflow context internal data, almost finished working on PTG etherpad 16:04:17 share your updates, if any 16:04:27 Why wont there be a meeting after the PTG? 16:04:44 no update from me. just preparing for PTG 16:04:47 Not much from my side, helped Renat with RPC serialization 16:05:01 No update from me, other than I have tired legs from skiing. 16:05:07 d0ugal: well, you can have it, but I won't be available 16:05:18 rakhmerov: okay, that's fine - we can skip it. Just checking. 16:05:21 I'll take a couple of days off 16:05:28 Good idea :) 16:05:49 working on documenting the tasks function. https://review.openstack.org/#/c/433096/ 16:05:54 d0ugal: let's get back to it in the end of this week. If you'll have what to discuss, why not have it 16:06:05 mgershen: is it ready for review? 16:06:24 yes 16:06:31 ok, great 16:06:46 d0ugal: still waiting for your review on https://review.openstack.org/#/c/429643/ 16:06:57 mgershen: nice! I'll look check it out. 16:07:00 i'd like to push it into rc2 16:07:09 and I really want input on how to document it, because I fear we might want to change what exactly should return for each task in the list 16:07:37 d0ugal: thanks, please do 16:07:46 rakhmerov: I actually did review it, I just didn't vote yet. I wasn't sure I was awake enough to fully understand it 16:07:50 rakhmerov: I think it looks good. 16:07:50 mgershen: do not fear, may the OpenStack force be with you 16:07:52 :) 16:08:27 rakhmerov: I guess either you or ddeja needs to review it? who else would be the second reviewer? 16:08:29 haha :) 16:08:32 d0ugal: did you get an idea and what problem I was trying to solve? 16:08:55 d0ugal: mostly Dawid 16:08:57 rakhmerov: no, not fully - it would be good it the problem was stated in the commit message :) 16:09:02 well, I don't know, we both can 16:09:26 d0ugal: how about talking tomorrow in IRC? 16:09:34 rakhmerov: sure, that sounds good. 16:09:46 I listed some major points, maybe still need more details, dunno 16:09:50 I can explain 16:09:56 ok 16:10:01 let's move on 16:10:13 #topic Ocata RC-2 readiness 16:10:31 if anyone else wants to review here is the docs preview (gate-tripleo-ci-centos-7-nonha-multinode test is stuck for a while): http://docs-draft.openstack.org/96/433096/1/check/gate-mistral-docs-ubuntu-xenial/00c127f//doc/build/html/dsl/dsl_v2.html#tasks-function 16:10:34 rakhmerov: the points in the commit message say what you did, but I don't think they really explain "why" - but maybe I need to read it again 16:10:38 this we're releasing RC2 which is supposed to be the final Ocata release 16:11:09 d0ugal: I'll look at the message again and see if I can improve it 16:11:25 thanks 16:11:28 mgershen: thanks, usually TripleO gate takes long, that's normal 16:12:16 d0ugal: briefly, our serialization system didn't work for custom types at all. Although we had, for example, ResultSerializer. It wasn't just used 16:12:38 d0ugal: moving forward we'll need more custom classes sent over RPC 16:13:10 I looked at OVO (oslo versioned project) which was a good candidate to use, but I thought it was kind of an overkill for what I wanted to achieve 16:13:25 ok, so RC2 this week 16:13:52 I'd like to ask all of you to check whether you want to squeeze anything else into RC2 16:14:09 and please be ready to review stuff in case of some urgent bugs 16:14:15 d0ugal and ddeja especially 16:14:18 rakhmerov: I'll have one thing 16:14:27 test coverage? 16:14:32 worse 16:15:00 I don't have anything. 16:15:00 ok 16:15:06 today I looked on test coverage, why it may fail and why on earth kombu driver have coverage 0% 16:15:06 ddeja: what's that? 16:15:15 so? 16:15:19 so I did this: https://review.openstack.org/#/c/433074/ 16:15:36 so, from some point (I have no idea when it stared) 16:15:54 tests from unit/engine/rpc_backend/kombu/* didn't get run at all 16:15:56 wooooooow!! 16:16:05 :( 16:16:06 X.X 16:16:07 epic fail :)) 16:16:14 I remember when it was failing 16:16:24 goosh.. 16:16:34 becouse I was making changes that was making tox to fail and I was fixing unit tests 16:16:59 but when I was making kombu driver work with rabbit in HA, I haven't fixed any unit tests 16:17:03 ddeja: the __init__ was deleted here: https://github.com/openstack/mistral/commit/5341fb2b5bc255410a04726ef24de2d95607c1f6 16:17:03 ok, do you think it's that serious? 16:17:13 is there a lot of stuff that really needs to be fixed? 16:17:15 I can help 16:17:21 rakhmerov: not a lot 16:17:25 I'll do it tommorow 16:17:30 I need this 100% ready 16:17:42 It's only 15 tests after all 16:17:46 oh, thanks d0ugal 16:18:17 ok, it was done by mistake I guess. Happens sometimes 16:18:19 no worries 16:18:23 yup 16:18:25 let's just fix it 16:18:27 hm, pycharm 16:18:39 ddeja: I'll be available to help 16:18:42 when I deleted the only file in dir, it also deleted __init__ 16:18:49 :( 16:18:50 any time of the day and night 16:18:56 This is why I use vim :-D 16:19:25 rakhmerov: thanks, but from the logs it's nothing hard to fix 16:19:27 d0ugal: I'm thinking to learn it back (I used to use it a lot ~8 years ago) 16:19:32 ok 16:19:50 I should have it by tommorow 12 UTC 16:20:02 if no, I'll let you guys know :) 16:20:08 d0ugal: any chance we can get https://bugs.launchpad.net/mistral/+bug/1627689 fixed? 16:20:08 Launchpad bug 1627689 in Mistral "Openstack service client caching breaks security and backward compatibility" [Medium,In progress] - Assigned to Dougal Matthews (d0ugal) 16:20:20 I guess unlikely, right? 16:20:30 rakhmerov: good question. I think it is quite complicated so it might be a bit late 16:20:41 I had forgotten about it 16:21:02 :) Ok, in Pike I'll do a better job reminding you about it 16:21:20 hah, sorry - I should do a better job of keeping up with my bugs. 16:21:28 Ocata has been too short :( 16:21:47 yes, true 16:22:17 ok, then please look at your tasks and move them to Pike if you see you won't complete them 16:22:52 I'll try to finish my two tasks on doc 16:23:44 d0ugal: I'd ask you to look at https://bugs.launchpad.net/mistral/+bug/1641174 16:23:44 Launchpad bug 1641174 in Mistral "Update the Mistral documentation to reflect the addition of Jinja2" [Medium,Confirmed] - Assigned to Dougal Matthews (d0ugal) 16:23:58 maybe you'll have time in the next 2 days to do it 16:25:09 rakhmerov: I assume documentation changes can be added after RC2? 16:25:15 but yeah, I will try and look into it 16:25:22 ok 16:25:26 sorry for the stupid question, where can I see all the issue in mistral that are assigned to me in Ocata? 16:25:31 but we really need to avoid getting into this situation again - can we require docs for features from Pike onwards? 16:25:43 mgershen: https://launchpad.net/mistral/+milestone/ocata-rc2 16:25:54 it's for Ocata RC2 16:26:46 d0ugal: yes, we touched this topic on the previous meeting. We'll need to require docs for all new features as part of "definition of done" for any task 16:26:47 rakhmerov: thank you 16:26:55 rakhmerov: great 16:27:14 I shall read the meeting log 16:27:36 d0ugal: having said that, I still think it should be OK to split into separate patches but we should look at "Implements" and "Closes-bug" more carefully and require docs 16:27:59 yeah, maybe we should require at least a docs draft 16:28:01 it could be sent as dependent patches 16:28:11 yup 16:28:12 yes, something like this 16:28:27 d0ugal: we can even require docs in the same patch if it's something small 16:28:29 It also makes it easier to review a new feature if you have docs :) 16:28:34 I mean, common sense will help 16:28:42 true 16:29:19 d0ugal: a general comment: we're very bad at planning now 16:29:22 I think all suggestions are good. 16:29:27 which is, of course, mostly my fault 16:29:41 I'd appreciate if you helped me improve in this aspect 16:30:04 I can try - how can we make planning more of a team effort? 16:30:44 first thing I see: be more active with that in ML 16:30:56 schedule meetings for planning 16:31:02 for but triaging 16:31:06 etc. 16:31:29 I'll come up with proposals on what we need to be doing 16:31:35 sounds good 16:31:49 and that should be done no matter what :) 16:32:20 except very rare cases may be like summits, PTGs etc. 16:33:01 next topic 16:33:13 #topic PTG topics final review 16:33:38 https://etherpad.openstack.org/p/mistral-ptg-pike 16:34:16 I put some more details into it today (Dawid did too) 16:34:51 Looks like a great doc. 16:34:52 I'd suggest you review the list of topic again and see if something important is missing 16:35:14 either in the topic list itself and/or some info about particular topics 16:35:21 d0ugal: thanks, trying hard ) 16:35:50 A couple of things are still don't have enough details 16:35:55 like Mistral/Glare 16:36:03 which is an important thing IMO actually 16:36:12 I am curious to hear about that :) 16:36:14 I'll do it tomorrow 16:36:17 rakhmerov: BTW, I'd like to ask for that thing 16:36:29 d0ugal: yeah, I guess I already told you a little bit about this idea 16:36:30 who's request is to add this support? 16:36:42 it's been my dream for a couple of years to implement something like this 16:37:00 ddeja: it's been mostly my idea 16:37:12 ok, so it's an inner request, not coming from some company :) 16:37:17 but people asked for something similar too 16:37:17 thanks 16:37:31 in a different form maybe but the reason is the same 16:37:38 coming, coming 16:38:00 not only internal 16:38:05 ok 16:38:14 now we just finally have resources to implement it 16:38:17 really 16:38:29 I think it will be done in the next few months 16:38:47 ddeja: for example, kong was requesting it too 16:38:54 OK 16:39:03 he even tried to implement a similar thing already 16:39:16 the patch is still on review somewhere, I can find it 16:39:22 the demand was the same 16:39:30 I hadn't even heard of Glare before this :) 16:39:43 ok, I'll let you all know when I put more details (ideally with WF snippets) 16:40:03 d0ugal: yeah, it's making some noise now in the community 16:40:22 there's even an idea to replace most of Glance with it 16:40:24 :) 16:40:54 I only saw that recently in the ML thread. Has there been other discussions about glare vs glance somewhere else? 16:41:14 btw, Mike (Glare PTL) will be at the PTG too, we'll be able to discuss this topic with him 16:41:45 rbrady: I guess not yet, but there will be definitely some 16:42:10 stay tuned 16:43:27 just a couple of words about how I'd like to approach PTG discussions: I formally divided all topics into three categories (functional reqs, non functional, architecture) 16:43:45 I'd like to discuss at least top 3 in each categories 16:44:14 so we need to make sure that top 3 are really that we think have higher priority 16:45:15 by "discuss" I mean to have all necessary work items be able to proceed with it, all conceptional roadblocks should be clarified and a solution is found 16:45:32 that's my goal 16:45:44 sounds good 16:45:55 yeah 16:46:10 how many hours do we have? 16:46:10 let's see how many people will come though 16:46:17 mgershen: 3 days 16:46:37 practically, we'll have 2.5 days 16:46:42 rakhmerov: I think it would be a good idea to try and give some days/times for the different topics 16:46:44 I don't count Fri afternoon 16:47:04 Otherwise if somebody can't attend every day, how will they know when to come? 16:47:16 d0ugal: yes, reading my thoughts, I was gonna say I'd plan this for tomorrow 16:47:23 cool 16:47:39 d0ugal: agree 16:47:43 way ahead of me then :) 16:48:23 rbrady, d0ugal: I'd ask you to look at Actions API topic and add all things that you're worried about 16:48:36 rakhmerov: ack 16:48:37 so that we can discuss productively 16:48:44 +1 16:48:49 I put all that I was able to recall today 16:48:52 :) 16:49:08 can't get more from my head I guess ) 16:49:17 I will look at this tomorrow 16:49:24 yep, thx 16:50:21 so, just summarizing: add whatever info you think is needed, I'll be looking at it again and fixing/beautifying before the event 16:50:33 it's better to have more than less 16:50:38 for this kind of work 16:50:54 that's probably all from my side 16:51:23 Sounds good 16:51:35 any other comments/remarks? 16:51:57 Nothing from me 16:52:03 ok 16:52:07 #topic Open Discussion 16:52:30 anything else may be on other things? 16:52:37 mgershen, ddeja, rbrady 16:52:46 nothing from my side 16:52:50 ok 16:52:59 I really want feedback about the docs, but it can be done there. 16:53:22 mgershen: no worries, we'll review your patch and give a feedback 16:53:32 or you want it now? 16:53:33 nothing from me. I'll look at updating the etherpad 16:53:40 ok 16:54:12 mgershen: ^ 16:54:15 so see you next week? 16:54:20 ok :) 16:54:21 yes 16:54:24 and in the review:-D 16:54:27 yup, next week or in #openstack-mistral 16:54:29 right ) 16:54:30 ... or in gerrit! 16:54:44 ok, thanks guys 16:54:51 cya 16:54:52 pleasure to work with you 16:54:53 bye 16:54:58 bye 16:55:03 #endmeeting