15:01:05 <d0ugal> #startmeeting mistral
15:01:06 <openstack> Meeting started Mon Apr 16 15:01:05 2018 UTC and is due to finish in 60 minutes.  The chair is d0ugal. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:01:07 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:01:09 <openstack> The meeting name has been set to 'mistral'
15:01:11 <d0ugal> d0ugal,rakmerov,apetrich: Office hour time!
15:01:20 <d0ugal> https://etherpad.openstack.org/p/mistral-office-hours
15:01:31 <d0ugal> I am going to start pinging people on line 17 of that etherpad
15:01:40 <d0ugal> Add your IRC nick if you want a ping when the office hour starts.
15:03:22 <d0ugal> mcdoker181818: We can talk about your question, if you are still around.
15:03:41 <mcdoker181818> Yea, i'm here
15:05:21 <d0ugal> bobh: Thanks for the typo fix!
15:05:23 <d0ugal> rakhmerov: ^
15:06:37 <bobh> d0ugal: :-)
15:07:23 <d0ugal> mcdoker181818: so I am not very familiar with that code
15:07:26 <d0ugal> Just reading it now.
15:09:06 <mcdoker181818> How to change the nickname color? I don't want to be pink :D
15:09:24 <d0ugal> mcdoker181818: click on the icon on the top right
15:09:56 <d0ugal> mcdoker181818: I think you have found a bug, I am not sure about the code but I don't think that workflow should be stuck in RUNNING.
15:10:03 <d0ugal> because it isn't :)
15:10:24 <d0ugal> It should, IMO, be in an error state.
15:11:44 <therve> d0ugal, I tested the token expiration bug a little bit
15:11:51 <therve> I could reproduce it with a heat action as well
15:12:13 <d0ugal> therve: Interesting.
15:12:21 <d0ugal> so that means it is likely our fault.
15:12:23 <d0ugal> Darn
15:12:30 <therve> d0ugal, I tried a few quick fixes, but I didn't make it work
15:12:42 <therve> Session stuff is confusing
15:12:49 <d0ugal> yeah, it really is.
15:13:12 <therve> Using token_endpoint.Token seems like a big no-no though
15:13:23 <d0ugal> Is that something we do?
15:13:34 <therve> https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/token_endpoint.py#L19
15:13:36 <d0ugal> I have not looked at that code for some time.
15:13:38 <d0ugal> ta
15:13:45 <therve> Yeah that's what get_session_and_auth creates
15:13:54 <d0ugal> oh yeah
15:14:32 <therve> At any rate, it's really easy to reproduce with std.sleep and any action
15:14:42 <therve> Ideally after reducing token expiration time
15:14:56 <therve> (Though not too little because I don't think it's supported)
15:15:01 <d0ugal> therve: yeah, I never reduced the expiration which made testing tedious.
15:15:17 <therve> Yeah
15:15:23 <d0ugal> https://github.com/d0ugal/tripleo-util/blob/master/scripts/tests/general.yaml#L8-L31
15:15:30 <d0ugal> but I did a similar test
15:15:56 <mcdoker181818> d0ugal: Should i create a ticket and just fix it?
15:16:05 <d0ugal> mcdoker181818: yes please
15:16:26 <d0ugal> mcdoker181818: I think adding what you suggested makes sense - but it would be good to get more eyes on that idea. A review is probably the best place for it.
15:16:48 <d0ugal> mcdoker181818: if you send me a bug I can triage it.
15:17:06 <d0ugal> therve: do you have a link to the bug handy? I can't find it.
15:17:46 <d0ugal> Got it.
15:17:49 <d0ugal> https://bugs.launchpad.net/tripleo/+bug/1761050
15:17:50 <openstack> Launchpad bug 1761050 in tripleo "Mistral or Zaqar fail to maintain a keystone session while deploying an overcloud" [High,Triaged]
15:19:41 <d0ugal> bobh: did you have anything you want to talk about?
15:23:04 <openstackgerrit> Brad P. Crochet proposed openstack/mistral stable/pike: Remove any old client actions that no longer exist  https://review.openstack.org/561649
15:23:30 <d0ugal> thrash: Nice! I have been wanting to do that.
15:25:12 <thrash> d0ugal: I'm not sure how much of that is relevant for pike though. We'll need to keep a close eye on the logs to make sure it doesn't introduce new issues.
15:25:47 <d0ugal> thrash: oh, I didn't notice that was a backport. I missed the original patch.
15:25:52 <thrash> :D
15:25:58 <d0ugal> thrash: yeah, I have no idea how to verify that patch.
15:26:09 <d0ugal> We do not have good coverage of all those actions
15:26:16 <d0ugal> so I am not sure it is safe to backport?
15:26:38 <thrash> d0ugal: Not really, no. Maybe we need a job that tests action creation against devstack?
15:27:03 <thrash> d0ugal: and reports on actions that can't be created?
15:27:17 <d0ugal> thrash: That would be good.
15:27:37 <thrash> d0ugal: All I can think of right now is specifically looking at the tripleo job when it is done to see what the logs say.
15:27:48 <d0ugal> thrash: does it have every client?
15:27:50 <thrash> d0ugal: https://bugzilla.redhat.com/show_bug.cgi?id=1516056
15:27:56 <openstack> bugzilla.redhat.com bug 1516056 in openstack-mistral "mapping error in mistral-db-manage.log" [High,Post] - Assigned to brad
15:27:56 <thrash> related bz
15:28:03 <thrash> d0ugal: tripleo does not, no.
15:28:22 <thrash> d0ugal: which is why we would need a devstack job that would have it.
15:28:31 <d0ugal> oh, January - that is why I missed the original patch.
15:28:49 <d0ugal> I have no memory of January.
15:29:07 <thrash> bahaha
15:30:08 <mcdoker181818> d0ugal: https://bugs.launchpad.net/mistral/+bug/1764441
15:30:09 <openstack> Launchpad bug 1764441 in Mistral "Timeout policy doesn't work with retry policy properly" [Undecided,New]
15:30:33 <d0ugal> thrash|f00dz: Looks like the devstack jobs currently log it. Just need to dig around. http://logs.openstack.org/75/561175/4/check/mistral-devstack-kombu/5f97c38/job-output.txt.gz#_2018-04-16_12_12_20_482901
15:30:53 <d0ugal> Quite a few failures in there.
15:30:59 <d0ugal> mcdoker181818: Thanks!
15:31:38 <d0ugal> mcdoker181818: What is your launchpad username? or you can just assign it to yourself if you want to work on it.
15:31:52 <d0ugal> I put it as Rocky-2 (Rocky-1 ends on Friday)
15:32:42 <mcdoker181818> Done.
15:33:33 <d0ugal> Thanks
15:34:05 <d0ugal> Okay, I am going to do some bug triage for 25 mins
15:34:14 <d0ugal> but I'll be around and happy to talk about whatever if people have topics.
15:34:52 <d0ugal> We have 13 "NEW" bugs - I hope to triage all of these by the end of the week.
15:34:54 <d0ugal> https://bugs.launchpad.net/mistral/+bugs?search=Search&field.status=New&orderby=id&start=0
15:37:20 <d0ugal> Starting with https://bugs.launchpad.net/mistral/+bug/1504725
15:37:21 <openstack> d0ugal: Error: Could not gather data from Launchpad for bug #1504725 (https://launchpad.net/bugs/1504725). The error has been logged
15:37:21 <d0ugal> It looks like Andras was able to confirm this in Mistral recently. So I guess it is legit. The two other projects closed it however which is interesting.
15:37:21 <d0ugal> It is a very old bug.
15:40:18 <d0ugal> Confirmed it for now, assume it is fairly low priority as it has been around for such a long time.
15:40:25 <d0ugal> Next. https://bugs.launchpad.net/mistral/+bug/1655273
15:40:26 <openstack> Launchpad bug 1655273 in Mistral "Human-readable failed action error" [Undecided,New]
15:41:28 <d0ugal> I think this is actually quite an important one. The error formatting for actions isn't great. It is hard to use programatically
15:41:40 <d0ugal> I would say it is human readable now, just - but isn't really machine readable.
15:42:09 <d0ugal> All the information is good to have, but it is hard to extract just the error message (if you want to show it to users for example)
15:45:37 <d0ugal> Triaged and commented.
15:46:22 <d0ugal> https://bugs.launchpad.net/mistral/+bug/1660590
15:46:22 <openstack> Launchpad bug 1660590 in Mistral "Mistralclient does not pass cacert to other Openstack clients" [Undecided,New]
15:46:36 <d0ugal> I am not sure about this. I don't really know anything about cacerts in OpenStack clients.
15:47:55 <d0ugal> Marked as Incomplete and I asked a question.
15:48:03 <d0ugal> https://bugs.launchpad.net/mistral/+bug/1660853
15:48:04 <openstack> Launchpad bug 1660853 in Mistral "Lexical error when registering std.wait_ssh action" [Undecided,New]
15:48:58 <mcdoker181818> I faced with this problem. And I fixed it somehow...
15:49:24 <d0ugal> mcdoker181818: the lexical error?
15:49:35 <mcdoker181818> with tls
15:51:01 <d0ugal> oh, interesting
15:51:03 <mcdoker181818> But i rewrite openstack actions, and because I can't merge fix :)
15:51:19 <d0ugal> You can't? Why not?
15:52:41 <mcdoker181818> My openstack action differs from vanilla version
15:52:50 <d0ugal> ah, I see
16:01:25 <d0ugal> Okay, that is the end of the slot!
16:01:52 <d0ugal> Thanks everyone. Next slot is probably Friday morning - I can never make the Wednesday one
16:01:58 <d0ugal> I am still thinking we should cancel or move it.
16:02:10 <d0ugal> Until next time!
16:02:13 <d0ugal> #endmeeting