08:04:05 <d0ugal> #startmeeting mistral
08:04:06 <openstack> Meeting started Fri May 25 08:04:05 2018 UTC and is due to finish in 60 minutes.  The chair is d0ugal. Information about MeetBot at http://wiki.debian.org/MeetBot.
08:04:07 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
08:04:10 <openstack> The meeting name has been set to 'mistral'
08:04:25 <d0ugal> It is the Friday office hour! :)
08:04:27 <d0ugal> Who is around?
08:04:29 <d0ugal> https://etherpad.openstack.org/p/mistral-office-hours
08:05:09 <d0ugal> rakhmerov, apetrich, bobh, mcdoker181818: PING! :)
08:05:24 <apetrich> o/
08:05:35 <apetrich> Morning folks
08:14:32 <d0ugal> We have no "NEW" bugs
08:14:38 <d0ugal> but we do have one "UNDECIDED" - https://bugs.launchpad.net/mistral/+bug/1772897
08:14:39 <openstack> Launchpad bug 1772897 in Mistral "Event-triggered workflows fail on start" [Undecided,Confirmed]
08:15:51 <d0ugal> I have never actually used the event trigger stuff to start workflows. How does it work?
08:29:45 <therve> d0ugal: AFAIU, it listens on rabbit notifications, and trigger workflows from them
08:30:05 <d0ugal> therve: thanks, I'll try and grep for that
08:30:14 <d0ugal> brb
08:30:33 <therve> https://github.com/openstack/mistral/blob/master/mistral/event_engine/default_event_engine.py#L268 is the meat
08:31:25 <therve> Probably none should use this :)
08:37:13 <d0ugal> therve: Why not?
08:37:23 <d0ugal> I guess nobody does if that bug is valid...
08:43:35 <openstackgerrit> Dougal Matthews proposed openstack/mistral master: Fix the call to start_workflow from events triggers  https://review.openstack.org/570535
08:44:04 <d0ugal> I guess that might fix it ^
08:48:41 <apetrich> d0ugal, I agree with the solution. but there's no test to know if that will work, right?
08:49:22 <d0ugal> apetrich: Just wondering that :) waiting for tox to finish.
08:50:05 <d0ugal> Well, there is a crappy mock test
08:50:09 <d0ugal> but that doesn't verify anything
08:50:21 <apetrich> I was about to mention it
08:50:22 <apetrich> :)
08:51:05 <openstackgerrit> Dougal Matthews proposed openstack/mistral master: Fix the call to start_workflow from events triggers  https://review.openstack.org/570535
08:51:38 <d0ugal> apetrich: see ^
08:51:56 * apetrich wonders how are still getting those errors related to that parameter
08:52:05 <d0ugal> lol
08:52:19 <apetrich> is that still wfexecution_id thing right?
08:52:45 <apetrich> it is
08:52:50 <apetrich> :) that was fast
08:52:54 <d0ugal> yeah
08:53:12 <apetrich> thanks I'm happy with that
08:53:24 <d0ugal> Really?
08:53:26 <d0ugal> lol
08:53:38 <apetrich> happy enough that the fix is valid
08:55:58 <d0ugal> brb
08:56:07 <d0ugal> I am going to end the meeting, but I'll still be around (in 5 mins)
08:56:10 <d0ugal> #endmeeting