15:01:14 <d0ugal> #startmeeting mistral
15:01:15 <openstack> Meeting started Mon Jun  4 15:01:14 2018 UTC and is due to finish in 60 minutes.  The chair is d0ugal. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:01:16 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:01:19 <openstack> The meeting name has been set to 'mistral'
15:01:22 <d0ugal> Who is around today?
15:01:28 <opetrenko_> here
15:01:34 <d0ugal> opetrenko_: Hey
15:01:45 <d0ugal> pgaxatte: did you manage to answer your question?
15:01:59 <opetrenko_> what question?
15:02:27 <pgaxatte> d0ugal: I think so :) I used "openstack workflow execution update -s CANCELLED"
15:02:48 <d0ugal> opetrenko_: How to stop a running execution
15:02:52 <d0ugal> pgaxatte: yup, that is correct
15:03:10 <d0ugal> We should document that and/or make a more obvious way to do it.
15:04:16 <pgaxatte> yeah it feels like I'm just setting a flag somewhere in DB and that this command will not actively stop anything
15:04:20 <pgaxatte> but it seems it does
15:04:38 <opetrenko_> New topic for new documentation
15:05:01 <opetrenko_> Probably we should ask as much people as we can, what do they need in docs
15:05:09 <pgaxatte> also I noticed the execution delete <id> does not work in this case
15:05:23 <pgaxatte> and the --force just returns an error
15:05:58 <d0ugal> pgaxatte: In what case? What was the error?
15:06:04 <d0ugal> opetrenko_: Agreed, it would be good to get feedback.
15:06:19 <pgaxatte> openstack workflow execution delete --force 5022e724-e582-4394-9b06-2271b0ea1fa5
15:06:19 <pgaxatte> Unknown argument: "force"
15:06:19 <pgaxatte> Unable to delete the specified execution(s).
15:06:28 <pgaxatte> the workflow was still running
15:06:45 <d0ugal> pgaxatte: Which version are you using? --force is quite new.
15:07:08 <opetrenko_> Yeah, because now There is only my opinion about what should be in it, but we can find minimal required topic for everyone
15:07:10 <d0ugal> opetrenko_: I added the Mistral core reviewers to your patch to try and get more eyes on it.
15:07:36 <pgaxatte> 3.14.0 for openstack cli, 3.5.0 for mistralclient and 5.2.2 for mistral infra
15:07:54 <opetrenko_> well, thats cool but not really
15:08:08 <opetrenko_> we need opinion from other users
15:08:10 <d0ugal> pgaxatte: So you have --force in mistralclient, but not in mistral server.
15:08:24 <pgaxatte> d0ugal, reading back my terminal, I got the exact same error without --force
15:08:25 <d0ugal> opetrenko_: Yes, of course, but it is a start.
15:08:55 <d0ugal> pgaxatte: Right, I guess you have hit a bug somewhere. I would check the mistral logs for errors
15:10:47 <d0ugal> opetrenko_: I don't have a good way to contact users and get their feedback.
15:12:25 <pgaxatte> d0ugal: the bug is client-side since I don't give the --force but it still appears in the URL called
15:12:38 <d0ugal> pgaxatte: aha, damn
15:12:46 <d0ugal> that is bad
15:13:08 <d0ugal> pgaxatte: If you downgrade to mistralclient 3.4.0 that will solve it
15:13:22 <d0ugal> I'm going to open a bug for this, we need a fix. Other people will hit this soon
15:14:12 <pgaxatte> by the way, the execution delete, is just supposed to remove it from the database like the expiration processus would do, right?
15:14:29 <d0ugal> pgaxatte: yup
15:14:34 <pgaxatte> if the workflow is still running, would it kill it?
15:14:42 <d0ugal> pgaxatte: but the expiration wont delete running workflows
15:14:44 <d0ugal> pgaxatte: yes
15:14:53 <pgaxatte> ok
15:15:24 <pgaxatte> there is no automatic expiration of any kind for a running workflow?
15:15:33 <d0ugal> pgaxatte: No, I don't believe so
15:15:46 <d0ugal> https://bugs.launchpad.net/mistral/+bug/1775027
15:15:48 <openstack> Launchpad bug 1775027 in Mistral "Execution deletion doesn't work if you use mistralclient 3.5.0 with Queens or earlier" [Critical,Confirmed]
15:16:47 <d0ugal> I'll take a look into this bug tomorrow.
15:17:03 <d0ugal> I suspect some of my colleagues will hit it soon :)
15:17:10 <d0ugal> pgaxatte: ^
15:17:47 <pgaxatte> d0ugal, ok great :)
15:18:02 <pgaxatte> I think I found it
15:18:06 <openstackgerrit> Toure Dunnon proposed openstack/mistral-extra master: Add Ansible actions to Mistral  https://review.openstack.org/514360
15:19:55 <pgaxatte> d0ugal: https://git.openstack.org/cgit/openstack/python-mistralclient/tree/mistralclient/api/v2/executions.py#n122
15:20:41 <d0ugal> pgaxatte: yup, exactly
15:21:06 <d0ugal> pgaxatte: If you like you can propose a fix - we just need to make sure the parameter isn't included unless it is set to true.
15:21:11 <pgaxatte> force is always included in the url parameters
15:21:21 <pgaxatte> exactly
15:21:27 <pgaxatte> I can try to submit that :)
15:21:31 <d0ugal> Great
15:21:36 <d0ugal> If you don't get a chance I can do it tomorrow
15:30:42 <openstackgerrit> Pierre Gaxatte proposed openstack/python-mistralclient master: Fix force parameter being always added to URL in execution delete  https://review.openstack.org/572136
15:32:47 <pgaxatte> d0ugal: let me know if the fix is ok with you, if needed I can take another look tomorrow
15:33:19 <d0ugal> pgaxatte: I think that looks pretty good.
15:33:35 <pgaxatte> i tried running tox but it fails even on master
15:33:41 <d0ugal> I'll try and get apetrich to review it too - he worked on this feature.
15:33:46 <d0ugal> pgaxatte: oh, what error?
15:34:26 <pgaxatte> oh nevermind, I wasn't on master, just a test branch :D
15:35:16 <d0ugal> lol
15:36:02 <pgaxatte> sometimes your cool prompt on zsh is just too long and you don't see the important info :D
15:36:52 <d0ugal> I am running the tests locally.
15:38:01 <pgaxatte> d0ugal: gotta go, I'll read your comments tomorrow if any. Bye!
15:42:27 <d0ugal> Sure
15:49:44 <d0ugal> I'm going to end things a little early
15:50:00 <d0ugal> Thanks all, hopefully we can continue discussing the documentation and get more input over time.
15:50:03 <d0ugal> #endmeeting