15:00:43 <rhochmuth> #startmeeting monasca
15:00:47 <openstack> Meeting started Wed Mar  8 15:00:43 2017 UTC and is due to finish in 60 minutes.  The chair is rhochmuth. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:47 <kornica> \0
15:00:48 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:50 <openstack> The meeting name has been set to 'monasca'
15:00:56 <rhochmuth> https://etherpad.openstack.org/p/monasca-team-meeting-agenda
15:00:58 <rhochmuth> o/
15:01:01 <dhague> o/
15:01:01 <hosanai> o/
15:01:03 <cbellucci> o/
15:01:07 <bklei> o/
15:01:08 <stevejims> o/
15:01:11 <shinya_kwbt> o/
15:01:29 <rhochmuth> hi everyone, and welcome to another installment of monasca, where all your monitoring dreams can come trye
15:01:32 <rhochmuth> true
15:01:49 <rbak> o/
15:01:53 <bklei> :)
15:02:01 <rhochmuth> sorry folks, i've been pretty sick this past week
15:02:07 <witek> hello
15:02:08 <kornica> lol...I am gonna get a pony...finally :D
15:02:14 <cbellucci> good morning :)
15:02:17 <rhochmuth> so, i've been out of commission
15:02:26 <kornica> Dr. Monasca's been sick ? that is unheard of
15:02:26 <bklei> bummer
15:02:46 <kornica> yeah, we've noticed lack of -1 @ gerrit :P
15:03:10 <rhochmuth> ok, well we might as well get started with the agenda
15:03:17 <rhochmuth> https://etherpad.openstack.org/p/monasca-team-meeting-agenda
15:03:24 <rhochmuth> 1. Reviews:
15:03:24 <rhochmuth> 1.1 https://review.openstack.org/#/c/437159/
15:03:24 <rhochmuth> 2.2 https://review.openstack.org/#/c/433016/
15:03:24 <rhochmuth> 2.3 https://review.openstack.org/#/c/442957
15:03:24 <rhochmuth> 2.4 https://review.openstack.org/#/c/395897/
15:03:25 <rhochmuth> 2.5 https://review.openstack.org/#/c/422108/
15:03:25 <rhochmuth> 2. Colon in dimension key + value
15:03:26 <rhochmuth> 2.1 https://review.openstack.org/#/c/439612/5
15:03:27 <rhochmuth> 2.2 https://bugs.launchpad.net/monasca/+bug/1668937
15:03:27 <openstack> Launchpad bug 1668937 in Monasca "Dimensions with Colons raises malformed exception in monasca-api" [High,New]
15:03:28 <rhochmuth> 2.3 https://bugs.launchpad.net/monasca/+bug/1671085
15:03:32 <kamil_> o/
15:03:35 <openstack> Launchpad bug 1671085 in Monasca "Allow colon in dimension key" [Medium,New]
15:03:44 <rhochmuth> #topic https://review.openstack.org/#/c/437159/
15:03:50 <bklei> that one is me
15:04:11 <bklei> it was a patch following up on a conversation we had about a month ago
15:04:13 <rhochmuth> so, i think this is ready to go, thanks for updating the docs
15:04:21 <rhochmuth> i just +1'd
15:04:27 <bklei> u bet -- i'll merge if we're ok with it
15:04:33 <rhochmuth> lgtm
15:04:38 <kornica> +2
15:04:52 <bklei> awesome
15:05:02 <rhochmuth> #topic https://review.openstack.org/#/c/433016/
15:06:16 <kornica> nothing much to add there, personally I think that it is in good shape, we had rbrandt to do some checks againts metric api compatybility
15:06:29 <kornica> witek: you think we're cool with as in current shape
15:06:31 <rhochmuth> thanks kornica
15:06:38 <rhochmuth> thanks rbrandt
15:06:51 <rhochmuth> i think it looks good to me
15:06:59 <witek> i have +2 already
15:07:00 <rhochmuth> i had reviewed earlier, but didn't leave comments
15:07:23 <rhochmuth> i can take another quick look, but i think it is ready to merge
15:07:32 <rhochmuth> concur with witek
15:08:27 <rhochmuth> #topic https://review.openstack.org/#/c/442957
15:08:55 <rhochmuth> kornica?
15:09:00 <kornica> it's us...had bunch of issues with it in devstack at this point, so just python code for now
15:09:17 <kornica> we have follow-up for the feature: https://review.openstack.org/#/c/442365/
15:09:25 <rhochmuth> do you want to add support for the java code too?
15:09:25 <kornica> witek, successfully tested on master
15:09:35 <rhochmuth> is that necessary?
15:09:53 <kornica> no, I don't think so, but we actually did not think about Java here
15:10:07 <kornica> is what necessary ? WSGI or devstack mod ?
15:10:19 <rhochmuth> just wondering if the python is sufficient
15:11:23 <kornica> well mod-wsgi is meant for python, but I know as much about wsgi as I've learned during past few days
15:11:28 <kornica> so, I might be wrong
15:11:44 <kornica> anyway, we did not take Java into account while doing WSGI for monasca-api
15:11:47 <rhochmuth> good point
15:11:51 <rhochmuth> i wasn't thinking
15:12:13 <rhochmuth> but you had mentioned just python code for now
15:12:39 <rhochmuth> so, i think the answer is just python code for now and no java code changes expected
15:12:57 <kornica> at this point, yes
15:13:13 <witek> Tomasz thought about integrating it to devstack, I don't know if that is necessary at all
15:13:20 <rhochmuth> so, i'll hopefully start catching up on my review backlog, but i'll try and bring up a new devstack environment and validate
15:13:54 <rhochmuth> i'm not sure it is necessary either
15:14:00 <kornica> well, I only did so to have a proof that it actually works + monasca-log-api devstack can run monasca-log-api under wsgi
15:14:24 <kornica> so was only natural for me to have it in monasca-api devstack
15:15:18 <kornica> anyway, we don't have time to work on this now, so assuming it would be needed or I;d have somet in, not so near, future - I could add this as non-invasive change to plugin
15:16:59 <rhochmuth> #topic https://review.openstack.org/#/c/395897/
15:17:50 <rhochmuth> kornica: do you believe that this one is ready too?
15:17:55 <kornica> it's quite old, but together with Li I think we managed to integrate oslo.db + keep old configuration option that Craig has doubts about
15:18:02 <kornica> *had
15:18:30 <kornica> rhochmuth: I think it is though I wouldn't mind extra test from someone
15:18:39 <kornica> just to ensure that we don't break anything with it
15:18:51 <rhochmuth> so, basically the old config options are supported and the new oslo.db
15:19:27 <kornica> as far as I looked into that, the only problematic option was that in old code there was url opt and in new there will be connection
15:19:46 <kornica> so in recent PS I think I found a way to support both + marked url as deprecated
15:19:59 <kornica> or at least I hope so
15:19:59 <rhochmuth> ok, thanks
15:20:00 <kornica> :)
15:20:16 <rhochmuth> is the default oslo.db?
15:20:20 <rhochmuth> in devstack?
15:20:34 <kornica> you mean, if other projects rely on oslo.db ?
15:20:57 <rhochmuth> no, i meant if you bring up a new devstack environment will it use your changes?
15:22:21 <kornica> from python-gate log
15:22:29 <kornica> Successfully installed .... oslo.db-4.17.0
15:23:09 <kornica> and gate used commit->f379d71 Use oslo.db for sqla driver
15:23:21 <kornica> so that says that, it will
15:23:29 <rhochmuth> thx
15:23:48 <rhochmuth> ok, i'll install, but i'll assume this is ready to merge
15:23:55 <kornica> I guess Artur said he'll test that tommorow
15:24:13 <kornica> but I might be wrong, I was leaving when I think he was telling that :P
15:24:22 <rhochmuth> #topic https://review.openstack.org/#/c/422108/
15:24:41 <rhochmuth> bklei: is this one for you?
15:24:44 <bklei> i'll take that one
15:25:01 <bklei> yeah -- been sitting a while -- not sure if kevin needs to do more work
15:25:26 <bklei> i think he's addressed hoppal's comments
15:25:34 <rhochmuth> looks like multiple +1's already
15:26:07 <rhochmuth> i added a +1
15:26:25 <rhochmuth> i had reviewed earlier, but didn't add any comments for some reason
15:26:37 <bklei> cool -- if nobody objects, i'll merge
15:27:35 <rhochmuth> #topic https://review.openstack.org/#/c/439612/5
15:28:20 <witek> kamil_: are you there?
15:28:25 <kamil_> yes
15:28:38 <kamil_> just a second
15:28:53 <kamil_> We found a bug in the monasca-api python version
15:29:23 <rhochmuth> yes, that was a nasty one
15:29:24 <kamil_> It is currently not possible to query for metrics withs dimensions like url:http://localhost:5050
15:29:52 <rhochmuth> yup, agree
15:29:54 <kamil_> So, we were thinking how to solve this issue and took a look into the java implementation
15:30:32 <kamil_> And there we found that the dimension is always splitted on the first occured colon. Indepentend how many colon will folow
15:31:15 <kamil_> but this means, that if the key can have a colon. But this is not explicit restricted
15:31:39 <rhochmuth> right, ":" is not a restricted char
15:32:05 <kamil_> In the first step we want to implement the same functionality in the python implementation as it is in java. Just to get rid of this bug
15:32:32 <rhochmuth> sounds good
15:32:41 <rhochmuth> that is this review, https://review.openstack.org/#/c/439612/5/monasca_api/tests/test_query_helpers.py
15:32:44 <rhochmuth> right?
15:32:52 <kamil_> And as an extension, we thought we could try to refactor the syntax for the dimensions. For example starting and ending with quotation marks
15:33:01 <kamil_> yes
15:33:37 <kamil_> Like: dimension='"url":"http://localhost:5050/"'
15:34:04 <rhochmuth> why would that be necessary?
15:34:19 <kamil_> Because then you will be able to have colon in the key
15:34:58 <kamil_> I don't know if this is a real usecase. But the spec is not restricting the colon for the key
15:35:08 <kamil_> we could also just restrict the colon in the key
15:35:17 <rhochmuth> is it due to how influxdb stores data that this occurs?
15:35:27 <rhochmuth> i'm wondering if the latter is a better option
15:35:32 <kamil_> influx is able to handle keys with colon
15:35:36 <kamil_> I checked it
15:36:08 <witek> rhochmuth: the latter is cheaper for sure
15:36:28 <kamil_> we could also try the enhancement with the latter
15:36:36 <rhochmuth> i think i'm missing the part where we require either quotes or to restrict it
15:37:06 <rhochmuth> can't we fix the issue in a way that doesn't require restricting chars or adding quotes?
15:37:19 <witek> if we split on the first colon, you cannot correctly read dimension keys with colon
15:37:55 <kamil_> it could be hard. Because you will never know what is the key and what the value in this example: service:name:monasca-api
15:38:16 <rhochmuth> so the db is using : as a delimiter
15:38:28 <rhochmuth> for key, value
15:38:44 <rhochmuth> and then we use that to split on
15:39:07 <kornica> isn't that written somewhere that dimension key suppose to use . (dot) to split segments ?
15:39:19 <kornica> service.name:monasca-api
15:39:23 <kornica> using example aboce
15:39:24 <rhochmuth> that is a convention, not a requirement
15:39:31 <kornica> ah, right
15:39:45 <kornica> well, looking at code and the bug looks more like requirements for me
15:40:18 <kamil_> So, the api gets a request like this: http://192.168.10.5/dashboard/monitoring/proxy/metrics/measurements/?dimensions=url:http%253A%252F%252Flocalhost%253A8191%252Fhealthcheck,hostname:monasca.cmm,component:monasca-persister,service:monitoring&name=http_status&start_time=2017-03-01T09:13:51Z
15:40:56 <rhochmuth> i'm wondering if restricting is a better option then
15:41:13 <rhochmuth> it seems like no one should be using the :
15:41:26 <rhochmuth> if they were, they would have had a pretty significant bug in dimenion keys
15:41:34 <rhochmuth> is there a way to escape it
15:41:46 <rhochmuth> that was the only other idea
15:41:48 <rhochmuth> i had
15:42:42 <kamil_> hmmm. maybe escaping could also work
15:43:10 <rhochmuth> well, it still implies a change
15:43:25 <kamil_> yes, unfortunately.
15:43:44 <kamil_> And if we change the api then we need to change all clients too
15:45:11 <kamil_> Okay just to understand. As a first step, we are okay with having the same functionality for dimension spliting in python-api as it is in java-api
15:45:14 <kamil_> ?
15:45:28 <rhochmuth> yes
15:46:19 <kamil_> Great. Thanks. And afterwards we can work on the "colon in key" problematic
15:46:26 <rhochmuth> sounds good
15:46:50 <kamil_> Thanks. That's all from my side
15:46:58 <rhochmuth> for which a doc change and parser change to restrict it in the dimension key is the easiest solution
15:47:07 <rhochmuth> i believe
15:47:27 <kamil_> yes, i think too
15:47:42 <witek> thanks Kamil and Roland
15:47:54 <rhochmuth> welcome
15:48:09 <rhochmuth> so, i think that covers that section in the agenda
15:48:17 <rhochmuth> thanks kamil_ for working on this
15:48:57 <rhochmuth> are there any other topics to discuss?
15:49:02 <rhochmuth> #topic open floor
15:49:09 <kamil_> @rhochmuth welcome
15:49:35 <rhochmuth> witek: are we every going to cover the neutron topic that we didn't get to at the mid-cycle
15:49:48 <rhochmuth> i was just wondering if we needed to cover that still?
15:50:03 <witek> we could, if there is interest
15:50:51 <rhochmuth> i thought you needed to discuss this with the monasca project as there might be something that neutron need to add/implment
15:51:36 <witek> we need to add cross-tenannt functionality to log agent
15:51:44 <witek> that's all actually
15:51:49 <rhochmuth> i see
15:51:54 <witek> most of the changes are on Neutron side
15:52:00 <rhochmuth> if that is all, then i'm not sure we need to discuss
15:52:37 <rhochmuth> but, if the neutron folks wantted to have a design discussion then i'm certainly open to accomodating that
15:53:24 <witek> OK, I'll let you know
15:53:29 <witek> thanks
15:55:00 <rhochmuth> ok, i think we can close the meeting a little early then if there are no other topics
15:55:28 <rhochmuth> bye everyone
15:55:35 <witek> thank you Roland
15:55:41 <witek> and everyone
15:55:42 <witek> bye
15:55:56 <rhochmuth> #endmeeting