15:01:54 <witek> #startmeeting monasca
15:01:55 <openstack> Meeting started Wed Feb 13 15:01:54 2019 UTC and is due to finish in 60 minutes.  The chair is witek. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:01:55 <joadavis> hello
15:01:56 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:01:58 <openstack> The meeting name has been set to 'monasca'
15:02:06 <witek> hi everyone
15:02:16 <Dobroslaw> hello
15:02:29 <toabctl> hi
15:02:35 <hosanai> hi
15:02:42 <witek> the agenda for today as usual here:
15:02:47 <witek> https://etherpad.openstack.org/p/monasca-team-meeting-agenda
15:03:06 <witek> could we start with merging APIs?
15:03:19 <chaconpiza> sure
15:03:28 <witek> #topic merge APIs
15:03:32 <chaconpiza> Hi, regarding the Merge Monasca APIs. In the spec is written that the monasca-common dependency can be removed from the monasca-api. We are wondering where should end up the kafka-client code, since it is being used by other modules like monasca-persister.
15:04:13 <dougsz> Good point - would be nice to remove that kafka client code!
15:04:19 <witek> the spec says that API relevant code should be moved
15:05:16 <witek> if we remove Kafka code, we have to implement it in every component
15:05:26 <witek> or make a dependency to API
15:06:10 <dougsz> What about the work to remove the forked client?
15:06:27 <dougsz> I suppose in the longer term we will use an external client library?
15:06:44 <witek> I have picked up consumer implementation with confluent client again
15:07:12 <witek> still, some wrapper around it would be useful
15:07:49 <chaconpiza> I see, so the monasca-api will continue importing from monasca-common the kafka-client lib.
15:08:30 <witek> corresponding to the modules in https://github.com/openstack/monasca-common/blob/master/monasca_common/kafka/
15:08:45 <dougsz> Ah - I had imagined that all the monasca components would just add the external Kafka library to their requirements. I didn't think about a wrapper. Could that be it's own library?
15:10:46 <witek> another alternative would be add this wrappers to individual components directly if it simplifies things
15:11:37 <dougsz> yes, i'd hope it'll be pretty light weight, so that could be simpler.
15:12:09 <witek> yes, new Kafka code should be simplier
15:12:40 <witek> do we have other shared code which would still live in monasca-common?
15:13:15 <chaconpiza> I don't think so
15:13:35 <chaconpiza> A yes...
15:13:43 <chaconpiza> the alarm expression parser
15:13:54 <chaconpiza> it is being used in monasca-ui as well
15:14:03 <witek> api and UI?
15:14:48 <dougsz> Thinking about adding the wrapper to each project, it scares me a little bit, given that there could be quite a few projects using it, it could easily diverge.
15:15:10 <chaconpiza> the code was copied from api to common to allow UI to used it
15:15:32 <chaconpiza> https://github.com/openstack/monasca-common/commit/086b9efcaf1c64693a2083dc3ef6115de7ae7b30
15:16:28 <witek> I'd say then, let's leave the other parts in monasca-common for now and finish API work first
15:16:49 <dougsz> Sounds sensible.
15:17:26 <joadavis> +1
15:17:34 <Dobroslaw> +1
15:17:41 <witek> chaconpiza: ?
15:18:14 <chaconpiza> +1
15:18:21 <witek> :) nice, thanks
15:18:37 <dougsz> And thanks for doing the work :)
15:18:45 <witek> how is the progress by the way?
15:19:08 <chaconpiza> So far Adrian and me are extending the coverage for api and common
15:20:00 <witek> cool, please ping us for reviews
15:20:13 <chaconpiza> thanks
15:20:29 <witek> srwilkers: are you around?
15:20:40 <srwilkers> hey witek
15:20:46 <srwilkers> got a bit of a late start today
15:20:48 <srwilkers> i'm around
15:20:49 <witek> hi
15:21:05 <witek> can we update shortly on OSH?
15:21:06 <srwilkers> hello :)
15:21:09 <srwilkers> sure
15:21:16 <witek> #topic openstack-helm
15:21:41 <witek> I have just copied the charts from monasca-helm repo to openstack-helm-addons
15:21:55 <witek> https://review.openstack.org/636597
15:22:26 <srwilkers> nice - i saw that this morning
15:22:42 <Dobroslaw> big...
15:22:46 <joadavis> wow, that is a lot of yaml
15:22:52 <witek> the idea is to adopt that code to OSH standards and eventually move to OSH repo
15:23:16 <witek> it is copied one to one from monasca-helm
15:24:23 <witek> srwilkers: could you point us how you would like the code to look like?
15:24:33 <srwilkers> yep :) to get the linting jobs happy to get it ready for the initial merge, we'll need to mark the directories coming in with the chart as irrelevant files here: https://github.com/openstack/openstack-helm-addons/blob/master/.zuul.yaml#L16 and here: https://github.com/openstack/openstack-helm-addons/blob/master/.zuul.yaml#L24
15:24:56 <srwilkers> sure, i'll attempt to without getting too much into the weeds on it
15:25:18 <witek> cool, thanks
15:25:30 <srwilkers> i'll pick on glance, as it's my favorite one to pick on: https://github.com/openstack/openstack-helm/tree/master/glance/templates
15:26:05 <srwilkers> you'll see we have various templates for things like the db-init job, the db-sync job, the ks-user job, etc
15:26:32 <srwilkers> we'll need to massage the various charts coming in with monasca to adopt those types of standards.  things like zookeeper and influxdb are obviously going to be different
15:27:07 <srwilkers> but at least for the monasca components themselves, we'd want them to use the same sort of patterns and standards where applicable so the user experience of the chart matches the other openstack services
15:28:04 <srwilkers> i need to revisit our documentation as well, as this was documented somewhere once upon a time.  if it's not anymore, i'll work to get it updated to provide a clear footing to get things moving in the right direction
15:29:06 <witek> great, any help and pointers to docs very appreciated
15:29:10 <srwilkers> im personally excited to get this rolling, as monitoring tools have a special place in my heart
15:29:18 <witek> :)
15:29:20 <srwilkers> of course -- i'll give a shout here when i've got the doc situation sorted out
15:29:38 <srwilkers> and feel free to ping me anytime for questions/help/pointers/whatever
15:29:42 <witek> that's our valentin's day present :)
15:30:14 <srwilkers> it's a great one :D
15:30:25 <srwilkers> i'm being summoned to stand up :)
15:30:55 <witek> :)
15:31:11 <witek> thanks srwilkers
15:31:51 <witek> also if anyone wants to help in that effort, very welcome
15:32:09 <joadavis> I'd like to, just bogged down with other things
15:32:44 <joadavis> zookeeper has been a thorn in my side this week.  As such, I'll mention we should move the helm charts to 3.4.13 from 3.4.10 which I see in the values.yaml
15:33:25 <witek> srwilkers: one more question, I guess we can stay with our Alpine images, at least for the start, right?
15:34:39 <witek> joadavis: I think that should not be a problem, thanks for the pointer
15:35:49 <witek> we can clarify later, let's move on
15:35:54 <witek> #topic reviews
15:36:41 <witek> https://review.openstack.org/#/c/622361/
15:37:24 <joadavis> looks ready for workflow approval
15:37:42 <witek> there are two things in this review: using monasca_db command in DevStack and fix in sub_alarm table definition
15:39:01 <witek> in Python 3 we had a problem with String type
15:39:33 <witek> https://review.openstack.org/#/c/634379
15:39:58 <witek> this one sets up a standard release notes job
15:40:52 <joadavis> it looked good, I just didn't workflow it to give others a chance to review (trying to stick to at least having two reviews before merging)
15:40:53 <witek> the output can be checked here: http://logs.openstack.org/79/634379/1/check/build-openstack-releasenotes/d4f9c11/html/
15:41:19 <witek> https://review.openstack.org/#/c/634922/
15:41:51 <witek> that's a trivial fix in default configuration value
15:42:47 <witek> https://review.openstack.org/#/c/633194/
15:43:23 <witek> I have given -1 on that one because I'm not sure if it works correctly
15:43:54 <joadavis> glad you tested that
15:43:59 <witek> the enumeration values are still initialized with sql script: email, webhook and pagerduty
15:44:18 <witek> on the other hand, in notification configuration all plugins are enabled
15:44:27 <witek> per default
15:45:05 <witek> there is logic which should sync these during the start of the service
15:45:36 <witek> for some reason it doesn't work, but I'm not sure why
15:47:16 <witek> there are many more reviews from Thomas:
15:47:18 <witek> https://review.openstack.org/#/q/projects:openstack/monasca+is:open+owner:%22Thomas+Bechtold%22
15:48:15 <witek> mainly clean-up for oslo.config
15:48:44 <witek> https://review.openstack.org/#/c/636150/
15:48:58 <witek> Fix alarm-definition-list in Python 3
15:49:25 <witek> thanks dougsz
15:49:43 <dougsz> np
15:49:56 <witek> did you look more at client code in terms of Python 3 support?
15:50:04 <dougsz> I ran away
15:50:09 <witek> haha
15:50:21 <dougsz> I'm sure it won't take too long, just need to find the time.
15:51:16 <witek> dougsz: chaconpiza: do you think it's something where piotrowskim could help?
15:51:29 <openstackgerrit> Merged openstack/monasca-notification master: Configure releasenotes job  https://review.openstack.org/634379
15:51:52 <witek> sorry, I meant Dobroslaw, not dougsz
15:52:02 <Dobroslaw> jep, could be another task for him
15:52:03 <chaconpiza> There are more small task related to the hacking lib
15:52:31 <joadavis> yes, several repos could use a hacking lib review
15:52:34 <chaconpiza> https://storyboard.openstack.org/#!/story/2004930
15:53:40 <witek> the last two reviews from the list:
15:53:45 <witek> https://review.openstack.org/#/c/636150/
15:53:49 <witek> ups
15:53:56 <witek> https://review.openstack.org/#/q/status:open++branch:master+topic:policy-names
15:54:43 <witek> these ones are about updating the policy names to OpenStack conventions
15:55:07 <witek> the reviews have been up for a while now already
15:55:45 <witek> some more reviews?
15:56:41 <witek> #topic open stage
15:56:48 <Dobroslaw> Just short info about https://github.com/monasca/monasca-docker
15:56:48 <Dobroslaw> Looks like it's no longer possible to build monasca-api
15:56:48 <Dobroslaw> Problem is that it's using really old PR for building https://review.openstack.org/#/c/417163
15:56:48 <Dobroslaw> and newer version of prometheus_client is incompatible anymore with this code
15:56:48 <Dobroslaw> I'm trying to push changes to build Docker in zuul but zuul don't like me...
15:58:40 <witek> shouldn't we use new master branch code?
15:59:24 <openstackgerrit> Merged openstack/monasca-notification master: Replace notification.conf with monasca-notification.conf  https://review.openstack.org/633163
15:59:55 <Dobroslaw> the thing is this code is used to push some metrics to monasca-sidecar and I never properly looked into what it used for...
15:59:58 <witek> I have to jump to another meeting now
16:00:06 <witek> thank you everyone for joining
16:00:12 <Dobroslaw> thank you
16:00:13 <witek> and for the productive meeting
16:00:13 <joadavis> thanks
16:00:16 <witek> thanks
16:00:17 <dougsz> thanks all
16:00:18 <witek> bye
16:00:22 <Dobroslaw> bye
16:00:25 <chaconpiza> thanks, bye
16:00:25 <witek> #endmeeting