15:00:17 <witek> #startmeeting monasca
15:00:18 <dougsz> hey all
15:00:18 <openstack> Meeting started Wed Feb 27 15:00:17 2019 UTC and is due to finish in 60 minutes.  The chair is witek. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:19 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:21 <openstack> The meeting name has been set to 'monasca'
15:00:22 <witek> hi dougsz
15:00:38 <witek> the agenda for today:
15:00:43 <witek> https://etherpad.openstack.org/p/monasca-team-meeting-agenda
15:00:49 <witek> feel free to add topics
15:01:27 <witek> #topic OpenStack release dates
15:01:37 <witek> just a reminder
15:01:59 <witek> we're approaching a couple of dates in the release schedule
15:02:23 <witek> Non-client library freeze being the first ont
15:02:25 <witek> one
15:02:27 <witek> tomorrow
15:02:42 <witek> it affects mainly monasca-common
15:03:30 <dougsz> Would be nice to get this change in if that's possible: https://review.openstack.org/#/c/638423/
15:03:55 <dougsz> Oops, sorry, note relevant
15:03:57 <dougsz> *not
15:04:08 <witek> would be good anyway :)
15:04:22 <dougsz> *monasca-agent change for statsd
15:04:50 <witek> we have 2 last minute changes in monasca-common
15:04:55 <witek> https://review.openstack.org/637190
15:05:07 <witek> and Kafka https://review.openstack.org/638725
15:05:41 <witek> I'll have a look at the validation change tonight
15:06:29 <witek> I think we can probably also merge https://review.openstack.org/626761
15:07:16 <witek> the next date is next week
15:07:21 <witek> for python-monascaclient
15:07:49 <witek> and then RC1 on March 21
15:08:55 <witek> please have a look through the repos and check which changes should land until then
15:09:12 <witek> #topic Kafka client
15:09:39 <witek> I've pushed implementation for the Kafka consumer in monasca-common
15:09:45 <witek> https://review.openstack.org/638725
15:10:08 <dougsz> Great to see this moving forward, need to take a closer look at that review when I have time
15:10:13 <witek> it has become much simpler than the kafka-python one
15:10:54 <witek> which makes me wondering if we indeed shouldn't move it out from monasca-common
15:12:18 <joadavis> If we move it out of monasca-common, how many places would we need to duplicate it?
15:12:28 <dougsz> I suppose the pattern of being able to swap in another kafka client and not update all the other monasca projects is a good one.
15:12:48 <dougsz> If the wrapper can be generic enough
15:13:19 <witek> dougsz: that's a point for leaving it in monasca-common, at least in the first phase
15:13:37 <witek> joadavis: producer in api and notification
15:13:52 <witek> consumer in persister and notification
15:14:10 <witek> then we also have monasca-transform
15:15:32 <witek> if we decide to leave it in monasca-common, I would like to merge it before the freeze this week, so that we can complete the work in Stein
15:15:50 <dougsz> Do you have a Monasca deployment with that wrapper running in production?
15:15:55 <witek> I know it's very short, but the code will not break anything for now
15:16:01 <witek> no
15:17:54 <joadavis> +1 for merging it now
15:17:56 <dougsz> I see, so you can get it in now, and then patch it up after the deadline
15:18:18 <dougsz> (if it needs patching up when you come to use it)
15:18:24 <witek> yes, I'm adding unit tests right now, should be ready tonight
15:20:16 <witek> should we move on?
15:20:42 <witek> #topic Dropping parse errors in monasca-persister
15:20:53 <witek> https://review.openstack.org/638589
15:21:41 <witek> the change allows for dropping the messages being blocked due to parsing errors in InfluxDB
15:22:55 <witek> but I think the actual reason might be the newer version of InfluxDB which we currently test
15:23:17 <witek> I haven't checked that though
15:23:59 <dougsz> Yeah, need to investigate more - I have hit similar problems to this with badly formatted metrics breaking the persistor
15:24:27 <witek> what was the reason?
15:25:20 <dougsz> I forget exactly now, but invalid characters in metric or something. Caused by metrics generated from logs not going via the Monasca API for validation.
15:27:20 <joadavis> I think that commit would be fine if we can get to the root cause.  I might like more detail in the log message if possible, and wonder if it should be error instead of warning
15:29:21 <witek> monasca-persister is our performance bottleneck that's why I'm a little reluctant
15:29:51 <witek> and also I would like to add full support for newer InfluxDB if that's the root cause of the problems
15:30:17 <dougsz> yeah - I agree it needs more investigation
15:30:45 <witek> but I'm fine with merging this one if we don't fine a better way
15:31:28 <witek> #topic legacy jobs migration to Bionic
15:32:01 <witek> there is a recent thread on mailing list about moving to Bionic for all jobs
15:32:39 <witek> I've checked that we still build jars with legacy Xenial jobs
15:32:57 <witek> I think in the thread mainly testing jobs were meant
15:33:13 <witek> but we should migrate these anyway
15:33:30 <witek> egacy-monasca-{common,api,persister,thresh}-maven-build
15:33:47 <witek> legacy-monasca-{common,persister,thresh}-localrepo-upload
15:34:14 <witek> we're actually not publishing API jar anymore
15:34:35 <witek> I guess we can remove building this as well, right?
15:34:59 <witek> meaning legacy-monasca-api-maven-build
15:36:02 <witek> I'll create a story in backlog for this
15:36:14 <witek> if someone has time, can take care of it
15:36:35 <witek> I hope it works without greater problems
15:37:10 <witek> #topic metrics grouping
15:37:54 <witek> mohankumar: is that one yours?
15:38:03 <pandy> Hi witek, that's mine :)
15:38:08 <witek> hi pandy
15:38:14 <mohankumar> witek : It's pandy
15:38:37 <pandy> first would like to thanks all for accepting paper to present at denver summit.
15:38:54 <witek> congratulations!
15:39:01 <joadavis> congratulations!!
15:39:05 <dougsz> +1
15:39:11 <mohankumar> pandy : congrats mate !
15:39:38 <pandy> coming to point, currenly VM dimesions are grouping with tenant_id & resource_id
15:40:22 <pandy> we had feedback from end users to have "tenant_name" & "resource_name"
15:41:20 <pandy> so would like to add that feature, looking forward your advise
15:42:24 <witek> documentation says "VM name and tenant name (in addition to default IDs) can be provided as dimensions if vm_name and tenant_name are provided in the list of metadata keys."
15:43:18 <joadavis> so either the names can be included in the metric when generated, or they can be matched up against data in post-processing
15:43:38 <pandy> https://github.com/openstack/monasca-agent/blob/9ee96263e9b7ae03c8a061cfecaa4e8fcda1bd87/docs/Libvirt.md#vm-dimensions
15:44:59 <pandy> I could see that in documents, but when we query metrics with dimensions "tenant_name" getting invalid parameter ?
15:45:23 <witek> http://git.openstack.org/cgit/openstack/monasca-agent/tree/docs/Libvirt.md#n70
15:45:49 <witek> please check `metadata` in you libvirt plugin configuration
15:48:36 <pandy> ok, I will check
15:48:55 <witek> https://github.com/openstack/monasca-agent/blob/master/monasca_agent/collector/checks_d/libvirt.py#L206
15:49:02 <witek> that should work, I guess
15:50:28 <witek> #topic open stage
15:50:42 <witek> do we have anything else?
15:51:05 <witek> oh, I haven't noticed the new entry in agenda
15:51:28 <pandy> okay, thanks. I got it :)
15:51:31 <witek> #topic custom alerting templates
15:52:06 <mohankumar> witek : please review and approve :)
15:52:19 <mohankumar> https://blueprints.launchpad.net/monasca/+spec/add-custom-alert-templates
15:52:42 <witek> that's something that we have in our backlog for some time already
15:53:03 <mohankumar> witek : okay
15:53:03 <witek> there is a story for templating Slack notifications
15:53:26 <mohankumar> witek: I see let me check
15:53:46 <witek> https://storyboard.openstack.org/#!/story/2001308
15:54:18 <witek> we definitely need something similar for emails as well
15:54:48 <witek> btw. we don't use launchpad anymore and moved to Storyboard
15:54:49 <dougsz> agreed, I need to finish the Slack one
15:55:30 <witek> here is the board with current tasks:
15:55:32 <witek> https://storyboard.openstack.org/#!/board/111
15:55:46 <pandy> yes, i remember that i was discussed same with dougsz some time back to customise notification at present it's verbose mode and hard to understand quickly
15:56:23 <witek> mohankumar: is that something that you could/would like to work on?
15:57:17 <mohankumar> witek : yes , I 'll sync with dougsz  and will find way to customize for email
15:57:28 <pandy> dougsz, would like to know status of slack notification ? if fine i can work on customising mail onle
15:57:49 <witek> could you please create a story for this?
15:58:06 <mohankumar> witek : sure !C
15:58:14 <witek> great, thanks
15:58:33 <witek> we have to wrap up
15:58:42 <witek> another meeting in 2 min.
15:59:02 <mohankumar> witek: another question , for bug reporting you use storyboard or launchpad ?
15:59:03 <witek> thanks for joining
15:59:17 <pandy> thanks :)
15:59:19 <witek> and please have a look on Kafka change later today or tomorrow
15:59:26 <witek> bye
15:59:37 <dougsz> bye all, will check Kafka change tomorrow
15:59:37 <witek> mohankumar: storyboard
15:59:39 <mohankumar> thanks all !
15:59:44 <witek> and tag it with `bug`
15:59:55 <mohankumar> witek : got it !
15:59:57 <witek> #endmeeting