15:01:29 <witek> #startmeeting monasca
15:01:31 <openstack> Meeting started Wed Mar 13 15:01:29 2019 UTC and is due to finish in 60 minutes.  The chair is witek. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:01:32 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:01:34 <openstack> The meeting name has been set to 'monasca'
15:01:44 <witek> hello
15:01:47 <dougsz> \o hey
15:01:51 <Dobroslaw> Hi
15:01:58 <witek> hi dougsz and Dobroslaw
15:02:41 <witek> please put items into agenda if you have any
15:02:45 <witek> https://etherpad.openstack.org/p/monasca-team-meeting-agenda
15:03:31 <witek> and if not we can go through the list of new changes in review
15:03:47 <witek> #topic reviews
15:04:06 <witek> https://review.openstack.org/642082
15:04:16 <witek> first one from Stig
15:05:07 <dougsz> Still need to review that one
15:05:31 <dougsz> My main concern is making sure it's backwards compatible
15:06:16 <witek> it gets some configuration details from Ceph config file and configures the plugin using that, right?
15:07:20 <dougsz> ah yes, there is another change in the pipeline I am thinking of
15:07:56 <witek> I see, not published yet
15:08:50 <Dobroslaw> It looks mostly as handling edge case
15:10:00 <witek> OK, the next two are the changes for Cassandra
15:10:06 <witek> https://review.openstack.org/642372
15:10:12 <witek> https://review.openstack.org/642216
15:11:06 <witek> good to see some changes there after a long time
15:12:19 <witek> building Docker image for python client:
15:12:27 <witek> https://review.openstack.org/640033
15:13:18 <Dobroslaw> I will test it tomorrow, code looks fine for me now
15:13:28 <witek> is it enough to run `./build_image.sh` to try it out?
15:13:54 <Dobroslaw> Yes
15:14:17 <witek> and how can the client be used afterwards?
15:15:08 <Dobroslaw> Like for connecting to existing network of docker comppse
15:15:57 <witek> any example? what should I run if I would like to list metrics for example?
15:16:38 <Dobroslaw> Ugh, I'm writing from phone now, will sent you tomorrow
15:16:51 <witek> I'll ask in review :)
15:16:57 <Dobroslaw> OK
15:17:57 <Dobroslaw> Readme could be updated with more examples
15:18:33 <witek> next one:
15:18:37 <witek> https://review.openstack.org/#/c/632718/
15:18:54 <witek> oh, merged already
15:18:55 <witek> great
15:19:10 <Dobroslaw> Merged already :-)
15:19:14 <witek> +2000 lines
15:19:22 <joadavis> impressive
15:19:36 <Dobroslaw> All thanks to adriancz
15:20:29 <witek> good job, that's pre step for API merging
15:20:47 <witek> any other reviews?
15:21:31 <pandy> witek, am submitting review for custom email notification in couple of minutes
15:21:33 <dougsz> Good stuff! adriancz
15:22:48 <witek> #topic bugs
15:23:07 <witek> we have three bug reports in etherpad
15:23:12 <witek> https://storyboard.openstack.org/#!/story/2005224
15:23:27 <openstackgerrit> Pandiyan proposed openstack/monasca-notification master: [WIP] Adding custom_email notification method  https://review.openstack.org/643075
15:23:32 <witek> I think we miss some details here
15:23:43 <dougsz> ^ That one is from the monasca grafana fork
15:23:47 <dougsz> Not the datasource
15:24:21 <dougsz> Questions are: 1) How do we track bugs for that component?
15:24:48 <dougsz> 2) Is the monasca-grafana fork 'supported'?
15:26:09 <witek> we haven't had many bug reports for Grafana fork, so I'm fine with having it in StoryBoard
15:26:26 <witek> althought it would fit better as Github issue
15:26:45 <dougsz> They are disabled at the moment - perhaps we should enable them?
15:27:14 <witek> oh, yes, probably good idea :)
15:27:25 <kaiokmo> I've run through this same issue as well a couple times :)
15:27:54 <dougsz> Yeah, there is no token refresh mechanism. I think you should at least get sent back to the login page.
15:28:23 <kaiokmo> that would make sense
15:28:25 <dougsz> We should hopefully be able to pick it up, as quite a few users complain about it.
15:29:29 <Dobroslaw> Unfortunately adding backend plugins to grafana do not have any progress in last year...
15:29:45 <witek> for supporting Grafana fork, we still don't have a better mechanism if you don't want or cannot proxy requests via Horizon
15:30:42 <witek> what we could do is to start working on adding support for Keystone Application Credentials in Monasca datasource
15:31:40 <dougsz> yeah, that is one promising avenue
15:31:49 <dougsz> Just need to find the manpower
15:31:49 <witek> the problem is, that we're storing these credentials on client, which is a security risk
15:32:24 <witek> the work on adding whitelisting to Application Credentials in Keystone is work in progress though
15:32:59 <witek> so I think we can use them securely soon
15:33:50 <dougsz> I've enabled github issues for the fork and moved the bug report
15:33:58 <witek> thanks dougsz !
15:34:18 <witek> does Palimariu work with you?
15:34:55 <dougsz> He's a user of a Monasca deployment we've done.
15:35:11 <dougsz> Trying to encourage upstream involvement :)
15:35:21 <witek> I see, very good!
15:36:14 <witek> then we have two security issues
15:36:20 <witek> https://storyboard.openstack.org/#!/story/2005215
15:37:14 <pandy> witek, I have initiated custom-email changes for monasca-notification, I need to add test cases for the same and added witek, dougz to review.
15:37:41 <witek> hold on pandy
15:37:50 <joadavis> The two security issues are from a batch I came across last week
15:38:08 <joadavis> they are old ones from a year or so ago, though I still see them in the code
15:38:23 <joadavis> I think these are "hardening opportunities" rather than gaping security issues
15:38:34 <witek> I cannot open https://storyboard.openstack.org/#!/story/2005217
15:38:40 <dougsz> +1
15:38:44 <dougsz> 404
15:38:53 <joadavis> There are a few more in our internal bug tracking which I need to try publishing
15:39:10 <joadavis> Sorry, I think I marked that one with the 'security bug' checkbox, which makes it private
15:39:18 <joadavis> I can go uncheck that
15:39:19 <dougsz> ah, I see
15:39:48 <joadavis> ok, you can try again
15:40:08 <witek> now I can see it
15:40:11 <joadavis> I'll go back through the list today and post any other relevant ones
15:40:42 <joadavis> In general, these seem like small changes.
15:40:50 <witek> should we tag these as bugs, so that these are easier to find?
15:41:00 <joadavis> But I know at least one would likely need a configuration setting to be implemented well
15:41:20 <joadavis> Sure. I wanted to bring it up in this meeting so we can discuss how best to handle them
15:41:32 <dougsz> Thanks for reporting joadavis
15:42:04 <dougsz> https://storyboard.openstack.org/#!/story/2005215 is relevant to you Pandy?
15:43:12 <pandy> dougsz, not relevant to me
15:43:13 <witek> these seem to be small tasks which should be easy to be picked up by anyone
15:43:56 <joadavis> yes.  I wish I'd been aware of this internal list months ago, as we could have easily included them in Rocky.
15:44:41 <witek> well, we can have them in Stein or Train :)
15:45:14 <witek> thanks joadavis
15:45:51 <witek> here, pandy's change for email notification templating:
15:46:01 <witek> https://review.openstack.org/643075
15:46:22 <witek> I've added it to the list on etherpad
15:46:50 <pandy> witek, I have just proposed WIP patch for custom email notification.
15:47:20 <joadavis> cool (and that might be a good pairing with story 2005215)
15:48:08 <pandy> Still I need to add "Tenant_Name" in subject, for that need to through libraries to import.
15:48:33 <witek> I think, I'd rather modify the existing plugin instead of adding a new one
15:49:33 <witek> ha, the same comment from dougsz in review :)
15:49:46 <dougsz> :)
15:50:08 <pandy> yes, I was thought about it, but don't want to change existing functionality did like this
15:50:09 <witek> thanks for the change pandy
15:51:08 <witek> do you think you can do the second step of adding it to the API after that one is merged?
15:52:35 <pandy> You mean after python-client changes ?
15:53:13 <dougsz> Both really, so users can set custom templates from the client, and the API supports that operation
15:53:28 <witek> yes
15:54:37 <pandy> dougsz,  yes. I feel good to have new plugins without touching existing one, so users can choose as their wish
15:54:44 <dougsz> A fair bit of work there I would imagine, I assume we would store templates in the DB
15:55:19 <witek> new point in the agenda
15:55:27 <pandy> yes, dougsz need to store in DB, which witek conveyed last time
15:55:28 <witek> #topic building Kolla images
15:55:50 <dougsz> ah yes, so this came up last week, totally possible.
15:56:30 <witek> do you know any details, I guess Dobroslaw is interested
15:57:07 <dougsz> You can easily get Kolla to build per repo images.
15:57:18 <pandy> Sorry to interupt. witek, dougsz hope both are agreed to have new plugins, if need to do changes in existing one please let me know, so I can find the possiblities.
15:57:26 <dougsz> I think the configuration mechanism is quite different to the existing Monasca docker images
15:57:38 <dougsz> As Dobroslaw knows :)
15:57:43 <Dobroslaw> Yes
15:58:21 <Dobroslaw> Providing config files Vs env variables
15:58:27 <dougsz> The images are also fairly heavyweight - either Debian or Centos based
15:59:40 <dougsz> On the plus side, the Kolla images maintained to some extent by the Kolla team
15:59:47 <dougsz> *are maintained
16:00:31 <witek> if I understood correctly, we had a problem with triggering the CI job when tagging the repo
16:00:31 <dougsz> pandy: I would rather not have a duplicate plugin, would be nice if we have one email plugin, and it does it's job well
16:00:57 <witek> I have to jump to another meeting
16:01:03 <witek> see you next week
16:01:06 <witek> bye
16:01:08 <dougsz> np, thanks all
16:01:13 <Dobroslaw> Thanks
16:01:16 <witek> #endmeeting