13:00:05 <chaconpiza> #startmeeting monasca
13:00:06 <openstack> Meeting started Tue May 12 13:00:05 2020 UTC and is due to finish in 60 minutes.  The chair is chaconpiza. Information about MeetBot at http://wiki.debian.org/MeetBot.
13:00:07 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
13:00:10 <openstack> The meeting name has been set to 'monasca'
13:00:20 <chaconpiza> Hello everyone
13:00:26 <piotrowskim> hi
13:00:28 <witek_> hi
13:00:28 <adriancz> hello
13:00:42 <chaconpiza> Hi Michal, Adrian and Witek
13:00:55 <chaconpiza> The agenda as usual https://etherpad.opendev.org/p/monasca-team-meeting-agenda
13:01:19 <chaconpiza> Let's start
13:01:36 <chaconpiza> #topic Follow-up on influxdb=5.3.0
13:02:05 <chaconpiza> It seems that the version 5.3.0 of influxdb-python-client isn't able to handle requests with long output.
13:02:28 <chaconpiza> A simple call like 'SHOW DIAGNOSTICS' raises an exception.
13:02:53 <chaconpiza> https://github.com/influxdata/influxdb-python/issues/820
13:02:57 <witek_> what about actual measurement queries?
13:03:47 <chaconpiza> I workarounded the call of SHOW DIAGNOSTICS, then Tempest test fails in 5 test cases.
13:04:38 <chaconpiza> https://zuul.opendev.org/t/openstack/build/5f8c3bcaa971462f80c0097267c0dbe9/log/job-output.txt
13:04:38 <witek_> https://review.opendev.org/725779
13:05:45 <chaconpiza> I sent a change to openstack/requirements for block that version. https://review.opendev.org/#/c/725824/
13:06:12 <witek_> but the client isn't throwing any exception for these tests, is it?
13:07:52 <chaconpiza> I didn't go deep for other calls
13:09:03 <witek_> I think it's good we blocked this version, as apparently there are some problems with it
13:09:22 <witek_> but we may need to look closer at these failing tests
13:09:47 <chaconpiza> and let's keep track on the open bug in https://github.com/influxdata/influxdb-python/issues/820
13:09:58 <witek_> +1
13:10:33 <chaconpiza> alright, then we notice that:
13:10:40 <chaconpiza> #topic Define minimum versions for InfluxDB and Influxdb-python-client
13:11:26 <chaconpiza> In monasca_api/common/repositories/influxdb/metrics_repository.py
13:11:42 <chaconpiza> The code handles InfluxDB version older than 0.11.0 and newer with different methods.
13:11:51 <chaconpiza> InfluxDB 0.11.0 is quite old.
13:12:14 <chaconpiza> As well, the code don't use the new methods from influxdb-python-client.
13:12:35 <chaconpiza> For example, in order to get the version of InfluxDB it queries 'SHOW DIAGNOSTICS' and parses the output.
13:13:21 <chaconpiza> since version 5.0.0 of influxdb-python-client there is present a method that returns the version.
13:13:28 <chaconpiza> https://github.com/influxdata/influxdb-python/blob/master/CHANGELOG.md#v500---2017-11-20
13:13:58 <chaconpiza> I would like to propose:
13:14:23 <chaconpiza> 1. Set InfluxDB 0.11.0 as the oldest supported.
13:14:42 <chaconpiza> 2. Set influxdb-python-client 5.0.0 as the minimum version
13:15:03 <chaconpiza> 3. refactor the code monasca_api/common/repositories/influxdb/metrics_repository.py
13:15:42 <chaconpiza> what do you think piotrowskim, witek_ and adriancz?
13:15:55 <witek_> fully agree on 1
13:16:50 <witek_> for 2 and 3, I'm not sure if we need to check the version at all, but indeed could be useful in future
13:16:53 <piotrowskim> 1, unless we have time for 3
13:17:48 <chaconpiza> The refactor is not difficult, is more like cut-here, trimm-there and prunning-over-there
13:19:11 <chaconpiza> let's keep track on this topic in this change https://review.opendev.org/#/c/725824/ I will set a new patch set
13:19:30 <adriancz> agree with pireowskim
13:19:43 <witek_> chaconpiza: will you be working on this?
13:19:48 <chaconpiza> yes
13:20:08 <chaconpiza> let's move forward to the next topic
13:20:10 <witek_> I'm OK with the approach
13:20:26 <chaconpiza> #topic Adding project-template for nodejs10
13:21:15 <chaconpiza> piotrkowskim, could you please give us a brief context?
13:21:21 <piotrowskim> ok, so as Arseni updated monasca-kibana-plugin and now it needs node in version 10, I belive we should check lint etc. for proper version
13:21:34 <piotrowskim> before it was version 4
13:21:47 <witek_> +1
13:22:15 <piotrowskim> right now, tests for monasca-kibana-plugin are switch off, it good to have working tests for project
13:23:29 <chaconpiza> Besides of the lint, do the unit test of monasca-kibana-plugin need a refactor ?
13:24:07 <chaconpiza> Are there in the new monasca-kibana-plugin unit test ?
13:24:16 <chaconpiza> *tests
13:24:31 <piotrowskim> i belive yes, cause a lot of changed in plugin itself
13:25:31 <chaconpiza> https://github.com/openstack/monasca-kibana-plugin/tree/master/server/__tests__
13:26:01 <chaconpiza> I am not sure if these unittest are compatible with the new monasca-kibana-plugin
13:26:58 <chaconpiza> piotrowskim could you take a look?
13:27:08 <piotrowskim> probably not, also I think is good to have much more information in README, for example how to run tests etc.. I am not familiar with NodeJS at all so it is more time consuming
13:27:17 <piotrowskim> yeah i will look at it
13:28:31 <chaconpiza> thanks
13:28:54 <chaconpiza> #topic Migrate from ujson to simplejson
13:29:31 <chaconpiza> I propose two options to handle the migration of ujson in onasca-log-api
13:30:38 <witek_> I think going with https://review.opendev.org/727119 is safer
13:30:46 <chaconpiza> In the first option I set the newest version of monasca-common in lower-constraints, since monasca-common has already the change ujson to simplejson
13:30:53 <witek_> as we decouple from new version of monasca-common
13:31:33 <witek_> and we aim to support train in monasca-log-api
13:31:57 <chaconpiza> As Witek just mention, the second option doesnt touch monasca-common, but instead copies the code from monasca-common into monasca-log-api
13:32:58 <chaconpiza> Ok, lets go for https://review.opendev.org/727119
13:33:12 <witek_> adriancz: opinion?
13:33:41 <adriancz> agree with Witek
13:33:43 <chaconpiza> adriancz, you would need to rebase on this one  https://review.opendev.org/727119
13:34:17 <witek_> nice, so we know how to proceed here
13:34:19 <chaconpiza> it is a little bit more work for you, but safer as witek_ mentioned
13:34:24 <chaconpiza> +1
13:34:45 <chaconpiza> I will then abandon the other change and set a -1 workflow
13:34:54 <adriancz> monasca-log-api is deprecated so we should go with safer option
13:35:04 <chaconpiza> +!
13:35:08 <adriancz> and we should not  invest to much time
13:36:00 <chaconpiza> Ok, we have an agreement.
13:36:33 <chaconpiza> #topic AOB
13:37:49 <chaconpiza> Is there any other topic you would like to disscus today?
13:37:49 <witek_> I'd like to start working on Contributor Documentation goal this week
13:37:57 <witek_> https://governance.openstack.org/tc/goals/selected/ussuri/project-ptl-and-contrib-docs.html
13:39:12 <chaconpiza> Speaking about documentation...
13:39:15 <chaconpiza> https://review.opendev.org/#/c/722666/
13:39:44 <chaconpiza> The change that modifies the code is merged and cherry-picked until stable/pike
13:40:03 <chaconpiza> it is from Keith
13:40:31 <witek_> right, I've helped on this a little in the last days
13:40:36 <chaconpiza> It looks good to me, lets then merge and cherry-pick until pike as well
13:41:07 <witek_> my change is documentation only, so I think we don't need to cherry-pick
13:41:47 <chaconpiza> the documentation isn't handle by releases?
13:42:18 <witek_> let me look it up
13:43:16 <witek_> https://docs.openstack.org/project-team-guide/stable-branches.html#review-guidelines
13:43:17 <chaconpiza> KeithMnemonic are you around?
13:43:24 <witek_> don't see anything about docs
13:44:01 <chaconpiza> Ok, thanks for the guidelines
13:44:30 <witek_> we can cherry-pick, doesn't hurt after all
13:44:35 <chaconpiza> +1
13:45:44 <chaconpiza> All right. These were all topics in the agenda for today.
13:46:17 <witek_> nothing else from my side
13:46:38 <chaconpiza> Thanks for coming  and let's gather next week. Goodbye.
13:46:45 <witek_> thanks chaconpiza
13:46:49 <witek_> thanks everyone
13:46:51 <witek_> and bye
13:47:01 <piotrowskim> bye
13:47:10 <adriancz> thanks bye
13:47:20 <chaconpiza> #endmeeting